msg91sms 1.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a0cd46e433933093fc4f61070941c6727bf0a0b0
-  data.tar.gz: ae06ef1a183cc035920aa9336f1946be1cd88eb6
+  metadata.gz: 9f046d7380b3a28ef0482137770dd3d5f79a329f
+  data.tar.gz: b24c1a716d80ead64d0c348213e9f11c9d311f23
 SHA512:
-  metadata.gz: 751eb63c21f1ac211edf86ec6adb506ce81bd26135a3f3e8202c478782d4c2da90b3c9542c78b075b6dda3882a5f4ff9ad3a8efa90e2663ee5314e34416a4414
-  data.tar.gz: 12997ef7720d893e033477986794cdfe68b69e7787728d2ad7404d971599adb79ec0173dfbf4cf3a60b974fd42787ff0c0f543a169a93b16055bddb83c04860b
+  metadata.gz: 473c7dce4b5f6e2504ee4a535e8e5239ed01d686a44b6c556b2eeb6fc7a74679d4b6fb3a34609e509e50ae724e3ef5caae3f98e8d3161020832275d4ded109d3
+  data.tar.gz: 86449a73d232a23c8f776e0f0255938a4226c2b88248ea23cac3416314aa3dfc5b4ac595d305a0ef2bc2af606a1bbebe34118e78ee40a17c7a88a8b4e7987727

data/README.md

@@ -106,7 +106,7 @@ _country_code:_ country code without + or zeros EG: `"91"` for india
 
 _mobile:_ mobile number without starting zeros or country code eg: `"7234567891"`
 
-_otp:_ otp recieved from user for verifying, eg: `"2277"`
+_otp_to_verify:_ otp recieved from user for verifying, eg: `"2277"`
 
 **Example**
 

data/lib/msg91sms.rb

@@ -30,13 +30,25 @@ module Msg91sms
 
   class TransactionalSms
     def self.deliver(sender, country_code, mobiles, message)
-      Transactional.send_transactional(sender, country_code, mobiles, message)
+      #verify mobile number manually else send error message as msg91 would
+      if Msg91sms.verify_mobile?(mobiles)
+        Transactional.send_transactional(sender, country_code, mobiles, message)
+      else
+        response='{"message":"Please Enter valid mobile no","type":"error"}'
+        JSON.parse(response)
+    end
     end
   end
 
   class OtpSms
     def self.generate(sender, country_code, mobiles, message=nil, otp=nil)
-      Otp.send_otp(sender, country_code, mobiles, message, otp)
+      #verify mobile number manually else send error message as msg91 would
+      if Msg91sms.verify_mobile?(mobiles)
+        Otp.send_otp(sender, country_code, mobiles, message, otp)
+      else
+        response='{"message":"Please Enter valid mobile no","type":"error"}'
+        JSON.parse(response)
+      end
     end
 
     def self.verification(country_code, mobile, otp)
@@ -44,5 +56,10 @@ module Msg91sms
     end
   end
 
+  #Helper method checking mobile number contains only numbers
+  def self.verify_mobile?(mobile)
+    mobile.scan(/\D/).empty?
+  end
+
 
 end

data/lib/msg91sms/version.rb

@@ -1,3 +1,3 @@
 module Msg91sms
-  VERSION = "1.0"
+  VERSION = "1.0.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: msg91sms
 version: !ruby/object:Gem::Version
-  version: '1.0'
+  version: 1.0.1
 platform: ruby
 authors:
 - flyingboy007
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-06-23 00:00:00.000000000 Z
+date: 2017-07-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler