mrkt 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3002468b0ce903416cfff2fa51ef03940cf35252
-  data.tar.gz: 410bed015b4ecc50ef564c63a72aafdb528fff68
+  metadata.gz: 1e7f61fce15d29887b4a005927f6f194cf5ab71c
+  data.tar.gz: ec88ab8e0a07767870ac7696e0bbee9d93d21af5
 SHA512:
-  metadata.gz: ccfddbff9633674fd87973063e3cff57fda750cb28d2087b334c2d17a536f9fb73032cd69edcf3f0be6e0fbb264cf4e2f8376b6f6cfa2fc2f2ad0d699f97816c
-  data.tar.gz: d4ff3f1a12d64609f3dab730c30f7bfc8b6e6767e6e527524c0cfc6441033c2c3ae5bee757182c92d26f5d0fb56b9f25ba865b7a320c4c63ebed6560a41e72d4
+  metadata.gz: 143a6acf4d42ed294a4d64d3367a6c4fdf1b783e25529500ba16007deb4e3c79024c5802f1be549537b3eed8d328ea5422adcf8d84afbad09a5280852f8fc90d
+  data.tar.gz: 001c7bced04d32e4e7118a3db7ae21b933491ee71d86bb929538bb4223986f05b5db4acb1e4fe1567804eff37bb596623faddb95f3b2010b4398d5adfb9c6dc4

data/.travis.yml

@@ -3,3 +3,5 @@ rvm:
   - 2.0.0
   - 2.1.5
   - 2.2.0
+addons:
+  code_climate: 45cd2174f49b570406e294ff393d456c4ae8532cf16dd6430abb06d8a0722a28

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    mrkt (0.4.0)
+    mrkt (0.5.0)
       faraday_middleware (~> 0.9.1)
 
 GEM
@@ -10,6 +10,8 @@ GEM
     addressable (2.3.8)
     byebug (4.0.5)
       columnize (= 0.9.0)
+    codeclimate-test-reporter (0.4.7)
+      simplecov (>= 0.7.1, < 1.0.0)
     coderay (1.1.0)
     columnize (0.9.0)
     crack (0.4.2)
@@ -60,6 +62,7 @@ PLATFORMS
 
 DEPENDENCIES
   bundler (~> 1.3)
+  codeclimate-test-reporter (~> 0.4.7)
   mrkt!
   pry-byebug (~> 3.1.0)
   rake (~> 10.0)

data/README.md

@@ -1,7 +1,8 @@
 # Mrkt
 
 [![Build Status](https://secure.travis-ci.org/raszi/mrkt.png)](http://travis-ci.org/raszi/mrkt)
-[![Gem Version](https://badge.fury.io/rb/mrkt.png)](http://badge.fury.io/rb/mrkt)
+[![Code Climate](https://codeclimate.com/github/raszi/mrkt/badges/gpa.svg)](https://codeclimate.com/github/raszi/mrkt)
+[![Test Coverage](https://codeclimate.com/github/raszi/mrkt/badges/coverage.svg)](https://codeclimate.com/github/raszi/mrkt)
 
 This gem provides some level of abstraction to Marketo REST APIs. Please note that this gem is alpha quality. 
 
@@ -53,7 +54,7 @@ client.debug = true
     
 ```ruby
 response = client.get_leads :email, 'sammy@acme.com'
-response.body[:result].each do |result|
+response[:result].each do |result|
   p "id: #{result[:id]}, email: #{result[:email]}"
 end
 ```
@@ -62,7 +63,7 @@ end
 
 ```ruby
 response = client.createupdate_leads([ email: 'sample@example.com', firstName: 'John' ], lookup_field: :email)
-response.body[:result].each do |result|
+response[:result].each do |result|
   p "id: #{result[:id]}, email: #{result[:email]}"
 end
 ```

data/lib/mrkt.rb

@@ -28,10 +28,12 @@ module Mrkt
       define_method(http_method) do |path, payload = {}, &block|
         authenticate!
 
-        connection.send(http_method, path, payload) do |req|
+        resp = connection.send(http_method, path, payload) do |req|
           add_authorization(req)
           block.call(req) unless block.nil?
         end
+
+        resp.body
       end
     end
   end

data/lib/mrkt/concerns/authentication.rb

@@ -14,13 +14,7 @@ module Mrkt
     end
 
     def authenticate
-      params = {
-        grant_type: 'client_credentials',
-        client_id: @client_id,
-        client_secret: @client_secret
-      }
-
-      connection.get('/identity/oauth/token', params).tap do |response|
+      connection.get('/identity/oauth/token', authentication_params).tap do |response|
         data = response.body
 
         @token = data.fetch(:access_token)
@@ -30,6 +24,14 @@ module Mrkt
       end
     end
 
+    def authentication_params
+      {
+        grant_type: 'client_credentials',
+        client_id: @client_id,
+        client_secret: @client_secret
+      }
+    end
+
     def add_authorization(req)
       req.headers[:authorization] = "Bearer #{@token}"
     end

data/lib/mrkt/version.rb

@@ -1,3 +1,3 @@
 module Mrkt
-  VERSION = '0.4.0'
+  VERSION = '0.5.0'
 end

data/mrkt.gemspec

@@ -8,9 +8,9 @@ Gem::Specification.new do |spec|
   spec.version       = Mrkt::VERSION
   spec.authors       = ['KARASZI István', 'Jacques Lemieux']
   spec.email         = ['github@spam.raszi.hu', 'jalemieux@gmail.com']
-  spec.description   = 'Marketo REST API Facade'
-  spec.summary       = ''
-  spec.homepage      = ''
+  spec.summary       = 'Marketo REST API Facade'
+  spec.description   = 'This gem helps you to use the Marketo REST API'
+  spec.homepage      = 'https://github.com/raszi/mrkt'
   spec.license       = 'MIT'
 
   spec.files         = `git ls-files`.split($/)
@@ -28,4 +28,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'webmock', '~> 1.21.0'
   spec.add_development_dependency 'simplecov', '~> 0.10.0'
   spec.add_development_dependency 'pry-byebug', '~> 3.1.0'
+  spec.add_development_dependency 'codeclimate-test-reporter', '~> 0.4.7'
 end

data/spec/concerns/crud_leads_spec.rb

@@ -28,7 +28,7 @@ describe Mrkt::CrudLeads do
         .to_return(json_stub(response_stub))
     end
 
-    it { is_expected.to be_success }
+    it { is_expected.to eq(response_stub) }
   end
 
   describe '#createupdate_leads' do
@@ -72,7 +72,7 @@ describe Mrkt::CrudLeads do
         .to_return(json_stub(response_stub))
     end
 
-    it { is_expected.to be_success }
+    it { is_expected.to eq(response_stub) }
   end
 
   describe '#delete_leads' do
@@ -101,7 +101,7 @@ describe Mrkt::CrudLeads do
         .to_return(json_stub(response_stub))
     end
 
-    it { is_expected.to be_success }
+    it { is_expected.to eq(response_stub) }
   end
 
   describe '#associate_lead' do
@@ -126,7 +126,7 @@ describe Mrkt::CrudLeads do
         }
       end
 
-      it { is_expected.to be_success }
+      it { is_expected.to eq(response_stub) }
     end
 
     context 'with a non-existing lead id' do

data/spec/concerns/import_leads_spec.rb

@@ -35,7 +35,7 @@ describe Mrkt::ImportLeads do
       tempfile.unlink
     end
 
-    it { is_expected.to be_success }
+    it { is_expected.to eq(response_stub) }
   end
 
   describe '#import_lead_status' do
@@ -63,14 +63,12 @@ describe Mrkt::ImportLeads do
         .to_return(json_stub(response_stub))
     end
 
-    it { is_expected.to be_success }
+    it { is_expected.to eq(response_stub) }
   end
 
   describe '#import_lead_failures' do
     let(:id) { 1 }
-    let(:respose_stub) do
-
-    end
+    let(:response_stub) { '' }
     subject { client.import_lead_failures(1) }
 
     before do
@@ -78,14 +76,12 @@ describe Mrkt::ImportLeads do
         .to_return(headers: { content_length: 0 })
     end
 
-    it { is_expected.to be_success }
+    it { is_expected.to eq(response_stub) }
   end
 
   describe '#import_lead_warnings' do
     let(:id) { 1 }
-    let(:respose_stub) do
-
-    end
+    let(:response_stub) { '' }
     subject { client.import_lead_warnings(1) }
 
     before do
@@ -93,6 +89,6 @@ describe Mrkt::ImportLeads do
         .to_return(headers: { content_length: 0 })
     end
 
-    it { is_expected.to be_success }
+    it { is_expected.to eq(response_stub) }
   end
 end

data/spec/spec_helper.rb

@@ -3,6 +3,11 @@ if ENV['COVERAGE']
   SimpleCov.start
 end
 
+if ENV['CODECLIMATE_REPO_TOKEN']
+  require "codeclimate-test-reporter"
+  CodeClimate::TestReporter.start
+end
+
 require 'bundler/setup'
 Bundler.setup
 

data/spec/support/webmock.rb

@@ -1,10 +1,16 @@
 require 'webmock/rspec'
 
-RSpec.configure do
+RSpec.configure do |config|
   def json_stub(content_stub)
     {
       headers: { content_type: 'application/json' },
       body: JSON.generate(content_stub)
     }
   end
+
+  if ENV['CODECLIMATE_REPO_TOKEN']
+    config.after(:suite) do
+      WebMock.disable_net_connect!(allow: 'codeclimate.com') 
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mrkt
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - KARASZI István
@@ -109,7 +109,21 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 3.1.0
-description: Marketo REST API Facade
+- !ruby/object:Gem::Dependency
+  name: codeclimate-test-reporter
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.4.7
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.4.7
+description: This gem helps you to use the Marketo REST API
 email:
 - github@spam.raszi.hu
 - jalemieux@gmail.com
@@ -132,7 +146,6 @@ files:
 - lib/mrkt/concerns/import_leads.rb
 - lib/mrkt/errors.rb
 - lib/mrkt/faraday_middleware.rb
-- lib/mrkt/faraday_middleware/request.rb
 - lib/mrkt/faraday_middleware/response.rb
 - lib/mrkt/version.rb
 - mrkt.gemspec
@@ -144,7 +157,7 @@ files:
 - spec/spec_helper.rb
 - spec/support/initialized_client.rb
 - spec/support/webmock.rb
-homepage: ''
+homepage: https://github.com/raszi/mrkt
 licenses:
 - MIT
 metadata: {}
@@ -167,7 +180,7 @@ rubyforge_project:
 rubygems_version: 2.4.3
 signing_key: 
 specification_version: 4
-summary: ''
+summary: Marketo REST API Facade
 test_files:
 - spec/concerns/authentication_spec.rb
 - spec/concerns/crud_leads_spec.rb

data/lib/mrkt/faraday_middleware/request.rb

@@ -1,58 +0,0 @@
-require 'faraday_middleware'
-
-module Mrkt
-  module FaradayMiddleware
-    class Request < Faraday::Middleware
-      def initialize(app, client_id, client_secret)
-        super(app)
-
-        @client_id = client_id
-        @client_secret = client_secret
-      end
-
-      def call(env)
-        authenticate(env) unless authenticated? || env[:authentication]
-
-        env.request_headers[:authorization] = "Bearer #{@token}"
-        @app.call(env)
-      end
-
-      def authenticated?
-        @token && token_valid?
-      end
-
-      def token_valid?
-        @valid_until && Time.now < @valid_until
-      end
-
-      def authenticate(orig_env)
-        env = Faraday::Env.from(orig_env)
-
-        body = env[:body]
-        params = Faraday::Utils::ParamsHash.new
-        params.update(
-          grant_type: 'client_credentials',
-          client_id: @client_id,
-          client_secret: @client_secret
-        )
-        env[:authentication] = true
-        env[:method] = :get
-
-        env[:url] = env[:url].dup
-        env[:url].path = '/identity/oauth/token'
-        env[:url].query = params.to_query
-
-        orig_env[:body] = body
-
-        response = @app.call(env)
-        data = response.body
-
-        @token = data[:access_token]
-        @token_type = data[:token_type]
-        @expires_in = data[:expires_in]
-        @valid_until = Time.now + data[:expires_in]
-        @scope = data[:scope]
-      end
-    end
-  end
-end