mr_speedy_ruby 1.0.0.pre.alpha.4 → 1.0.0.pre.alpha.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5d2c2406e33ada4b65dd88f1ab38466a18290dd9d83f0c29df982c419c660f48
-  data.tar.gz: 4d201453a1d10a717e4f338692f2c94fe6362ee1c94632d23377dcec6277616d
+  metadata.gz: a1e0002485b9bc4db8045c792a8d5a5e439ecb726cf39d08ff2ea3966fe928ec
+  data.tar.gz: 7a8b284eec6852baeef910382ea720df6a4f0854dffd3f5e3bbf9266eb588484
 SHA512:
-  metadata.gz: 1ac74e3e6d1ea3def5a5154248c1ed121659c410baea0a8009d8f35aba30ac65e0f54cce422eaf2fcfd0219a1409eb2fd36ba83277980e6c2fabe7ee142198a7
-  data.tar.gz: cdcf8e9499ff5e501a76bcf7ce259d36edfeefd2e39029ff63872241df60948308022150b30730eb22ca6a6e38a9a552517cabade835bd7b930dda90fc44b285
+  metadata.gz: 6b8bff1e5e413ba37b0d9b0c95f600b3187d69e7e3aa4ef17fd035441095c94f3d244499630ada8d0d1ec462691f983412d65ff2e8176f55f02a0df151ae91cd
+  data.tar.gz: 139799fd6c6ca76763b3c26078aaf62556697a45a2cd65809d718b55fb1973a949d85e5ec57f6aa2d04f793dfe058b839ce450119148105aea564770243396cb

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    mr_speedy_ruby (1.0.0.pre.alpha.4)
+    mr_speedy_ruby (1.0.0.pre.alpha.5)
 
 GEM
   remote: https://rubygems.org/

data/fixtures/vcr_cassettes/raise_invalid_parameters.yml

@@ -0,0 +1,49 @@
+---
+http_interactions:
+- request:
+    method: post
+    uri: https://robotapitest.mrspeedy.ph/api/business/1.1/create-order
+    body:
+      encoding: UTF-8
+      string: '{"matter":null,"vehicle_type_id":8,"points":[{"address":"","contact_person":{"name":"","phone":""},"packages":[]},{"address":"Unit
+        802, EcoTower, 32nd Street corner 9th Avenue, BGC, Taguig, 1634 Metro Manila","contact_person":{"name":"Reciever","phone":"639123456789"},"packages":[]}]}'
+    headers:
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Ruby
+      Host:
+      - robotapitest.mrspeedy.ph
+      X-Dv-Auth-Token:
+      - 70B4ABCA8A35AC50E1585E27F217DF160F740D46
+  response:
+    status:
+      code: 400
+      message: Bad Request
+    headers:
+      Server:
+      - nginx
+      Date:
+      - Tue, 27 Oct 2020 08:37:50 GMT
+      Content-Type:
+      - application/json; charset=utf-8
+      Transfer-Encoding:
+      - chunked
+      Connection:
+      - keep-alive
+      X-Frame-Options:
+      - DENY
+      X-Content-Type-Options:
+      - nosniff
+      X-Xss-Protection:
+      - 1; mode=block;
+      Strict-Transport-Security:
+      - max-age=63072000; includeSubDomains
+    body:
+      encoding: UTF-8
+      string: '{"is_successful":false,"errors":["invalid_parameters"],"parameter_errors":{"matter":["not_nullable"],"points":[{"address":["min_length"],"contact_person":{"phone":["invalid_phone"]}},null]}}'
+    http_version:
+  recorded_at: Tue, 27 Oct 2020 08:37:50 GMT
+recorded_with: VCR 5.1.0

data/lib/mr_speedy_ruby/base.rb

@@ -7,7 +7,7 @@ module MrSpeedyRuby
     require "json"
 
     AUTH_TOKEN_HEADER="X-DV-Auth-Token".freeze
-    PRODUCTION_BASE_URL="http://robot.mrspeedy.ph".freeze
+    PRODUCTION_BASE_URL="https://robot.mrspeedy.ph".freeze
     STAGING_BASE_URL="https://robotapitest.mrspeedy.ph".freeze
 
     # Constructor method
@@ -109,7 +109,12 @@ module MrSpeedyRuby
     def validate_error(response:)
       success = response["is_successful"]
       error = response["errors"]&.first || ""
-      MrSpeedyRuby::ErrorParser.raise_errors_from(code: error) unless success
+      unless success
+        MrSpeedyRuby::ErrorParser.raise_errors_from(
+          code: error,
+          errors: response["parameter_errors"]
+        )
+      end
     end
   end
 end

data/lib/mr_speedy_ruby/error_parser.rb

@@ -33,8 +33,8 @@ module MrSpeedyRuby
     class << self
       # Raise Error from Response Status
       # @param code [String] error code
-      def raise_errors_from(code:)
-        raise_error_for(code)
+      def raise_errors_from(code:, errors: nil)
+        raise_error_for(code, errors)
 
         # Default to Unexpected Error
         raise UnexpectedError
@@ -48,12 +48,19 @@ module MrSpeedyRuby
       # @private
       #
       # @raise [MrSpeedyRuby::MrSpeedyError] raise code based error
-      def raise_error_for(code)
+      def raise_error_for(code, errors)
         error = ERROR_CODES[code]
+        return unless error
 
-        # Constantize string class
-        # @see https://stackoverflow.com/a/5924541
-        raise Object.const_get("MrSpeedyRuby::#{error}") if error
+        if error == MrSpeedyRuby::InvalidParameters
+          # Include parameter errors
+          msg = "Request parameters contain errors, ERRORS: #{errors.inspect}"
+          raise MrSpeedyRuby::InvalidParameters, msg
+        else
+          # Constantize string class
+          # @see https://stackoverflow.com/a/5924541
+          raise Object.const_get("MrSpeedyRuby::#{error}")
+        end
       end
     end
   end

data/lib/mr_speedy_ruby/version.rb

@@ -1,3 +1,3 @@
 module MrSpeedyRuby
-  VERSION = "1.0.0-alpha.4"
+  VERSION = "1.0.0-alpha.6"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mr_speedy_ruby
 version: !ruby/object:Gem::Version
-  version: 1.0.0.pre.alpha.4
+  version: 1.0.0.pre.alpha.6
 platform: ruby
 authors:
 - Peter John Alvarado
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-05-14 00:00:00.000000000 Z
+date: 2020-10-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -133,6 +133,7 @@ files:
 - fixtures/vcr_cassettes/orders_with_limit.yml
 - fixtures/vcr_cassettes/orders_with_offset.yml
 - fixtures/vcr_cassettes/place_order.yml
+- fixtures/vcr_cassettes/raise_invalid_parameters.yml
 - lib/mr_speedy_ruby.rb
 - lib/mr_speedy_ruby/base.rb
 - lib/mr_speedy_ruby/client.rb
@@ -148,7 +149,7 @@ licenses:
 metadata:
   homepage_uri: https://github.com/redjoker011/mr_speedy_ruby
   source_code_uri: https://github.com/redjoker011/mr_speedy_ruby
-post_install_message: 
+post_install_message:
 rdoc_options:
 - "--title"
 - MrSpeedyRuby - mr.speedy api integration for ruby
@@ -170,9 +171,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.3.1
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.3
-signing_key: 
+rubyforge_project:
+rubygems_version: 2.7.6
+signing_key:
 specification_version: 4
 summary: Mr.speedy api integration for ruby
 test_files: []