mperham-politics 0.2.1 → 0.2.2

data/History.rdoc

@@ -1,5 +1,10 @@
 = Changelog
 
+== 0.2.2 (2009-01-07)
+
+* Fix invalid leader? logic in TokenWorker which could allow
+  two workers to become leader at the same time. (Brian Dainton)
+
 == 0.2.1 (2008-11-04)
 
 * Cleanup and prepare for public release for RubyConf 2008.

data/README.rdoc

@@ -23,6 +23,10 @@ toes?  There are several answers:
    is fault tolerant but not as scalable, as only one process is performing the task at a given
    point in time.  See the +TokenWorker+ mixin.
 
+== Installation
+
+  sudo gem install mperham-politics -s http://gems.github.com
+
 == Dependencies
 
 StaticQueueWorker mixin
@@ -39,7 +43,7 @@ TokenWorker mixin
 Name::      Mike Perham
 Email::     mailto:mperham@gmail.com
 Twitter::   http://twitter.com/mperham
-Homepage::  http://mikeperham.com/politics/
+Homepage::  http://mikeperham.com/
 
 This software is free for you to use as you'd like.  If you find it useful, please consider giving 
 me a recommendation at {Working with Rails}[http://workingwithrails.com/person/10797-mike-perham].

data/lib/politics/token_worker.rb

@@ -142,17 +142,15 @@ module Politics
     
     # Nominate ourself as leader by contacting the memcached server
     # and attempting to add the token with our name attached.
+    # The result will tell us if memcached stored our value and therefore
+    # if we are now leader.
     def nominate
-      memcache_client.add(token, worker_name, iteration_length)
+      result = memcache_client.add(token, worker_name, iteration_length)
+      @leader = (result == 'STORED')
     end
 
-    # Check to see if we are leader by looking at the process name
-    # associated with the token.
     def leader?
-      @leader ||= begin
-        master_worker = memcache_client.get(token)
-        worker_name == master_worker
-      end
+      @leader
     end
 
     # Easy to mock or monkey-patch if another MemCache client is preferred.

data/lib/politics/version.rb

@@ -1,5 +1,5 @@
 module Politics
   module Version
-    STRING = "0.2.1"
+    STRING = "0.2.2"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: mperham-politics
 version: !ruby/object:Gem::Version 
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors: 
 - Mike Perham
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2008-10-27 00:00:00 -07:00
+date: 2008-12-22 00:00:00 -08:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency