moxml 0.5.98 → 0.5.99

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8c17ad7b7e8250a5f143af509bfe551cb5c29deb1a2ae7f5cc64f275d8d460df
-  data.tar.gz: 9c6302666df0ca9a3761b2c072dc098ff3bc49a419b9cba404161e7d352bc70b
+  metadata.gz: e0799669e81215c8738217d5d9f75a5cc8842a9a35c92553d07f3f60ee6a8196
+  data.tar.gz: 86aeb7370ef541cc898fa1f3c9a63ba3da154a7ffb09a68d0236f82a1241fc10
 SHA512:
-  metadata.gz: f47afe09d0f5cbe9016846c3ca7d8b43bd7f8f79b63b7dfdc51013578a71b82ef4b28701a7dea4be55edbb96e9a2f5cc011c7cc51a7029dcdcad557e542c8c37
-  data.tar.gz: 1d7d971a95328b9397b71c49ff0c01df4af8ffc1e38c461a4801dd294993d58faa6eae05018000dd5c02e719a9162d25fcdf912b334409b2d3731f6fb67b36c5
+  metadata.gz: '0932b236b7f6e452705f49c6328848edd315774b35ae47d732a90fa65e5ed98612265765fab4c5bde3ca7eaad79b583457da72e051dbbac3d1df027986105435'
+  data.tar.gz: 1afbad96dc4a770d0b7c74a23fa55d6d80b2c80a3276bec9ae4b83d10cbda9cb59ae22649634ebfc4c6b49ab7715364396bf387236234372fc93212e4a3d0777

data/lib/moxml/adapter/leptris.rb

@@ -1774,6 +1774,31 @@ module Moxml
           child_native
         end
 
+        # moxml#304: a cross-document attach makes the target's tree
+        # point into the child's owning document; when that document is
+        # collected its arena dies and the subtree vanishes (empty
+        # output, nameless element pairs — silent, GC-dependent). Pin
+        # the owning document on the target's document so the arena
+        # outlives every attached subtree.
+        def pin_foreign_owner_document(parent, child)
+          return unless child.is_a?(NN) || child.is_a?(::Leptris::XML::Node)
+
+          # Two document fetches + identity compare on the same-document
+          # hot path (every builder add_child); the WeakMap bridge and
+          # the pin only pay when the child actually comes from another
+          # document.
+          child_doc = child.is_a?(NN) ? NN_DOCUMENT.bind_call(child) : child.document
+          return if child_doc.nil?
+
+          parent_doc = parent.is_a?(NN) ? NN_DOCUMENT.bind_call(parent) : parent.document
+          return if parent_doc.nil? || child_doc.equal?(parent_doc)
+
+          owner = child_doc.is_a?(NN) ? to_binding(child_doc) : child_doc
+          docs = attachments.get(parent_doc, :adopted_docs) || []
+          docs << owner
+          attachments.set(parent_doc, :adopted_docs, docs)
+        end
+
         def add_child(parent, child)
           if NATIVE_READ_LAYER && !(NATIVE_MUTATIONS_COHERENT &&
                    parent.is_a?(::Leptris::XML::NativeNode) &&
@@ -1781,6 +1806,7 @@ module Moxml
             parent = to_binding(parent)
             child = to_binding(child)
           end
+          pin_foreign_owner_document(parent, child)
           case parent
           when ::Leptris::XML::Document then add_document_child(parent, child)
           else

data/lib/moxml/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Moxml
-  VERSION = "0.5.98"
+  VERSION = "0.5.99"
 end

data/spec/moxml/adapter/leptris_append_gc_spec.rb

@@ -0,0 +1,52 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+# moxml#304: cross-document append_xml / add_child silently lost
+# appended subtrees under GC pressure on MRI < 3.4 — the wrapper
+# registry's WeakMap loses/mangles entries during incremental GC
+# marking (moxml#303's root cause) while the appended fragment's
+# natives are only weakly held; the references then read freed
+# natives ("<sections></sections>", nameless element pairs).
+# The strong-registry fallback (WEAK_WRAPPERS=false on MRI < 3.4)
+# resolves it; this pins the shape.
+RSpec.describe "leptris cross-document append under GC pressure" do
+  let(:ctx) { Moxml.new(:leptris) }
+  let(:frags) do
+    [
+      '<clause id="a"><p>one</p></clause>',
+      '<annex id="b"><p>two &amp; more</p><fn ref="1"/><!-- c --></annex>',
+      '<p standalone="x" y="1"/>',
+    ]
+  end
+
+  it "keeps appended subtrees across collections" do
+    8.times do
+      root = ctx.parse("<sections/>").root
+      frags.each do |frag|
+        root.append_xml(frag)
+        GC.start(full_mark: true, immediate_sweep: true)
+      end
+      out = root.to_xml(indent: 0)
+      expect(out).to include("<clause")
+      expect(out).to include("<annex")
+      expect(out).to include("standalone")
+      expect(out).not_to include("<></>")
+    end
+  end
+
+  it "keeps parse_fragment nodes across collections" do
+    built = ctx.parse("<sections/>")
+    4.times do
+      frags.each do |frag|
+        ctx.parse_fragment(frag).each do |node|
+          built.root.add_child(node)
+          GC.start(full_mark: true, immediate_sweep: true)
+        end
+      end
+      out = built.root.to_xml(indent: 0)
+      expect(out).to include("<clause")
+      expect(out).to include("<annex")
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: moxml
 version: !ruby/object:Gem::Version
-  version: 0.5.98
+  version: 0.5.99
 platform: ruby
 authors:
 - Ribose Inc.
@@ -440,6 +440,7 @@ files:
 - spec/moxml/adapter/base_spec.rb
 - spec/moxml/adapter/entity_restoration_spec.rb
 - spec/moxml/adapter/headed_ox_spec.rb
+- spec/moxml/adapter/leptris_append_gc_spec.rb
 - spec/moxml/adapter/leptris_doc_parts_spec.rb
 - spec/moxml/adapter/leptris_parse_skips_spec.rb
 - spec/moxml/adapter/leptris_record_driver_spec.rb