moxml 0.5.34 → 0.5.35

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d43dcd89303022c12889585b26d38ab3bf199046d869b6412d45c6f3f9249347
-  data.tar.gz: e09d8585d90c5a2765040aaf4060bedaececca5228fe7808c11841088415d2e0
+  metadata.gz: f80e7825989e8653fcc4037f6e6a538ca28da7c6637d6bb941985bcc98d4dabf
+  data.tar.gz: 974854c0f42279c86e404e48920a2fd6e92cebbac22a7c6781bae023fa017fde
 SHA512:
-  metadata.gz: ff23fcc8eaa05cefd83e236a387b707803d8fd06968e9bc84aefd450ff3f2eeca6445fe5a16e3ddd65bcf315b78e140bf27de3f45c30125a34eb6723cee26768
-  data.tar.gz: af7d2a75a27d30be26dc4daf750a77661235cf9c203b7e5c0638fde4fe58bed062499f4fa0b1f6648cb6aabc5b45768dfcfa101f095e1037143be67366ad8d94
+  metadata.gz: 7749417f017a166425fb18e896e6c0346475dd78cb32792fe725153512b64c384f60cf026e5d8503e7fb0878f22a3e6f92221126f98f08550a7b58ba1e65e2a4
+  data.tar.gz: 6545711a0dec77522f2965c5239c7cb8632878170e0fd6ea024be4d64515e49cd26550cf40b9dab7dda1ed2faa5e98caa0e076e0fda6781f7cc64463c520fd59

data/docs/_pages/performance.adoc

@@ -235,6 +235,18 @@ generation; `xmlns` writes keep the global bump.
 | `Element#text` read | 422ns | 346ns (-18%) |
 | `create_text` allocations | 6/node | 5/node |
 | Bare attribute read `[]` | 714ns | 513ns (-28%) |
+| Consumer pipeline (parse + typed walk) | 6112µs (0.50x) | 4915µs (0.67x) |
+
+The pipeline jump has two causes: leptris 1.9.157-1.9.162 (inline
+attribute values, TLS hoist, inline edge encoding, O(this-document)
+free, create+append -24%) and the restoration of the bare-read
+early return — a style edit in #205 dropped the `return`, and every
+entity-free bare read fell through into the full resolver (correct
+values, double the work; 15276µs on the same fixture). The parity
+suite now pins zero attribute-list materializations for bare reads
+on fast-path adapters — silent fall-throughs of this shape are
+exactly what allocation counts and materialization counters catch
+when wall-clock is noisy.
 
 Allocations unchanged (the invalidation clears are nil-writes; the
 read cache materializes lazily). The remaining cold-walk gap is

data/lib/moxml/element.rb

@@ -68,11 +68,9 @@ module Moxml
         # the document and the attachment store on every read, which
         # dominated the fast path.
         value = adapter.bare_attr_value(@native, key)
-        if value.is_a?(String) && entity_bearing?
-          return adapter.restore_entities(value)
-        end
+        return adapter.restore_entities(value) if value.is_a?(String) && entity_bearing?
 
-        value
+        return value
       end
 
       cache = attribute_read_cache

data/lib/moxml/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Moxml
-  VERSION = "0.5.34"
+  VERSION = "0.5.35"
 end

data/spec/integration/contract_parity_spec.rb

@@ -63,6 +63,34 @@
       end
     end
 
+    describe "bare-read fast path (regression: #205 dropped the return)" do
+      it "answers bare reads without materializing the attribute list" do
+        doc = ctx.parse(%(<r><e a="1" b="2"/></r>))
+        e = doc.root.children.first
+
+        materializations = 0
+        e.singleton_class.class_eval do
+          orig = instance_method(:attributes)
+          define_method(:attributes) do
+            materializations += 1
+            orig.bind_call(self)
+          end
+        end
+
+        expect(e["a"]).to eq("1")
+        expect(e["b"]).to eq("2")
+        expect(e["a"]).to eq("1")
+        # Fast-path adapters (nokogiri, leptris) must not materialize;
+        # the resolver adapters answer from the materialized list and
+        # the read cache — one list walk per element per generation.
+        if ctx.config.adapter.bare_get_qname_safe?
+          expect(materializations).to eq(0)
+        else
+          expect(materializations).to be > 0
+        end
+      end
+    end
+
     describe "qname create + namespace assignment (issue #208)" do
       it "does not double the prefix when the name is already qualified" do
         doc = ctx.parse(%(<r xmlns:p="urn:p"/>))

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: moxml
 version: !ruby/object:Gem::Version
-  version: 0.5.34
+  version: 0.5.35
 platform: ruby
 authors:
 - Ribose Inc.