moxiworks_platform 0.0.1 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 475dc2ec6d0129c5c8b8bf0ac055deaf0322d5e1
-  data.tar.gz: 2e45e81432029a487bce5ca73145df7b16b54113
+  metadata.gz: af96fed391f3936ebed6ede94c6f4b05d8ddf9d5
+  data.tar.gz: 1a4a034af70aad0fdbbe149a7d959d7ce0ed4150
 SHA512:
-  metadata.gz: 9ddb57edd8cd6f0c68f3f38aef503b118ce2470167f94f6f1930875db8c769f21e959a6f2a25bb9532d18ea756a9ed06a766eec3a8deefe5f902ba610461364f
-  data.tar.gz: 16a8f1f862e5c7632bdf9f632d5695cdfdf601fb44fab0339bfb4263ad91c37813f3e8c9a51d99ae29aed3329fd90907fffc7ebb3e3687ba72d9c1af23b3ee4c
+  metadata.gz: 5e37c415d0b7071b1a6fdd9913f6f79e33de27cd9e6659cc8e76b02f46785c7833c0332966048083cd4ca64d8154826468d39fc3f1326b898ac6e0908a152b01
+  data.tar.gz: 7b02fec0cc6fea7e4ae335748f9e9b22abfa27a96059f6b7b0b3d7b27c99eec6cc492c2ee3ebddf4bfffd690be8eb4e3c0774b38b2ec59433bd60f31d87dc8a4

data/Gemfile

@@ -2,3 +2,9 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in moxiworks_platform.gemspec
 gemspec
+
+group :test do
+  gem 'vcr', '~> 2.9.3'
+  gem 'webmock'
+
+end

data/lib/moxiworks_platform/contact.rb

@@ -24,7 +24,7 @@ module MoxiworksPlatform
     #   Moxi Works Platform ID for the Contact
     #
     #   @return [String] Moxi Works Platform ID for the contact
-    attr_accessor :partner_contact_id
+    attr_accessor :moxi_works_contact_id
 
 
     # @!attribute business_website
@@ -534,7 +534,19 @@ module MoxiworksPlatform
     #   success = MoxiWorksPlatform::Contact.delete(moxi_works_agent_id: '123abcd', partner_contact_id: 'myUniqueContactId' )
     #
     def self.delete(opts={})
-      self.send_request(:delete, opts)
+      url = "#{MoxiworksPlatform::Config.url}/api/contacts/#{opts[:partner_contact_id]}"
+      required_opts = [:moxi_works_agent_id, :partner_contact_id]
+      required_opts.each do |opt|
+        raise ::MoxiworksPlatform::Exception::ArgumentError, "#{opt} required" if
+            opts[opt].nil? or opts[opt].empty?
+      end
+      RestClient::Request.execute(method: :delete,
+                                  url: url,
+                                  payload: opts, headers: self.headers) do |response|
+        puts response if MoxiworksPlatform::Config.debug
+        json = JSON.parse(response)
+        json['status'] == 'success'
+      end
     end
 
     # Send our remote request to the Moxi Works Platform
@@ -614,7 +626,9 @@ module MoxiworksPlatform
                                   url: url,
                                   payload: opts, headers: self.headers) do |response|
         puts response if MoxiworksPlatform::Config.debug
+        self.check_for_error_in_response(response)
         json = JSON.parse(response)
+        return false if not json['status'].nil? and json['status'] =='fail'
         contact = MoxiworksPlatform::Contact.new(json) unless json.nil? or json.empty?
       end
       contact
@@ -642,8 +656,8 @@ module MoxiworksPlatform
     # @example
     #   contact = MoxiWorksPlatform::Contact.find(moxi_works_agent_id: '123abcd', partner_contact_id: 'myUniqueContactId' )
     #   success = contact.delete
-    def delete(opts={})
-      MoxiworksPlatform::Contact.delete(opts)
+    def delete
+      MoxiworksPlatform::Contact.delete(self.to_hash)
     end
 
     private
@@ -665,7 +679,9 @@ module MoxiworksPlatform
 
     def numeric_value_for(attr_name, opts={})
       val = self.instance_variable_get("@#{attr_name}")
+      return val.to_i if val.is_a? Numeric and opts[:type] == :integer
       return val if val.is_a? Numeric
+      val.gsub!(/[^[:digit:]|\.]/, '') if val.is_a? String
       case opts[:type]
         when :integer
           instance_variable_set("@#{attr_name}", (val.nil? or val.empty?) ? nil : val.to_i)

data/lib/moxiworks_platform/credentials.rb

@@ -101,7 +101,7 @@ module MoxiworksPlatform
     # Removing the secret access key from the default inspect string.
     # @api private
     def inspect
-      "#<#{self.class.name} access_key_id=#{platform_identifier.inspect}>"
+      "#<#{self.class.name} platform_identifier=#{platform_identifier.inspect}>"
     end
 
   end

data/lib/moxiworks_platform/exception.rb

@@ -6,5 +6,8 @@ module MoxiworksPlatform
     # an expected argument is not defined, or the argument is in an unexpected form
     class ArgumentError < PlatformError; end
 
+    class AuthorizationError < PlatformError; end
+
+    class RemoteRequestFailure < PlatformError; end
   end
 end

data/lib/moxiworks_platform/resource.rb

@@ -30,7 +30,7 @@ module MoxiworksPlatform
       {
           Authorization: auth_header,
           Accept: accept_header,
-          'Content-Type' =>  content_type
+          'Content-Type' =>  content_type_header
       }
     end
 
@@ -38,7 +38,8 @@ module MoxiworksPlatform
     #
     # @return [String] Authorization header content
     def self.auth_header
-      raise 'MoxiworksPlatform::Credentials must be set before using' unless
+      raise MoxiworksPlatform::Exception::AuthorizationError,
+            'MoxiworksPlatform::Credentials must be set before using' unless
           MoxiworksPlatform::Credentials.set?
       identifier = MoxiworksPlatform::Credentials.platform_identifier
       secret = MoxiworksPlatform::Credentials.platform_secret
@@ -55,10 +56,23 @@ module MoxiworksPlatform
     # formatted Content-Type header
     #
     # @return [String] Content-Type header content
-    def self.content_type
+    def self.content_type_header
       'application/x-www-form-urlencoded'
     end
 
+    def self.check_for_error_in_response(response)
+      begin
+        json = JSON.parse(response)
+      rescue => e
+        raise MoxiworksPlatform::Exception::RemoteRequestFailure, "unable to parse remote response #{e}\n response:\n  #{response}"
+      end
+      message = "unable to perform remote action on Moxi Works platform\n"
+      message << json['messages'].join(',') unless json['messages'].nil?
+
+      raise MoxiworksPlatform::Exception::RemoteRequestFailure, message  if
+          not json['status'].nil? and (%w(error fail).include?(json['status']))
+    end
+
     # maps Hash values to Instance variables for mapping JSON object values to our Class attributes
     #
     def initialize(hash={})
@@ -83,7 +97,6 @@ module MoxiworksPlatform
       hash
     end
 
-
   end
 
 end

data/lib/moxiworks_platform/version.rb

@@ -1,3 +1,3 @@
 module MoxiworksPlatform
-  VERSION = '0.0.1'
+  VERSION = '0.1.0'
 end

data/moxiworks_platform.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |spec|
   spec.email         = ["tres.wong-godfrey@moxiworks.com"]
 
   spec.summary       = %q{Ruby Moxi Works Platform Client}
-  spec.homepage      = 'http://github.io/moxiworks-platform/moxiworks-platform-ruby'
+  spec.homepage      = 'https://github.io/moxiworks-platform/moxiworks-ruby'
 
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   spec.bindir        = "exe"
@@ -21,6 +21,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec", "~> 3.0"
   spec.add_development_dependency 'rest-client'
-  spec.add_dependency 'hashie'
 
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: moxiworks_platform
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.0
 platform: ruby
 authors:
 - Tres Wong-Godfrey
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-04-04 00:00:00.000000000 Z
+date: 2016-04-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -66,20 +66,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: hashie
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description: 
 email:
 - tres.wong-godfrey@moxiworks.com
@@ -103,7 +89,7 @@ files:
 - lib/moxiworks_platform/resource.rb
 - lib/moxiworks_platform/version.rb
 - moxiworks_platform.gemspec
-homepage: http://github.io/moxiworks-platform/moxiworks-platform-ruby
+homepage: https://github.io/moxiworks-platform/moxiworks-ruby
 licenses: []
 metadata: {}
 post_install_message: