moviepilot-gwo 0.1 → 0.1.1

data/lib/gwo.rb

@@ -150,7 +150,7 @@ module GWO
 \
             #{ js_logger("'variant: ' + GWO_#{section}_name") }\
         }
-        google_analytics_info += "google_analytics_info += \"&GWO_#{section}_name=\" + GWO_#{section}_name;" if options[:ga_tracking]
+        google_analytics_info += "google_analytics_info += \"&#{section}=\" + GWO_#{section}_name;" if options[:ga_tracking]
       end
 
       if options[:ga_tracking]
@@ -158,8 +158,8 @@ module GWO
         variable_assignments += %{\
            window.onload = function(){ \
             var google_analytics_info = ''; #{google_analytics_info}; if(typeof(trackPageView) == 'function') {\
-              trackPageView(#{base_url} + "?ab_test=true" + google_analytics_info);\
-              #{js_logger("#{base_url} + \"?ab_test=true\" + google_analytics_info")}\
+              trackPageView(#{base_url} + "?ab_test=#{id}" + google_analytics_info);\
+              #{js_logger("#{base_url} + \"?ab_test=#{id}\" + google_analytics_info")}\
             }\
           }\
         }

data/spec/lib/gwo_spec.rb

@@ -6,29 +6,29 @@ describe GWO do
 
   describe "google analytics stuff" do
     it "should not create any google analytics stuff by default" do
-      gwo_start("gwo_id", "section_name").should_not =~ /google_analytics_info \+= \"&GWO_section_name_name=\" \+ GWO_section_name_name;/
-      gwo_start("gwo_id", "section_name").should_not =~ /trackPageView\(document.location \+ \"\?ab_test=true\" \+ google_analytics_info\)/
+      gwo_start("gwo_id", "section_name").should_not =~ /google_analytics_info \+= \"&section_name=\" \+ GWO_section_name_name;/
+      gwo_start("gwo_id", "section_name").should_not =~ /trackPageView\(document.location \+ \"\?ab_test=gwo_id\" \+ google_analytics_info\)/
     end
     it "should not create google analytics stuff if option is disabled" do
-      gwo_start("gwo_id", "section_name", :ga_tracking => false).should_not =~ /google_analytics_info \+= \"&GWO_section_name_name=\" \+ GWO_section_name_name;/
-      gwo_start("gwo_id", "section_name", :ga_tracking => false).should_not =~ /trackPageView\(document.location \+ \"\?ab_test=true\" \+ google_analytics_info\)/
+      gwo_start("gwo_id", "section_name", :ga_tracking => false).should_not =~ /google_analytics_info \+= \"&section_name=\" \+ GWO_section_name_name;/
+      gwo_start("gwo_id", "section_name", :ga_tracking => false).should_not =~ /trackPageView\(document.location \+ \"\?ab_test=gwo_id\" \+ google_analytics_info\)/
     end
 
     it "should create correct google analytics stuff for default urls" do
-      gwo_start("gwo_id", "section_name", :ga_tracking => true).should =~ /google_analytics_info \+= \"&GWO_section_name_name=\" \+ GWO_section_name_name;/
-      gwo_start("gwo_id", "section_name", :ga_tracking => true).should =~ /trackPageView\(document.location \+ \"\?ab_test=true\" \+ google_analytics_info\)/
+      gwo_start("gwo_id", "section_name", :ga_tracking => true).should =~ /google_analytics_info \+= \"&section_name=\" \+ GWO_section_name_name;/
+      gwo_start("gwo_id", "section_name", :ga_tracking => true).should =~ /trackPageView\(document.location \+ \"\?ab_test=gwo_id\" \+ google_analytics_info\)/
     end
 
     it "should create correct google analytics stuff for static urls" do
-      gwo_start("gwo_id", "section_name", :ga_tracking => true, :ga_base_url => "http://example.com").should =~ /google_analytics_info \+= \"&GWO_section_name_name=\" \+ GWO_section_name_name;/
-      gwo_start("gwo_id", "section_name", :ga_tracking => true, :ga_base_url => "http://example.com").should =~ /trackPageView\(\"http:\/\/example\.com\" \+ \"\?ab_test=true\" \+ google_analytics_info\)/
+      gwo_start("gwo_id", "section_name", :ga_tracking => true, :ga_base_url => "http://example.com").should =~ /google_analytics_info \+= \"&section_name=\" \+ GWO_section_name_name;/
+      gwo_start("gwo_id", "section_name", :ga_tracking => true, :ga_base_url => "http://example.com").should =~ /trackPageView\(\"http:\/\/example\.com\" \+ \"\?ab_test=gwo_id\" \+ google_analytics_info\)/
     end
 
     it "should create correct google analytics stuff for several sections" do
-      gwo_start("gwo_id", ["section_name1", "section_name2", "section_name3"], :ga_tracking => true).should =~ /google_analytics_info \+= \"&GWO_section_name1_name=\" \+ GWO_section_name1_name;/
-      gwo_start("gwo_id", ["section_name1", "section_name2", "section_name3"], :ga_tracking => true).should =~ /google_analytics_info \+= \"&GWO_section_name2_name=\" \+ GWO_section_name2_name;/
-      gwo_start("gwo_id", ["section_name1", "section_name2", "section_name3"], :ga_tracking => true).should =~ /google_analytics_info \+= \"&GWO_section_name3_name=\" \+ GWO_section_name3_name;/
-      gwo_start("gwo_id", ["section_name1", "section_name2", "section_name3"], :ga_tracking => true).should =~ /trackPageView\(document.location \+ \"\?ab_test=true\" \+ google_analytics_info\)/
+      gwo_start("gwo_id", ["section_name1", "section_name2", "section_name3"], :ga_tracking => true).should =~ /google_analytics_info \+= \"&section_name1=\" \+ GWO_section_name1_name;/
+      gwo_start("gwo_id", ["section_name1", "section_name2", "section_name3"], :ga_tracking => true).should =~ /google_analytics_info \+= \"&section_name2=\" \+ GWO_section_name2_name;/
+      gwo_start("gwo_id", ["section_name1", "section_name2", "section_name3"], :ga_tracking => true).should =~ /google_analytics_info \+= \"&section_name3=\" \+ GWO_section_name3_name;/
+      gwo_start("gwo_id", ["section_name1", "section_name2", "section_name3"], :ga_tracking => true).should =~ /trackPageView\(document.location \+ \"\?ab_test=gwo_id\" \+ google_analytics_info\)/
     end
 
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: moviepilot-gwo
 version: !ruby/object:Gem::Version 
-  version: "0.1"
+  version: 0.1.1
 platform: ruby
 authors: 
 - Alex MacCaw
@@ -33,7 +33,6 @@ files:
 - rails/init.rb
 has_rdoc: true
 homepage: http://github.com/kesselborn/gwo
-licenses: 
 post_install_message: 
 rdoc_options: 
 - --line-numbers
@@ -55,7 +54,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.5
+rubygems_version: 1.2.0
 signing_key: 
 specification_version: 2
 summary: Plugin to easily make use of Server-Side Dynamic Section Variations with Google Web Optimizer