movie_show_times 0.0.2 → 0.0.3

data/lib/movie_show_times.rb

@@ -2,6 +2,7 @@ require "movie_show_times/version"
 require 'movie_show_times/crawler'
 require 'movie_show_times/parser'
 require 'movie_show_times/language_parser'
+require 'movie_show_times/genre_parser'
 
 module MovieShowTimes
   

data/lib/movie_show_times/genre_parser.rb

@@ -0,0 +1,36 @@
+# encoding: UTF-8
+
+module MovieShowTimes
+  class GenreParser
+    
+    def initialize(language = 'en')
+      @language = language
+      terms = nil
+      
+      begin
+        genres_file_contents = File.open("#{File.dirname(__FILE__)}/genres/#{language}.txt").readlines.map(&:chomp)
+        terms = genres_file_contents.join('|')
+      rescue Errno::ENOENT
+      end
+      @regular_expression = Regexp.new("(#{terms})", 'i') unless terms.nil?
+    end
+    
+    def parse(info_line)
+      if @regular_expression
+        parts = info_line.split(' - ')
+        parts.each do |p|
+          return p unless @regular_expression.match(p).nil?
+        end        
+      end
+      
+      nil
+      
+    end
+  end
+
+end
+
+=begin
+i.match("-+[^-]+-")
+
+=end

data/lib/movie_show_times/genres/en.txt

@@ -0,0 +1,28 @@
+Action
+Adventure
+Animation
+Biography
+Comedy
+Crime
+Documentary
+Drama
+Family
+Fantasy
+Film-Noir
+Game-Show
+History
+Horror
+Music
+Musical
+Mystery
+News
+Reality-TV
+Romance
+Sci-Fi
+Scifi
+Sport
+Suspense
+Talk-Show
+Thriller
+War
+Western

data/lib/movie_show_times/genres/es.txt

@@ -0,0 +1,26 @@
+acción
+aventura
+animación
+biografía
+comedia
+crimen
+documental
+drama
+familia
+fantasía
+Cine negro
+historia
+horror
+música
+musical
+misterio
+noticias
+reality
+romance
+ciencia ficción
+scifi
+deporte
+suspenso
+Talk-Show
+guerra
+western

data/lib/movie_show_times/parser.rb

@@ -10,6 +10,7 @@ module MovieShowTimes
     def initialize(language = 'en')
       @language = language
       @language_parser = MovieShowTimes::LanguageParser.new(language)
+      @genre_parser = MovieShowTimes::GenreParser.new(language)
       @theaters = Hash.new
       @movies = Hash.new
     end
@@ -49,16 +50,11 @@ module MovieShowTimes
     
     def parse_movie_info(info_line)
       duration = ChronicDuration.parse(info_line)
-      genre = parse_genre(info_line)
+      genre = @genre_parser.parse(info_line)
       language = @language_parser.parse(info_line)
       
       { :duration => duration, :genre => genre, :language => language }
     end
-    
-    def parse_genre(info_line)
-      matches = info_line.match(/(Drama|Scifi\/Fantasy|Documentary)/)
-      return matches[0] unless matches.nil?
-      nil
-    end
+
   end
 end

data/lib/movie_show_times/version.rb

@@ -1,3 +1,3 @@
 module MovieShowTimes
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/spec/genre_parser_spec.rb

@@ -0,0 +1,38 @@
+# encoding: UTF-8
+require 'spec_helper'
+
+describe MovieShowTimes::GenreParser do
+  context 'when initialized with language that does not have genre names file' do
+    it "it should return nil" do
+      @parser = MovieShowTimes::GenreParser.new('ur')
+      @parser.parse('1گھنٹہ 40م‏‏ - ہسپانوی').should be_nil
+    end
+  end
+  
+  
+  context 'parsing an info string' do
+    context 'in english' do
+      before :all do
+        @parser = MovieShowTimes::GenreParser.new('en')
+      end
+
+      it "detects genre name" do
+        @parser.parse('1hr 25min‎- Suspense - English').should match('Suspense')
+      end
+
+      it "detects genres names when there is more than one" do
+        @parser.parse('1hr 25min‎- Suspense/Thriller - English').should match('Suspense/Thriller')
+      end
+    end
+    
+    context 'in spanish' do
+      before :all do
+        @parser = MovieShowTimes::GenreParser.new('es')
+      end
+
+      it "detects genres names" do
+        @parser.parse('1h 57min‎- Acción/Aventuras/Drama‎- inglés‎').should match('Acción/Aventuras/Drama')
+      end
+    end
+  end
+end

data/spec/movie_show_times_spec.rb

@@ -87,14 +87,10 @@ describe MovieShowTimes do
     end
     
     it "provides movie info with genre" do
-      pending
-      
       movie = @movieShowTimes.movies['Mirror Mirror']
-      movie[:info][:genre].should_not be_nil
       movie[:info][:genre].should match('Scifi/Fantasy')
       
       movie = @movieShowTimes.movies['American Reunion']
-      movie[:info][:genre].should_not be_nil
       movie[:info][:genre].should match('Comedy/Romance')
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: movie_show_times
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-04-20 00:00:00.000000000Z
+date: 2012-04-21 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mechanize
-  requirement: &2153566980 !ruby/object:Gem::Requirement
+  requirement: &2156941580 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2153566980
+  version_requirements: *2156941580
 - !ruby/object:Gem::Dependency
   name: nokogiri
-  requirement: &2153566560 !ruby/object:Gem::Requirement
+  requirement: &2156941160 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2153566560
+  version_requirements: *2156941160
 - !ruby/object:Gem::Dependency
   name: chronic_duration
-  requirement: &2153566140 !ruby/object:Gem::Requirement
+  requirement: &2156940740 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2153566140
+  version_requirements: *2156940740
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &2153565720 !ruby/object:Gem::Requirement
+  requirement: &2156940320 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2153565720
+  version_requirements: *2156940320
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &2153565300 !ruby/object:Gem::Requirement
+  requirement: &2156939900 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +65,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2153565300
+  version_requirements: *2156939900
 - !ruby/object:Gem::Dependency
   name: fakeweb
-  requirement: &2156927680 !ruby/object:Gem::Requirement
+  requirement: &2156939480 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,7 +76,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2156927680
+  version_requirements: *2156939480
 description: Get Movie Show Times by Location
 email:
 - chrishein@gmail.com
@@ -91,6 +91,9 @@ files:
 - Rakefile
 - lib/movie_show_times.rb
 - lib/movie_show_times/crawler.rb
+- lib/movie_show_times/genre_parser.rb
+- lib/movie_show_times/genres/en.txt
+- lib/movie_show_times/genres/es.txt
 - lib/movie_show_times/language_parser.rb
 - lib/movie_show_times/languages/de.txt
 - lib/movie_show_times/languages/en.txt
@@ -108,6 +111,7 @@ files:
 - spec/fixtures/movies_bsas_4.txt
 - spec/fixtures/movies_bsas_5.txt
 - spec/fixtures/movies_bsas_6.txt
+- spec/genre_parser_spec.rb
 - spec/language_parser_spec.rb
 - spec/movie_show_times_spec.rb
 - spec/spec_helper.rb
@@ -143,6 +147,7 @@ test_files:
 - spec/fixtures/movies_bsas_4.txt
 - spec/fixtures/movies_bsas_5.txt
 - spec/fixtures/movies_bsas_6.txt
+- spec/genre_parser_spec.rb
 - spec/language_parser_spec.rb
 - spec/movie_show_times_spec.rb
 - spec/spec_helper.rb