movieDB 0.3.3 → 0.3.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 68334b883ec9779ff8af09572abf86e198bf961d
-  data.tar.gz: e9d628939efba68b613bd5691110e0874687a778
+  metadata.gz: abd7277f09e27f87c05a46760b7604142a13c4f4
+  data.tar.gz: 7b7982a640eff36476dcc23dfeb737e87f3ee911
 SHA512:
-  metadata.gz: 91331899578db5d4d806665a4bcd8b241a6c9b28b04bfcc0c0b3f5c26677118bdb2e41c7bfc5eb227fba2f821c8521c006f8e01d0a694e155e4a54dce74ab354
-  data.tar.gz: b3bde0df28b95fab130d24e7196c61bf01b7314430a5cb3542f3bc07ba4d16d747ceea412a61876d080a5cbdddda4114c5b54208c8a2f7615812e2ee489b9ce2
+  metadata.gz: 950a7d07348be94e30fb40e74048de44c6548f1794bf0c65ac140a6f2845733a76533c0d49e7ea5dec9f5b8397e76082f8b93580959c08ae0cf3d2e8589cca5c
+  data.tar.gz: e8293834822371dec1e2579eeff6e4f6aa9baf035c46ca8a0324d7458ca029c6c875afec8577cbb329448022207bc0c2d20ed0fec243b2c1eb11dee1b3f81863

data/Changelog.md

@@ -1,6 +1,8 @@
 ## Change Log
 
 Below is a complete listing of changes for each revision of movieDB.
+### 0.3.4
+* Moved attribute headers to data_export file.
 
 ### 0.3.3 / Jun 22, 2015
 * Changed test suite from rspec to unit test.

data/lib/movieDB.rb

@@ -85,11 +85,7 @@ unless defined? MovieDB::Movie
       DEFAULT_REVENUE = 456790
 
       def initialize(attributes = {})
-        $IMDB_ATTRIBUTES_HEADERS = movie_attr = %w(title cast_members cast_characters cast_member_ids cast_members_characters
-                        trailer_url director writers filming_locations company genres languages countries
-                        length plot poster rating votes mpaa_rating tagline year release_date revenue)
-
-        movie_attr.each do |attr|
+        MovieDB::DataExport::IMDB_ATTRIBUTES_HEADERS.each do |attr|
           self.send("#{attr}=", (attributes.has_key?(attr.to_sym) ? attributes[attr.to_sym] : self.class.const_get("DEFAULT_#{attr.upcase}")))
         end
       end
@@ -100,7 +96,7 @@ unless defined? MovieDB::Movie
       # You can fetch IMDb movie data like this:
       #   ids = ["2024544", "1800241" ]
       #
-      #   MovieDB::Movie.get_data(ids)
+      #   MovieDB::Movie.find_imdb_id(ids)
       #
       #  The fetch data is stored in redis for 1800 seconds
       #  And then written to a xls file.
@@ -144,7 +140,7 @@ unless defined? MovieDB::Movie
           imdb_movie_data = @imdb_movie_data[idx]
           tmdb_movie_data = @tmdb_movie_data[idx]
 
-          $IMDB_ATTRIBUTES_HEADERS.each do |attr_key|
+          MovieDB::DataExport::IMDB_ATTRIBUTES_HEADERS.each do |attr_key|
             begin imdb_movie_data.send(attr_key)
               attr_value = imdb_movie_data.send(attr_key)
             rescue

data/lib/movieDB/data_export.rb

@@ -6,7 +6,12 @@ require "json"
 # The key and values are written into a spreadsheet for later data analysis.
 module MovieDB
   module DataExport
+    IMDB_ATTRIBUTES_HEADERS = %w(title cast_members cast_characters cast_member_ids cast_members_characters
+                    trailer_url director writers filming_locations company genres languages countries
+                    length plot poster rating votes mpaa_rating tagline year release_date revenue)
+
     def export_movie_data(db_redis, imdb_ids)
+
       @db_redis = db_redis
       @imdb_ids = imdb_ids
 
@@ -38,7 +43,7 @@ module MovieDB
     end
 
     def create_spreadsheet_header
-      @sheet.row(0).concat $IMDB_ATTRIBUTES_HEADERS
+      @sheet.row(0).concat MovieDB::DataExport::IMDB_ATTRIBUTES_HEADERS
 
       title_format = Spreadsheet::Format.new :color => :blue, :weight => :bold, :size => 13
       float_format = Spreadsheet::Format.new :number_format => "0.00"
@@ -54,7 +59,7 @@ module MovieDB
       @imdb_ids.each_with_index do |imdb_id, idx|
         row = @sheet.row(idx + 1)
 
-        $IMDB_ATTRIBUTES_HEADERS.each do |attr_key|
+        MovieDB::DataExport::IMDB_ATTRIBUTES_HEADERS.each do |attr_key|
           string_values = ['title', 'language', 'length', 'rating', 'vote', 'release', 'mpaa_rating', 'year', 'revenue']
 
           # Check to see if the fetch redis value is in a JSON

data/lib/movieDB/version.rb

@@ -1,3 +1,3 @@
 module MovieDB
-  VERSION = "0.3.3"
+  VERSION = "0.3.4"
 end

data/test/unit/test_movie_db.rb

@@ -2,19 +2,16 @@ require 'test/unit'
 require "imdb"
 require "redis"
 require 'fileutils'
-
+require 'movieDB'
 begin
-  require 'MovieDB'
-rescue MovieError
+  require 'movieDB'
+rescue
 end
 
 class TestMovieDB < Test::Unit::TestCase
-
   # This unit test writes an excel file to the reports directory
-  # in your gem folder.
-  #
-  # So, this method removes and empty the reports folder of
-  # all or andy pre-existing test files.
+  # in your gem folder. So, this method removes and empty the reports folder of
+  # all or any pre-existing test files.
   def remove_test_files_from_reports_directory
     testxlsfiles = File.join("**", "reports", "*.xls")
     FileUtils.rm Dir.glob(testxlsfiles)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: movieDB
 version: !ruby/object:Gem::Version
-  version: 0.3.3
+  version: 0.3.4
 platform: ruby
 authors:
 - Albert McKeever
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-22 00:00:00.000000000 Z
+date: 2015-06-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler