move-to-go 5.0.6 → 5.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 91b6f9abf8f63efa4c4a49c64fa0ef214200fa78
-  data.tar.gz: 2842fa80a9fa1719c421924aae7e0250ea48bfe6
+  metadata.gz: 2d2b73e2b0e9c9080ec03808579ceabc8061071b
+  data.tar.gz: cc02c544cae43e1537df432fab74bbf345037626
 SHA512:
-  metadata.gz: 72b34f0e942fd720e85eebe9e9ff0cc6bf72d1396524e489e76812387405d98ec6f3174034ca6ce739be4527a357edeffa7e5664f30f2dcc55feec5ff1f9c60c
-  data.tar.gz: adde6e214d1941b7299592517258d55a9bea6db8015b6020cc9ddbbb2ee78790e565f78b631c96acb714fd405d1159665f760cadebfee5e882f07efe47fde5d5
+  metadata.gz: b2fa9757d14809a3e62c748f2a987b911a0e0b00be5b218d67bc6fb3ea72e82b50d42d4282079541ac6dcda82a31ddcd171ee17384acfd1064efed7817e49cf8
+  data.tar.gz: 3823343232c3d45f3b1c662ac99bf838042bf07a7427418d81642d4ddf63891c26945c65691c9611321e8cc8224b0859c42e35b68a549dfb57032398ed7d9ced

data/lib/move-to-go/model/organizations.rb

@@ -50,21 +50,21 @@ module MoveToGo
                     else raise
                 end
             } 
-            # Find all posible duplicates and collect them to sets.
+            # Find all possible duplicates and collect them to sets.
             possible_duplicate_sets = self
-                .values
-                .group_by{ |org|
-                    fields_to_check.map{ |field|
-                    case field # Some fields (Address) are accually class objects, check what we are dealing with
-                        when Symbol then val = org.instance_variable_get(field)
-                        when Array then val = org.instance_variable_get(field[0]).instance_variable_get(field[1])
-                    end
-                    val.downcase.strip
-                    }
+            .values
+            .group_by{ |org|
+                fields_to_check.map{ |field|
+                case field # Some fields (Address) are actually class objects, check what we are dealing with
+                    when Symbol then val = org.instance_variable_get(field)
+                    when Array then val = org.instance_variable_get(field[0]).instance_variable_get(field[1])
+                end
+                val != nil ? val.downcase.strip : val = ''
                 }
-                .select { |k, v| v.size > 1 }
-                .values
-
+            }
+            .select { |k, v| v.size > 1 }
+            .values
+                
             return DuplicateSetArray.new(@rootmodel, possible_duplicate_sets)
         end
     end

data/spec/organizations_spec.rb

@@ -205,4 +205,30 @@ describe MoveToGo::Organizations do
         org.custom_values.first.value.should eq "https"
     end
 
+    it "should handle if the value of a field is Nil" do
+        # given
+        model =  MoveToGo::RootModel.new
+
+        organization = MoveToGo::Organization.new
+        organization.name = nil
+        organization.integration_id = "1337"
+        model.add_organization(organization)
+
+        (1..3).each do |n|
+            organization = MoveToGo::Organization.new
+            organization.name = "Ankeborgs bibliotek"
+            organization.integration_id = n.to_s
+            model.add_organization(organization)
+        end
+
+        set_to_check = []
+        model.organizations
+            .find_duplicates_by(:name)
+            .each do |duplicate_set|
+                set_to_check = duplicate_set
+            end
+        # when, the
+        set_to_check.length.should eq 3
+    end
+
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: move-to-go
 version: !ruby/object:Gem::Version
-  version: 5.0.6
+  version: 5.0.7
 platform: ruby
 authors:
 - Petter Sandholdt
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-03 00:00:00.000000000 Z
+date: 2017-01-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: iso_country_codes