mournful_settings 0.1.0 → 0.1.1

data/README.rdoc

@@ -44,8 +44,6 @@ be encrypted:
       true
     end
 
-If you use this option, you do not need an encrypted field in the database 
-
 === Retrieving a setting
  
 To use a stored setting, use the 'for' class method:

data/lib/mournful_settings/setting_methods.rb

@@ -20,7 +20,7 @@ module MournfulSettings
       end
 
       def for(name, default = nil)
-        setting = find_by_name(name)
+        setting = find_by_name(name.to_s)  # values should be passed to AR as strings
         setting ? setting.value : default
       end
       

data/lib/mournful_settings/version.rb

@@ -1,9 +1,17 @@
 module MournfulSettings
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end
 
 # History
 # =======
+#
+# 0.1.1: Improves query to find setting via for
+# ---------------------------------------------
+# It makes sense for settings to be identified via a symbol, as this is a label.
+# However, best practice for querying a database is to pass in a string to
+# represent the data being retrieved. So the _for_ method has been altered to
+# convert the setting's name into a string before passing it to ActiveRecord
+# within a query. See: https://github.com/ernie/squeel/issues/67
 # 
 # 0.1.0: Acts As Mournful Setting
 # -------------------------------

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mournful_settings
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-03-12 00:00:00.000000000 Z
+date: 2013-09-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -71,7 +71,8 @@ files:
 - test/dummy/test/setting_test.rb
 - test/test_helper.rb
 homepage: https://github.com/reggieb/mournful_settings
-licenses: []
+licenses:
+- MIT-LICENSE
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -90,7 +91,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 1.8.25
 signing_key: 
 specification_version: 3
 summary: Tool for adding encrypted settings to an app.