motion_model 0.3.3 → 0.3.4

data/CHANGELOG

@@ -1,3 +1,11 @@
+2012-01-14: Fixed problem where data returned from forms was of type NSString, which
+            confused some monkey-patching code.
+            Changed before_ hooks such that handlers returning false would terminate
+            the process. So, if before_save returns anything other than false, the
+            save continues. Only if before_save returns false does the save get
+            interrupted.
+            Fixed immutable string issue in validations.
+
 2012-01-09: Added automatic date/timestamp support for created_at and updated_at columns
             Added Hash extension except, Array introspection methods has_hash_key? and
             has_hash_value?

data/lib/motion_model/model/model.rb

@@ -426,8 +426,9 @@ module MotionModel
     end
 
     def call_hooks(hook_name, &block)
-      call_hook('before', hook_name)
-      block.call
+      result = call_hook('before', hook_name)
+      # returning false from a before_ hook stops the process
+      block.call if result !== false && block_given?
       call_hook('after', hook_name)
     end
 

data/lib/motion_model/model/model_casts.rb

@@ -30,19 +30,23 @@ module MotionModel
     end
 
     def cast_to_array(arg)
-      arg.is_a?(Array) ? arg : arg.to_a
+      arg.is_a?(Array) ? Array(arg) : arg.to_a
+    end
+
+    def cast_to_string(arg)
+      String(arg)
     end
 
     def cast_to_type(column_name, arg) #nodoc
       return nil if arg.nil? && ![ :boolean, :bool ].include?(type(column_name))
 
       return case type(column_name)
-      when :string then arg.to_s
+      when :string then cast_to_string(arg)
       when :boolean, :bool then cast_to_bool(arg)
       when :int, :integer, :belongs_to_id then cast_to_integer(arg)
       when :float, :double then cast_to_float(arg)
       when :date then cast_to_date(arg)
-      when :text then arg.to_s
+      when :text then cast_to_string(arg)
       when :array then cast_to_array(arg)
       else
         raise ArgumentError.new("type #{column_name} : #{type(column_name)} is not possible to cast.")

data/lib/motion_model/validatable.rb

@@ -97,8 +97,7 @@ module MotionModel
       validation.each_pair do |validation_type, setting|
         if self.respond_to? validation_method(validation_type)
           value = self.send(field)
-          value.strip! if value.is_a?(String)
-          result &&= self.send(validation_method(validation_type), field, value, setting)
+          result &&= self.send(validation_method(validation_type), field, value.is_a?(String) ? value.strip : value, setting)
         else
           ex = ValidationSpecificationError.new("unknown validation type :#{validation_type.to_s}")
         end

data/lib/motion_model/version.rb

@@ -1,3 +1,3 @@
 module MotionModel
-  VERSION = "0.3.3"
+  VERSION = "0.3.4"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: motion_model
 version: !ruby/object:Gem::Version
-  version: 0.3.3
+  version: 0.3.4
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-01-09 00:00:00.000000000 Z
+date: 2013-01-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bubble-wrap