most_related 0.0.4 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b655ee05c62fde06ac5da9dbb806d5b2d46aa2e8
-  data.tar.gz: b716b9ac1370e5fa5f31a1cb6c12a3fa0267c397
+  metadata.gz: 9df9224092e0d94960866ace4c1d4e9c451396a1
+  data.tar.gz: a96d26680751aa63103a65165d42f3bf63db21fb
 SHA512:
-  metadata.gz: 652d59f88d1a0dfbf6b782dbfa6c9b4cd6d5b61d6eb812470aa5398771ec63f9b53f145a981d03c7d8bfbac1c087da72f73abada3fc2bd42b34ee7f61374ac32
-  data.tar.gz: bd8d55d28bb3c534d440d41a5f447994ccc10ec5439730ed2434900fcc4e27d80134e1001a2080debefeb83e9aeaae3c5a03ba6c25c36d1890ed7274fd8a0664
+  metadata.gz: 9d4b6204200e7cf6518e7d2633d148b4c3830203c9e681aa872fcd83dfe782797a82e7a637c183cca9a762434adef82169e84a38f851ca7b926f0ae9adf6ab75
+  data.tar.gz: 70f89313fde9be828d433c2e65bcbd07bf107a062a2207987d8386578928b76bd0b464922a3e0854ed3f668376a05c51a4c01da2027dbffa12c1e5920e15a56f

data/.gitignore

@@ -15,3 +15,4 @@ spec/reports
 test/tmp
 test/version_tmp
 tmp
+.byebug_history

data/.ruby-version

@@ -1 +1 @@
-2.2.2
+2.3.3

data/README.md

@@ -1,6 +1,6 @@
 # MostRelated
 
-`most_related` returns models that have the most many to many associated models in common
+`most_related` returns models that have the most associated models in common
 
 ## Installation
 
@@ -23,7 +23,7 @@ Post example
     class Post < ActiveRecord::Base
       has_most_related :authors
       has_most_related :tags, as: :most_related_by_tags
-      has_most_related [:authors, :tags], as: :most_related_by_author_or_tag
+      has_most_related :authors, :tags, as: :most_related_by_author_or_tag
 
       has_many :author_posts
       has_many :authors, through: :author_posts
@@ -38,28 +38,27 @@ Post example
       belongs_to :post
     end
 
-To return the posts with the most authors in common with post, in descending order:
+To return the posts with the most authors in common with `post`, in descending order:
 
     post.most_related
 
-To return the posts with the most tags in common with post, in descending order:
+To return the posts with the most tags in common with `post`, in descending order:
 
     post.most_related_by_tag
 
-To return the posts with the most authors and tags in common with post, in descending order:
+To return the posts with the most authors and tags in common with `post`, in descending order:
 
     post.most_related_by_author_or_tag
 
-The count of the many to many associated models in common is accessible on each returned model
+The count of the associated models in common is accessible on each returned model
 
     post.most_related_count
     post.most_related_by_tag_count
     post.most_related_by_author_or_tag_count
 
-If multiple many to many associations are used, the syntax is specific to MySql although
-it could be made to work with Postgres.
+Note multiple associations do not work with sqlite.
 
-Because of the use of 'group', pagination is not supported.
+Because of the use of `group`, pagination is not supported.
 
 ## Contributing
 

data/lib/most_related.rb

@@ -3,14 +3,14 @@ require "most_related/version"
 module MostRelated
 
   # `most_related` returns those models that have the most
-  # many to many associated models in common
+  #  associated models in common
   #
   # Post example:
   #
   #   class Post < ActiveRecord::Base
   #     has_most_related :authors
   #     has_most_related :tags, as: :most_related_by_tags
-  #     has_most_related [:authors, :tags], as: :most_related_by_author_or_tag
+  #     has_most_related :authors, :tags, as: :most_related_by_author_or_tag
   #
   #     has_many :author_posts
   #     has_many :authors, through: :author_posts
@@ -25,31 +25,25 @@ module MostRelated
   #     belongs_to :post
   #   end
   #
-  # To return the posts with the most authors in common with post, in descending order:
+  # To return the posts with the most authors in common with `post`, in descending order:
   #   post.most_related
   #
-  # To return the posts with the most tags in common with post, in descending order:
+  # To return the posts with the most tags in common with `post`, in descending order:
   #   post.most_related_by_tag
   #
-  # To return the posts with the most authors and tags in common with post, in descending order:
+  # To return the posts with the most authors and tags in common with `post`, in descending order:
   #   post.most_related_by_author_or_tag
   #
-  # The count of the many to many associated models in common is accessible on each returned model
+  # The count of the associated models in common is accessible on each returned model
   #   eg post.most_related_count, post.most_related_by_tag_count and post.most_related_by_author_or_tag_count
   #
-  def has_most_related(many_to_many_associations, as: :most_related)
+  def has_most_related(*many_to_many_associations, as: :most_related)
 
     # defaults to 'def most_related'
     define_method as do
       table_name = self.class.table_name
       association_scopes = []
 
-      many_to_many_associations = if many_to_many_associations.is_a?(Array)
-        many_to_many_associations
-      else
-        [many_to_many_associations]
-      end
-
       many_to_many_associations.each do |many_to_many_association|
         assocation = self.class.reflect_on_association(many_to_many_association)
         join_table, foreign_key, association_foreign_key = self.class.join_table_values(assocation)
@@ -60,17 +54,22 @@ module MostRelated
           joins("INNER JOIN #{join_table} ON #{join_table}.#{foreign_key} = #{table_name}.id")
       end
 
-      # with postgres, multiple many-to-many associations doesn't work and here's why
-      # http://dba.stackexchange.com/questions/88988/postgres-error-column-must-appear-in-the-group-by-clause-or-be-used-in-an-aggre
       scope = self.class.select("#{table_name}.*, count(#{table_name}.id) AS #{as}_count").
-        where.not(id: self.id).group("#{table_name}.id").order("#{as}_count DESC")
+        where.not(id: self.id).order("#{as}_count DESC")
+      group_by_clause = 'id'
 
       # if there is only one many-to-many association no need to use UNION sql syntax
-      if association_scopes.size == 1
-        scope.merge(association_scopes.first)
+      if association_scopes.one?
+        scope.merge(association_scopes.first).group(group_by_clause)
       else
+        # with postgres the group by clause has to be different
+        # http://dba.stackexchange.com/questions/88988/postgres-error-column-must-appear-in-the-group-by-clause-or-be-used-in-an-aggre
+        if ActiveRecord::Base.connection.adapter_name == 'PostgreSQL'
+          group_by_clause = self.class.column_names.join(', ')
+        end
+
         # see http://blog.ubersense.com/2013/09/27/tech-talk-unioning-scoped-queries-in-rails/
-        scope.from("((#{association_scopes.map(&:to_sql).join(') UNION ALL (')})) AS #{table_name}")
+        scope.from("((#{association_scopes.map(&:to_sql).join(') UNION ALL (')})) AS #{table_name}").group(group_by_clause)
       end
     end
 

data/lib/most_related/version.rb

@@ -1,3 +1,3 @@
 module MostRelated
-  VERSION = "0.0.4"
+  VERSION = '0.1.0'
 end

data/most_related.gemspec

@@ -18,13 +18,13 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.required_ruby_version     = '>= 1.9.3'
-  spec.add_runtime_dependency 'activerecord', '~> 4.0', '>= 4.0.0'
-  spec.add_development_dependency 'bundler', '~> 1.3'
-  spec.add_development_dependency 'rspec', '~> 2.14', '>= 2.14.1'
-  spec.add_development_dependency 'database_cleaner', '~>1.4'
+  spec.required_ruby_version     = '>= 2.1'
+  spec.add_runtime_dependency     'activerecord', '~> 4.2'
+  spec.add_development_dependency 'bundler', '~> 1.13'
+  spec.add_development_dependency 'rspec', '~> 3.5'
+  spec.add_development_dependency 'database_cleaner', '~>1.5'
   spec.add_development_dependency 'sqlite3', '~>1.3'
-  spec.add_development_dependency 'mysql2', '~>0.3'
-  spec.add_development_dependency 'pg', '~>0.18'
-  spec.add_development_dependency 'byebug', '~>4.0'
+  spec.add_development_dependency 'mysql2', '~>0.4'
+  spec.add_development_dependency 'pg', '~>0.19'
+  spec.add_development_dependency 'byebug', '~>9.0'
 end

data/spec/spec_helper.rb

@@ -21,7 +21,6 @@ DatabaseCleaner.strategy = :transaction
 
 # See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 RSpec.configure do |config|
-  config.treat_symbols_as_metadata_keys_with_true_values = true
   config.run_all_when_everything_filtered = true
   config.filter_run :focus
 

data/spec/support/models.rb

@@ -1,7 +1,7 @@
 class Post < ActiveRecord::Base
   has_most_related :authors
   has_most_related :tags, as: :most_related_by_tag
-  has_most_related [:authors, :tags], as: :most_related_by_author_or_tag
+  has_most_related :authors, :tags, as: :most_related_by_author_or_tag
 
   has_and_belongs_to_many :tags
   has_many :author_posts

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: most_related
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.1.0
 platform: ruby
 authors:
 - Jolyon Pawlyn
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-09 00:00:00.000000000 Z
+date: 2016-12-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -16,68 +16,56 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.0'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 4.0.0
+        version: '4.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.0'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 4.0.0
+        version: '4.2'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '1.13'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '1.13'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.14'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 2.14.1
+        version: '3.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.14'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 2.14.1
+        version: '3.5'
 - !ruby/object:Gem::Dependency
   name: database_cleaner
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.4'
+        version: '1.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.4'
+        version: '1.5'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
@@ -98,42 +86,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.3'
+        version: '0.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.3'
+        version: '0.4'
 - !ruby/object:Gem::Dependency
   name: pg
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.18'
+        version: '0.19'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.18'
+        version: '0.19'
 - !ruby/object:Gem::Dependency
   name: byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '9.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '9.0'
 description: Adds an instance method to a active record model that returns the most
   related models based on associated models in common
 email:
@@ -168,7 +156,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 1.9.3
+      version: '2.1'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -176,7 +164,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: Returns models that have the most associated models in common