mosaic-facebook 0.2.0 → 0.2.1

data/Rakefile

@@ -9,6 +9,8 @@ Bundler::GemHelper.install_tasks
 desc "Run RSpec"
 RSpec::Core::RakeTask.new do |t|
   t.verbose = false
+  t.pattern = ['spec/**/*_spec.rb']
+  t.rspec_opts = ['--options', 'spec/spec.opts']
 end
 # Spec::Rake::SpecTask.new(:spec) do |spec|
 #   spec.ruby_opts << '-rubygems'

data/lib/mosaic/facebook/api/notification.rb

@@ -1,5 +1,7 @@
 require 'mosaic/facebook/error'
 
+# TODO: fix the namespace (ie. module) this should be Mosaic::Facebook::Api::Notification
+#       or notification.rb should be moved up a folder
 module Mosaic
   module Facebook
     class Notification < Mosaic::Facebook::Api::ApiObject
@@ -7,7 +9,7 @@ module Mosaic
       class << self
         # send_email requires these parameters: to, subject, body, access_token
         def send_email(options)
-          response = get("/method/notifications.sendEmail", options)
+          response = get("/method/notifications.sendEmail", :query => options)
           raise Mosaic::Facebook::Error.new(response['error_response']) if response.include?('error_response')
           response
         end

data/lib/mosaic/facebook/graph/account.rb

@@ -5,23 +5,20 @@ module Mosaic
         attr_accessor :id, :name, :access_token, :category
 
         def insights
+          # requires read_insights permission
           @insights ||= AssociationProxy.new(Mosaic::Facebook::Graph::Insights, "/#{self.id}/insights")
         end
 
         def posts
           @posts ||= AssociationProxy.new(Mosaic::Facebook::Graph::Post, "/#{self.id}/posts")
         end
-        
-        def user
-          @user ||= AssociationProxy.new(Mosaic::Facebook::Graph::User, "/me")
-        end
 
         class << self
           def all(options = {})
             # need 'manage_pages' extended permission to get pages (via accounts connection)
-            @all ||= find("/#{facebook_user}/accounts", options)
+            @all ||= find("/me/accounts", options)
           end
-          
+
           def find_by_name(name, options = {})
             all(options).find { |account| account.name == name }
           end

data/lib/mosaic/facebook/graph/application.rb

@@ -1,12 +1,26 @@
+require 'cgi'
+
 module Mosaic
   module Facebook
     module Graph
       class Application < Mosaic::Facebook::Graph::GraphObject
-        attr_accessor :id, :name, :link
+        attr_accessor :id, :name, :link, :secret
+
+        def access_token
+          @access_token ||= get_access_token
+        end
 
         def subscriptions
+          # requires an application access token
           @subscriptions ||= AssociationProxy.new(Mosaic::Facebook::Graph::Subscription, "/#{id}/subscriptions")
         end
+
+        protected
+
+        def get_access_token
+          response = get('/oauth/access_token', :client_id => id, :client_secret => secret, :grant_type => 'client_credentials')
+          CGI.parse(response.body)['access_token'].first
+        end
       end
     end
   end

data/lib/mosaic/facebook/graph/graph_object.rb

@@ -10,6 +10,12 @@ module Mosaic
           response
         end
 
+        def get(path, options = {})
+          response = super(path, options)
+          raise Mosaic::Facebook::Error.new(response['error']) if !response.success?
+          response
+        end
+
         def post(path, options = {})
           response = super(path, options)
           raise Mosaic::Facebook::Error.new(response['error']) if !response.success?
@@ -18,7 +24,7 @@ module Mosaic
 
         class << self
           def find(path, options = {})
-            response = get(path, options)
+            response = get(path, :query => options)
             raise Mosaic::Facebook::Error.new(response['error']) if !response.success?
             data = response.parsed_response
             if data.include?('data')

data/lib/mosaic/facebook/object.rb

@@ -10,10 +10,9 @@ module Mosaic
         attributes.each { |key,value| instance_variable_set("@#{key}".to_sym, value) }
       end
 
-      def delete(path, options = {})
+      def get(path, options = {})
         query = { :access_token => self.class.facebook_access_token }.merge(options)
-        body = Hash[instance_variables.collect { |ivar| [ivar.sub(/@/,''),instance_variable_get(ivar)] }]
-        self.class.delete path, :query => query, :body => serialize_body(body)
+        self.class.get path, :query => query
       end
 
       def post(path, options)
@@ -22,7 +21,6 @@ module Mosaic
         self.class.post path, :query => query, :body => serialize_body(body)
       end
 
-
       class << self
         def attr_name(*names)
           self.attribute_names += names.collect(&:to_s)
@@ -53,14 +51,6 @@ module Mosaic
           @facebook_access_token ||= configuration && configuration['access_token']
         end
 
-        def facebook_user
-          @facebook_user ||= configuration['user']
-        end
-
-        def get(path, options)
-          super(path, :query => options)
-        end
-
       private
         def logger
           @logger ||= if defined?(Rails)

data/lib/mosaic/facebook/version.rb

@@ -1,5 +1,5 @@
 module Mosaic
   module Facebook
-    VERSION = "0.2.0"
+    VERSION = "0.2.1"
   end
 end

data/spec/api/notification_spec.rb

@@ -0,0 +1,24 @@
+require File.expand_path('../../spec_helper.rb', __FILE__)
+
+describe Mosaic::Facebook::Notification do
+  def options
+    options = {:recipients => "000000000", :subject => "testing", :text => "ajit", :access_token => "xxx"}
+  end
+
+  context "when no or invalid token is passed" do
+    it "should require an access_token" do
+      expect { Mosaic::Facebook::Notification.send_email(options.merge(:access_token => nil)) }.to raise_error(Mosaic::Facebook::AccessTokenError, /Invalid application ID/i)
+    end
+
+    it "should require a valid access_token" do
+      expect { Mosaic::Facebook::Notification.send_email(options.merge(:recipients => RSpec.configuration.user_id)) }.to raise_error(Mosaic::Facebook::AccessTokenError, /INVALID OAUTH ACCESS TOKEN/i)
+    end
+
+  end
+
+  context "when a valid access_token is provided" do
+    it "should send a notification" do
+      expect { Mosaic::Facebook::Notification.send_email(options.merge(:recipients => RSpec.configuration.user_id, :access_token => RSpec.configuration.access_token)) }.to_not raise_error
+    end
+  end
+end

data/spec/fql/comment_spec.rb

@@ -0,0 +1,7 @@
+require File.expand_path('../../spec_helper.rb', __FILE__)
+
+describe Mosaic::Facebook::Graph::Comment do
+  it "should be tested" do
+    pending "writing tests"
+  end
+end

data/spec/fql/post_spec.rb

@@ -0,0 +1,7 @@
+require File.expand_path('../../spec_helper.rb', __FILE__)
+
+describe Mosaic::Facebook::Graph::Comment do
+  it "should be tested" do
+    pending "writing tests"
+  end
+end

data/spec/graph/account_spec.rb

@@ -0,0 +1,48 @@
+require File.expand_path('../../spec_helper.rb', __FILE__)
+
+describe Mosaic::Facebook::Graph::Account do
+  context "self.all" do
+    it "should require an access token" do
+      expect { Mosaic::Facebook::Graph::Account.all }.to raise_error(Mosaic::Facebook::AccessTokenError)
+    end
+
+    context "when an access token is provided" do
+      it "should return the current user's apps and pages" do
+        # requires manage_pages permission
+        # TODO: update test suite to generate appropriate test users
+        accounts = Mosaic::Facebook::Graph::Account.all(:access_token => RSpec.configuration.access_token)
+        expect(accounts).to be_an_instance_of Array
+        expect(accounts.first).to be_an_instance_of Mosaic::Facebook::Graph::Account
+      end
+    end
+  end
+
+  context "self.find_by_name" do
+    it "should find an account for a named page" do
+      account = Mosaic::Facebook::Graph::Account.find_by_name('Mosaic (staging)', :access_token => RSpec.configuration.access_token)
+      expect(account).to be_an_instance_of Mosaic::Facebook::Graph::Account
+    end
+  end
+
+  context "given a known account" do
+    before(:all) do
+      @account = Mosaic::Facebook::Graph::Account.find_by_name('Mosaic (staging)', :access_token => RSpec.configuration.access_token)
+    end
+
+    it "should retrieve the insights" do
+      # requires read_insights permission
+      # TODO: update test suite to generate appropriate test users
+      insights = @account.insights.all(:access_token => RSpec.configuration.access_token)
+      expect(insights).to be_an_instance_of Array
+      expect(insights.first).to be_an_instance_of Mosaic::Facebook::Graph::Insights
+    end
+
+    it "should retrieve the posts" do
+      # FIXME: limit=3 work-around for facebook bug as per:
+      #        https://developers.facebook.com/bugs/525301577527928?browse=search_516709daab5da1453067889
+      posts = @account.posts.all(:access_token => RSpec.configuration.access_token, :limit => 3)
+      expect(posts).to be_an_instance_of Array
+      expect(posts.first).to be_an_instance_of Mosaic::Facebook::Graph::Post
+    end
+  end
+end

data/spec/graph/application_spec.rb

@@ -0,0 +1,35 @@
+require File.expand_path('../../spec_helper.rb', __FILE__)
+
+describe Mosaic::Facebook::Graph::Application do
+  context "self.find_by_id" do
+    it "should require an access token" do
+      expect { Mosaic::Facebook::Graph::Application.find_by_id(RSpec.configuration.app_id) }.to raise_error(Mosaic::Facebook::Error, /unsupported get request/i)
+    end
+
+    context "with an access token" do
+      it "should find an application" do
+        application = Mosaic::Facebook::Graph::Application.find_by_id(RSpec.configuration.app_id, :access_token => RSpec.configuration.access_token)
+        expect(application).to be_an_instance_of(Mosaic::Facebook::Graph::Application)
+      end
+    end
+  end
+
+  context "given an application (and a client secret)" do
+    before(:all) do
+      @application = Mosaic::Facebook::Graph::Application.new(:id => RSpec.configuration.app_id, :secret => RSpec.configuration.app_secret)
+    end
+
+    it "should retrieve an access token" do
+      access_token = @application.access_token
+      expect(access_token).to be_an_instance_of String
+    end
+
+    it "should return a list of subscriptions" do
+      # requires an application access token
+      subscriptions = @application.subscriptions.all(:access_token => @application.access_token)
+      expect(subscriptions).to be_an_instance_of Array
+      # TODO: add subscription to test?
+      # expect(subscriptions.first).to be_an_instance_of Mosaic::Facebook::Graph::Subscription
+    end
+  end
+end

data/spec/graph/comment_spec.rb

@@ -0,0 +1,7 @@
+require File.expand_path('../../spec_helper.rb', __FILE__)
+
+describe Mosaic::Facebook::Graph::Comment do
+  it "should be tested" do
+    pending "writing tests"
+  end
+end

data/spec/graph/event_spec.rb

@@ -0,0 +1,7 @@
+require File.expand_path('../../spec_helper.rb', __FILE__)
+
+describe Mosaic::Facebook::Graph::Event do
+  it "should be tested" do
+    pending "writing tests"
+  end
+end

data/spec/graph/insights_spec.rb

@@ -0,0 +1,7 @@
+require File.expand_path('../../spec_helper.rb', __FILE__)
+
+describe Mosaic::Facebook::Graph::Insights do
+  it "should be tested" do
+    pending "writing tests"
+  end
+end

data/spec/graph/page_spec.rb

@@ -0,0 +1,25 @@
+require File.expand_path('../../spec_helper.rb', __FILE__)
+
+describe Mosaic::Facebook::Graph::Page do
+  context "given a valid page" do
+    before(:all) do
+      @page = Mosaic::Facebook::Graph::Page.new(:id => RSpec.configuration.page_id)
+    end
+
+    context "with a valid access token" do
+      it "should return a page feed" do
+        # FIXME: limit=3 work-around for facebook bug as per:
+        #        https://developers.facebook.com/bugs/525301577527928?browse=search_516709daab5da1453067889
+        feed = @page.feed.all(:access_token => RSpec.configuration.access_token, :limit => 3)
+        expect(feed).to be_an_instance_of Array
+        expect(feed.first).to be_an_instance_of Mosaic::Facebook::Graph::Post
+      end
+
+      it "should return a event list" do
+        events = @page.events.all(:access_token => RSpec.configuration.access_token)
+        expect(events).to be_an_instance_of Array
+        expect(events.first).to be_an_instance_of Mosaic::Facebook::Graph::Event
+      end
+    end
+  end
+end

data/spec/graph/post_spec.rb

@@ -0,0 +1,31 @@
+require File.expand_path('../../spec_helper.rb', __FILE__)
+
+describe Mosaic::Facebook::Graph::Post do
+  context "given a page with posts" do
+    before(:all) do
+      @page = Mosaic::Facebook::Graph::Page.new(:id => RSpec.configuration.page_id)
+      # FIXME: limit=10 work-around for facebook bug as per:
+      #        https://developers.facebook.com/bugs/525301577527928?browse=search_516709daab5da1453067889
+      @posts = @page.feed.all(:access_token => RSpec.configuration.access_token, :limit => 10)
+    end
+
+    it "should retrieve the user who posted it" do
+      post = @posts.first
+      expect(post.from.all).to be_an_instance_of Mosaic::Facebook::Graph::User
+    end
+
+    # FIXME: requires a comment to actually exist in the retrieved posts...
+    #        maybe find a comment through another means first, and follow it to the post?
+    context "and a post with comments" do
+      before(:all) do
+        @post = @posts.find { |post| post.comments.all.any? }
+      end
+
+      it "should retrieve the post's comments" do
+        comments = @post.comments.all
+        expect(comments).to be_an_instance_of Array
+        expect(comments.first).to be_an_instance_of Mosaic::Facebook::Graph::Comment
+      end
+    end
+  end
+end

data/spec/graph/subscription_spec.rb

@@ -0,0 +1,7 @@
+require File.expand_path('../../spec_helper.rb', __FILE__)
+
+describe Mosaic::Facebook::Graph::Subscription do
+  it "should be tested" do
+    pending "writing tests"
+  end
+end

data/spec/graph/user_spec.rb

@@ -0,0 +1,38 @@
+require File.expand_path('../../spec_helper.rb', __FILE__)
+
+describe Mosaic::Facebook::Graph::User do
+  context "self.me" do
+    it "should require an access token" do
+      expect { Mosaic::Facebook::Graph::User.me }.to raise_error(Mosaic::Facebook::AccessTokenError)
+    end
+
+    context "when an access token is provided" do
+      it "should return the current user" do
+        me = Mosaic::Facebook::Graph::User.me(:access_token => RSpec.configuration.access_token)
+        expect(me).to be_an_instance_of Mosaic::Facebook::Graph::User
+      end
+    end
+  end
+
+  context "given a valid user" do
+    before(:all) do
+      @me = Mosaic::Facebook::Graph::User.new(:id => 'me')
+    end
+
+    context "#accounts" do
+      it "should require an access token" do
+        expect { @me.accounts.all }.to raise_error(Mosaic::Facebook::AccessTokenError)
+      end
+
+      context "when a valid access token is provided" do
+        # requires manage_pages permission
+        # TODO: update test suite to generate appropriate test users
+        it "should return the user's apps and pages" do
+          accounts = @me.accounts.all(:access_token => RSpec.configuration.access_token)
+          expect(accounts).to be_an_instance_of Array
+          expect(accounts.first).to be_an_instance_of Mosaic::Facebook::Graph::Account
+        end
+      end
+    end
+  end
+end

data/spec/mosaic-facebook_spec.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), 'spec_helper')
+require File.expand_path('../spec_helper.rb', __FILE__)
 
 describe "mosaic-facebook" do
   # before(:each) do

data/spec/spec.opts

@@ -1,3 +1,3 @@
 --colour
---format specdoc
---backtrace
+#--format documentation
+--format progress

data/spec/spec_helper.rb

@@ -17,4 +17,6 @@ RSpec.configure do |config|
   config.add_setting :access_token, :default => FACEBOOK_CONFIG["access_token"]
   config.add_setting :user_id, :default => FACEBOOK_CONFIG["user_id"]
   config.add_setting :page_id, :default => FACEBOOK_CONFIG["page_id"]
+  config.add_setting :app_id, :default => FACEBOOK_CONFIG["app_id"]
+  config.add_setting :app_secret, :default => FACEBOOK_CONFIG["app_secret"]
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mosaic-facebook
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
   prerelease: 
 platform: ruby
 authors:
@@ -99,9 +99,19 @@ files:
 - lib/mosaic/facebook/version.rb
 - lib/mosaic_facebook.rb
 - mosaic-facebook.gemspec
+- spec/api/notification_spec.rb
 - spec/facebook_config.yml.example
-- spec/mosaic-facebook/notification_spec.rb
-- spec/mosaic-facebook/page_spec.rb
+- spec/fql/comment_spec.rb
+- spec/fql/post_spec.rb
+- spec/graph/account_spec.rb
+- spec/graph/application_spec.rb
+- spec/graph/comment_spec.rb
+- spec/graph/event_spec.rb
+- spec/graph/insights_spec.rb
+- spec/graph/page_spec.rb
+- spec/graph/post_spec.rb
+- spec/graph/subscription_spec.rb
+- spec/graph/user_spec.rb
 - spec/mosaic-facebook_spec.rb
 - spec/spec.opts
 - spec/spec_helper.rb
@@ -130,9 +140,19 @@ signing_key:
 specification_version: 3
 summary: gem/plugin to connect to facebook graph api
 test_files:
+- spec/api/notification_spec.rb
 - spec/facebook_config.yml.example
-- spec/mosaic-facebook/notification_spec.rb
-- spec/mosaic-facebook/page_spec.rb
+- spec/fql/comment_spec.rb
+- spec/fql/post_spec.rb
+- spec/graph/account_spec.rb
+- spec/graph/application_spec.rb
+- spec/graph/comment_spec.rb
+- spec/graph/event_spec.rb
+- spec/graph/insights_spec.rb
+- spec/graph/page_spec.rb
+- spec/graph/post_spec.rb
+- spec/graph/subscription_spec.rb
+- spec/graph/user_spec.rb
 - spec/mosaic-facebook_spec.rb
 - spec/spec.opts
 - spec/spec_helper.rb

data/spec/mosaic-facebook/notification_spec.rb

@@ -1,25 +0,0 @@
-require File.expand_path(File.join(File.dirname(__FILE__), '..', 'spec_helper.rb'))
-
-
-describe Mosaic::Facebook::Notification do
-  def options
-    options = {:recipients => "000000000", :subject => "testing", :text => "ajit", :access_token => "xxx"}
-  end
-
-  context "when no or invalid token is passed" do
-    it "should require an access_token" do
-      lambda { Mosaic::Facebook::Notification.send_email(options.merge(:access_token => nil)) }.should raise_error(Mosaic::Facebook::AccessTokenError, /Invalid application ID/i)
-    end
-
-    it "should require a valid access_token" do
-      lambda {Mosaic::Facebook::Notification.send_email(options.merge(:recipients => RSpec.configuration.user_id))}.should raise_error(Mosaic::Facebook::AccessTokenError, /INVALID OAUTH ACCESS TOKEN/i)
-    end
-
-  end
-
-  context "when a valid access_token is provided" do
-    it "should send a notification" do
-      Mosaic::Facebook::Notification.send_email(options.merge(:recipients => RSpec.configuration.user_id, :access_token => RSpec.configuration.access_token))
-    end
-  end
-end

data/spec/mosaic-facebook/page_spec.rb

@@ -1,17 +0,0 @@
-require File.expand_path(File.join(File.dirname(__FILE__), '..', 'spec_helper.rb'))
-
-describe Mosaic::Facebook::Graph::Page do
-  context "when a valid token and page id are passed" do
-    it "should return a page feed" do
-      feed = Mosaic::Facebook::Graph::Page.new().feed.all({ :access_token => RSpec.configuration.access_token, :id => RSpec.configuration.page_id })
-      feed.should be_an_instance_of Array
-      feed.first.should be_an_instance_of Mosaic::Facebook::Graph::Post
-    end
-
-    it "should return a event list" do
-      events = Mosaic::Facebook::Graph::Page.new().events.all({ :access_token => RSpec.configuration.access_token, :id => RSpec.configuration.page_id })
-      events.should be_an_instance_of Array
-      events.first.should be_an_instance_of Mosaic::Facebook::Graph::Event
-    end
-  end
-end