morgoth-alexa 0.0.3 → 0.0.4

data/VERSION

@@ -1 +1 @@
-0.0.3
+0.0.4

data/alexa.gemspec

@@ -2,11 +2,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{alexa}
-  s.version = "0.0.3"
+  s.version = "0.0.4"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Wojciech Wnętrzak"]
-  s.date = %q{2009-07-06}
+  s.date = %q{2009-07-07}
   s.email = %q{w.wnetrzak@gmail.com}
   s.extra_rdoc_files = [
     "LICENSE",
@@ -23,6 +23,7 @@ Gem::Specification.new do |s|
      "lib/alexa.rb",
      "lib/alexa/url_info.rb",
      "test/alexa_test.rb",
+     "test/fixtures/empty.xml",
      "test/fixtures/polsl.xml",
      "test/fixtures/polsl_small.xml",
      "test/test_helper.rb"

data/lib/alexa/url_info.rb

@@ -28,20 +28,20 @@ module Alexa
       xml = XmlSimple.xml_in(xml.force_encoding(Encoding::UTF_8), 'ForceArray' => false)
       group = response_group.split(',')
       alexa = xml['Response']['UrlInfoResult']['Alexa']
-      @rank = alexa['TrafficData']['Rank'].to_i if group.include?('Rank')
+      @rank = alexa['TrafficData']['Rank'].to_i if group.include?('Rank') and !alexa['TrafficData']['Rank'].empty?
       @data_url = alexa['TrafficData']['DataUrl']['content'] if group.include?('Rank')
       @rank_by_country = alexa['TrafficData']['RankByCountry']['Country'] if group.include?('RankByCountry')
       @rank_by_city = alexa['TrafficData']['RankByCity']['City'] if group.include?('RankByCity')
-      @usage_statistics = alexa['TrafficData']['UsageStatistics']["UsageStatistic"]if group.include?('UsageStats')
+      @usage_statistics = alexa['TrafficData']['UsageStatistics']["UsageStatistic"] if group.include?('UsageStats') and !alexa['TrafficData']['UsageStatistics'].nil?
 
       @site_title = alexa['ContentData']['SiteData']['Title'] if group.include?('SiteData')
       @site_description = alexa['ContentData']['SiteData']['Description'] if group.include?('SiteData')
       @language_locale = alexa['ContentData']['Language']['Locale'] if group.include?('Language')
       @language_encoding = alexa['ContentData']['Language']['Encoding'] if group.include?('Language')
-      @links_in_count = alexa['ContentData']['LinksInCount'].to_i if group.include?('LinksInCount')
+      @links_in_count = alexa['ContentData']['LinksInCount'].to_i if group.include?('LinksInCount') and !alexa['ContentData']['LinksInCount'].empty?
       @keywords = alexa['ContentData']['Keywords']['Keyword'] if group.include?('Keywords')
-      @speed_median_load_time = alexa['ContentData']['Speed']['MedianLoadTime'].to_i if group.include?('Speed')
-      @speed_percentile = alexa['ContentData']['Speed']['Percentile'].to_i if group.include?('Speed')
+      @speed_median_load_time = alexa['ContentData']['Speed']['MedianLoadTime'].to_i if group.include?('Speed') and !alexa['ContentData']['Speed']['MedianLoadTime'].empty?
+      @speed_percentile = alexa['ContentData']['Speed']['Percentile'].to_i if group.include?('Speed') and !alexa['ContentData']['Speed']['Percentile'].empty?
 
       @related_links = alexa['Related']['RelatedLinks']['RelatedLink'] if group.include?('RelatedLinks')
     end

data/test/alexa_test.rb

@@ -52,7 +52,7 @@ class AlexaTest < Test::Unit::TestCase
         assert_equal "About the university, studies, faculties and departments, photo gallery.", @alexa.site_description
       end
 
-      should "not crush" do
+      should "not crash" do
         assert_nothing_raised do
           @alexa.language_locale
         end
@@ -124,6 +124,70 @@ class AlexaTest < Test::Unit::TestCase
 
     end
 
+    context "should not crash when parsing empty xml response and" do
+      setup do
+        xml = fixture_file('empty.xml')
+        @alexa.parse_xml(xml)
+      end
+
+      should "return nil" do
+        assert_nil @alexa.rank
+      end
+
+      should "return nil" do
+        assert_nil @alexa.data_url
+      end
+
+      should "return nil" do
+        assert_nil @alexa.site_title
+      end
+
+      should "return nil" do
+        assert_nil @alexa.site_description
+      end
+
+      should "return nil" do
+        assert_nil @alexa.language_locale
+      end
+
+      should "return nil" do
+        assert_nil @alexa.language_encoding
+      end
+
+      should "return nil" do
+        assert_nil @alexa.links_in_count
+      end
+
+      should "return nil" do
+        assert_nil @alexa.keywords
+      end
+
+      should "return nil" do
+        assert_nil @alexa.related_links
+      end
+
+      should "return nil" do
+        assert_nil @alexa.speed_median_load_time
+      end
+
+      should "return nil" do
+        assert_nil @alexa.speed_percentile
+      end
+
+      should "return nil" do
+        assert_nil @alexa.rank_by_country
+      end
+
+      should "return nil" do
+        assert_nil @alexa.rank_by_city
+      end
+
+      should "return nil" do
+        assert_nil @alexa.usage_statistics
+      end
+
+    end
+
     should "not raise error when response is OK" do
       assert_nothing_raised do
         @alexa.send :handle_response, Net::HTTPOK.new("1.1", "200", "OK")

data/test/fixtures/empty.xml

@@ -0,0 +1,39 @@
+<?xml version="1.0"?>
+<aws:UrlInfoResponse xmlns:aws="http://alexa.amazonaws.com/doc/2005-10-05/"><aws:Response xmlns:aws="http://awis.amazonaws.com/doc/2005-07-11"><aws:OperationRequest><aws:RequestId>6a12c8f4-056f-4fce-95cd-2f9d2a353236</aws:RequestId></aws:OperationRequest><aws:UrlInfoResult><aws:Alexa>
+  
+  <aws:ContactInfo>
+    <aws:DataUrl type="canonical">404</aws:DataUrl>
+    <aws:PhoneNumbers>
+      <aws:PhoneNumber/>
+    </aws:PhoneNumbers>
+    <aws:OwnerName/>
+    <aws:Email/>
+    <aws:PhysicalAddress/>
+    <aws:CompanyStockTicker/>
+  </aws:ContactInfo>
+  <aws:ContentData>
+    <aws:DataUrl type="canonical">404</aws:DataUrl>
+    <aws:SiteData>
+      <aws:Title>404</aws:Title>
+    </aws:SiteData>
+    <aws:Speed>
+      <aws:MedianLoadTime/>
+      <aws:Percentile/>
+    </aws:Speed>
+    <aws:AdultContent/>
+    <aws:Language/>
+    <aws:LinksInCount/>
+    <aws:Keywords/>
+    <aws:OwnedDomains/>
+  </aws:ContentData>
+  <aws:Related>
+    <aws:DataUrl type="canonical">404</aws:DataUrl>
+    <aws:RelatedLinks/>
+  </aws:Related>
+  <aws:TrafficData>
+    <aws:DataUrl type="canonical">404</aws:DataUrl>
+    <aws:Rank/>
+    <aws:RankByCountry/>
+    <aws:RankByCity/>
+  </aws:TrafficData>
+</aws:Alexa></aws:UrlInfoResult><aws:ResponseStatus xmlns:aws="http://alexa.amazonaws.com/doc/2005-10-05/"><aws:StatusCode>Success</aws:StatusCode></aws:ResponseStatus></aws:Response></aws:UrlInfoResponse>

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: morgoth-alexa
 version: !ruby/object:Gem::Version 
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors: 
 - "Wojciech Wn\xC4\x99trzak"
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-07-06 00:00:00 -07:00
+date: 2009-07-07 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -42,6 +42,7 @@ files:
 - lib/alexa.rb
 - lib/alexa/url_info.rb
 - test/alexa_test.rb
+- test/fixtures/empty.xml
 - test/fixtures/polsl.xml
 - test/fixtures/polsl_small.xml
 - test/test_helper.rb