moonshado-sms 1.0.1 → 1.1.0.rc1

data/VERSION.yml

@@ -1,5 +1,5 @@
 --- 
-:patch: 1
-:build: 
+:patch: 0
+:build: rc1
 :major: 1
-:minor: 0
+:minor: 1

data/lib/moonshado/configuration.rb

@@ -1,10 +1,11 @@
 module Moonshado
   class Configuration
 
-    OPTIONS = [:api_key, :development_environments, :keywords,
-               :sms_uri, :keyword_uri, :auto_register_keyword,
-               :environment_name, :host, :http_open_timeout,
-               :http_read_timeout, :port, :protocol, :secure].freeze
+    OPTIONS = [:api_key, :keywords, :sms_uri, 
+               :keyword_uri, :auto_register_keyword,
+               :host, :http_open_timeout, :http_read_timeout,
+               :port, :protocol, :secure,
+               :production_environment].freeze
 
     attr_accessor :api_key
     attr_accessor :keywords
@@ -17,8 +18,11 @@ module Moonshado
     attr_accessor :auto_register_keywords
     attr_accessor :production_environment
     attr_accessor :port
+    attr_accessor :message_length_range
+    attr_accessor :message_length_check
 
     alias_method :secure?, :secure
+    alias_method :message_length_check?, :message_length_check
 
     def initialize
       @secure                   = false
@@ -30,6 +34,8 @@ module Moonshado
       @keywords_uri             = '/keywords'
       @auto_register_keywords   = false
       @port                     = default_port
+      @message_length_range     = 3..115
+      @message_length_check     = true
     end
 
     def api_key

data/lib/moonshado/sms.rb

@@ -31,19 +31,10 @@ module Moonshado
       @message = message
     end
 
-    # def self.find(id)
-    #   if config[:test_env] == true
-    #     {:sms => {:id => id, :reports => '[{"update_date":"2010-01-03T22:56:45-08:00","status_info":"test"}]'}, :stat => "ok"}
-    #   else
-    #     response = RestClient.get("#{url}/#{id}")
-    #     JSON.parse(response.body)
-    #   end
-    # end
-
     def deliver_sms
       raise MoonshadoSMSException.new("Invalid message") unless is_message_valid?(@message)
 
-      data = {:sms => {:device_address => format_number(@number), :message => @message}}
+      data = {:sms => {:device_address => format_number(@number), :message => @message.to_s}}
 
       if production_environment?
         begin
@@ -70,7 +61,11 @@ module Moonshado
     end
 
     def is_message_valid?(message)
-      message.size <= 115 && !message.nil? && message.is_a?(String) && !message.empty?
+      if message_length_check?
+        message_length_range.include?(message.to_s.size)
+      else
+        true
+      end
     end
 
     class MoonshadoSMSException < StandardError; end
@@ -95,5 +90,13 @@ module Moonshado
           {"stat"=>"fail", "error"=>"json parser error", "response"=>json.to_s}
         end
       end
+
+      def message_length_range
+        configuration.message_length_range
+      end
+
+      def message_length_check?
+        configuration.message_length_check?
+      end
   end
 end

data/moonshado-sms.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{moonshado-sms}
-  s.version = "1.0.1"
+  s.version = "1.1.0.rc1"
 
-  s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
+  s.required_rubygems_version = Gem::Requirement.new("> 1.3.1") if s.respond_to? :required_rubygems_version=
   s.authors = ["Kevin Patel"]
-  s.date = %q{2010-08-29}
+  s.date = %q{2010-08-30}
   s.email = %q{tech@moonshado.com}
   s.extra_rdoc_files = [
     "LICENSE",

data/test/sms_test.rb

@@ -3,6 +3,7 @@ require 'helper'
 class Moonshado::SmsTest < Test::Unit::TestCase
   context Moonshado::Sms do
     setup do
+      Moonshado::Sms.configuration = nil
       Moonshado::Sms.configure do |config|
         config.api_key = '20lsdjf2'
         config.production_environment = false
@@ -59,10 +60,10 @@ class Moonshado::SmsTest < Test::Unit::TestCase
 
   context Moonshado::Sms do
     setup do
+      Moonshado::Sms.configuration = nil
       Moonshado::Sms.configure do |config|
         config.api_key = '20lsdjf2'
         config.host = 'notreal.moonshado.com'
-        config.production_environment = true
       end
     end
 
@@ -70,4 +71,22 @@ class Moonshado::SmsTest < Test::Unit::TestCase
       assert_equal(Moonshado::Sms.new("1(555)555-6471", "test").deliver_sms["stat"], "fail")
     end
   end
+
+  context Moonshado::Sms do
+    setup do
+      Moonshado::Sms.configuration = nil
+      Moonshado::Sms.configure do |config|
+        config.api_key = '20lsdjf2'
+        config.production_environment = false
+        config.message_length_check = false
+      end
+    end
+
+    should "not enforce message length" do
+      assert_nothing_raised do
+        message = "Well, if you like burgers give 'em a try sometime. I can't usually get 'em myself because my girlfriend's a vegitarian which pretty much makes me a vegitarian. But I do love the taste of a good burger. Mm-mm-mm. You know what they call a Quarter Pounder with cheese in France?"
+        Moonshado::Sms.new("1(555)555-6471", message).deliver_sms
+      end
+    end
+  end
 end

metadata

@@ -1,13 +1,14 @@
 --- !ruby/object:Gem::Specification 
 name: moonshado-sms
 version: !ruby/object:Gem::Version 
-  hash: 21
-  prerelease: false
+  hash: 977940566
+  prerelease: true
   segments: 
   - 1
-  - 0
   - 1
-  version: 1.0.1
+  - 0
+  - rc1
+  version: 1.1.0.rc1
 platform: ruby
 authors: 
 - Kevin Patel
@@ -15,7 +16,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-08-29 00:00:00 -04:00
+date: 2010-08-30 00:00:00 -04:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -140,12 +141,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
 required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
   requirements: 
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version 
-      hash: 3
+      hash: 25
       segments: 
-      - 0
-      version: "0"
+      - 1
+      - 3
+      - 1
+      version: 1.3.1
 requirements: []
 
 rubyforge_project: