moodle2cc 0.1.3 → 0.1.4

data/lib/moodle2cc/cc/web_link.rb

@@ -22,7 +22,11 @@ module Moodle2CC::CC
     end
 
     def self.external_link?(mod)
-      !!URI.parse(mod.reference.strip).scheme
+      begin
+        !!URI.parse(mod.reference.to_s.strip.gsub(/\s/, '+')).scheme
+      rescue URI::InvalidURIError
+        !!mod.reference.strip.match(/^https?\:\/\//)
+      end
     end
 
     def create_resource_node(resources_node)

data/lib/moodle2cc/version.rb

@@ -1,3 +1,3 @@
 module Moodle2CC
-  VERSION = "0.1.3"
+  VERSION = "0.1.4"
 end

data/test/unit/cc/web_link_test.rb

@@ -53,6 +53,26 @@ class TestUnitCCWebLink < MiniTest::Unit::TestCase
     assert_equal false, web_link.external_link
   end
 
+  def test_it_converts_external_link_with_spaces_in_the_url
+    @mod.reference = "http://en.wikipedia.org/wiki/Einstein with a Space"
+    web_link = Moodle2CC::CC::WebLink.new @mod
+    assert_equal true, web_link.external_link
+
+    @mod.reference = "files/my file.txt"
+    web_link = Moodle2CC::CC::WebLink.new @mod
+    assert_equal false, web_link.external_link
+  end
+
+  def test_it_converts_external_link_with_completely_invalid_url
+    @mod.reference = 'http://!@#$%^&*'
+    web_link = Moodle2CC::CC::WebLink.new @mod
+    assert_equal true, web_link.external_link
+
+    @mod.reference = 'files/!@#$%^&*.txt'
+    web_link = Moodle2CC::CC::WebLink.new @mod
+    assert_equal false, web_link.external_link
+  end
+
   def test_if_converts_href
     @mod.reference = "http://en.wikipedia.org/wiki/Einstein"
     web_link = Moodle2CC::CC::WebLink.new @mod

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: moodle2cc
 version: !ruby/object:Gem::Version 
-  hash: 29
+  hash: 19
   prerelease: 
   segments: 
   - 0
   - 1
-  - 3
-  version: 0.1.3
+  - 4
+  version: 0.1.4
 platform: ruby
 authors: 
 - Christopher Durtschi
@@ -17,7 +17,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-08-06 00:00:00 Z
+date: 2012-08-15 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: rubyzip