monkey_forms 0.0.17 → 0.0.18

data/.travis.yml

@@ -0,0 +1,9 @@
+# Specify which ruby versions you wish to run your tests on, each version will be used
+rvm:
+  - 1.8.7 # (current default)
+  - 1.9.2
+  - rbx
+  - rbx-2.0
+  - ree
+  - jruby
+  - ruby-head

data/lib/monkey_forms/serializers/gzip_cookie.rb

@@ -4,10 +4,11 @@ require 'zlib'
 # Saves form as cookie as json+gzip
 class MonkeyForms::Serializers::GzipCookie
   def initialize options={}
-    @cookie_name = options[:name]
-    @domain      = options[:domain]
+    @cookie_name = options[:name].to_s
+    @domain      = options[:domain].to_s
     @secure      = options[:secure]
     @httponly    = options[:httponly]
+    @path        = (options[:path] || '/').to_s
   end
 
   def load options={}
@@ -16,7 +17,11 @@ class MonkeyForms::Serializers::GzipCookie
     return result if request.blank?
     cookie = request.cookies[@cookie_name]
     return result if cookie.nil? or cookie.empty?
-    result.merge!(ActiveSupport::JSON.decode(Zlib::Inflate.inflate(cookie)).stringify_keys)
+    begin
+      result.merge!(ActiveSupport::JSON.decode(Zlib::Inflate.inflate(cookie)).stringify_keys)
+    rescue Zlib::DataError
+      return result
+    end
   end
 
   def save options = {}
@@ -28,7 +33,8 @@ class MonkeyForms::Serializers::GzipCookie
     cookie_hash = { :value    => cookie_json,
                     :httponly => @httponly,
                     :secure   => @secure,
-                    :domain   => @domain }
+                    :domain   => @domain,
+                    :path     => @path }
     response.set_cookie(@cookie_name, cookie_hash)
   end
 end

data/lib/monkey_forms/version.rb

@@ -1,3 +1,3 @@
 module MonkeyForms
-  VERSION = "0.0.17"
+  VERSION = "0.0.18"
 end

data/lib/monkey_forms.rb

@@ -68,6 +68,9 @@ module MonkeyForms
 
           self.class.attributes.each do |a|
             @attributes[a] ||= ""
+            if self.class.strip_attributes?
+              @attributes[a].strip! if @attributes[a].class == String
+            end
           end
         end
       end
@@ -93,7 +96,7 @@ module MonkeyForms
           @_model_name = (@_form_name.try(:to_s) ||
                           superclass.instance_variable_get(:@_form_name).try(:to_s) ||
                           name.underscore).try(:underscore)
-          %w( singular human i18n_key partial_path plural ).each do |method|
+          %w( singular human i18n_key partial_path plural param_key).each do |method|
             @_model_name.class_eval do
               define_method method do
                 self
@@ -112,6 +115,15 @@ module MonkeyForms
         @form_storage = storage_object
       end
 
+      def dont_strip_form_attributes!
+        @_strip_attributes = false
+      end
+
+      def strip_attributes?
+        return true if !defined?(@_strip_attributes)
+        return @_strip_attributes
+      end
+
       def set_form_attribute_human_names options
         @_form_attribute_names ||= {}
         @_form_attribute_names.merge!(options)

data/test/test_monkey_forms.rb

@@ -24,6 +24,14 @@ class TestMonkeyForms < MiniTest::Unit::TestCase
     assert_equal "Joe <joe@tanga.com>", last_response.body
   end
 
+  def test_form_post_with_bad_cookie
+    post "https://test.domain.com/form", :form => { :name => "Joe" }
+    set_cookie "order_cookie=bad_value; path=/; domain=test.domain.com; secure"
+    post "https://test.domain.com/form", :form => { :name => "Joe" }
+    assert_equal 200, last_response.status
+    skip "i can't get this test to fail. :("
+  end
+
   def test_attribute_name
     o = OrderForm.new
     o.valid?
@@ -42,6 +50,7 @@ class TestMonkeyForms < MiniTest::Unit::TestCase
     assert last_response.headers["Set-Cookie"].include?("HttpOnly")
     assert last_response.headers["Set-Cookie"].include?("secure")
     assert last_response.headers["Set-Cookie"].include?("test.domain.com")
+    assert last_response.headers["Set-Cookie"].include?("path=/;")
   end
 
   def test_setters_from_inside_form
@@ -117,6 +126,11 @@ class TestMonkeyForms < MiniTest::Unit::TestCase
     assert_equal "Joe <joe@tanga.com>", o.person
   end
 
+  def test_can_access_attributes_stripped
+    o = OrderForm.new :form => { :email => "joe@tanga.com" , :name => " Joe " }
+    assert_equal "Joe <joe@tanga.com>", o.person
+  end
+
   def test_array
     submit_form(:line_items => [ {:id => "previous"}])
     attributes = submit_form(:line_items => [ {:id => "new"}])

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: monkey_forms
 version: !ruby/object:Gem::Version
-  version: 0.0.17
+  version: 0.0.18
   prerelease: 
 platform: ruby
 authors:
@@ -9,12 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-07-03 00:00:00.000000000 -07:00
-default_executable: 
+date: 2011-09-14 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
-  requirement: &2162256400 !ruby/object:Gem::Requirement
+  requirement: &70272335220300 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -22,10 +21,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2162256400
+  version_requirements: *70272335220300
 - !ruby/object:Gem::Dependency
   name: minitest
-  requirement: &2162255960 !ruby/object:Gem::Requirement
+  requirement: &70272335219740 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -33,10 +32,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2162255960
+  version_requirements: *70272335219740
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &2162255100 !ruby/object:Gem::Requirement
+  requirement: &70272335219240 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -44,10 +43,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2162255100
+  version_requirements: *70272335219240
 - !ruby/object:Gem::Dependency
   name: sinatra
-  requirement: &2162254500 !ruby/object:Gem::Requirement
+  requirement: &70272335218620 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -55,10 +54,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2162254500
+  version_requirements: *70272335218620
 - !ruby/object:Gem::Dependency
   name: rack-test
-  requirement: &2162253900 !ruby/object:Gem::Requirement
+  requirement: &70272335217960 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -66,10 +65,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2162253900
+  version_requirements: *70272335217960
 - !ruby/object:Gem::Dependency
   name: shotgun
-  requirement: &2162253440 !ruby/object:Gem::Requirement
+  requirement: &70272335217120 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -77,10 +76,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2162253440
+  version_requirements: *70272335217120
 - !ruby/object:Gem::Dependency
   name: haml
-  requirement: &2162252820 !ruby/object:Gem::Requirement
+  requirement: &70272335216360 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -88,10 +87,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2162252820
+  version_requirements: *70272335216360
 - !ruby/object:Gem::Dependency
   name: msgpack
-  requirement: &2162252360 !ruby/object:Gem::Requirement
+  requirement: &70272335215640 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -99,7 +98,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2162252360
+  version_requirements: *70272335215640
 description: Helps make complex forms
 email:
 - joe@tanga.com
@@ -108,6 +107,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .travis.yml
 - BUGS
 - Gemfile
 - NOTES
@@ -150,7 +150,6 @@ files:
 - test/sinatra/sample_sinatra.rb
 - test/sinatra/views/form.haml
 - test/test_monkey_forms.rb
-has_rdoc: true
 homepage: https://github.com/joevandyk/monkey_forms
 licenses: []
 post_install_message: 
@@ -165,7 +164,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -258444513416663442
+      hash: 1638740973580231578
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -174,10 +173,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -258444513416663442
+      hash: 1638740973580231578
 requirements: []
 rubyforge_project: monkey_forms
-rubygems_version: 1.6.2
+rubygems_version: 1.8.10
 signing_key: 
 specification_version: 3
 summary: Helps make complex forms