mongoid_slug 0.4.3 → 0.4.4

data/lib/mongoid_slug.rb

@@ -12,6 +12,7 @@ module Mongoid::Slug
       options = args.last.is_a?(Hash) ? args.pop : {}
       self.slug_name = options[:as] || :slug
       self.slugged_fields = args
+
       field slug_name
       index slug_name, :unique => true
       before_save :generate_slug
@@ -19,25 +20,33 @@ module Mongoid::Slug
   end
 
   def to_param
-    slug
+    self.send slug_name
   end
 
   private
 
-  def duplicate_of(slug, association_chain=[])
+  def find_(slug, stack=[])
     if embedded?
-      association_chain << association_name
-      _parent.send :duplicate_of, slug, association_chain
+      stack << association_name
+      _parent.send :find_, slug, stack
     else
-      association_chain.reverse! << "slug"
-      collection.find(association_chain.join(".") => slug)
+      stack.reverse!
+      path = (stack + [slug_name]).join(".")
+      found = collection.find(path => slug).to_a
+
+      stack.each do |name|
+        if found.any?
+          found = found.first.send(name)
+        end
+      end
+
+      found
     end
   end
 
   def find_unique_slug(suffix='')
     slug = ("#{slug_base} #{suffix}").parameterize
-
-    if duplicate_of(slug).reject{ |doc| doc.id == self.id }.empty?
+    if find_(slug).to_a.reject{ |doc| doc.id == self.id }.empty?
       slug
     else
       suffix = suffix.blank? ? '1' : "#{suffix.to_i + 1}"

data/spec/models/person.rb

@@ -2,5 +2,6 @@ class Person
   include Mongoid::Document
   include Mongoid::Slug
   field :name
+  field :age, :type => Integer
   slug  :name, :as => :permalink
 end

data/spec/mongoid_slug_spec.rb

@@ -24,27 +24,27 @@ describe Mongoid::Slug do
 
     it "appends a counter when slug is not unique" do
       similar_book = Book.create(:title => @book.title)
-      similar_book.slug.should match /\d$/
+      similar_book.to_param.should match /\d$/
     end
 
     it "does not append a counter when slug is unique" do
-      @book.slug.should_not match /\d$/
+      @book.to_param.should_not match /\d$/
     end
 
     it "does not update slug if slugged fields have not changed" do
-      former_slug = @book.slug
+      former_slug = @book.to_param
       @book.update_attributes(:isbn => "9785545858118")
-      @book.slug.should eql former_slug
+      @book.to_param.should eql former_slug
     end
 
     it "does not update slug if slugged fields have changed but generated slug is the same" do
-      former_slug = @book.slug
+      former_slug = @book.to_param
       @book.update_attributes(:title => "A thousand plateaus")
-      @book.slug.should eql former_slug
+      @book.to_param.should eql former_slug
     end
 
     it "finds by slug" do
-      Book.where(:slug => @book.slug).first.should eql @book
+      Book.where(:slug => @book.to_param).first.should eql @book
     end
 
   end
@@ -71,21 +71,27 @@ describe Mongoid::Slug do
 
     it "appends a counter when slug is not unique" do
       similar_subject = @book.subjects.create(:name => @subject.name)
-      similar_subject.slug.should match /\d$/
+      similar_subject.to_param.should match /\d$/
     end
 
     it "does not append a counter when slug is unique" do
-      @subject.slug.should_not match /\d$/
+      @subject.to_param.should_not match /\d$/
     end
 
-    it "does not update slug if slugged field has not changed" do
-      former_slug = @subject.slug
+    it "does not update slug if slugged fields have not changed" do
+      former_slug = @subject.to_param
       @subject.update_attributes(:description => "Lorem ipsum dolor sit amet")
-      @subject.slug.should eql former_slug
+      @subject.to_param.should eql former_slug
+    end
+
+    it "does not update slug if slugged fields have changed but generated slug is the same" do
+      former_slug = @subject.to_param
+      @subject.update_attributes(:title => "PSYCHOANALYSIS")
+      @subject.to_param.should eql former_slug
     end
 
     it "finds by slug" do
-      @book.subjects.where(:slug => @subject.slug).first.should eql @subject
+      @book.subjects.where(:slug => @subject.to_param).first.should eql @subject
     end
 
   end
@@ -105,10 +111,16 @@ describe Mongoid::Slug do
       @publisher.to_param.should eql "Harvard UP".parameterize
     end
 
-    it "does not update slug if slugged field has not changed" do
-      former_slug = @publisher.slug
+    it "does not update slug if slugged fields have not changed" do
+      former_slug = @publisher.to_param
       @publisher.update_attributes(:year => 2001)
-      @publisher.slug.should eql former_slug
+      @publisher.to_param.should eql former_slug
+    end
+
+    it "does not update slug if slugged fields have changed but generated slug is the same" do
+      former_slug = @publisher.to_param
+      @publisher.update_attributes(:name => "oup")
+      @publisher.to_param.should eql former_slug
     end
 
   end
@@ -136,11 +148,17 @@ describe Mongoid::Slug do
     it "appends a counter when slug is not unique" do
       similar_author = Author.create(:first_name => @author.first_name,
                                      :last_name => @author.last_name)
-      similar_author.slug.should match /\d$/
+      similar_author.to_param.should match /\d$/
     end
 
     it "does not append a counter when slug is unique" do
-      @author.slug.should_not match /\d$/
+      @author.to_param.should_not match /\d$/
+    end
+
+    it "does not update slug if slugged fields have changed but generated slug is the same" do
+      former_slug = @author.to_param
+      @author.update_attributes(:first_name => "gilles", :last_name => "DELEUZE")
+      @author.to_param.should eql former_slug
     end
 
     it "finds by slug" do
@@ -174,21 +192,27 @@ describe Mongoid::Slug do
 
     it "appends a counter when slug is not unique" do
       similar_baz = @bar.bazes.create(:name => @baz.name)
-      similar_baz.slug.should match /\d$/
+      similar_baz.to_param.should match /\d$/
     end
 
     it "does not append a counter when slug is unique" do
-      @baz.slug.should_not match /\d$/
+      @baz.to_param.should_not match /\d$/
     end
 
-    it "does not update slug if slugged field has not changed" do
-      former_slug = @baz.slug
+    it "does not update slug if slugged fields have not changed" do
+      former_slug = @baz.to_param
       @baz.update_attributes(:other => "Lorem ipsum dolor sit amet")
-      @baz.slug.should eql former_slug
+      @baz.to_param.should eql former_slug
+    end
+
+    it "does not update slug if slugged fields have changed but generated slug is the same" do
+      former_slug = @baz.to_param
+      @baz.update_attributes(:name => "BAZ")
+      @baz.to_param.should eql former_slug
     end
 
     it "finds by slug" do
-      @bar.bazes.where(:slug => @baz.slug).first.should eql @baz
+      @bar.bazes.where(:slug => @baz.to_param).first.should eql @baz
     end
 
   end
@@ -204,9 +228,48 @@ describe Mongoid::Slug do
       @person.send(:permalink).should eql "john-doe"
     end
 
+    it "generates slug" do
+      @person.to_param.should eql(@person.name.parameterize)
+    end
+
+    it "updates slug" do
+      @person.update_attributes(:name => "Jane Doe")
+      @person.to_param.should eql "Jane Doe".parameterize
+    end
+
+    it "generates a unique slug" do
+      similar_person = Person.create(:name => @person.name)
+      similar_person.to_param.should_not eql @person.to_param
+    end
+
+    it "appends a counter when slug is not unique" do
+      similar_person = Person.create(:name => @person.name)
+      similar_person.to_param.should match /\d$/
+    end
+
+    it "does not append a counter when slug is unique" do
+      @person.to_param.should_not match /\d$/
+    end
+
+    it "does not update slug if slugged fields have not changed" do
+      former_slug = @person.to_param
+      @person.update_attributes(:age => 31)
+      @person.to_param.should eql former_slug
+    end
+
+    it "does not update slug if slugged fields have changed but generated slug is the same" do
+      former_slug = @person.to_param
+      @person.update_attributes(:name => "JOHN DOE")
+      @person.to_param.should eql former_slug
+    end
+
+    it "finds by slug" do
+      Person.where(:permalink => @person.to_param).first.should eql @person
+    end
+
   end
 
-  context "#duplicate_of" do
+  context "#find_" do
 
     before(:each) do
       @foo = Foo.create(:name => "foo")
@@ -215,15 +278,15 @@ describe Mongoid::Slug do
     end
 
     it "finds duplicate slug of a root document" do
-      @foo.send(:duplicate_of, @foo.slug).count.should eql 1
+      @foo.send(:find_, @foo.to_param).count.should eql 1
     end
 
     it "finds duplicate slug of an embedded document" do
-      @bar.send(:duplicate_of, @bar.slug).count.should eql 1
+      @bar.send(:find_, @bar.to_param).count.should eql 1
     end
 
     it "finds duplicate slug of a deeply-embedded document" do
-      @baz.send(:duplicate_of, @baz.slug).count.should eql 1
+      @baz.send(:find_, @baz.to_param).count.should eql 1
     end
 
   end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: mongoid_slug
 version: !ruby/object:Gem::Version 
-  hash: 9
+  hash: 7
   prerelease: false
   segments: 
   - 0
   - 4
-  - 3
-  version: 0.4.3
+  - 4
+  version: 0.4.4
 platform: ruby
 authors: 
 - Hakan Ensari
@@ -16,7 +16,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-07-07 00:00:00 +01:00
+date: 2010-07-08 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency