mongoid_orderable 6.0.3 → 6.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8882038ec4e57486bd693bc1732f935f2d01f949aeedc7f71b3c54bca5ac0b44
-  data.tar.gz: c0c82c4802280dfe6005e89122e9f7905fabcdf261bc9b3864016d10a70c112c
+  metadata.gz: a2babceab2f835fc658b2b41350208c65cc0aba49449b72a73e7275c84583479
+  data.tar.gz: ffdda4411505dc18f660dea2567a3d6d5e59aa40c6d95e9ef1a7404e4455c625
 SHA512:
-  metadata.gz: 64332b6ae9d7786864d238accdd3ec81c8defa059ff1d7e1763e487a271c2dffb2f25b3a1a2332947a3b262ecc6cb8da33aae0acdab0cd04bd3ac6e0a2a2ca44
-  data.tar.gz: 918ea29f2b71caf6cfba5cdc7e145bba69d0d90d2561e1983676fa13a3517f87eaabd7f66d628fbae1ec45df56fe82a11a723de632bbd1650697f39939d10534
+  metadata.gz: 41e8f1cae5a56384b9f5b2a953218c1a11de6b66d5b3ef1459d7fa4404d97ccb1151127eaefba3027c83f0d701b74630ff31c4aa329d48b0067cab683122d9b4
+  data.tar.gz: f7f3195f9c63bb9daba132b83d7afa973e58c9afe743a69ea261621eb89454b669f497dc33b69e0d4eefc0e1245523b6da2c97797906dbf98469ab69d2c94e21

data/CHANGELOG.md

@@ -1,11 +1,16 @@
-### 6.0.4 (Next)
+### 6.0.5 (Next)
 
 * Your contribution here.
 
+### 6.0.4 (Next)
+
+* [#75](https://github.com/mongoid/mongoid_orderable/pull/75): Fix: Setting #move_to should mark an orderable object as changed so that callbacks are triggered.
+
 ### 6.0.3 (2021/06/27)
 
 * [#72](https://github.com/mongoid/mongoid_orderable/pull/72): Feature: Add :if and :unless conditions which disable callbacks.
 * [#71](https://github.com/mongoid/mongoid_orderable/pull/71): Fix: Add TTL index to locks table.
+* [#73](https://github.com/mongoid/mongoid_orderable/pull/73): Refactor: Replace Travis CI with Github Actions.
 
 ### 6.0.2 (2021/01/26)
 

data/lib/mongoid/orderable/installer.rb

@@ -48,6 +48,7 @@ module Orderable
       klass.send :include, Mixins::Callbacks
       klass.send :include, Mixins::Movable
       klass.send :include, Mixins::Listable
+      klass.send :prepend, Mixins::Cascadeable if klass.embedded?
     end
 
     def generate_all_helpers

data/lib/mongoid/orderable/mixins/cascadeable.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+module Mongoid
+module Orderable
+module Mixins
+  # This is required to trigger callbacks on embedded objects.
+  # Otherwise, the #move_to parameter won't work when saving the parent.
+  module Cascadeable
+    def in_callback_state?(kind)
+      super || move_all.present?
+    end
+  end
+end
+end
+end

data/lib/mongoid/orderable/version.rb

@@ -2,6 +2,6 @@
 
 module Mongoid
   module Orderable
-    VERSION = '6.0.3'
+    VERSION = '6.0.4'
   end
 end

data/lib/mongoid_orderable.rb

@@ -18,6 +18,7 @@ require 'mongoid/orderable/mixins/helpers'
 require 'mongoid/orderable/mixins/callbacks'
 require 'mongoid/orderable/mixins/listable'
 require 'mongoid/orderable/mixins/movable'
+require 'mongoid/orderable/mixins/cascadeable'
 require 'mongoid/orderable/generators/base'
 require 'mongoid/orderable/generators/listable'
 require 'mongoid/orderable/generators/lock_collection'

data/spec/integration/cascadeable_spec.rb

@@ -0,0 +1,12 @@
+require 'spec_helper'
+
+describe Mongoid::Orderable::Mixins::Cascadeable do
+
+  it do
+    eo = EmbedsOrderable.create!
+    orderable = eo.embedded_orderables.create!
+    expect(orderable.in_callback_state?(:update)).to eq false
+    orderable.move_to = 2
+    expect(orderable.in_callback_state?(:update)).to eq true
+  end
+end

data/spec/integration/embedded_spec.rb

@@ -19,11 +19,33 @@ describe EmbeddedOrderable do
       expect(positions).to eq([[1, 2], [1, 2, 3]])
     end
 
-    it 'moves an item returned by a query to position' do
-      embedded_orderable1 = EmbedsOrderable.first.embedded_orderables.where(position: 1).first
-      embedded_orderable2 = EmbedsOrderable.first.embedded_orderables.where(position: 2).first
-      embedded_orderable1.move_to! 2
-      expect(embedded_orderable2.reload.position).to eq(1)
+    it 'move_to! moves an item returned by a query to position' do
+      parent = EmbedsOrderable.first
+      child1 = parent.embedded_orderables.where(position: 1).first
+      child2 = parent.embedded_orderables.where(position: 2).first
+      child1.move_to!(2)
+      expect(child1.reload.position).to eq(2)
+      expect(child2.reload.position).to eq(1)
+    end
+
+    it 'move_to moves an item returned by a query to position when saving the parent' do
+      parent = EmbedsOrderable.first
+      child1 = parent.embedded_orderables.where(position: 1).first
+      child2 = parent.embedded_orderables.where(position: 2).first
+      child1.move_to(2)
+      parent.save!
+      expect(child1.reload.position).to eq(2)
+      expect(child2.reload.position).to eq(1)
+    end
+
+    it 'move_to= moves an item returned by a query to position when saving the parent' do
+      parent = EmbedsOrderable.first
+      child1 = parent.embedded_orderables.where(position: 1).first
+      child2 = parent.embedded_orderables.where(position: 2).first
+      child1.move_to = 2
+      parent.save!
+      expect(child1.reload.position).to eq(2)
+      expect(child2.reload.position).to eq(1)
     end
   end
 

data/spec/support/models.rb

@@ -53,7 +53,7 @@ end
 class EmbedsOrderable
   include Mongoid::Document
 
-  embeds_many :embedded_orderables
+  embeds_many :embedded_orderables, cascade_callbacks: true
 end
 
 class EmbeddedOrderable

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mongoid_orderable
 version: !ruby/object:Gem::Version
-  version: 6.0.3
+  version: 6.0.4
 platform: ruby
 authors:
 - pyromaniac
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-06-28 00:00:00.000000000 Z
+date: 2023-01-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -111,11 +111,13 @@ files:
 - lib/mongoid/orderable/handlers/transaction.rb
 - lib/mongoid/orderable/installer.rb
 - lib/mongoid/orderable/mixins/callbacks.rb
+- lib/mongoid/orderable/mixins/cascadeable.rb
 - lib/mongoid/orderable/mixins/helpers.rb
 - lib/mongoid/orderable/mixins/listable.rb
 - lib/mongoid/orderable/mixins/movable.rb
 - lib/mongoid/orderable/version.rb
 - lib/mongoid_orderable.rb
+- spec/integration/cascadeable_spec.rb
 - spec/integration/concurrency_spec.rb
 - spec/integration/conditional_spec.rb
 - spec/integration/customized_spec.rb
@@ -135,7 +137,7 @@ homepage: https://github.com/mongoid/mongoid_orderable
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -150,11 +152,12 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.9
-signing_key: 
+rubygems_version: 3.4.4
+signing_key:
 specification_version: 4
 summary: Mongoid orderable list implementation
 test_files:
+- spec/integration/cascadeable_spec.rb
 - spec/integration/concurrency_spec.rb
 - spec/integration/conditional_spec.rb
 - spec/integration/customized_spec.rb