mongoid_enumerable 0.4.1 → 0.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 18e17dfe853d6105ee28629168235d887a48e3c4bbb3c664e12fbbf498fecd29
-  data.tar.gz: c8098cd06f3564632e66b2b3215364ccd7e4b3f76abfd7b38bc68ca906e8e793
+  metadata.gz: eea7a8187ca0baa94f1a246cad4ba93500e46177176da71d250e548bf344dc19
+  data.tar.gz: f4f94d1bb5eb15077d7681a8a475b444ca16ced8a09034f4d953ac5151702912
 SHA512:
-  metadata.gz: 968163534163961a35c1fae3d38aa4d9c8df4540a8fda3748173abd7712ea789453ed79732c110b6d8fdf2d1d89bf273ec4b44387edc97fa394aad679d79034a
-  data.tar.gz: d934f50160025fc5361f90fc8a7c4d6321ae958f5adec90d0cb15093845530c233e0d1a87d7a9a02c396b52c94e0dadde6b56d80b3e76ab4a90043447e226419
+  metadata.gz: 42eb07241e7d9211d929fe1cbc107020f87e8f48e5c1f1c08ec3ffac1690a479123659b25ee44e0e97fcf85a516d851df6f106ee69db2ce139dbf05ceda65883
+  data.tar.gz: f094c1e7ed54b3ede3a725f3c3cf55cf4b9fd4c50e726ee2d0e78879c576125d0f0c0b8da0f543ae638c15bfc9461de091af41863f004fbe501fe2750aa70f43

data/.rubocop.yml

@@ -0,0 +1,21 @@
+AllCops:
+  NewCops: disable
+
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+
+Style/Documentation:
+  Enabled: false
+
+Metrics/BlockLength:
+  Exclude:
+    - 'spec/**/*'
+
+Metrics/ParameterLists:
+  Max: 7
+
+Layout/LineLength:
+  Max: 120
+
+Metrics/MethodLength:
+  Max: 16

data/Gemfile

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 source "https://rubygems.org"
 
-git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
+git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 
 # Specify your gem's dependencies in mongoid_enumerable.gemspec
 gemspec

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    mongoid_enumerable (0.4.1)
+    mongoid_enumerable (0.4.2)
       mongoid (>= 4.0)
 
 GEM
@@ -15,6 +15,7 @@ GEM
       minitest (~> 5.1)
       tzinfo (~> 1.1)
       zeitwerk (~> 2.2)
+    ast (2.4.0)
     bson (4.8.2)
     byebug (11.1.1)
     coderay (1.1.2)
@@ -39,6 +40,7 @@ GEM
       rspec (>= 2.99.0, < 4.0)
     i18n (1.8.2)
       concurrent-ruby (~> 1.0)
+    jaro_winkler (1.5.4)
     listen (3.2.1)
       rb-fsevent (~> 0.10, >= 0.10.3)
       rb-inotify (~> 0.9, >= 0.9.10)
@@ -54,13 +56,18 @@ GEM
     notiffany (0.1.3)
       nenv (~> 0.1)
       shellany (~> 0.0)
+    parallel (1.19.1)
+    parser (2.7.1.2)
+      ast (~> 2.4.0)
     pry (0.13.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
+    rainbow (3.0.0)
     rake (13.0.1)
     rb-fsevent (0.10.3)
     rb-inotify (0.10.1)
       ffi (~> 1.0)
+    rexml (3.2.4)
     rspec (3.9.0)
       rspec-core (~> 3.9.0)
       rspec-expectations (~> 3.9.0)
@@ -77,6 +84,15 @@ GEM
       rspec (>= 3)
       terminal-notifier (>= 1.4)
     rspec-support (3.9.2)
+    rubocop (0.82.0)
+      jaro_winkler (~> 1.5.1)
+      parallel (~> 1.10)
+      parser (>= 2.7.0.1)
+      rainbow (>= 2.2.2, < 4.0)
+      rexml
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 1.4.0, < 2.0)
+    ruby-progressbar (1.10.1)
     shellany (0.0.1)
     simplecov (0.18.5)
       docile (~> 1.1)
@@ -87,6 +103,7 @@ GEM
     thread_safe (0.3.6)
     tzinfo (1.2.7)
       thread_safe (~> 0.1)
+    unicode-display_width (1.7.0)
     zeitwerk (2.3.0)
 
 PLATFORMS
@@ -102,6 +119,7 @@ DEPENDENCIES
   rake (~> 13.0)
   rspec (~> 3.0)
   rspec-nc
+  rubocop
   simplecov
 
 BUNDLED WITH

data/Guardfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # A sample Guardfile
 # More info at https://github.com/guard/guard#readme
 
@@ -28,8 +30,6 @@ guard :rspec, cmd: "bundle exec rspec --format Nc --format documentation" do
   require "guard/rspec/dsl"
   dsl = Guard::RSpec::Dsl.new(self)
 
-  # Feel free to open issues for suggestions and improvements
-
   # RSpec files
   rspec = dsl.rspec
   watch(rspec.spec_helper) { rspec.spec_dir }
@@ -39,32 +39,4 @@ guard :rspec, cmd: "bundle exec rspec --format Nc --format documentation" do
   # Ruby files
   ruby = dsl.ruby
   dsl.watch_spec_files_for(ruby.lib_files)
-
-  # Rails files
-  rails = dsl.rails(view_extensions: %w(erb haml slim))
-  dsl.watch_spec_files_for(rails.app_files)
-  dsl.watch_spec_files_for(rails.views)
-
-  watch(rails.controllers) do |m|
-    [
-      rspec.spec.call("routing/#{m[1]}_routing"),
-      rspec.spec.call("controllers/#{m[1]}_controller"),
-      rspec.spec.call("acceptance/#{m[1]}")
-    ]
-  end
-
-  # Rails config changes
-  watch(rails.spec_helper)     { rspec.spec_dir }
-  watch(rails.routes)          { "#{rspec.spec_dir}/routing" }
-  watch(rails.app_controller)  { "#{rspec.spec_dir}/controllers" }
-
-  # Capybara features specs
-  watch(rails.view_dirs)     { |m| rspec.spec.call("features/#{m[1]}") }
-  watch(rails.layouts)       { |m| rspec.spec.call("features/#{m[1]}") }
-
-  # Turnip features and steps
-  watch(%r{^spec/acceptance/(.+)\.feature$})
-  watch(%r{^spec/acceptance/steps/(.+)_steps\.rb$}) do |m|
-    Dir[File.join("**/#{m[1]}.feature")][0] || "spec/acceptance"
-  end
 end

data/README.md

@@ -37,7 +37,7 @@ class Task
   include Mongoid::Document
   include MongoidEnumerable
 
-  enumerable :status, %w(completed running failed waiting), default: "waiting"
+  enumerable :status, %w[completed running failed waiting], default: "waiting"
 end
 ```
 
@@ -57,13 +57,13 @@ task.waiting? # false
 #### Default
 Defines which value is the default for new documents. If not specified the first value is used as default.
 ```ruby
-enumerable :status, %w(completed running failed waiting), default: "waiting"
+enumerable :status, %w[completed running failed waiting], default: "waiting"
 ```
 #### Prefix
 You can define a prefix for your methods that could be useful if you have more than one enumerable with the same values.
 ```ruby
-enumerable :build_status, %w(completed running failed waiting), default: "waiting", prefix: "build_"
-enumerable :deploy_status, %w(completed running failed waiting), default: "waiting", prefix: "deploy_"
+enumerable :build_status, %w[completed running failed waiting], default: "waiting", prefix: "build_"
+enumerable :deploy_status, %w[completed running failed waiting], default: "waiting", prefix: "deploy_"
 
 task.build_completed?
 task.build_failed!
@@ -82,7 +82,7 @@ class Task
   include Mongoid::Document
   include MongoidEnumerable
 
-  enumerable :status, %w(completed running failed waiting), default: "waiting", before_change: :can_status_change?
+  enumerable :status, %w[completed running failed waiting], default: "waiting", before_change: :can_status_change?
 
   def can_status_change?(old_value, new_value)
     new_value != "waiting"
@@ -108,7 +108,7 @@ class Task
   include Mongoid::Document
   include MongoidEnumerable
 
-  enumerable :status, %w(completed running failed waiting),
+  enumerable :status, %w[completed running failed waiting],
     default: "waiting",
     after_change: :status_changed
 

data/Rakefile

@@ -1,6 +1,10 @@
+# frozen_string_literal: true
+
 require "bundler/gem_tasks"
 require "rspec/core/rake_task"
+require "rubocop/rake_task"
 
 RSpec::Core::RakeTask.new(:spec)
+RuboCop::RakeTask.new(:linter)
 
-task :default => :spec
+task default: %i[linter spec]

data/bin/console

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require "bundler/setup"
 require "mongoid_enumerable"

data/lib/mongoid_enumerable.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "mongoid_enumerable/version"
 require "mongoid"
 
@@ -6,8 +8,6 @@ module MongoidEnumerable
     define_enumerable_methods(model)
   end
 
-  private
-
   def self.define_enumerable_methods(model)
     model.define_singleton_method :enumerable do |field_name, values, options = {}|
       MongoidEnumerable.define_enumerable_method(
@@ -48,24 +48,24 @@ module MongoidEnumerable
       value_before = send(field_name)
       value_after = value
 
-      callback_result = run_callback(model: model, callback_method_name: before_change,
-        value_before: value_before, value_after: value_after)
+      callback_result = run_callback(callback_method_name: before_change,
+                                     value_before: value_before, value_after: value_after)
 
       if callback_result
         update!(field_name => value)
-        run_callback(model: model, callback_method_name: after_change,
-          value_before: value_before, value_after: value_after)
+        run_callback(callback_method_name: after_change,
+                     value_before: value_before, value_after: value_after)
       end
     end
 
-    define_method("#{method_name}?") do
+    model.define_method("#{method_name}?") do
       send(field_name) == value
     end
 
     model.scope method_name, -> { where(field_name => value) }
   end
 
-  def run_callback(model:, callback_method_name:, value_before:, value_after:)
+  def run_callback(callback_method_name:, value_before:, value_after:)
     if callback_method_name
       callback_method = method(callback_method_name)
       validate_callback_method(method: callback_method)
@@ -77,8 +77,8 @@ module MongoidEnumerable
   end
 
   def validate_callback_method(method:)
-    if method.arity != 2 && method.arity >= 0
-      raise "Method #{method.name} must receive two parameters: old_value and new_value"
-    end
+    return if method.arity == 2 || method.arity.negative?
+
+    raise "Method #{method.name} must receive two parameters: old_value and new_value"
   end
 end

data/lib/mongoid_enumerable/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module MongoidEnumerable
-  VERSION = '0.4.1'
+  VERSION = "0.4.2"
 end

data/mongoid_enumerable.gemspec

@@ -1,5 +1,6 @@
+# frozen_string_literal: true
 
-lib = File.expand_path("../lib", __FILE__)
+lib = File.expand_path("lib", __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require "mongoid_enumerable/version"
 
@@ -9,8 +10,8 @@ Gem::Specification.new do |spec|
   spec.authors       = ["Douglas Lise"]
   spec.email         = ["douglaslise@gmail.com"]
 
-  spec.summary       = %q{Mongoid Enumerable}
-  spec.description   = %q{Mongoid Enumerable}
+  spec.summary       = "Mongoid Enumerable"
+  spec.description   = "Mongoid Enumerable"
   spec.homepage      = "https://github.com/douglaslise/mongoid_enumerable"
 
   spec.files         = `git ls-files -z`.split("\x0").reject do |f|
@@ -21,13 +22,14 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_development_dependency "bundler"
-  spec.add_development_dependency "rake", "~> 13.0"
-  spec.add_development_dependency "rspec", "~> 3.0"
-  spec.add_development_dependency "rspec-nc"
-  spec.add_development_dependency "mongoid"
   spec.add_development_dependency "byebug"
   spec.add_development_dependency "guard"
   spec.add_development_dependency "guard-rspec"
+  spec.add_development_dependency "mongoid"
+  spec.add_development_dependency "rake", "~> 13.0"
+  spec.add_development_dependency "rspec", "~> 3.0"
+  spec.add_development_dependency "rspec-nc"
+  spec.add_development_dependency "rubocop"
   spec.add_dependency "mongoid", ">= 4.0"
   spec.add_development_dependency "simplecov"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mongoid_enumerable
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.4.2
 platform: ruby
 authors:
 - Douglas Lise
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-04-24 00:00:00.000000000 Z
+date: 2020-05-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -25,35 +25,35 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '13.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '13.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: guard
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec-nc
+  name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -81,21 +81,35 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: byebug
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
-  name: guard
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: rspec-nc
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -109,7 +123,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: guard-rspec
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -159,6 +173,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - ".travis.yml"
 - Gemfile
 - Gemfile.lock