mongoid_denormalize 0.4.0 → 0.4.1

data/README.md

@@ -143,7 +143,7 @@ So, if User has_many :posts and User has_many :comments, but Comments are embedd
 Contributing
 -------
 
-Clone the repository and run Bundler with `bundle install` so that you can run the rake tasks.
+Clone the repository and run Bundler with `bundle install`. Use `rake -T` to view available rake tasks.
 
 Contributors
 -------

data/lib/mongoid_denormalize.rb

@@ -1,3 +1,4 @@
+require 'mongoid_denormalize/version'
 require File.dirname(__FILE__) + '/railties/railtie' if defined?(Rails::Railtie)
 
 # = Mongoid::Denormalize
@@ -103,7 +104,8 @@ module Mongoid::Denormalize
 
   def assign_and_save(obj, assignments, prefix)
     attributes_hash = Hash[assignments.collect do |assignment|
-      if self.changed_attributes.has_key?(assignment[:source_field])
+      if self.changed_attributes.has_key?(assignment[:source_field].to_s) ||
+          self.changed_attributes.has_key?(assignment[:source_field].to_sym)
         ["#{prefix}_#{assignment[:source_field]}", assignment[:value]]
       end
     end]
@@ -111,7 +113,7 @@ module Mongoid::Denormalize
     unless attributes_hash.empty?
       # The more succinct update_attributes(changes, :without_protection => true) requires Mongoid 3.0.0, 
       # but we only require 2.1.9
-      obj.assign_attributes(attributes_hash, :without_protection => true)
+      obj.write_attributes(attributes_hash, false)
       obj.save(:validate => false)
     end
   end

data/lib/mongoid_denormalize/version.rb

@@ -0,0 +1,5 @@
+module Mongoid
+  module Denormalize
+    VERSION = '0.4.1'
+  end
+end

data/spec/mongoid_denormalize_spec.rb

@@ -0,0 +1,150 @@
+require "spec_helper"
+
+describe Mongoid::Denormalize do
+  before(:each) do
+    @post = Post.create!(:title => "Blog post", :body => "Lorem ipsum...", :created_at => Time.parse("Jan 1 2010 12:00"))
+    @user = User.create!(:name => "John Doe", :email => "john@doe.com", :post => @post, :location => [1, 1], :nickname => "jdoe")
+    @comment = @post.comments.create(:body => "This is the comment", :user => @user)
+    @post.reload #neccessary for older versions of Mongoid
+    @moderated_comment = @post.comments.create(:body => "This is a moderated comment", :moderator => @user)
+    @article = @user.articles.create!(:title => "Article about Lorem", :body => "Lorem ipsum...", :created_at => Time.parse("Jan 1 2010 12:00"))
+
+    @user.comments << @comment
+    @user.moderated_comments << @moderated_comment
+    @user.save
+    @user.reload
+    @other_user = User.create!(:name => "Bill")
+  end
+
+  context "denormalize from" do
+    it "should define multiple fields for association" do
+      @post.fields.should have_key "user_name"
+      @post.fields.should have_key "user_email"
+      @post.fields.should have_key "user_location"
+    end
+    
+    it "should default to string field type for associated fields" do
+      @post.fields["user_name"].type.should eql String
+    end
+    
+    it "should allow setting the field type for associated fields" do
+      @comment.fields["post_created_at"].type.should eql Time
+    end
+    
+    it "should allow multiple declarations for the same association" do
+      @comment.fields.should have_key "user_name"
+      @comment.fields.should have_key "user_email"
+    end
+    
+    it "should denormalize fields without specified type" do
+      @comment.user_name.should eql @user.name
+      @comment.user_email.should eql @user.email
+      @post.user_name.should eql @user.name
+      @post.user_email.should eql @user.email
+    end
+    
+    it "should denormalize fields with specified type" do
+      @comment.post_created_at.should eql @post.created_at
+      
+      @post.user_location.should eql @user.location
+    end
+
+    it "should use fresh values from database where possible" do
+      @other_post = Post.create!(:title => "My first blog post")
+      @other_post.update_attribute(:user_id, @user.id)
+      @other_post.user_name.should eql @user.name
+    end
+    
+    it "should update denormalized values if attribute is changed" do
+      @user.update_attributes(:name => "Bob Doe", :location => [4, 4])
+
+      @post.reload #needed for old versions of Mongoid
+      @post.user_location.should eql @user.location
+
+      @comment.reload #needed for old versions of Mongoid
+      @comment.user_name.should eql @user.name
+    end
+    
+    it "should update denormalized values if object is changed" do
+      @other_user = User.create!(:name => "Bill", :email => "bill@doe.com")
+      
+      @comment.user = @other_user
+      @comment.save!
+      
+      @comment.user_name.should eql @other_user.name
+      @comment.user_email.should eql @other_user.email
+    end
+  end
+  
+  context "denormalize to" do
+    it "should push denormalized fields to one-to-one association" do
+      @user.name = "Elvis"
+      @user.save!
+
+      @post.reload #needed for old versions of Mongoid
+      @post.user_name.should eql "Elvis"
+    end
+    
+    it "should push denormalized fields to one-to-many association" do
+      @post.created_at = Time.parse("Jan 1 2011 12:00")
+      @post.save!
+
+      @comment.reload #needed for old versions of Mongoid
+      @comment.post_created_at.should eql Time.parse("Jan 1 2011 12:00")
+    end
+
+    it "should push denormalized fields to association using inverse_of class name" do
+      @user.update_attributes(:name => "Bob Doe", :email => "bob@doe.com")
+      @user.save!
+
+      @article.reload #needed for old versions of Mongoid
+      @article.author_name.should eql "Bob Doe"
+      @article.author_email.should eql "bob@doe.com"
+    end
+
+    it "should push to overriden field names" do
+      @user.nickname = "jonsey"
+      @user.save!
+      
+      @moderated_comment.reload
+      @moderated_comment.mod_nickname.should eql "jonsey"
+    end
+
+    it "shouldn't make superfluous saves" do
+      @comment.should_not_receive(:save)
+      @post.save!
+    end
+  end
+  
+  context "rake task" do
+    it "should correct inconsistent denormalizations on regular documents" do
+      if ::Mongoid::VERSION < '3'
+        Post.collection.update({ '_id' => @post.id }, { '$set' => { 'user_name' => 'Clint Eastwood' } })
+      else
+        @post.set(:user_name, 'Clint Eastwood')
+      end
+
+      @post.reload #needed for old versions of Mongoid
+      @post.user_name.should eq 'Clint Eastwood'
+
+      Rake::Task["db:denormalize"].invoke
+      Rake::Task["db:denormalize"].reenable
+      
+      @post.reload
+      @post.user_name.should eql @user.name
+    end
+    
+    it "should correct inconsistent denormalizations on referenced embedded documents" do
+      @rake_user = User.create!(:name => "Johnny Depp", :email => "johnny@depp.com")
+      @rake_comment = @post.comments.create!(:body => "Depp's comment", :user => @rake_user)
+      
+      @rake_user.update_attributes!(:name => "J. Depp")
+      
+      Rake::Task["db:denormalize"].invoke
+      Rake::Task["db:denormalize"].reenable
+      
+      @post.reload
+      @post.comments.last.user_name.should eql @rake_user.name
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mongoid_denormalize
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
   prerelease: 
 platform: ruby
 authors:
@@ -11,56 +11,8 @@ bindir: bin
 cert_chain: []
 date: 2013-06-19 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: mongoid_denormalize
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: bson_ext
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: jeweler
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
@@ -116,10 +68,12 @@ extra_rdoc_files:
 - README.md
 files:
 - lib/mongoid_denormalize.rb
+- lib/mongoid_denormalize/version.rb
 - lib/railties/denormalize.rake
 - lib/railties/railtie.rb
 - LICENSE
 - README.md
+- spec/mongoid_denormalize_spec.rb
 homepage: http://github.com/logandk/mongoid_denormalize
 licenses: []
 post_install_message: 
@@ -132,9 +86,6 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 4386387219584124888
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -143,8 +94,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 1.8.25
 signing_key: 
 specification_version: 3
 summary: Mongoid denormalization helper.
-test_files: []
+test_files:
+- spec/mongoid_denormalize_spec.rb