mongoid 5.1.2 → 5.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 922955f679b61344863a31c45286a9e6a98fef4c
-  data.tar.gz: 70619f1566afa0b012a1125fd19532cb8e7ab7b1
+  metadata.gz: b4fed172bb6af11ba2b149b79f186088e927654b
+  data.tar.gz: 5a773064e7b4e5b53b299763cc224376e1c2b982
 SHA512:
-  metadata.gz: 200a3e9686b108018cc53c8278333f71ad8aff307a730d7e5ab5c09d1849b56a34dfd3e59f48af397314d2b936261ed4d482a26ca5d83e8f0b1bc7ebb9b962eb
-  data.tar.gz: c4daaaa77a96197384841ba4849621a63b9ea8add033cd691ff3323285d0221ffec05dce0024e8b59f012f1e0a56548da40158b5c76184b1baa1d9333a853cfa
+  metadata.gz: c0acac4c15262c18ada59b3297588f8ad173f9a3729ecb8b2bbffdb43276549c7e9f7ea94856141c7dde36c028964373d3a27e7bba21990fb8958f6051931b0a
+  data.tar.gz: 70a79115a1c45102070577281ad7664b89a34a284c14bb08a6b79af4bd385d544c4f9bce177b9babedfb13734dcfd480e1c2ca7e9676b5b405a77ed21e588788

data/lib/mongoid/attributes.rb

@@ -350,7 +350,7 @@ module Mongoid
       if localized_fields.has_key?(name)
         value = localized_fields[name].send(:lookup, value)
       end
-      !!value
+      value.present?
     end
   end
 end

data/lib/mongoid/criteria/modifiable.rb

@@ -173,7 +173,7 @@ module Mongoid
       # @since 3.0.0
       def create_document(method, attrs = nil, &block)
         attributes = selector.reduce(attrs ? attrs.dup : {}) do |hash, (key, value)|
-          unless key.to_s =~ /\$/ || (value.is_a?(Hash) && !attribute_names.include?(key))
+          unless key.to_s =~ /\$/ || value.is_a?(Hash)
             hash[key] = value
           end
           hash

data/lib/mongoid/shardable.rb

@@ -58,7 +58,9 @@ module Mongoid
       #
       # @since 2.0.0
       def shard_key(*names)
-        self.shard_key_fields = names
+        names.each do |name|
+          self.shard_key_fields << self.database_field_name(name).to_sym
+        end
       end
     end
   end

data/lib/mongoid/version.rb

@@ -1,4 +1,4 @@
 # encoding: utf-8
 module Mongoid
-  VERSION = "5.1.2"
+  VERSION = "5.1.3"
 end

data/spec/mongoid/attributes_spec.rb

@@ -1652,6 +1652,16 @@ describe Mongoid::Attributes do
 
   context 'when calling the attribute check method' do
 
+    context 'when the attribute is blank' do
+      let(:person) do
+        Person.create(title: '')
+      end
+
+      it 'returns false' do
+        expect(person.title?).to be(false)
+      end
+    end
+
     context 'when the attribute is localized' do
       let(:person) do
         Person.create(desc: 'localized')
@@ -1687,7 +1697,7 @@ describe Mongoid::Attributes do
       end
 
       it 'does not apply localization when checking the attribute' do
-        expect(person.name?).to be(false)
+        expect(person.username?).to be(false)
       end
     end
   end

data/spec/mongoid/criteria/modifiable_spec.rb

@@ -612,17 +612,6 @@ describe Mongoid::Criteria::Modifiable do
           end
         end
       end
-
-      context 'when the criteria selector includes a hash field' do
-
-        let(:document) do
-          Person.where(map: { foo: :bar }).first_or_create
-        end
-
-        it 'sets the hash field' do
-          expect(document.map).to eq({ foo: :bar })
-        end
-      end
     end
   end
 
@@ -747,17 +736,6 @@ describe Mongoid::Criteria::Modifiable do
           end
         end
       end
-
-      context 'when the criteria selector includes a hash field' do
-
-        let(:document) do
-          Person.where(map: { foo: :bar }).first_or_create
-        end
-
-        it 'sets the hash field' do
-          expect(document.map).to eq({ foo: :bar })
-        end
-      end
     end
   end
 

data/spec/mongoid/relations/auto_save_spec.rb

@@ -150,7 +150,7 @@ describe Mongoid::Relations::AutoSave do
           end
         end
 
-        pending "when updating the child" do
+        context "when updating the child" do
 
           before do
             person.account = account

data/spec/mongoid/serializable_spec.rb

@@ -394,7 +394,7 @@ describe Mongoid::Serializable do
             hash["addresses"]
           end
 
-          pending "when the ids were not loaded" do
+          context "when the ids were not loaded" do
 
             before do
               person.save
@@ -409,6 +409,8 @@ describe Mongoid::Serializable do
             end
 
             it "does not generate new ids" do
+              pending
+              fail
               expect(hash["addresses"].first["_id"]).to be_nil
             end
           end

data/spec/mongoid/shardable_spec.rb

@@ -22,27 +22,37 @@ describe Mongoid::Shardable do
   describe ".shard_key" do
 
     let(:klass) do
-      Class.new do
-        include Mongoid::Shardable
-      end
+      Band
     end
 
     before do
-      klass.shard_key(:name)
+      Band.shard_key(:name)
     end
 
     it "specifies a shard key on the collection" do
       expect(klass.shard_key_fields).to eq([:name])
     end
+
+    context 'when a relation is used as the shard key' do
+
+      let(:klass) do
+        Game
+      end
+
+      before do
+        Game.shard_key(:person)
+      end
+
+      it "converts the shard key to the foreign key field" do
+        expect(klass.shard_key_fields).to eq([:person_id])
+      end
+    end
   end
 
   describe "#shard_key_selector" do
 
     let(:klass) do
-      Class.new do
-        include Mongoid::Shardable
-        attr_accessor :name
-      end
+      Band
     end
 
     let(:object) do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mongoid
 version: !ruby/object:Gem::Version
-  version: 5.1.2
+  version: 5.1.3
 platform: ruby
 authors:
 - Durran Jordan
@@ -30,7 +30,7 @@ cert_chain:
   ZIvvwAhgCjVW5QCi2I1noxXLmtZ3XDawWu8kaGtu8giHXcwL3941m8hvFZ/Wr9Yi
   JvcXJt2a4/JvwnIs2hmKuyfhZmB9HEE5wQQaCMnnC14=
   -----END CERTIFICATE-----
-date: 2016-03-31 00:00:00.000000000 Z
+date: 2016-04-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -811,7 +811,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: mongoid
-rubygems_version: 2.4.6
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: Elegant Persistence in Ruby for MongoDB.