mongoid 2.2.3 → 2.2.4

data/CHANGELOG.md

@@ -5,13 +5,87 @@ For instructions on upgrading to newer versions, visit
 
 ## 2.4.0 \[ In Development \] \[ Branch: master \]
 
+### New Features
+
 * Ranges can now be passed to #where criteria to create a $gte/$lte query under the
   covers. `Person.where(dob: start_date...end_date)`
 
-## 2.3.1 \[ In Development \] \[ Branch: 2.3.0-stable \]
+### Resolved Issues
+
+* \#1333 Fixed errors with custom types that exist in namespaces. (Peter Gumeson)
+
+## 2.3.4 \[ In Development \] \[ Branch: 2.3.0-stable \]
+
+## 2.3.3
+
+### Resolved Issues
+
+* \#1386 Lowered mongo/bson dependency to 1.3
+
+* \#1377 Fix aggregation functions to properly handle nil or indefined values.
+  (Maxime Garcia)
+
+* \#1373 Warn if a scope overrides another scope.
+
+* \#1372 Never persist when binding inside of a read attribute for validation.
+
+* \#1364 Fixed reloading of documents with non bson object id ids.
+
+* \#1360 Fixed performance of Mongoid's observer instantiation by hooking into
+  Active Support's load hooks, a la AR.
+
+* \#1358 Fixed type error on many to many synchronization when inverse_of is
+  set to nil.
+
+* \#1356 $in criteria can now be chained to non-complex criteria on the same
+  key without error.
+
+* \#1350, \#1351 Fixed errors in the string conversions of double quotes and
+  tilde when paramterizing keys.
+
+* \#1349 Mongoid documents should not blow up when including Enumerable.
+  (Jonas Nicklas)
+
+## 2.3.2
+
+### Resolved Issues
+
+* \#1347 Fix embedded matchers when provided a hash value that does not have a
+  modifier as a key.
+
+* \#1346 Dup default sorting criteria when calling first/last on a criteria.
+
+* \#1343 When passing no arguments to `Criteria#all_of` return all documents.
+  (Chris Leishman)
+
+* \#1339 Ensure destroy callbacks are run on cascadable children when deleting via
+  nested attributes.
+
+* \#1324 Setting `inverse_of: nil` on a many-to-many referencing the same class
+  returns nil for the inverse foreign key.
+
+* \#1323 Allow both strings and symbols as ids in the attributes array for
+  nested attributes. (Michael Wood)
+
+* \#1312 Setting a logger on the config now accepts anything that quacks like a
+  logger.
+
+* \#1297 Don't hit the database when accessing relations if the base is new.
+
+* \#1239 Allow appending of referenced relations in create blocks, post default set.
+
+* \#1236 Ensure all models are loaded in rake tasks, so even in threadsafe mode
+  all indexes can be created.
+
+* \#736 Calling #reload on embedded documents now works properly.
+
+## 2.3.1
 
 ### Resolved Issues
 
+* \#1338 Calling #find on a scope or relation checks that the document in the
+  identity map actually matches other scope parameters.
+
 * \#1321 HABTM no longer allows duplicate entries or keys, instead of the previous
   inconsistencies.
 
@@ -22,17 +96,31 @@ For instructions on upgrading to newer versions, visit
 
 * \#1311 Fix issue with custom field serialization inheriting from hash.
 
+* \#1310 The referenced many enumerable target no longer duplicates loaded and
+  added documents when the identity map is enabled.
+
 * \#1295 Fixed having multiple includes only execute the eager loading of the first.
 
 * \#1287 Fixed max versions limitation with versioning.
 
 * \#1277 attribute_will_change! properly flags the attribute even if no change occured.
 
+* \#1063 Paranoid documents properly run destroy callbacks on soft destroy.
+
+* \#1061 Raise `Mongoid::Errors::InvalidTime` when time serialization fails.
+
+* \#1002 Check for legal bson ids when attempting conversion.
+
 * \#920 Allow relations to be named target.
 
+* \#905 Return normalized class name in metadata if string was defined with a
+  prefixed ::.
+
 * \#861 accepts_nested_attributes_for is no longer needed to set embedded documents
   via a hash or array of hashes directly.
 
+* \#857 Fixed cascading of dependent relations when base document is paranoid.
+
 * \#768 Fixed class_attribute definitions module wide.
 
 * \#408 Embedded documents can now be soft deleted via `Mongoid::Paranoia`.
@@ -123,6 +211,27 @@ For instructions on upgrading to newer versions, visit
 * Deleting versions created with `Mongoid::Versioning` no longer fires off
   dependent cascading on relations.
 
+## 2.2.4
+
+* \#1377 Fix aggregation functions to properly handle nil or indefined values.
+  (Maxime Garcia)
+
+* \#1373 Warn if a scope overrides another scope.
+
+* \#1372 Never persist when binding inside of a read attribute for validation.
+
+* \#1358 Fixed type error on many to many synchronization when inverse_of is
+  set to nil.
+
+* \#1356 $in criteria can now be chained to non-complex criteria on the same
+  key without error.
+
+* \#1350, \#1351 Fixed errors in the string conversions of double quotes and
+  tilde when paramterizing keys.
+
+* \#1349 Mongoid documents should not blow up when including Enumerable.
+  (Jonas Nicklas)
+
 ## 2.2.3
 
 * \#1295 Fixed having multiple includes only execute the eager loading of the first.

data/lib/mongoid/criteria.rb

@@ -383,14 +383,19 @@ module Mongoid #:nodoc:
       clone.tap do |crit|
         converted = BSON::ObjectId.convert(klass, attributes || {})
         converted.each_pair do |key, value|
-          unless crit.selector[key]
+          existing = crit.selector[key]
+          unless existing
             crit.selector[key] = { operator => value }
           else
-            if crit.selector[key].has_key?(operator)
-              new_value = crit.selector[key].values.first.send(combine, value)
-              crit.selector[key] = { operator => new_value }
+            if existing.respond_to?(:merge)
+              if existing.has_key?(operator)
+                new_value = existing.values.first.send(combine, value)
+                crit.selector[key] = { operator => new_value }
+              else
+                crit.selector[key][operator] = value
+              end
             else
-              crit.selector[key][operator] = value
+              crit.selector[key] = { operator => value }
             end
           end
         end

data/lib/mongoid/extensions/object/checks.rb

@@ -14,9 +14,6 @@ module Mongoid #:nodoc:
         # @example Is the array vacant?
         #   [].vacant?
         #
-        # @example Is the hash vacant?
-        #   {}.vacant?
-        #
         # @example Is the object vacant?
         #   nil.vacant?
         #
@@ -24,7 +21,7 @@ module Mongoid #:nodoc:
         #
         # @since 2.0.2
         def _vacant?
-          is_a?(::Enumerable) || is_a?(::String) ? empty? : !self
+          is_a?(::Array) || is_a?(::String) ? empty? : !self
         end
       end
     end

data/lib/mongoid/extensions/string/inflections.rb

@@ -18,7 +18,7 @@ module Mongoid #:nodoc:
         CHAR_CONV = {
           " " => "-",
           "!" => "-excl-",
-          "\"" => "-bckslsh-",
+          "\"" => "-dblquo-",
           "#" => "-hash-",
           "$" => "-dol-",
           "%" => "-perc-",
@@ -48,7 +48,7 @@ module Mongoid #:nodoc:
           "{" => "-ocurly-",
           "|" => "-pipe-",
           "}" => "-clcurly-",
-          "~" => "-tilda-"
+          "~" => "-tilde-"
         }
 
         REVERSALS = {

data/lib/mongoid/named_scope.rb

@@ -125,10 +125,20 @@ module Mongoid #:nodoc:
 
     protected
 
+      # Warns if overriding another scope or method.
+      #
+      # @example Warn if name exists.
+      #   Model.valid_scope_name?("test")
+      #
+      # @param [ String, Symbol ] name The name of the scope.
       def valid_scope_name?(name)
-        if !scopes[name] && respond_to?(name, true)
-          Mongoid.logger.warn "Creating scope :#{name}. " \
-                                    "Overwriting existing method #{self.name}.#{name}." if Mongoid.logger
+        if scopes[name] || respond_to?(name, true)
+          if Mongoid.logger
+            Mongoid.logger.warn(
+              "Creating scope :#{name}. " +
+              "Overwriting existing method #{self.name}.#{name}."
+            )
+          end
         end
       end
     end

data/lib/mongoid/relations/metadata.rb

@@ -229,6 +229,19 @@ module Mongoid # :nodoc:
         !!extension
       end
 
+      # Does this metadata have a forced nil inverse_of defined. (Used in many
+      # to manies)
+      #
+      # @example Is this a forced nil inverse?
+      #   metadata.forced_nil_inverse?
+      #
+      # @return [ true, false ] If inverse_of has been explicitly set to nil.
+      #
+      # @since 2.3.3
+      def forced_nil_inverse?
+        has_key?(:inverse_of) && inverse_of.nil?
+      end
+
       # Handles all the logic for figuring out what the foreign_key is for each
       # relations query. The logic is as follows:
       #

data/lib/mongoid/relations/referenced/many.rb

@@ -33,7 +33,7 @@ module Mongoid #:nodoc:
             args.flatten.each do |doc|
               next unless doc
               append(doc)
-              doc.save if persistable?
+              doc.save if persistable? && !doc.validated?
             end
           end
         end

data/lib/mongoid/relations/referenced/many_to_many.rb

@@ -142,7 +142,9 @@ module Mongoid # :nodoc:
         #
         # @since 2.0.0.rc.1
         def nullify
-          criteria.pull(metadata.inverse_foreign_key, base.id)
+          unless metadata.forced_nil_inverse?
+            criteria.pull(metadata.inverse_foreign_key, base.id)
+          end
           if persistable?
             base.set(
               metadata.foreign_key,

data/lib/mongoid/relations/synchronization.rb

@@ -93,8 +93,10 @@ module Mongoid # :nodoc:
         #
         # @since 2.1.0
         def synced(metadata)
-          synced_save(metadata)
-          synced_destroy(metadata)
+          unless metadata.forced_nil_inverse?
+            synced_save(metadata)
+            synced_destroy(metadata)
+          end
         end
 
         private

data/lib/mongoid/validations.rb

@@ -44,7 +44,9 @@ module Mongoid #:nodoc:
     # @since 2.0.0.rc.1
     def read_attribute_for_validation(attr)
       if relations[attr.to_s]
+        begin_validate
         relation = send(attr)
+        exit_validate
         relation.do_or_do_not(:in_memory) || relation
       else
         send(attr)

data/lib/mongoid/version.rb

@@ -1,4 +1,4 @@
 # encoding: utf-8
 module Mongoid #:nodoc
-  VERSION = "2.2.3"
+  VERSION = "2.2.4"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mongoid
 version: !ruby/object:Gem::Version
-  version: 2.2.3
+  version: 2.2.4
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-10-11 00:00:00.000000000Z
+date: 2011-10-31 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
-  requirement: &70191203667940 !ruby/object:Gem::Requirement
+  requirement: &70285743605420 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,10 +21,10 @@ dependencies:
         version: '3.0'
   type: :runtime
   prerelease: false
-  version_requirements: *70191203667940
+  version_requirements: *70285743605420
 - !ruby/object:Gem::Dependency
   name: tzinfo
-  requirement: &70191203666840 !ruby/object:Gem::Requirement
+  requirement: &70285743604460 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -32,10 +32,10 @@ dependencies:
         version: 0.3.22
   type: :runtime
   prerelease: false
-  version_requirements: *70191203666840
+  version_requirements: *70285743604460
 - !ruby/object:Gem::Dependency
   name: mongo
-  requirement: &70191203665380 !ruby/object:Gem::Requirement
+  requirement: &70285743603500 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +43,10 @@ dependencies:
         version: '1.3'
   type: :runtime
   prerelease: false
-  version_requirements: *70191203665380
+  version_requirements: *70285743603500
 - !ruby/object:Gem::Dependency
   name: rdoc
-  requirement: &70191203663940 !ruby/object:Gem::Requirement
+  requirement: &70285743602700 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -54,10 +54,10 @@ dependencies:
         version: 3.5.0
   type: :development
   prerelease: false
-  version_requirements: *70191203663940
+  version_requirements: *70285743602700
 - !ruby/object:Gem::Dependency
   name: bson_ext
-  requirement: &70191203662020 !ruby/object:Gem::Requirement
+  requirement: &70285743601320 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -65,10 +65,10 @@ dependencies:
         version: '1.3'
   type: :development
   prerelease: false
-  version_requirements: *70191203662020
+  version_requirements: *70285743601320
 - !ruby/object:Gem::Dependency
   name: mocha
-  requirement: &70191203660340 !ruby/object:Gem::Requirement
+  requirement: &70285743600280 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -76,10 +76,10 @@ dependencies:
         version: 0.9.12
   type: :development
   prerelease: false
-  version_requirements: *70191203660340
+  version_requirements: *70285743600280
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70191203659100 !ruby/object:Gem::Requirement
+  requirement: &70285743588060 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -87,10 +87,10 @@ dependencies:
         version: '2.6'
   type: :development
   prerelease: false
-  version_requirements: *70191203659100
+  version_requirements: *70285743588060
 - !ruby/object:Gem::Dependency
   name: watchr
-  requirement: &70191203658200 !ruby/object:Gem::Requirement
+  requirement: &70285743587280 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -98,7 +98,7 @@ dependencies:
         version: '0.6'
   type: :development
   prerelease: false
-  version_requirements: *70191203658200
+  version_requirements: *70285743587280
 description: Mongoid is an ODM (Object Document Mapper) Framework for MongoDB, written
   in Ruby.
 email:
@@ -385,7 +385,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 598136195800288460
+      hash: 1180237711887586276
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: