mongoid-undo 0.9.1 → 0.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0adf9adc40a0c51746f7c46da47e0208ca8f2652
-  data.tar.gz: 7b53acaffc646ac028274fb2f256f230ca79460a
+  metadata.gz: 733b0d209220876c801f04e9137e83ced99c4fae
+  data.tar.gz: 19a73d8202018bb7d3e61bc962aee9d700aaa8d9
 SHA512:
-  metadata.gz: 3f8eb1f55953b9be2469cf43592cb2275ee018a1c7fa3855af25db0fcf7ef3f6baa4cd12cbb9bbb647e10f47e196d852f0f1202352d519538aaae29e97faac82
-  data.tar.gz: 97f70f2d965886002a3a8e35707e7cd685b76d0eb7b6ac5378975c1357b4aa8106d9c8576aee6821554db0e014941d365e590ca58c7523c692b29c52137e5144
+  metadata.gz: 8454e97989f4ac081dc30a4f44658e614c217bec5bf5fc2d08a545cfee41ee5f04d8e32f526fd50ad62a8b45383a490dc4d15e413bae2b441d374cb2f56e2931
+  data.tar.gz: f9ccebd0c19f711097539050c9b57dc89529d32d76cf235c15ac2c12e8e1ac93a7acc6919b2a1cb26c00ce55dcf309deb35df44e8009d67ebbd73b9900259e24

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+# 0.8.0 (March 30, 2014)
+* Adds both callbacks for undo and redo.
+
 # 0.7.0 (February 8, 2014)
 * Simpler tests.
 

data/README.md

@@ -64,6 +64,23 @@ document.redo
 document.persisted? #=> false
 ```
 
+### Callbacks
+
+Mongoid::Undo defines two callbacks which are called before and after `undo`, respectively `redo`. Both are based on `ActiveModel::Callbacks`which means they behave like the allready known Rails callbacks.
+
+```ruby
+class Document
+  include Mongoid::Document
+  include Mongoid::Undo
+
+  before_undo do
+    # Do something fancy.
+  end
+
+  before_redo { false } # Don't allow redoing.
+```
+
+
 ## Installation
 
 In your Gemfile:
@@ -80,6 +97,7 @@ gem 'mongoid-undo'
 4. Push to the branch (`git push origin my-new-feature`)
 5. Create new Pull Request
 
+
 ## Copyright
 
 (The MIT license)

data/lib/mongoid/undo.rb

@@ -7,6 +7,7 @@ module Mongoid
 
     include Mongoid::Paranoia
     include Mongoid::Versioning
+    include Mongoid::Callbacks
 
     included do
       field :action, type: Symbol, versioned: false
@@ -18,14 +19,18 @@ module Mongoid
           reload
         end
       end
+
+      define_model_callbacks :undo, :redo
     end
 
     def undo
-      case action
-      when :create, :destroy
-        deleted_at.present? ? restore : delete
-      when :update
-        retrieve
+      run_callbacks __callee__ do
+        case action
+        when :create, :destroy
+          deleted_at.present? ? restore : delete
+        when :update
+          retrieve
+        end
       end
     end
     alias_method :redo, :undo

data/lib/mongoid/undo/version.rb

@@ -1,5 +1,5 @@
 module Mongoid
   module Undo
-    VERSION = '0.9.1'
+    VERSION = '0.10.0'
   end
 end

data/test/test_helper.rb

@@ -6,7 +6,29 @@ require 'mongoid/undo'
 
 Mongoid.load!(File.expand_path('../mongoid.yml', __FILE__), 'test')
 
-class Minitest::Test
+class MiniTest::Unit::TestCase
   alias_method :assert_not, :refute
   alias_method :assert_not_equal, :refute_equal
+
+  # Copied from activesupport/lib/active_support/testing/assertions.rb
+  def assert_difference(expression, difference = 1, message = nil, &block)
+    expressions = Array(expression)
+
+    exps = expressions.map { |e|
+      e.respond_to?(:call) ? e : lambda { eval(e, block.binding) }
+    }
+    before = exps.map { |e| e.call }
+
+    yield
+
+    expressions.zip(exps).each_with_index do |(code, e), i|
+      error  = "#{code.inspect} didn't change by #{difference}"
+      error  = "#{message}.\n#{error}" if message
+      assert_equal(before[i] + difference, e.call, error)
+    end
+  end
+
+  def assert_no_difference(expression, message = nil, &block)
+    assert_difference expression, 0, message, &block
+  end
 end

data/test/undo_test.rb

@@ -110,4 +110,47 @@ class UndoTest < Minitest::Unit::TestCase
     document.redo
     assert_not_equal updated_at, document.updated_at
   end
+
+
+  def test_callbacks
+    document = Document.create(name: 'foo')
+    mock = MiniTest::Mock.new
+
+    document.class.before_undo { mock.before_undo }
+    document.class.after_undo { mock.after_undo }
+
+    mock.expect :before_undo, nil
+    mock.expect :after_undo, nil
+
+    document.undo
+    mock.verify
+
+    document.class.before_redo { mock.before_redo }
+    document.class.after_redo { mock.after_redo }
+
+    mock.expect :before_redo, nil
+    mock.expect :after_redo, nil
+
+    document.redo
+    mock.verify
+  end
+
+
+  def test_disabling_undo_via_callbacks
+    document = Document.create(name: 'foo')
+    document.destroy
+
+    # Disable undoing
+    document.class.before_undo proc { false }
+
+    assert_no_difference 'Document.count' do
+      document.undo
+    end
+  end
+
+
+  def teardown
+    Document.reset_callbacks :undo
+    Document.reset_callbacks :redo
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mongoid-undo
 version: !ruby/object:Gem::Version
-  version: 0.9.1
+  version: 0.10.0
 platform: ruby
 authors:
 - Mario Uher
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-17 00:00:00.000000000 Z
+date: 2014-03-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport