mongoid-likeable 4.0 → 4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: beb40afa034fee3ce48271478f2696a2ad7a64da
-  data.tar.gz: 795f59cb6f1ab81860b901b731ad36a9213d81c7
+  metadata.gz: d7ab27bc064a7dcef21812624431d8753ab09468
+  data.tar.gz: 6fdb93ff39733743b70f696a6fa4164b72beae29
 SHA512:
-  metadata.gz: 892539d5492964552c47269dbd6bd4883d47a59f33c6d1337255184a0194edeb50906b7000dd9212667a7693130e088eda0f0f76348f394a47990fdae4ab04a1
-  data.tar.gz: cf993ad44cbfd38452f50d55620083627d1a724ee727b39c29d36fd732490875c3c032e830442905e4c25a3d51de7b2020af1f588a571aad704533352c7d3d4e
+  metadata.gz: 2e13db4dc2662872836dec79c155feaa3111645c1c07b133768007262d27bcca7bc1f408821d2b918fffab34bc487f41ff7b5a498549e984f31ed313e4377653
+  data.tar.gz: 25933c7334d8786104a9ada57df4f71fdbd2adc0a5c0d07062d96fc21537e6be152db45dda0fe10ce6d60c69857329236c5e385eaf9d0698be789df42fc2d1d7

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+4.1
+---
+* Improved code
+* Thread safety without mutex
+
 4.0
 ---
 * Thread safety

data/README.md

@@ -21,7 +21,7 @@ or add the gem to your `Gemfile`
 
 ## Thread safety
 
-This gem is thread safe. It uses a mutex on the likeable object.
+This gem is thread safe.
 
 ## Usage
 

data/lib/mongoid/likeable.rb

@@ -6,8 +6,6 @@ module Mongoid
     extend ActiveSupport::Concern
 
     included do
-      LIKEABLE_MUTEX = Mutex.new
-
       field :likes, type: Integer, default: 0
       field :likers, type: Array, default: []
     end
@@ -15,21 +13,15 @@ module Mongoid
     def like(liker)
       id = liker_id(liker)
       return if liked? id
-      LIKEABLE_MUTEX.synchronize do
-        inc :likes, 1
-        push :likers, id
-        touch
-      end
+      push :likers, id
+      update_likers
     end
 
     def unlike(liker)
       id = liker_id(liker)
       return unless liked? id
-      LIKEABLE_MUTEX.synchronize do
-        inc :likes, -1
-        pull :likers, id
-        touch
-      end
+      pull :likers, id
+      update_likers
     end
 
     def liked?(liker)
@@ -38,7 +30,6 @@ module Mongoid
     end
 
     private
-
     def liker_id(liker)
       if liker.respond_to?(:_id)
         liker._id
@@ -46,5 +37,9 @@ module Mongoid
         liker
       end
     end
+
+    def update_likers
+      update_attribute :likes, likers.size
+    end
   end
 end

data/mongoid-likeable.gemspec

@@ -3,7 +3,7 @@ $:.push File.expand_path('../lib', __FILE__)
 
 Gem::Specification.new do |s|
   s.name        = 'mongoid-likeable'
-  s.version     = '4.0'
+  s.version     = '4.1'
   s.platform    = Gem::Platform::RUBY
   s.authors     = ['Diowa']
   s.email       = ['dev@diowa.com']
@@ -13,7 +13,7 @@ Gem::Specification.new do |s|
 
   s.rubyforge_project = 'mongoid-likeable'
 
-  s.add_dependency 'mongoid', '~> 3.1.2'
+  s.add_dependency 'mongoid', '~> 3.1.3'
 
   s.add_development_dependency 'database_cleaner'
   s.add_development_dependency 'rake'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mongoid-likeable
 version: !ruby/object:Gem::Version
-  version: '4.0'
+  version: '4.1'
 platform: ruby
 authors:
 - Diowa
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-09 00:00:00.000000000 Z
+date: 2013-04-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mongoid
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 3.1.2
+        version: 3.1.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 3.1.2
+        version: 3.1.3
 - !ruby/object:Gem::Dependency
   name: database_cleaner
   requirement: !ruby/object:Gem::Requirement