mongoid-history 0.8.0 → 0.8.1

data/spec/integration/multi_relation_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe Mongoid::History::Tracker do
-  before :all do
+  before :each do
     class Model
       include Mongoid::Document
       include Mongoid::History::Trackable
@@ -10,39 +10,33 @@ describe Mongoid::History::Tracker do
       belongs_to :user, inverse_of: :models
       has_and_belongs_to_many :external_users, class_name: 'User', inverse_of: :external_models
 
-      track_history on: %i[name user external_user_ids], # track title and body fields only, default is :all
-                    modifier_field: :modifier, # adds "referenced_in :modifier" to track who made the change, default is :modifier
-                    modifier_field_inverse_of: nil, # no inverse modifier relationship
-                    version_field: :version, # adds "field :version, :type => Integer" to track current version, default is :version
-                    track_create: false,    # track document creation, default is false
-                    track_update: true,     # track document updates, default is true
-                    track_destroy: false    # track document destruction, default is false
+      track_history on: %i[name user external_user_ids], modifier_field_inverse_of: nil
     end
 
     class User
       include Mongoid::Document
+
       has_many :models, dependent: :destroy, inverse_of: :user
       has_and_belongs_to_many :external_model, class_name: 'Model', inverse_of: :external_users
     end
   end
 
-  it 'should be possible to undo when having multiple relations to modifier class' do
-    user = User.new
-    user.save
+  after :each do
+    Object.send(:remove_const, :Model)
+    Object.send(:remove_const, :User)
+  end
 
-    model = Model.new
-    model.name = 'Foo'
-    model.user = user
-    model.save!
+  let(:user) { User.create! }
+  let(:model) { Model.create!(name: 'Foo', user: user, modifier: user) }
 
-    model.name = 'Bar'
-    model.save!
+  it 'should be possible to undo when having multiple relations to modifier class' do
+    model.update_attributes!(name: 'Bar', modifier: user)
 
     model.undo! user
-    expect(model.name).to eq('Foo')
+    expect(model.name).to eq 'Foo'
 
-    model.redo! user, 1
-    expect(model.name).to eq('Bar')
+    model.redo! user, 2
+    expect(model.name).to eq 'Bar'
   end
 
   it 'should track foreign key relations' do

data/spec/integration/multiple_trackers_spec.rb

@@ -1,33 +1,25 @@
 require 'spec_helper'
 
 describe Mongoid::History do
-  before :all do
-    Mongoid::History.tracker_class_name = nil
-
-    module MultipleTrackersSpec
-      class First
-        include Mongoid::Document
-        include Mongoid::History::Trackable
-
-        field :text, type: String
-        track_history on: [:text],
-                      track_create: true,
-                      track_update: true,
-                      track_destroy: true,
-                      tracker_class_name: :first_history_tracker
-      end
-
-      class Second
-        include Mongoid::Document
-        include Mongoid::History::Trackable
-
-        field :text, type: String
-        track_history on: [:text],
-                      track_create: true,
-                      track_update: true,
-                      track_destroy: true,
-                      tracker_class_name: :second_history_tracker
-      end
+  before :each do
+    class First
+      include Mongoid::Document
+      include Mongoid::History::Trackable
+
+      field :text, type: String
+      track_history on: [:text], tracker_class_name: :first_history_tracker
+    end
+
+    class Second
+      include Mongoid::Document
+      include Mongoid::History::Trackable
+
+      field :text, type: String
+      track_history on: [:text], tracker_class_name: :second_history_tracker
+    end
+
+    class User
+      include Mongoid::Document
     end
 
     class FirstHistoryTracker
@@ -39,25 +31,30 @@ describe Mongoid::History do
     end
   end
 
+  after :each do
+    Object.send(:remove_const, :First)
+    Object.send(:remove_const, :Second)
+    Object.send(:remove_const, :User)
+    Object.send(:remove_const, :FirstHistoryTracker)
+    Object.send(:remove_const, :SecondHistoryTracker)
+  end
+
+  let(:user) { User.create! }
+
   it 'should be possible to have different trackers for each class' do
     expect(FirstHistoryTracker.count).to eq(0)
     expect(SecondHistoryTracker.count).to eq(0)
-    expect(MultipleTrackersSpec::First.tracker_class).to be FirstHistoryTracker
-    expect(MultipleTrackersSpec::Second.tracker_class).to be SecondHistoryTracker
-
-    foo = MultipleTrackersSpec::First.new
-    foo.save
+    expect(First.tracker_class).to be FirstHistoryTracker
+    expect(Second.tracker_class).to be SecondHistoryTracker
 
-    bar = MultipleTrackersSpec::Second.new
-    bar.save
+    foo = First.create!(modifier: user)
+    bar = Second.create!(modifier: user)
 
     expect(FirstHistoryTracker.count).to eq 1
     expect(SecondHistoryTracker.count).to eq 1
 
-    foo.text = "I'm foo"
-    foo.save
-    bar.text = "I'm bar"
-    bar.save
+    foo.update_attributes!(text: "I'm foo")
+    bar.update_attributes!(text: "I'm bar")
 
     expect(FirstHistoryTracker.count).to eq 2
     expect(SecondHistoryTracker.count).to eq 2

data/spec/integration/nested_embedded_documents_spec.rb

@@ -1,84 +1,64 @@
 require 'spec_helper'
 
 describe Mongoid::History::Tracker do
-  before :all do
-    class Modelone
+  before :each do
+    class ModelOne
       include Mongoid::Document
       include Mongoid::History::Trackable
 
       field :name, type: String
-      belongs_to :user, inverse_of: :modelones
-      embeds_many :embones
-
-      track_history on: :all, # track title and body fields only, default is :all
-                    modifier_field: :modifier, # adds "referenced_in :modifier" to track who made the change, default is :modifier
-                    version_field: :version,   # adds "field :version, :type => Integer" to track current version, default is :version
-                    track_create: false,    # track document creation, default is false
-                    track_update: true,     # track document updates, default is true
-                    track_destroy: false    # track document destruction, default is false
+      belongs_to :user, inverse_of: :model_ones
+      embeds_many :emb_ones
+
+      track_history
     end
 
-    class Embone
+    class EmbOne
       include Mongoid::Document
       include Mongoid::History::Trackable
 
       field :name
-      embeds_many :embtwos, store_as: :ems
-      embedded_in :modelone
-
-      track_history on: :all, # track title and body fields only, default is :all
-                    modifier_field: :modifier, # adds "referenced_in :modifier" to track who made the change, default is :modifier
-                    version_field: :version,   # adds "field :version, :type => Integer" to track current version, default is :version
-                    track_create: false,    # track document creation, default is false
-                    track_update: true,     # track document updates, default is true
-                    track_destroy: false, # track document destruction, default is false
-                    scope: :model
+      embeds_many :emb_twos, store_as: :ems
+      embedded_in :model_one
+
+      track_history
     end
 
-    class Embtwo
+    class EmbTwo
       include Mongoid::Document
       include Mongoid::History::Trackable
 
       field :name
-      embedded_in :embone
-
-      track_history on: :all, # track title and body fields only, default is :all
-                    modifier_field: :modifier, # adds "referenced_in :modifier" to track who made the change, default is :modifier
-                    version_field: :version,   # adds "field :version, :type => Integer" to track current version, default is :version
-                    track_create: false,    # track document creation, default is false
-                    track_update: true,     # track document updates, default is true
-                    track_destroy: false, # track document destruction, default is false
-                    scope: :modelone
+      embedded_in :emb_one
+
+      track_history scope: :model_one
     end
 
     class User
       include Mongoid::Document
-      has_many :modelones, dependent: :destroy, inverse_of: :user
+
+      has_many :model_ones, dependent: :destroy, inverse_of: :user
     end
   end
 
-  it 'should be able to track history for nested embedded documents' do
-    user = User.new
-    user.save!
+  after :each do
+    Object.send(:remove_const, :ModelOne)
+    Object.send(:remove_const, :EmbOne)
+    Object.send(:remove_const, :EmbTwo)
+    Object.send(:remove_const, :User)
+  end
+
+  let(:user) { User.create! }
 
-    model = Modelone.new(name: 'm1name')
-    model.user = user
-    model.save!
-    embedded1 = model.embones.create(name: 'e1name')
-    embedded2 = embedded1.embtwos.create(name: 'e2name')
+  it 'should be able to track history for nested embedded documents' do
+    model = ModelOne.create!(name: 'm1name', user: user, modifier: user)
+    embedded1 = model.emb_ones.create!(name: 'e1name', modifier: user)
+    embedded2 = embedded1.emb_twos.create!(name: 'e2name', modifier: user)
 
-    embedded2.name = 'a new name'
-    embedded2.save!
+    embedded2.update_attributes!(name: 'a new name')
 
-    model.history_tracks.first.undo! user
+    model.history_tracks[-1].undo! user
     expect(embedded1.reload.name).to eq('e1name')
     expect(embedded2.reload.name).to eq('e2name')
   end
-
-  after :all do
-    Object.send(:remove_const, :Modelone)
-    Object.send(:remove_const, :Embone)
-    Object.send(:remove_const, :Embtwo)
-    Object.send(:remove_const, :User)
-  end
 end

data/spec/integration/nested_embedded_polymorphic_documents_spec.rb

@@ -1,8 +1,8 @@
 require 'spec_helper'
 
 describe Mongoid::History::Tracker do
-  before :all do
-    class Modelone
+  before :each do
+    class ModelOne
       include Mongoid::Document
       include Mongoid::History::Trackable
 
@@ -10,15 +10,10 @@ describe Mongoid::History::Tracker do
       belongs_to :user
       embeds_one :one_embedded, as: :embedable
 
-      track_history on: :all,
-                    modifier_field: :modifier,
-                    version_field: :version,
-                    track_create: true,
-                    track_update: true,
-                    track_destroy: true
+      track_history
     end
 
-    class Modeltwo
+    class ModelTwo
       include Mongoid::Document
       include Mongoid::History::Trackable
 
@@ -26,12 +21,7 @@ describe Mongoid::History::Tracker do
       belongs_to :user
       embeds_one :one_embedded, as: :embedable
 
-      track_history on: :all,
-                    modifier_field: :modifier,
-                    version_field: :version,
-                    track_create: true,
-                    track_update: true,
-                    track_destroy: true
+      track_history
     end
 
     class OneEmbedded
@@ -42,13 +32,7 @@ describe Mongoid::History::Tracker do
       embeds_many :embedded_twos, store_as: :ems
       embedded_in :embedable, polymorphic: true
 
-      track_history on: :all,
-                    modifier_field: :modifier,
-                    version_field: :version,
-                    track_create: true,
-                    track_update: true,
-                    track_destroy: true,
-                    scope: %i[modelone modeltwo]
+      track_history scope: %i[model_one model_two]
     end
 
     class EmbeddedTwo
@@ -58,70 +42,74 @@ describe Mongoid::History::Tracker do
       field :name
       embedded_in :one_embedded
 
-      track_history on: :all,
-                    modifier_field: :modifier,
-                    version_field: :version,
-                    track_create: true,
-                    track_update: true,
-                    track_destroy: true,
-                    scope: %i[modelone modeltwo]
+      track_history scope: %i[model_one model_two]
     end
 
     class User
       include Mongoid::Document
-      has_many :modelones
-      has_many :modeltwos
+
+      has_many :model_ones
+      has_many :model_twos
     end
   end
 
+  after :each do
+    Object.send(:remove_const, :ModelOne)
+    Object.send(:remove_const, :ModelTwo)
+    Object.send(:remove_const, :OneEmbedded)
+    Object.send(:remove_const, :EmbeddedTwo)
+    Object.send(:remove_const, :User)
+  end
+
+  let (:user) { User.create! }
+
   it 'tracks history for nested embedded documents with polymorphic relations' do
-    user = User.new
-    user.save!
-
-    modelone = user.modelones.build(name: 'modelone')
-    modelone.save!
-    modelone.build_one_embedded(name: 'modelone_one_embedded').save!
-    expect(modelone.history_tracks.count).to eq(2)
-    expect(modelone.one_embedded.history_tracks.count).to eq(1)
-
-    modelone.reload
-    modelone.one_embedded.update_attribute(:name, 'modelone_embedded_one!')
-    expect(modelone.history_tracks.count).to eq(3)
-    expect(modelone.one_embedded.history_tracks.count).to eq(2)
-    expect(modelone.history_tracks.last.action).to eq('update')
-
-    modelone.build_one_embedded(name: 'Lorem ipsum').save!
-    expect(modelone.history_tracks.count).to eq(4)
-    expect(modelone.one_embedded.history_tracks.count).to eq(1)
-    expect(modelone.one_embedded.history_tracks.last.action).to eq('create')
-    expect(modelone.one_embedded.history_tracks.last.association_chain.last['name']).to eq('one_embedded')
-
-    embedded_one1 = modelone.one_embedded.embedded_twos.create(name: 'modelone_one_embedded_1')
-    expect(modelone.history_tracks.count).to eq(5)
-    expect(modelone.one_embedded.history_tracks.count).to eq(2)
+    user = User.create!
+
+    model_one = user.model_ones.build(name: 'model_one', modifier: user)
+    model_one.save!
+    model_one.build_one_embedded(name: 'model_one_one_embedded', modifier: user).save!
+    expect(model_one.history_tracks.count).to eq(2)
+    expect(model_one.one_embedded.history_tracks.count).to eq(1)
+
+    model_one.reload
+    model_one.one_embedded.update_attributes!(name: 'model_one_embedded_one!')
+    expect(model_one.history_tracks.count).to eq(3)
+    expect(model_one.one_embedded.history_tracks.count).to eq(2)
+    expect(model_one.history_tracks.last.action).to eq('update')
+
+    model_one.build_one_embedded(name: 'Lorem ipsum', modifier: user).save!
+    expect(model_one.history_tracks.count).to eq(4)
+    expect(model_one.one_embedded.history_tracks.count).to eq(1)
+    expect(model_one.one_embedded.history_tracks.last.action).to eq('create')
+    expect(model_one.one_embedded.history_tracks.last.association_chain.last['name']).to eq('one_embedded')
+
+    embedded_one1 = model_one.one_embedded.embedded_twos.create!(name: 'model_one_one_embedded_1', modifier: user)
+    expect(model_one.history_tracks.count).to eq(5)
+    expect(model_one.one_embedded.history_tracks.count).to eq(2)
     expect(embedded_one1.history_tracks.count).to eq(1)
 
-    modeltwo = user.modeltwos.build(name: 'modeltwo')
-    modeltwo.save!
-    modeltwo.build_one_embedded(name: 'modeltwo_one_embedded').save!
-    expect(modeltwo.history_tracks.count).to eq(2)
-    expect(modeltwo.one_embedded.history_tracks.count).to eq(1)
-
-    modeltwo.reload
-    modeltwo.one_embedded.update_attribute(:name, 'modeltwo_one_embedded!')
-    expect(modeltwo.history_tracks.count).to eq(3)
-    expect(modeltwo.one_embedded.history_tracks.count).to eq(2)
-    expect(modeltwo.history_tracks.last.action).to eq('update')
-
-    modeltwo.build_one_embedded(name: 'Lorem ipsum').save!
-    expect(modeltwo.history_tracks.count).to eq(4)
-    expect(modeltwo.one_embedded.history_tracks.count).to eq(1)
-    expect(modeltwo.one_embedded.history_tracks.last.action).to eq('create')
-    expect(modeltwo.one_embedded.history_tracks.last.association_chain.last['name']).to eq('one_embedded')
-
-    embedded_one2 = modeltwo.one_embedded.embedded_twos.create(name: 'modeltwo_one_embedded_1')
-    expect(modeltwo.history_tracks.count).to eq(5)
-    expect(modeltwo.one_embedded.history_tracks.count).to eq(2)
+    model_two = user.model_twos.build(name: 'model_two', modifier: user)
+    model_two.save!
+    model_two.build_one_embedded(name: 'model_two_one_embedded', modifier: user).save!
+    expect(model_two.history_tracks.count).to eq(2)
+    expect(model_two.one_embedded.history_tracks.count).to eq(1)
+
+    model_two.reload
+    model_two.one_embedded.update_attributes!(name: 'model_two_one_embedded!')
+    expect(model_two.history_tracks.count).to eq(3)
+    expect(model_two.one_embedded.history_tracks.count).to eq(2)
+    expect(model_two.history_tracks.last.action).to eq('update')
+
+    model_two.build_one_embedded(name: 'Lorem ipsum', modifier: user).save!
+    expect(model_two.history_tracks.count).to eq(4)
+    expect(model_two.one_embedded.history_tracks.count).to eq(1)
+    expect(model_two.one_embedded.history_tracks.last.action).to eq('create')
+    expect(model_two.one_embedded.history_tracks.last.association_chain.last['name']).to eq('one_embedded')
+
+    embedded_one2 = model_two.one_embedded.embedded_twos.create!(name: 'model_two_one_embedded_1', modifier: user)
+    expect(model_two.history_tracks.count).to eq(5)
+    expect(model_two.one_embedded.history_tracks.count).to eq(2)
     expect(embedded_one2.history_tracks.count).to eq(1)
   end
 end