mongoid-filterable 0.4.1 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 71010c85b650681652bd079d24a156341bee7f1f9594d03fe3fd6d1636ab9083
-  data.tar.gz: 91a7a5441612055ea19400f403d94d934117b39a7d71a110684d2f9d502f1bc8
+  metadata.gz: 78743b377f67ff51a0cd93129f3b5a9b975b937e60b6fc12479c09cf3d2f7c8b
+  data.tar.gz: b84102c6f3aa6147fcfdd45e008bb48ba708854fc3d023964bb1cacacf27b092
 SHA512:
-  metadata.gz: 0fe5207b06afd57c1681131cfb6acd99a87b8acdf66ffb97812f6f81e00dc34a5af512fdb6fc8c1246966ebe5d6ea3a3cafe8180b5fe78a64e6aba21dcbc94ee
-  data.tar.gz: cbb78b9092a458ca27e75b4ffbc44a29ca0b38fea927a6c6f53c8ce2c04255aa2029efe129535bea351670440f0d3f7e9c83db6904e9fa98ce809c77df9cebc5
+  metadata.gz: ea813f93c96f3faf030cf6aa64866b58a947ae5f438cea237a23727ae348f2266ad29918a7ea452be21340e56ad3d409619a681cce461eaa0e9e6cfd1b7868e2
+  data.tar.gz: 819e2fb4acbb612df9a79974e488d3f864e6c9e45550ee5ce31611ea772e67e055adc3173f106f033bcd60ca59b8563c29efe321063febff284189a73ca45460

data/README.md

@@ -45,6 +45,7 @@ City.create(name: 'city1', people: 100)
 City.create(name: 'city2', people: 1000)
 City.filter({name: 'city'}).count # => 2
 City.filter({name: 'city1'}).count # => 1
+City.filter({name: ''}).count # => 0
 City.filter({people: 500}) # => 1
 ```
 

data/lib/mongoid-filterable/filterable.rb

@@ -7,15 +7,15 @@ module Mongoid
       ##
       # Applies params scopes to current scope
       #
-      def filter(filtering_params, operator = '$and')
+      def filter(filtering_params, operator='$and')
         return all unless filtering_params
         results = all
         selectors = []
         criteria = unscoped
 
         filtering_params.each do |key, value|
-          # false is permitted in order to work properly with boolean fields
-          if (value.present? || value == false) && respond_to?("filter_with_#{key}")
+          if respond_to?("filter_with_#{key}")
+            # check the number of arguments of filter scope
             if value.is_a?(Array) && scopes["filter_with_#{key}".to_sym][:scope].arity > 1
               selectors.push criteria.public_send("filter_with_#{key}", *value).selector
             else
@@ -30,7 +30,7 @@ module Mongoid
       ##
       # Adds attr scope
       #
-      def filter_by(attr, filter = nil)
+      def filter_by(attr, filter=nil)
         if filter
           scope "filter_with_#{attr}", filter
         elsif fields[attr.to_s].type == String

data/lib/mongoid-filterable/version.rb

@@ -1,5 +1,5 @@
 module Mongoid
   module Filterable
-    VERSION = '0.4.1'
+    VERSION = '1.0.0'
   end
 end

data/spec/filterable_spec.rb

@@ -32,7 +32,7 @@ describe Mongoid::Filterable do
   context 'when use default operator' do
     it 'should create correct selector' do
       expect(City.filter(code: :code1).selector).to eq(
-        {"active" => true, "$and" => [{"code" => :code1}]}
+        'active' => true, '$and' => [{'code' => :code1}]
       )
     end
 
@@ -125,18 +125,18 @@ describe Mongoid::Filterable do
   end
 
   context 'when value is nil' do
-    it 'should ignore filter' do
+    it 'should apply filter' do
       City.create(people: 100)
       City.create(people: 500)
-      expect(City.filter(people: nil).count).to eq(2)
+      expect(City.filter(people: nil).count).to eq(0)
     end
   end
 
   context 'when value is empty string' do
-    it 'should ignore filter' do
+    it 'should apply filter' do
       City.create(people: 100)
       City.create(people: 500)
-      expect(City.filter(people: '').count).to eq(2)
+      expect(City.filter(people: '').count).to eq(0)
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mongoid-filterable
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 1.0.0
 platform: ruby
 authors:
 - Rafael Jurado
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-22 00:00:00.000000000 Z
+date: 2018-06-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -114,7 +114,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: Easy way to add scopes to your models.