mongo_session_store-rails 7.0.1 → 7.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4cc351553fcd221464f8cc31fcdf8ed4521ecc0a
-  data.tar.gz: 620cfa638750088628fad4deac356e5508883e9c
+  metadata.gz: 0b2c427330f188c495b3fd4aa16d8352c3b71bf4
+  data.tar.gz: a22b000c5c5f2cd995d6b87ffc55b235c6fb2983
 SHA512:
-  metadata.gz: f73e58cf6180feadb3625c7175d463b18109d63fb593fcf5969d96c0cf770d541e06a28763266eb7b306011a0bbb848f4fe4b6bee25cdb4d78778ded73162c5c
-  data.tar.gz: 06d4da4187599b1d19bfec5f091ba02f39008874780a88a31864d2c3d3e810357052e2f51ffd26c02f6d1979788295fdfb58374121bbddb68630ab99ee00cdd1
+  metadata.gz: 12dc944b536e31d022d5247f56ce92428fef334c8316cbce37d0a770918cc06ef83c5240bbfcdbb081dd2ab49ad0df0535d44e8b69a405705dec526c99dc1292
+  data.tar.gz: 37fe63ee0f750b8bc1dec37ef0d03607947b4a5341069956ccbba2ce861cfdadc2e3e218b0b7627218f1fff2e43e19d03156b76cc3871d48eb4267c8047921d0

data/README.md

@@ -103,6 +103,25 @@ BUNDLE_GEMFILE=gemfiles/rails-4.2-mongo.gemfile bundle exec rake
 BUNDLE_GEMFILE=gemfiles/rails-4.2-mongoid.gemfile bundle exec rake
 ```
 
+## Performance benchmark
+
+The repository includes a performance benchmark. It runrs against all available
+included stores and outputs the results.
+
+```
+ruby perf/benchmark.rb
+```
+
+## Releases
+
+To create a new release checkou the `master` branch and make sure it's in the
+right state to release. Run the `release` Rake task and follow the
+instructions.
+
+```
+rake release
+```
+
 ## Previous contributors
 
 MongoSessionStore started as a fork of the DataMapper session store, modified

data/lib/mongo_session_store/mongo_store_base.rb

@@ -16,10 +16,6 @@ module ActionDispatch
         self.class.session_class
       end
 
-      def generate_sid
-        BSON::ObjectId.new.to_s
-      end
-
       def get_session(env, sid)
         id, record = find_or_initialize_session(sid)
         env[SESSION_RECORD_KEY] = record
@@ -40,7 +36,7 @@ module ActionDispatch
         existing_session = (id && session_class.where(:_id => id).first)
         session = existing_session if existing_session
         session ||= session_class.new(:_id => generate_sid)
-        [session._id.to_s, session]
+        [session._id, session]
       end
 
       def get_session_record(env, sid)

data/lib/mongo_session_store/version.rb

@@ -1,3 +1,3 @@
 module MongoSessionStore
-  VERSION = "7.0.1".freeze
+  VERSION = "7.0.2".freeze
 end

data/mongo_session_store.gemspec

@@ -5,7 +5,7 @@ Gem::Specification.new do |s|
   s.version = MongoSessionStore::VERSION
 
   s.authors          = ["Tom de Bruijn", "Brian Hempel", "Nicolas M\303\251rouze", "Tony Pitale", "Chris Brickley"]
-  s.email            = ["tom@tomdebruijn.com.com"]
+  s.email            = ["tom@tomdebruijn.com"]
   s.files            = `git ls-files`.split("\n")
   s.test_files       = `git ls-files -- {spec,perf}/*`.split("\n")
   s.homepage         = "http://github.com/appsignal/mongo_session_store"

data/spec/lib/mongo_session_store/mongo_store/session_spec.rb

@@ -62,11 +62,11 @@ if mongo_orm == "mongo"
       end
 
       context "with matching records" do
-        let(:session) { described_class.new(:_id => BSON::ObjectId.new).tap(&:save) }
+        let(:session) { described_class.new(:_id => generate_sid).tap(&:save) }
         let(:id) { session._id }
         before do
           # Noise
-          described_class.new(:_id => BSON::ObjectId.new).tap(&:save)
+          described_class.new(:_id => generate_sid).tap(&:save)
         end
 
         it "returns session model objects" do
@@ -83,14 +83,14 @@ if mongo_orm == "mongo"
       context "without data" do
         let(:attributes) do
           {
-            :_id => BSON::ObjectId.new,
+            :_id => generate_sid,
             :created_at => created_at,
             :updated_at => updated_at
           }
         end
 
         it "creates a session object with empty data" do
-          expect(session._id).to be_kind_of(BSON::ObjectId)
+          expect(session._id).to be_kind_of(String)
           expect(session.data).to eq({})
           expect(session.created_at).to eq(created_at)
           expect(session.updated_at).to eq(updated_at)
@@ -100,7 +100,7 @@ if mongo_orm == "mongo"
       context "with data key as a symbol" do
         let(:attributes) do
           {
-            :_id => BSON::ObjectId.new,
+            :_id => generate_sid,
             :data => BSON::Binary.new(Marshal.dump(:foo => "bar"), :generic),
             :created_at => created_at,
             :updated_at => updated_at
@@ -108,7 +108,7 @@ if mongo_orm == "mongo"
         end
 
         it "creates a session object with correct data" do
-          expect(session._id).to be_kind_of(BSON::ObjectId)
+          expect(session._id).to be_kind_of(String)
           expect(session.data).to eq(:foo => "bar")
           expect(session.created_at).to eq(created_at)
           expect(session.updated_at).to eq(updated_at)
@@ -118,7 +118,7 @@ if mongo_orm == "mongo"
       context "with data key as a string" do
         let(:attributes) do
           {
-            :_id => BSON::ObjectId.new,
+            :_id => generate_sid,
             "data" => BSON::Binary.new(Marshal.dump(:foo => "bar"), :generic),
             :created_at => created_at,
             :updated_at => updated_at
@@ -126,7 +126,7 @@ if mongo_orm == "mongo"
         end
 
         it "creates a session object with correct data" do
-          expect(session._id).to be_kind_of(BSON::ObjectId)
+          expect(session._id).to be_kind_of(String)
           expect(session.data).to eq(:foo => "bar")
           expect(session.created_at).to eq(created_at)
           expect(session.updated_at).to eq(updated_at)
@@ -135,7 +135,7 @@ if mongo_orm == "mongo"
     end
 
     describe "#save" do
-      let(:id) { BSON::ObjectId.new }
+      let(:id) { generate_sid }
       subject { described_class.collection.find(:_id => id).first }
 
       describe "_id attribute" do
@@ -235,7 +235,7 @@ if mongo_orm == "mongo"
     end
 
     describe "#destroy" do
-      let(:id) { BSON::ObjectId.new }
+      let(:id) { generate_sid }
       let(:session) { described_class.new(:_id => id) }
       before { session.save }
 

data/spec/lib/mongo_session_store/mongo_store_base_spec.rb

@@ -99,10 +99,10 @@ describe ActionDispatch::Session::MongoStoreBase do
     let(:store_class) { mongo_orm == "mongoid" ? MongoidStore : MongoStore }
     let(:store) { store_class.new(nil) }
     let(:session_class) { store_class::Session }
-    subject { store.send(:set_session, env, BSON::ObjectId.new, {}) }
+    subject { store.send(:set_session, env, generate_sid, {}) }
 
     context "with existing session record" do
-      let(:id) { BSON::ObjectId.new }
+      let(:id) { generate_sid }
       let!(:session_record) { session_class.new(:_id => id).tap(&:save) }
       let(:env) do
         {
@@ -182,7 +182,7 @@ describe ActionDispatch::Session::MongoStoreBase do
   end
 
   describe "#destroy_session" do
-    let(:id) { BSON::ObjectId.new }
+    let(:id) { generate_sid }
     let(:store_class) { mongo_orm == "mongoid" ? MongoidStore : MongoStore }
     let(:store) { store_class.new(nil) }
     let(:session_class) { store_class::Session }

data/spec/spec_helper.rb

@@ -2,6 +2,7 @@ require "mongo"
 require "mongoid" if Gem.loaded_specs["mongoid"]
 require "mongo_session_store-rails"
 require "support/helpers/test_database_helper"
+require "support/helpers/session_id_helper"
 
 def mongo_orm
   defined?(Mongoid) ? "mongoid" : "mongo"
@@ -9,6 +10,7 @@ end
 
 RSpec.configure do |config|
   config.include TestDatabaseHelper
+  config.include SessionIdHelper
 
   config.order = "random"
   config.mock_with :rspec do |c|

data/spec/support/helpers/session_id_helper.rb

@@ -0,0 +1,5 @@
+module SessionIdHelper
+  def generate_sid
+    ActionDispatch::Session::MongoStoreBase.new(nil).generate_sid
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mongo_session_store-rails
 version: !ruby/object:Gem::Version
-  version: 7.0.1
+  version: 7.0.2
 platform: ruby
 authors:
 - Tom de Bruijn
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-01 00:00:00.000000000 Z
+date: 2016-12-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
@@ -100,7 +100,7 @@ dependencies:
         version: 0.45.0
 description: 
 email:
-- tom@tomdebruijn.com.com
+- tom@tomdebruijn.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -232,6 +232,7 @@ files:
 - spec/support/apps/rails_4.2_app/db/migrate/20140301171212_add_devise_users.rb
 - spec/support/apps/rails_4.2_app/db/schema.rb
 - spec/support/apps/rails_4.2_app/db/seeds.rb
+- spec/support/helpers/session_id_helper.rb
 - spec/support/helpers/test_database_helper.rb
 homepage: http://github.com/appsignal/mongo_session_store
 licenses:
@@ -364,4 +365,5 @@ test_files:
 - spec/support/apps/rails_4.2_app/db/migrate/20140301171212_add_devise_users.rb
 - spec/support/apps/rails_4.2_app/db/schema.rb
 - spec/support/apps/rails_4.2_app/db/seeds.rb
+- spec/support/helpers/session_id_helper.rb
 - spec/support/helpers/test_database_helper.rb