mongify 1.3.1 → 1.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2666a90ce1ed143778b58f442d33914ff368d1b6
-  data.tar.gz: 231908954f10b624d88056e633141035c1aaaa1b
+  metadata.gz: 2c9b7a85234abf8705ad06a4f3b17df8b041f347
+  data.tar.gz: 88ac19500da4d1bf630de63a79273dafa09e91f9
 SHA512:
-  metadata.gz: 9b6f9ab2f4445bde689ad9d1ea14fb729e88961030a25c72a21a387e333dae7559ff6a5b11295b7c7b0e8957d372bb0910b339f548b6e95ad0088b0d5c19e3c1
-  data.tar.gz: fb4dc2a80709689de982330db5fb900d8d602128e700f243b41c7b5e2c4749f2673222797ab6388ca072b5393f0425e190563251a4e9175881fe14bf2d2ad308
+  metadata.gz: 258b0d620e1b5de76f308aca344a50dc8a0f6ea6d9506f2558e2ee205394dc75dfe63111789995c2b307905b91eb926e7a33c407b58e276ffca131864a0f4908
+  data.tar.gz: 77c2164795bfcf713b1af6af6eda7030f39c8b8b98bdc60e2f4871032e23e2fa43c755e7c0235bd3fb057edb9c83c321b004d31b9ce824753ece779a4b27a65d

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Mongify ChangeLog
 
+## 1.3.2 / 04 Sep 2017
+* Minor code refactoring
+* Removed exception handling around ALL exceptions (this should improve finding issues outside of Mongify)
+
 ## 1.3.1 / 09 Nov 2016
 * Updated gem requirements to exlucde ActiveRecord/ActiveSupport 5.0
 * Locked down gem versions to prevent issues on newer gems (Like ActiveRecord 5 and Mongo)

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    mongify (1.3.1)
+    mongify (1.3.2)
       activerecord (>= 4.2, < 5.0)
       activesupport (>= 4.2, < 5.0)
       bson (= 1.12.5)
@@ -120,4 +120,4 @@ DEPENDENCIES
   yard (>= 0.8)
 
 BUNDLED WITH
-   1.13.5
+   1.15.4

data/README.rdoc

@@ -36,11 +36,15 @@ Building a config file is as simple as this:
     password    "passw0rd"
     database    "my_database"
     batch_size  10000           # This is defaulted to 10000 but in case you want to make that smaller (on lower RAM machines)
+    # Uncomment the following line if you get a "String not valid UTF-8" error.
+    # encoding "utf8"
   end
 
   mongodb_connection do
     host        "localhost"
     database    "my_database"
+    # Uncomment the following line if you get a "String not valid UTF-8" error.
+    # encoding "utf8"
   end
 
 You can check your configuration by running

data/bin/mongify

@@ -6,7 +6,9 @@
 # Author: Andrew Kalek
 #
 
-$:.unshift  File.join(File.dirname(File.dirname(File.expand_path(__FILE__))), 'lib')
+$LOAD_PATH.unshift File.join(
+  File.dirname(File.dirname(File.expand_path(__FILE__))), 'lib'
+)
 require 'mongify/cli'
 
 Mongify.root = Dir.pwd

data/lib/mongify/cli/application.rb

@@ -29,9 +29,6 @@ module Mongify
         rescue MongifyError => error
           $stderr.puts "Error: #{error}"
           report_error
-        rescue Exception => error
-          report_error
-          raise error
         end
       end
 
@@ -51,4 +48,4 @@ module Mongify
       end
     end
   end
-end
+end

data/lib/mongify/database/base_connection.rb

@@ -6,11 +6,21 @@ module Mongify
     #
     class BaseConnection
       # List of required fields to make a valid base connection
-      REQUIRED_FIELDS = %w{host}
+      REQUIRED_FIELDS = %w[host].freeze
       # List of all the available fields to make up a connection
-      AVAILABLE_FIELDS = %w{adapter host username password database socket port encoding batch_size}
+      AVAILABLE_FIELDS = %w[
+        adapter
+        host
+        username
+        password
+        database
+        socket
+        port
+        encoding
+        batch_size
+      ].freeze
       # List of all fields that should be forced to a string
-      STRING_FIELDS = %w{adapter}
+      STRING_FIELDS = %w[adapter].freeze
 
       def initialize(options=nil)
         if options
@@ -21,19 +31,21 @@ module Mongify
         end
       end
 
-      # Returns all settings as a hash, this is used mainly in building ActiveRecord::Base.establish_connection
+      # Returns all settings as a hash, this is used mainly in building
+      # ActiveRecord::Base.establish_connection
       def to_hash
         hash = {}
         instance_variables.each do |variable|
-          value = self.instance_variable_get variable
-          hash[variable.to_s.gsub('@','').to_sym] = value unless value.nil?
+          value = instance_variable_get variable
+          hash[variable.to_s.delete('@').to_sym] = value unless value.nil?
         end
         hash
       end
 
       # Ensures the required fields are filled
       def valid?
-        #TODO: Improve this to create an errors array with detailed errors (or maybe just use activemodel)
+        # TODO: Improve this to create an errors array with detailed errors
+        # (or maybe just use activemodel)
         REQUIRED_FIELDS.each do |require_field|
           return false unless instance_variables.map(&:to_s).include?("@#{require_field}") and
                               !instance_variable_get("@#{require_field}").to_s.empty?
@@ -41,12 +53,14 @@ module Mongify
         true
       end
 
-      # Used to setup connection, Raises NotImplementedError because it needs to be setup in BaseConnection's children
+      # Used to setup connection, Raises NotImplementedError because it
+      # needs to be setup in BaseConnection's children
       def setup_connection_adapter
         raise NotImplementedMongifyError
       end
 
-      # Used to test connection, Raises NotImplementedError because it needs to be setup in BaseConnection's children
+      # Used to test connection, Raises NotImplementedError because it needs to
+      # be setup in BaseConnection's children
       def has_connection?
         raise NotImplementedMongifyError
       end
@@ -93,4 +107,4 @@ module Mongify
 
     end
   end
-end
+end

data/lib/mongify/version.rb

@@ -1,4 +1,4 @@
 module Mongify
   # Mongify's Current Version Number
-  VERSION = "1.3.1"
-end
+  VERSION = "1.3.2"
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mongify
 version: !ruby/object:Gem::Version
-  version: 1.3.1
+  version: 1.3.2
 platform: ruby
 authors:
 - Andrew Kalek
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-09 00:00:00.000000000 Z
+date: 2017-09-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -370,7 +370,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.7
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: Translate your SQL data to MongoDB with ease