money_mover 0.0.6 → 0.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 00f83a02bf6fbc8289d72c49efb7317a2d0f2826
-  data.tar.gz: f08ee651e612808e09e23d355df6182bd64f09b9
+  metadata.gz: c6381fecabe648a60a7a28e66f67582988c1645f
+  data.tar.gz: 585d5f5e065aafff7d61dc146dafa2d9196e912e
 SHA512:
-  metadata.gz: 499c8c897ff246de0d6ad400f4ad7736868b8a735104c4a20872a4a3dea56a4313d0b56bb4dd6dbbd10186884c50facb739f5dd5104c17751688373be156a7ae
-  data.tar.gz: 149b4ffec1177b88251b16a7730dd99dfd0eddc54dc38c12653a6d63e6e9a01493103b7ac5cf80d8b64ca4ba80bf9c969feec3e666d5c7f852acb9bfa758f102
+  metadata.gz: d453300e4eac7fc7d5f966d25697aaf2cf235b0d59906c55b7910df70d60eb9e954e3d937d84dbd352c1a3478ded530fb987a2a95b2aa2bde0131f7051a18131
+  data.tar.gz: d9595b26247a965c2603bff50f1583c0c2506572ae0fd456e26332deb9c881d99f2f5ff99178cf50f20aa75cc6cb7736d6520f4ee1db92d189e92ad6fcadbadf

data/lib/money_mover/dwolla/models/api_resource.rb

@@ -5,9 +5,10 @@ module MoneyMover
 
       attr_accessor :id, :_links, :_embedded
 
-      attr_reader :resource_location
+      attr_reader :resource_location, :attrs
 
       def initialize(attrs = {}, client = AccountClient.new)
+        @attrs = attrs
         @id = attrs[:id]
         @resource_location = attrs[:resource_location]
         @_links = attrs[:_links]

data/lib/money_mover/dwolla/models/verified_business_customer.rb

@@ -37,13 +37,13 @@ module MoneyMover
           doingBusinessAs: doingBusinessAs,
           website: website,
           type: 'business',
+          ipAddress: ipAddress
         }
 
         # hack to fix bug on dwolla's side with funding sources being removed if no dba is sent
         create_attrs[:doingBusinessAs] = businessName unless doingBusinessAs.present?
-        create_attrs[:ipAddress] = ipAddress if ipAddress.present?
 
-        create_attrs
+        create_attrs.reject{|_key, val| !val.present? }
       end
     end
   end

data/lib/money_mover/version.rb

@@ -1,3 +1,3 @@
 module MoneyMover
-  VERSION = '0.0.6'
+  VERSION = '0.0.7'
 end

data/spec/integration/money_mover/dwolla/customers/funding-sources/create_spec.rb

@@ -27,14 +27,44 @@ describe MoneyMover::Dwolla::CustomerFundingSource do
   }}
 
   before do
-    dwolla_helper.stub_create_customer_funding_source_request customer_token, create_params, dwolla_helper.customer_funding_source_created_response(customer_token, funding_source_token)
+    dwolla_helper.stub_create_customer_funding_source_request customer_token, create_params, create_response
   end
 
   describe '#save' do
-    it 'creates new customer funding source in dwolla' do
-      expect(subject.save).to eq(true)
-      expect(subject.id).to eq(funding_source_token)
-      expect(subject.resource_location).to eq(dwolla_helper.customer_funding_source_endpoint(customer_token, funding_source_token))
+    context 'valid' do
+      let(:create_response) { dwolla_helper.customer_funding_source_created_response customer_token, funding_source_token }
+
+      it 'creates new customer funding source in dwolla' do
+        expect(subject.save).to eq(true)
+        expect(subject.id).to eq(funding_source_token)
+        expect(subject.resource_location).to eq(dwolla_helper.customer_funding_source_endpoint(customer_token, funding_source_token))
+      end
+    end
+
+    context 'invalid' do
+      let(:create_response) do
+        dwolla_helper.error_response(
+          code: "ValidationError",
+          message: "Validation error(s) present. See embedded errors list for more details.",
+          _embedded: {
+            errors: [
+              {
+                code: "Invalid",
+                message: "Invalid parameter.",
+                path: "/routingNumber"
+              }
+            ]
+          }
+        )
+      end
+
+      it 'returns false and sets errors' do
+        expect(subject.save).to eq(false)
+        expect(subject.errors[:routingNumber]).to eq(['Invalid parameter.'])
+
+        expect(subject.id).to be_nil
+        expect(subject.resource_location).to be_nil
+      end
     end
   end
 end

data/spec/integration/money_mover/dwolla/models/verified_business_customer_spec.rb

@@ -0,0 +1,112 @@
+require 'spec_helper'
+
+describe MoneyMover::Dwolla::VerifiedBusinessCustomer do
+  let(:firstName) { 'first name' }
+  let(:lastName) { 'last name' }
+  let(:email) { 'some@example.com' }
+  let(:address1) { '123 Anywhere St.' }
+  let(:address2) { 'Suite 200' }
+  let(:city) { 'St. Louis' }
+  let(:state) { 'MO' }
+  let(:postalCode) { '63104' }
+  let(:dateOfBirth) { '01/28/1970' }
+  let(:ssn) { '123456789' }
+  let(:phone) { '636-333-3333' }
+  let(:businessClassification) { 'some-business-classification' }
+  let(:businessType) { 'llc' }
+  let(:businessName) { 'Some Company, LLC' }
+  let(:ein) { '987654321' }
+  let(:doingBusinessAs) { 'Alternate Company Name' }
+  let(:website) { 'http://website.com' }
+  let(:ipAddress) { '127.0.0.1' }
+
+  # TODO: add test for not being able to set type, status, created, etc. directly...
+
+  subject { described_class.new attrs }
+
+  describe '#save' do
+    let(:attrs) {{
+      firstName: firstName,
+      lastName: lastName,
+      email: email,
+      address1: address1,
+      address2: address2,
+      city: city,
+      state: state,
+      postalCode: postalCode,
+      dateOfBirth: dateOfBirth,
+      ssn: ssn,
+      phone: phone,
+      businessClassification: businessClassification,
+      businessType: businessType,
+      businessName: businessName,
+      ein: ein,
+      doingBusinessAs: doingBusinessAs,
+      website: website,
+      ipAddress: ipAddress
+    }}
+
+    let(:create_customer_params) {{
+      firstName: firstName,
+      lastName: lastName,
+      email: email,
+      address1: address1,
+      address2: address2,
+      city: city,
+      state: state,
+      postalCode: postalCode,
+      dateOfBirth: dateOfBirth,
+      ssn: ssn,
+      phone: phone,
+      businessClassification: businessClassification,
+      businessType: businessType,
+      businessName: businessName,
+      ein: ein,
+      doingBusinessAs: doingBusinessAs,
+      website: website,
+      ipAddress: ipAddress,
+      type: 'business'
+    }}
+
+    before do
+      dwolla_helper.stub_create_customer_request create_customer_params, create_response
+    end
+
+    context 'success' do
+      let(:customer_token) { '9481924a-6795-4e7a-b436-a7a48a4141ca' }
+
+      let(:create_response) { dwolla_helper.customer_created_response customer_token }
+
+      it 'creates new customer in dwolla' do
+        expect(subject.save).to eq(true)
+
+        expect(subject.id).to eq(customer_token)
+        expect(subject.resource_location).to eq(dwolla_helper.customer_endpoint(customer_token))
+      end
+    end
+
+    context 'fail' do
+      let(:create_response) { dwolla_helper.resource_create_error_response error_response }
+
+      let(:error_response) {{
+        code: "ValidationError",
+        message: "Validation error(s) present. See embedded errors list for more details.",
+        _embedded: {
+          errors: [
+            { code: "Duplicate", message: "A customer with the specified email already exists.", path: "/email"
+          }
+          ]
+        }
+      }}
+
+      it 'returns errors' do
+        expect(subject.save).to eq(false)
+
+        expect(subject.errors[:email]).to eq(['A customer with the specified email already exists.'])
+
+        expect(subject.id).to be_nil
+        expect(subject.resource_location).to be_nil
+      end
+    end
+  end
+end

data/spec/unit/money_mover/dwolla/models/verified_business_customer_spec.rb

@@ -0,0 +1,201 @@
+require 'spec_helper'
+
+describe MoneyMover::Dwolla::VerifiedBusinessCustomer do
+  let(:firstName) { double 'first name' }
+  let(:lastName) { double 'last name' }
+  let(:email) { double 'email' }
+  let(:address1) { double 'address 1' }
+  let(:address2) { double 'address 2' }
+  let(:city) { double 'city' }
+  let(:state) { double 'state' }
+  let(:postalCode) { double 'postal code' }
+  let(:dateOfBirth) { double 'dob' }
+  let(:ssn) { double 'ssn' }
+  let(:phone) { double 'phone' }
+  let(:businessClassification) { double 'business classification' }
+  let(:businessType) { double 'business type' }
+  let(:businessName) { double 'business name' }
+  let(:ein) { double 'ein' }
+  let(:doingBusinessAs) { double 'dba' }
+  let(:website) { double 'website' }
+  let(:ipAddress) { double 'ip address' }
+
+  # TODO: add test for not being able to set type, status, created, etc. directly...
+
+  let(:account_client) { double 'account client' }
+
+  subject { described_class.new attrs, account_client }
+
+  describe '#save' do
+    let(:attrs) {{
+      firstName: firstName,
+      lastName: lastName,
+      email: email,
+      address1: address1,
+      address2: address2,
+      city: city,
+      state: state,
+      postalCode: postalCode,
+      dateOfBirth: dateOfBirth,
+      ssn: ssn,
+      phone: phone,
+      businessClassification: businessClassification,
+      businessType: businessType,
+      businessName: businessName,
+      ein: ein,
+      doingBusinessAs: doingBusinessAs,
+      website: website,
+      ipAddress: ipAddress
+    }}
+
+    let(:create_customer_params) {{
+      firstName: firstName,
+      lastName: lastName,
+      email: email,
+      address1: address1,
+      address2: address2,
+      city: city,
+      state: state,
+      postalCode: postalCode,
+      dateOfBirth: dateOfBirth,
+      ssn: ssn,
+      phone: phone,
+      businessClassification: businessClassification,
+      businessType: businessType,
+      businessName: businessName,
+      ein: ein,
+      doingBusinessAs: doingBusinessAs,
+      website: website,
+      ipAddress: ipAddress,
+      type: 'business'
+    }}
+
+    let(:dwolla_response) { double 'dwolla response', success?: success?, resource_id: resource_id, resource_location: resource_location, errors: dwolla_errors }
+    let(:resource_id) { double 'resource id' }
+    let(:resource_location) { double 'resource location' }
+    let(:dwolla_errors) {{
+      errorKey1: 'some error 1',
+      errorKey2: 'some error 2'
+    }}
+
+    let(:create_endpoint) { "/customers" }
+
+    before do
+      allow(account_client).to receive(:post).with(create_endpoint, create_customer_params) { dwolla_response }
+    end
+
+    shared_examples 'resource created successfully' do
+      it 'returns true' do
+        expect(subject.save).to eq(true)
+        expect(subject.errors.count).to eq(0)
+
+        expect(subject.id).to eq(resource_id)
+        expect(subject.resource_location).to eq(resource_location)
+      end
+    end
+
+    context 'success' do
+      let(:success?) { true }
+
+      it_behaves_like "resource created successfully"
+
+      context 'only required fields sent' do
+        let(:attrs) {{
+          firstName: firstName,
+          lastName: lastName,
+          email: email,
+          address1: address1,
+          city: city,
+          state: state,
+          postalCode: postalCode,
+          dateOfBirth: dateOfBirth,
+          ssn: ssn,
+          phone: phone,
+          businessClassification: businessClassification,
+          businessType: businessType,
+          businessName: businessName,
+          ein: ein
+        }}
+
+        let(:create_customer_params) {{
+          firstName: firstName,
+          lastName: lastName,
+          email: email,
+          address1: address1,
+          city: city,
+          state: state,
+          postalCode: postalCode,
+          dateOfBirth: dateOfBirth,
+          ssn: ssn,
+          phone: phone,
+          businessClassification: businessClassification,
+          businessType: businessType,
+          businessName: businessName,
+          ein: ein,
+          doingBusinessAs: businessName,
+          type: 'business'
+        }}
+
+        it_behaves_like "resource created successfully"
+      end
+
+      context 'sending empty strings for non-required fields' do
+        let(:attrs) {{
+          firstName: firstName,
+          lastName: lastName,
+          email: email,
+          address1: address1,
+          address2: "",
+          city: city,
+          state: state,
+          postalCode: postalCode,
+          dateOfBirth: dateOfBirth,
+          ssn: ssn,
+          phone: phone,
+          businessClassification: businessClassification,
+          businessType: businessType,
+          businessName: businessName,
+          ein: ein,
+          doingBusinessAs: "",
+          website: "",
+          ipAddress: ""
+        }}
+
+        let(:create_customer_params) {{
+          firstName: firstName,
+          lastName: lastName,
+          email: email,
+          address1: address1,
+          city: city,
+          state: state,
+          postalCode: postalCode,
+          dateOfBirth: dateOfBirth,
+          ssn: ssn,
+          phone: phone,
+          businessClassification: businessClassification,
+          businessType: businessType,
+          businessName: businessName,
+          ein: ein,
+          doingBusinessAs: businessName,
+          type: 'business'
+        }}
+
+        it_behaves_like "resource created successfully"
+      end
+    end
+
+    context 'fail' do
+      let(:success?) { false }
+
+      it 'returns errors' do
+        expect(subject.save).to eq(false)
+
+        expect(subject.errors[:errorKey1]).to eq(['some error 1'])
+        expect(subject.errors[:errorKey2]).to eq(['some error 2'])
+
+        expect(subject.id).to be_nil
+        expect(subject.resource_location).to be_nil
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: money_mover
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.0.7
 platform: ruby
 authors:
 - Daniel Errante
@@ -216,20 +216,22 @@ files:
 - spec/integration/money_mover/dwolla/documents/create_spec.rb
 - spec/integration/money_mover/dwolla/funding-sources/micro-deposits/initiation_spec.rb
 - spec/integration/money_mover/dwolla/funding-sources/micro-deposits/verification_spec.rb
+- spec/integration/money_mover/dwolla/models/verified_business_customer_spec.rb
 - spec/integration/money_mover/dwolla/request_signature_validator_spec.rb
 - spec/integration/money_mover/dwolla/transfers/create_spec.rb
-- spec/lib/money_mover/dwolla/client_spec.rb
-- spec/lib/money_mover/dwolla/config_spec.rb
-- spec/lib/money_mover/dwolla/error_handler_spec.rb
-- spec/lib/money_mover/dwolla/funding_source_spec.rb
-- spec/lib/money_mover/dwolla/microdeposits_initiation_spec.rb
-- spec/lib/money_mover/dwolla/root_account_spec.rb
-- spec/lib/money_mover/dwolla/token_spec.rb
-- spec/lib/money_mover/dwolla/transfer_spec.rb
-- spec/lib/money_mover/dwolla/webhook_subscription_spec.rb
 - spec/spec_helper.rb
 - spec/support/dwolla_helper.rb
 - spec/support/fixtures/sample.jpg
+- spec/unit/money_mover/dwolla/client_spec.rb
+- spec/unit/money_mover/dwolla/config_spec.rb
+- spec/unit/money_mover/dwolla/error_handler_spec.rb
+- spec/unit/money_mover/dwolla/funding_source_spec.rb
+- spec/unit/money_mover/dwolla/microdeposits_initiation_spec.rb
+- spec/unit/money_mover/dwolla/models/verified_business_customer_spec.rb
+- spec/unit/money_mover/dwolla/root_account_spec.rb
+- spec/unit/money_mover/dwolla/token_spec.rb
+- spec/unit/money_mover/dwolla/transfer_spec.rb
+- spec/unit/money_mover/dwolla/webhook_subscription_spec.rb
 homepage: https://github.com/danoph/money_mover
 licenses:
 - MIT
@@ -261,17 +263,19 @@ test_files:
 - spec/integration/money_mover/dwolla/documents/create_spec.rb
 - spec/integration/money_mover/dwolla/funding-sources/micro-deposits/initiation_spec.rb
 - spec/integration/money_mover/dwolla/funding-sources/micro-deposits/verification_spec.rb
+- spec/integration/money_mover/dwolla/models/verified_business_customer_spec.rb
 - spec/integration/money_mover/dwolla/request_signature_validator_spec.rb
 - spec/integration/money_mover/dwolla/transfers/create_spec.rb
-- spec/lib/money_mover/dwolla/client_spec.rb
-- spec/lib/money_mover/dwolla/config_spec.rb
-- spec/lib/money_mover/dwolla/error_handler_spec.rb
-- spec/lib/money_mover/dwolla/funding_source_spec.rb
-- spec/lib/money_mover/dwolla/microdeposits_initiation_spec.rb
-- spec/lib/money_mover/dwolla/root_account_spec.rb
-- spec/lib/money_mover/dwolla/token_spec.rb
-- spec/lib/money_mover/dwolla/transfer_spec.rb
-- spec/lib/money_mover/dwolla/webhook_subscription_spec.rb
 - spec/spec_helper.rb
 - spec/support/dwolla_helper.rb
 - spec/support/fixtures/sample.jpg
+- spec/unit/money_mover/dwolla/client_spec.rb
+- spec/unit/money_mover/dwolla/config_spec.rb
+- spec/unit/money_mover/dwolla/error_handler_spec.rb
+- spec/unit/money_mover/dwolla/funding_source_spec.rb
+- spec/unit/money_mover/dwolla/microdeposits_initiation_spec.rb
+- spec/unit/money_mover/dwolla/models/verified_business_customer_spec.rb
+- spec/unit/money_mover/dwolla/root_account_spec.rb
+- spec/unit/money_mover/dwolla/token_spec.rb
+- spec/unit/money_mover/dwolla/transfer_spec.rb
+- spec/unit/money_mover/dwolla/webhook_subscription_spec.rb