money_extensions 1.3.0 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b02ce974d0847bc55984f19c7b7052cac5178e8ca17ed4c17778b7cab20b918d
-  data.tar.gz: 888c92464c6ba7510c855ac6ee8670c802d41f6e408f2e3cbf21ae793e1fdd7d
+  metadata.gz: 06650b1771418b5d1bdc6d6391949813b5068ac49a69c8ab05e8d2c25a00be01
+  data.tar.gz: 134f2a5024b53e835adf631ea62d39e7005c0f2823ed3339a651197165fef6a0
 SHA512:
-  metadata.gz: fbef0196b7903684d86d191ea69dbc1f007949647f5135bbafcaea0ae6f9ee097fa46eee3892e4b9a799909345cabbb6f8b2fbe9681e994198d9e7220dd76991
-  data.tar.gz: 52f7c134ad23cc2db1d1d040be03abfbf7607bf48731f838004609cf114045c4efdf09f708f3ae8864ff242a38b20e5e79f1a4cfd6f8d4d73cbcd3299784b845
+  metadata.gz: e67f7a24cf172adbf7b8c155e47385daddfc86bc15270df25555aa4b1edac30082ea8e79fc12d9f40f0f2f644cee002d817a144a3777a85acda3caf470b15bc4
+  data.tar.gz: c971b6a50588c06dc507737fdba9ff27bfd800f4d64438538f4f15e62fb6b3b25eb23d6db45a9b4be9effe2b6e27dbfa03ebe14de38eb063fb06796c55471503

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 1.4.0
+
+- [PLAT-401] Optimise split_between when we are doing so with numbers
+
 ## 1.3.0
 
 - [PLAT-377] Improve bundler require time for the Gem

data/lib/money_extensions/split_between.rb

@@ -1,11 +1,23 @@
 # frozen_string_literal: true
 
 module SplitBetween
+  extend ActiveSupport::Concern
+
   # Override division -- should not do it, but use split_between
   def /(*_params)
     raise "Division of money NOT allowed - use 'split_between' to avoid rounding errors"
   end
 
+  module ClassMethods
+    def split_evenly_between(cents, number)
+      Money::Allocation.generate(cents, number).map { |num| Money.from_cents(num) }
+    end
+  end
+
+  def split_evenly_between(number)
+    Money.split_evenly_between(cents, number)
+  end
+
   # Split the money between the specified number - and return an array of money
   # Remainder in splits are given to the highest value e.g.
   # $2.00 splits [40, 81, 40] into [49, 102, 49]
@@ -13,11 +25,7 @@ module SplitBetween
   def split_between(params)
     # if just a number is passed in, then money is split equally
     if params.is_a?(Integer)
-      divisor = params
-      raise ArgumentError, 'Can only split up over a positive number' if divisor < 1
-
-      rounded_split = lossy_divide(divisor)
-      results       = Array.new(divisor, rounded_split) # Create with 'divisor' num elements
+      results = split_evenly_between(params)
 
       # if an array of monies is passed in, then split in proportions
     elsif params.is_a?(Array)
@@ -36,14 +44,17 @@ module SplitBetween
       results.map! do |ratio|
         ::Money.new((cents * (ratio.to_f / total)).round)
       end
+
+      # Distribute rounding to max absolute to avoid a $0 amount getting the rounding
+      remainder = self - results.total_money
+      if !remainder.zero?
+        biggest_value_index = results.index(results.max_by(&:abs))
+        results[biggest_value_index] += remainder
+      end
     else
       raise 'Either a Integer or array has to be passed in for splitting money'
     end
 
-    # Distribute rounding to max absolute to avoid a $0 amount getting the rounding
-    biggest_value_index = results.index(results.max_by(&:abs))
-    results[biggest_value_index] += self - results.total_money
-
     results
   end
 end

data/lib/money_extensions/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module MoneyExtensions
-  VERSION = '1.3.0'
+  VERSION = '1.4.0'
 end

data/spec/money_spec.rb

@@ -5,6 +5,26 @@ describe Money do
     expect { Money.new(50)/10 }.to raise_error(RuntimeError)
   end
 
+  it 'should split evenly between' do
+    money = Money.new(100)
+
+    expect(money.split_evenly_between(3)).to eq [34,33,33].map{ |i| Money.new(i) }
+    expect(money.split_evenly_between(3).sum(Money.zero)).to eq money
+
+    expect(money.split_evenly_between(6)).to eq [17,17,17,17,16,16].map{ |i| Money.new(i) }
+    expect(money.split_evenly_between(6).sum(Money.zero)).to eq money
+  end
+
+  it 'should split evenly between negative numbers' do
+    money = Money.new(-100)
+
+    expect(money.split_evenly_between(3)).to eq [-33,-33,-34].map{ |i| Money.new(i) }
+    expect(money.split_evenly_between(3).sum(Money.zero)).to eq money
+
+    expect(money.split_evenly_between(6)).to eq [-16,-16,-17,-17,-17,-17].map{ |i| Money.new(i) }
+    expect(money.split_evenly_between(6).sum(Money.zero)).to eq money
+  end
+
   it "should split money correctly" do
     money = Money.new(100)
 
@@ -21,7 +41,7 @@ describe Money do
     expect(money.split_between([1,2])).to eq [33,67].map{ |i| Money.new(i)}
 
     money_negative = Money.new(-100)
-    expect(money_negative.split_between(3)).to eq [-34,-33,-33].map{ |i| Money.new(i)}
+    expect(money_negative.split_between(3)).to eq [-33,-33,-34].map{ |i| Money.new(i)}
     expect(money_negative.split_between([1,2,2,5])).to eq [-10,-20,-20,-50].map{ |i| Money.new(i)}
     expect(money_negative.split_between([1,2])).to eq [-33,-67].map{ |i| Money.new(i)}
 

data/spec/support/coverage_loader.rb

@@ -1,3 +1,3 @@
 require 'coverage/kit'
 
-Coverage::Kit.setup(minimum_coverage: 86.5)
+Coverage::Kit.setup(minimum_coverage: 87.0)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: money_extensions
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.4.0
 platform: ruby
 authors:
 - Michael Noack
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-07-02 00:00:00.000000000 Z
+date: 2022-07-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: money