money-tree 0.10.0 → 0.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e6b1fd18c035198917d9939d44f6bcbbe4ae69ef168af5de52ab32f5778662b1
-  data.tar.gz: 31ef2d35cd3d2f10cf40d7fe44787a38857c1c79173494f97d0d296f7828bfba
+  metadata.gz: 040b86e807e6dea0ebf4dfc4b5e508e3f9ef673c94b95a210a18c125d8857974
+  data.tar.gz: '01800e0fb32058488fd01f1a8f2be3539788c7d0bebc0021fd49776fdde947a4'
 SHA512:
-  metadata.gz: 03c0b6c55c8f290f10989870d559904a644a68f441cc0ae6498d9cde12bc4853f63babc6ce68d5ad1dfbfb3f6a67b0b4b400053fdddacb62faa9d01adc43f765
-  data.tar.gz: 8c37b6e7386c60be7ac9797a248039b88ff39b0f46438a07c46aa363b8c8fa30160cdeb0f6d5d54f92fc0b512f437e6a73488cc12e355c25b04fb9dcb7af5d33
+  metadata.gz: 70a6465799b1f7140a2e45c2ded416b41e4b64a7801b57325ed20cea470c92cad96e7644596d523a192254e7284eb772406e90af0a797f5b367304cbe2e9b725
+  data.tar.gz: 2d0c6bea3a33f161cf30a3400d3f75b6119098f035eca6cdac076c11c03596a2e0e205456b1e3ea2453f2ad1e58fd7edec91ff21ec1a8fd515c2d7836169762c

data/.github/workflows/spec.yml

@@ -0,0 +1,31 @@
+---
+name: Spec
+
+on:
+  pull_request:
+    branches:
+      - master
+  push:
+    branches:
+      - master
+
+jobs:
+  test:
+    runs-on: ${{ matrix.os }}
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest, macos-latest]
+        ruby: ['2.7', '3.0']
+    steps:
+    - uses: actions/checkout@v2
+    - uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+        bundler-cache: false
+    - name: Install Dependencies
+      run: |
+        bundle install
+    - name: Run Tests
+      run: |
+        bundle exec rspec

data/README.md

@@ -1,13 +1,23 @@
-[![Build Status](https://travis-ci.org/GemHQ/money-tree.png)](https://travis-ci.org/GemHQ/money-tree) [![Coverage Status](https://img.shields.io/coveralls/GemHQ/money-tree.svg)](https://coveralls.io/r/GemHQ/money-tree?branch=master) [![Code Climate](https://codeclimate.com/github/GemHQ/money-tree.png)](https://codeclimate.com/github/GemHQ/money-tree) [![Gem Version](https://badge.fury.io/rb/money-tree.png)](http://badge.fury.io/rb/money-tree)
 # MoneyTree
+
+[![GitHub release (latest by date)](https://img.shields.io/github/v/release/GemHQ/money-tree)](https://github.com/GemHQ/money-tree/releases)
+[![Gem](https://img.shields.io/gem/v/money-tree)](https://rubygems.org/gems/money-tree)
+[![Gem](https://img.shields.io/gem/dt/money-tree)](https://rubygems.org/gems/money-tree)
+[![GitHub top language](https://img.shields.io/github/languages/top/GemHQ/money-tree?color=red)](https://github.com/GemHQ/money-tree/pulse)
+
+[![GitHub Workflow Status](https://img.shields.io/github/workflow/status/GemHQ/money-tree/Spec)](https://github.com/GemHQ/money-tree/actions)
+[![Coverage Status](https://img.shields.io/coveralls/GemHQ/money-tree.svg)](https://coveralls.io/r/GemHQ/money-tree?branch=master)
+[![Code Climate](https://codeclimate.com/github/GemHQ/money-tree.png)](https://codeclimate.com/github/GemHQ/money-tree)
+[![GitHub](https://img.shields.io/github/license/GemHQ/money-tree)](LICENSE)
+
 ### RSpec tested. Big Brother removed.
 
 MoneyTree is a Ruby implementation of Bitcoin Wallets. Specifically, it supports [Hierachical Deterministic wallets](https://en.bitcoin.it/wiki/Deterministic_Wallet) according to the protocol specified in [BIP0032](https://github.com/bitcoin/bips/blob/master/bip-0032.mediawiki).
 
 ___
-If you find this helpful, please consider a small Bitcoin donation to 1nj2kie1hATcFbAaD7dEY53QaxNgt4KBp
+If you find this helpful, please consider a small Bitcoin donation to `1nj2kie1hATcFbAaD7dEY53QaxNgt4KBp`.
 
-![Donate BTC](https://raw.github.com/wink/money-tree/master/donation_btc_qr_code.gif)
+![Donate BTC](./.github/donation_btc_qr_code.gif)
 ___
 
 ## Why would I want an HD Wallet?
@@ -163,7 +173,7 @@ Because we need multiple pieces of info to reconstruct nodes in a tree, when we'
 "xpub661MyMwAqRbcFtXgS5sYJABqqG9YLmC4Q1Rdap9gSE8NqtwybGhePY2gZ29ESFjqJoCu1Rupje8YtGqsefD265TMg7usUDFdp6W1EGMcet8"
 ```
 
-In addition to the key and the chain code, this encoding also includes info about the depth and index of the key, along with a fingerprint of its parent key (which I presume is for quickly sorting a big pile of keys into a tree).   
+In addition to the key and the chain code, this encoding also includes info about the depth and index of the key, along with a fingerprint of its parent key (which I presume is for quickly sorting a big pile of keys into a tree).
 
 These are the addresses that you should use to represent each node in the tree structure, however these are NOT the bitcoin addresses you should pass around for receiving money. These are more for storing inside a wallet file so that you can reconstruct the tree.
 

data/Rakefile

@@ -3,4 +3,4 @@ require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task :default => :spec

data/lib/money-tree/address.rb

@@ -1,13 +1,13 @@
 module MoneyTree
   class Address
     attr_reader :private_key, :public_key
-    
+
     def initialize(opts = {})
       private_key = opts.delete(:private_key)
       @private_key = MoneyTree::PrivateKey.new({ key: private_key }.merge(opts))
       @public_key = MoneyTree::PublicKey.new(@private_key, opts)
     end
-    
+
     def to_s(network: :bitcoin)
       public_key.to_s(network: network)
     end

data/lib/money-tree/node.rb

@@ -90,7 +90,12 @@ module MoneyTree
       left_int = left_from_hash(hash)
       raise InvalidKeyForIndex, 'greater than or equal to order' if left_int >= MoneyTree::Key::ORDER # very low probability
       factor = BN.new left_int.to_s
-      child_public_key = public_key.uncompressed.group.generator.mul(factor).add(public_key.uncompressed.point).to_bn.to_i
+
+      gen_point = public_key.uncompressed.group.generator.mul(factor)
+
+      sum_point_hex = MoneyTree::OpenSSLExtensions.add(gen_point, public_key.uncompressed.point)
+      child_public_key = OpenSSL::PKey::EC::Point.new(public_key.group, OpenSSL::BN.new(sum_point_hex, 16)).to_bn.to_i
+
       raise InvalidKeyForIndex, 'at infinity' if child_public_key == 1/0.0 # very low probability
       child_chain_code = right_from_hash(hash)
       return child_public_key, child_chain_code

data/lib/money-tree/support.rb

@@ -4,11 +4,11 @@ require 'base64'
 module MoneyTree
   module Support
     include OpenSSL
-    
+
     INT32_MAX = 256 ** [1].pack("L*").size
     INT64_MAX = 256 ** [1].pack("Q*").size
     BASE58_CHARS = "123456789ABCDEFGHJKLMNPQRSTUVWXYZabcdefghijkmnopqrstuvwxyz"
-    
+
     def int_to_base58(int_val, leading_zero_bytes=0)
       base58_val, base = '', BASE58_CHARS.size
       while int_val > 0
@@ -40,7 +40,7 @@ module MoneyTree
       s
     end
     alias_method :base58_to_hex, :decode_base58
-    
+
     def to_serialized_base58(hex)
       hash = sha256 hex
       hash = sha256 hash
@@ -48,7 +48,7 @@ module MoneyTree
       address = hex + checksum
       encode_base58 address
     end
-    
+
     def from_serialized_base58(base58)
       hex = decode_base58 base58
       checksum = hex.slice!(-8..-1)
@@ -56,45 +56,45 @@ module MoneyTree
       raise EncodingError unless checksum == compare_checksum
       hex
     end
-    
+
     def digestify(digest_type, source, opts = {})
       source = [source].pack("H*") unless opts[:ascii]
       bytes_to_hex Digest.digest(digest_type, source)
     end
-    
+
     def sha256(source, opts = {})
       digestify('SHA256', source, opts)
     end
-    
+
     def ripemd160(source, opts = {})
       digestify('RIPEMD160', source, opts)
     end
-    
+
     def encode_base64(hex)
       Base64.encode64([hex].pack("H*")).chomp
     end
-    
+
     def decode_base64(base64)
       Base64.decode64(base64).unpack("H*")[0]
     end
-    
+
     def hmac_sha512(key, message)
       digest = Digest::SHA512.new
       HMAC.digest digest, key, message
     end
-    
+
     def hmac_sha512_hex(key, message)
       md = hmac_sha512(key, message)
       md.unpack("H*").first.rjust(64, '0')
     end
-    
+
     def bytes_to_int(bytes, base = 16)
       if bytes.is_a?(Array)
         bytes = bytes.pack("C*")
       end
       bytes.unpack("H*")[0].to_i(16)
     end
-    
+
     def int_to_hex(i, size=nil)
       hex = i.to_s(16).downcase
       if (hex.size % 2) != 0
@@ -107,19 +107,19 @@ module MoneyTree
         hex
       end
     end
-        
+
     def int_to_bytes(i)
       [int_to_hex(i)].pack("H*")
     end
-    
+
     def bytes_to_hex(bytes)
       bytes.unpack("H*")[0].downcase
     end
-    
+
     def hex_to_bytes(hex)
       [hex].pack("H*")
     end
-    
+
     def hex_to_int(hex)
       hex.to_i(16)
     end

data/lib/money-tree/version.rb

@@ -1,3 +1,3 @@
 module MoneyTree
-  VERSION = "0.10.0"
+  VERSION = "0.11.0"
 end

data/lib/money-tree.rb

@@ -8,5 +8,4 @@ require "money-tree/networks"
 require "money-tree/node"
 
 module MoneyTree
-  
 end

data/lib/openssl_extensions.rb

@@ -1,73 +1,28 @@
 # encoding: ascii-8bit
 
 require 'openssl'
-require 'ffi'
 
 module MoneyTree
   module OpenSSLExtensions
-    extend FFI::Library
-    ffi_lib ['libssl.so.1.0.0', 'libssl.so.10', 'libssl1.0.0', 'ssl']
-
-    NID_secp256k1 = 714
-    POINT_CONVERSION_COMPRESSED = 2
-    POINT_CONVERSION_UNCOMPRESSED = 4
-
-    attach_function :EC_KEY_free, [:pointer], :int
-    attach_function :EC_KEY_get0_group, [:pointer], :pointer
-    attach_function :EC_KEY_new_by_curve_name, [:int], :pointer
-    attach_function :EC_POINT_clear_free, [:pointer], :int
-    attach_function :EC_POINT_add, [:pointer, :pointer, :pointer, :pointer, :pointer], :int
-    attach_function :EC_POINT_point2hex, [:pointer, :pointer, :int, :pointer], :string
-    attach_function :EC_POINT_hex2point, [:pointer, :string, :pointer, :pointer], :pointer
-    attach_function :EC_POINT_new, [:pointer], :pointer
-    
     def self.add(point_0, point_1)
       validate_points(point_0, point_1)
-      eckey = EC_KEY_new_by_curve_name(NID_secp256k1)
-      group = EC_KEY_get0_group(eckey)
-      
+      group = OpenSSL::PKey::EC::Group.new('secp256k1')
       point_0_hex = point_0.to_bn.to_s(16)
-      point_0_pt = EC_POINT_hex2point(group, point_0_hex, nil, nil)
+      point_0_pt = OpenSSL::PKey::EC::Point.new(group, OpenSSL::BN.new(point_0_hex, 16))
       point_1_hex = point_1.to_bn.to_s(16)
-      point_1_pt = EC_POINT_hex2point(group, point_1_hex, nil, nil)
-
-      sum_point = EC_POINT_new(group)
-      success = EC_POINT_add(group, sum_point, point_0_pt, point_1_pt, nil)
-      hex = EC_POINT_point2hex(group, sum_point, POINT_CONVERSION_UNCOMPRESSED, nil)
-
-      EC_KEY_free(eckey)
-      EC_POINT_clear_free(sum_point)
-      EC_POINT_clear_free(point_0_pt)
-      EC_POINT_clear_free(point_1_pt)
-
-      eckey = nil
-      group = nil
-      sum_point = nil
-      point_0_pt = nil
-      point_1_pt = nil
-
-      hex
+      point_1_pt = OpenSSL::PKey::EC::Point.new(group, OpenSSL::BN.new(point_1_hex, 16))
+      sum_point = point_0_pt.add(point_1_pt)
+      sum_point.to_bn.to_s(16)
     end
 
     def self.validate_points(*points)
       points.each do |point|
         if !point.is_a?(OpenSSL::PKey::EC::Point)
-          raise ArgumentError, "point must be an OpenSSL::PKey::EC::Point object" 
+          raise ArgumentError, "point must be an OpenSSL::PKey::EC::Point object"
         elsif point.infinity?
-          raise ArgumentError, "point must not be infinity" 
+          raise ArgumentError, "point must not be infinity"
         end
       end
     end
   end
 end
-
-
-class OpenSSL::PKey::EC::Point
-  include MoneyTree::OpenSSLExtensions
-  
-  def add(point)
-    sum_point_hex = MoneyTree::OpenSSLExtensions.add(self, point)
-    self.class.new group, OpenSSL::BN.new(sum_point_hex, 16)
-  end
-  
-end

data/money-tree.gemspec

@@ -6,8 +6,8 @@ require 'money-tree/version'
 Gem::Specification.new do |spec|
   spec.name          = "money-tree"
   spec.version       = MoneyTree::VERSION
-  spec.authors       = ["Micah Winkelspecht"]
-  spec.email         = ["winkelspecht@gmail.com"]
+  spec.authors       = ["Micah Winkelspecht", "Afri Schoedon"]
+  spec.email         = ["winkelspecht@gmail.com", "gems@q9f.cc"]
   spec.description   = %q{A Ruby Gem implementation of Bitcoin HD Wallets}
   spec.summary       = %q{Bitcoin Hierarchical Deterministic Wallets in Ruby! (Bitcoin standard BIP0032)}
   spec.homepage      = "https://github.com/gemhq/money-tree"
@@ -17,22 +17,11 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
-  
-  # used with gem install ... -P HighSecurity
-  spec.cert_chain  = ["certs/mattatgemco.pem"]
-  # Sign gem when evaluating spec with `gem` command
-  #  unless ENV has set a SKIP_GEM_SIGNING
-  if ($0 =~ /gem\z/) and not ENV.include?("SKIP_GEM_SIGNING")
-    spec.signing_key = File.join(Gem.user_home, ".ssh", "gem-private_key.pem")
-  end
 
- 
-  spec.add_dependency "ffi"
-    
-  spec.add_development_dependency "bundler", "~> 1.3"
-  spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec"
-  spec.add_development_dependency "simplecov"
-  spec.add_development_dependency "coveralls"
-  spec.add_development_dependency "pry"
+  spec.add_dependency 'openssl', '>= 2.2'
+
+  spec.add_development_dependency "bundler", "~> 2.2"
+  spec.add_development_dependency "rake", "~> 13.0"
+  spec.add_development_dependency "rspec", "~> 3.10"
+  spec.add_development_dependency "pry", "~> 0.4"
 end

data/spec/lib/money-tree/address_spec.rb

@@ -4,14 +4,20 @@ describe MoneyTree::Address do
   describe "initialize" do
     it "generates a private key by default" do
       address = MoneyTree::Address.new
+      expect(address).to be
+      expect(address).to be_instance_of MoneyTree::Address
+      expect(address.private_key).to be_instance_of MoneyTree::PrivateKey
       expect(address.private_key.key.length).to eql(64)
     end
-    
+
     it "generates a public key by default" do
       address = MoneyTree::Address.new
+      expect(address).to be
+      expect(address).to be_instance_of MoneyTree::Address
+      expect(address.public_key).to be_instance_of MoneyTree::PublicKey
       expect(address.public_key.key.length).to eql(66)
     end
-        
+
     it "imports a private key in hex form" do
       address = MoneyTree::Address.new private_key: "5eae5375fb5f7a0ea650566363befa2830ef441bdcb19198adf318faee86d64b"
       expect(address.private_key.key).to eql("5eae5375fb5f7a0ea650566363befa2830ef441bdcb19198adf318faee86d64b")
@@ -20,36 +26,46 @@ describe MoneyTree::Address do
       expect(address.private_key.to_s).to eql("KzPkwAXJ4wtXHnbamTaJqoMrzwCUUJaqhUxnqYhnZvZH6KhgmDPK")
       expect(address.public_key.to_s).to eql("13uVqa35BMo4mYq9LiZrXVzoz9EFZ6aoXe")
     end
-    
+
     it "imports a private key in compressed wif format" do
       address = MoneyTree::Address.new private_key: "KzPkwAXJ4wtXHnbamTaJqoMrzwCUUJaqhUxnqYhnZvZH6KhgmDPK"
       expect(address.private_key.key).to eql("5eae5375fb5f7a0ea650566363befa2830ef441bdcb19198adf318faee86d64b")
       expect(address.public_key.key).to eql("022dfc2557a007c93092c2915f11e8aa70c4f399a6753e2e908330014091580e4b")
       expect(address.to_s).to eql("13uVqa35BMo4mYq9LiZrXVzoz9EFZ6aoXe")
     end
-    
+
     it "imports a private key in uncompressed wif format" do
       address = MoneyTree::Address.new private_key: "5JXz5ZyFk31oHVTQxqce7yitCmTAPxBqeGQ4b7H3Aj3L45wUhoa"
       expect(address.private_key.key).to eql("5eae5375fb5f7a0ea650566363befa2830ef441bdcb19198adf318faee86d64b")
       expect(address.public_key.key).to eql("022dfc2557a007c93092c2915f11e8aa70c4f399a6753e2e908330014091580e4b")
     end
   end
-  
+
   describe "to_s" do
     before do
       @address = MoneyTree::Address.new private_key: "5eae5375fb5f7a0ea650566363befa2830ef441bdcb19198adf318faee86d64b"
     end
-    
+
     it "returns compressed base58 public key" do
       expect(@address.to_s).to eql("13uVqa35BMo4mYq9LiZrXVzoz9EFZ6aoXe")
       expect(@address.public_key.to_s).to eql("13uVqa35BMo4mYq9LiZrXVzoz9EFZ6aoXe")
     end
-    
+
     it "returns compressed WIF private key" do
       expect(@address.private_key.to_s).to eql("KzPkwAXJ4wtXHnbamTaJqoMrzwCUUJaqhUxnqYhnZvZH6KhgmDPK")
     end
   end
 
+  context "bitcoin wiki" do
+    # ref https://en.bitcoin.it/wiki/Technical_background_of_version_1_Bitcoin_addresses
+    subject(:wiki) { MoneyTree::Address.new private_key: '18e14a7b6a307f426a94f8114701e7c8e774e7f9a47e2c2035db29a206321725' }
+
+    it "always regenerates the bitcoin wiki example" do
+      expect(wiki.public_key.key).to eq "0250863ad64a87ae8a2fe83c1af1a8403cb53f53e486d8511dad8a04887e5b2352"
+      expect(wiki.to_s).to eq "1PMycacnJaSqwwJqjawXBErnLsZ7RkXUAs"
+    end
+  end
+
   context "testnet3" do
     before do
       @address = MoneyTree::Address.new network: :bitcoin_testnet

data/spec/lib/money-tree/openssl_extensions_spec.rb

@@ -1,5 +1,23 @@
 require 'spec_helper'
 
+FIXED_KEY1 = <<-fixed_key
+-----BEGIN EC PRIVATE KEY-----
+MHQCAQEEIOvYaAN53KFhyLIElYFZCpm/Q2wq72Uu0kRcKeCDdlJVoAcGBSuBBAAK
+oUQDQgAE4cdbt+NxMCBLg0cQYqo/UEwfzAONpz/n7ux+QrdKuH9NRulf9D4996x5
+r7QBY+l5GJ+RgzLoXbFjPyPQtCV+/Q==
+-----END EC PRIVATE KEY-----
+fixed_key
+
+FIXED_KEY2 = <<-fixed_key
+-----BEGIN EC PRIVATE KEY-----
+MHQCAQEEIP6nKLMEcH9R3hv695rCUl9OV+ueC9UX18F2PIH5wcFpoAcGBSuBBAAK
+oUQDQgAErilvn3ms9cKHLNHHegiUU+NuW8c2f223vYInEV+s9ZNSGd28usAXZ6lN
+O2zE534+k09fFe2skHtdoXbLJuZV8g==
+-----END EC PRIVATE KEY-----
+fixed_key
+
+FIXED_SUM = "04F3C291542F410F61D61861D911F71ABD320A7B77ED571F92FEC533F61549BF218BAA47BD134847D89917F7483AFE20CCD9B1A4CBDFC443B389D1313B48E018F4"
+
 describe MoneyTree::OpenSSLExtensions do
   include MoneyTree::OpenSSLExtensions
 
@@ -8,8 +26,15 @@ describe MoneyTree::OpenSSLExtensions do
     let(:key2) { OpenSSL::PKey::EC.new("secp256k1").generate_key }
     let(:point_1) { key1.public_key }
     let(:point_2) { key2.public_key }
+
     let(:point_infinity) { key1.public_key.set_to_infinity! }
 
+    let(:fixed_key1) { OpenSSL::PKey::EC.new(FIXED_KEY1) }
+    let(:fixed_key2) { OpenSSL::PKey::EC.new(FIXED_KEY2) }
+    let(:fixed_point1) { fixed_key1.public_key }
+    let(:fixed_point2) { fixed_key2.public_key }
+    let(:fixed_sum_point) { OpenSSL::PKey::EC::Point.new(OpenSSL::PKey::EC::Group.new("secp256k1"), OpenSSL::BN.new(FIXED_SUM, 16)) }
+
     it "requires valid points" do
       expect { MoneyTree::OpenSSLExtensions.add(0, 0) }.to raise_error(ArgumentError)
       expect { MoneyTree::OpenSSLExtensions.add(nil, nil) }.to raise_error(ArgumentError)
@@ -17,7 +42,30 @@ describe MoneyTree::OpenSSLExtensions do
       expect { MoneyTree::OpenSSLExtensions.add(0, point_2) }.to raise_error(ArgumentError)
       expect { MoneyTree::OpenSSLExtensions.add(point_infinity, point_2) }.to raise_error(ArgumentError)
       expect { MoneyTree::OpenSSLExtensions.add(point_1, point_2) }.to_not raise_error
+      expect { MoneyTree::OpenSSLExtensions.validate_points(point_1) }.to_not raise_error
+    end
+
+    it "validates points correctly" do
+      expect { MoneyTree::OpenSSLExtensions.validate_points(point_1) }.to_not raise_error
+      expect { MoneyTree::OpenSSLExtensions.validate_points(point_2) }.to_not raise_error
+      expect { MoneyTree::OpenSSLExtensions.validate_points(point_infinity) }.to raise_error(ArgumentError)
+    end
+
+    it "should add points correctly" do
+      result = MoneyTree::OpenSSLExtensions.add(fixed_point1, fixed_point2)
+
+      expect(result).to eql(FIXED_SUM)
+
+      group = OpenSSL::PKey::EC::Group.new("secp256k1")
+      result_point = OpenSSL::PKey::EC::Point.new(group, OpenSSL::BN.new(result, 16))
+
+      expect(result_point).to eql(fixed_sum_point)
+    end
+
+    it 'should be able to create the same hex output for the point' do
+      hex_output = fixed_sum_point.to_bn.to_s(16)
+
+      expect(hex_output).to eq(FIXED_SUM)
     end
   end
-  
 end

data/spec/lib/money-tree/private_key_spec.rb

@@ -4,7 +4,7 @@ describe MoneyTree::PrivateKey do
   before do
     @key = MoneyTree::PrivateKey.new key: "5eae5375fb5f7a0ea650566363befa2830ef441bdcb19198adf318faee86d64b"
   end
-  
+
   describe "to_hex" do
     it "has 64 characters" do
       # must always be 64 characters - leading zeroes need to be preserved!
@@ -15,81 +15,81 @@ describe MoneyTree::PrivateKey do
       master = MoneyTree::Master.new seed_hex: "9cf6b6e8451c7d551cb402e2997566e5c7c258543eadb184f9f39322b2e6959b"
       expect(master.node_for_path("m/427").private_key.to_hex.length).to eql(64)
     end
-    
+
     it "is a valid hex" do
-      expect(@key.to_hex).to eql('5eae5375fb5f7a0ea650566363befa2830ef441bdcb19198adf318faee86d64b'      )
+      expect(@key.to_hex).to eql('5eae5375fb5f7a0ea650566363befa2830ef441bdcb19198adf318faee86d64b')
     end
   end
-  
+
   describe "to_wif" do
     it "is a 52 character base58 key" do
       expect(@key.to_wif.length).to eql(52)
     end
-    
+
     it "starts with K or L" do
       expect(%w(K L)).to include(@key.to_wif[0])
     end
-    
+
     it "is a valid compressed wif" do
-      expect(@key.to_wif).to eql('KzPkwAXJ4wtXHnbamTaJqoMrzwCUUJaqhUxnqYhnZvZH6KhgmDPK'      )
+      expect(@key.to_wif).to eql('KzPkwAXJ4wtXHnbamTaJqoMrzwCUUJaqhUxnqYhnZvZH6KhgmDPK')
     end
   end
-  
+
   describe "to_wif(compressed: false)" do
     it "is a 51 character base58 key" do
       expect(@key.to_wif(compressed: false).length).to eql(51)
     end
-    
+
     it "starts with 5" do
       expect(@key.to_wif(compressed: false)[0]).to eql('5')
     end
-    
+
     it "is valid" do
       expect(@key.to_wif(compressed: false)).to eql('5JXz5ZyFk31oHVTQxqce7yitCmTAPxBqeGQ4b7H3Aj3L45wUhoa')
     end
   end
-  
+
   describe "from_wif(wif)" do
     it "returns the key from a wif" do
       expect(@key.from_wif("5HueCGU8rMjxEXxiPuD5BDku4MkFqeZyd4dZ1jvhTVqvbTLvyTJ")).to eql('0c28fca386c7a227600b2fe50b7cae11ec86d3bf1fbe471be89827e19d72aa1d')
     end
-    
+
     it "raises an error on bad checksum" do
       expect { @key.from_wif("5HueCGU8rMjxEXxiPuD5BDku4MkFqeZyd4dZ1jvhTVqvbTBADTJ") }.to raise_error(MoneyTree::Key::InvalidWIFFormat)
     end
   end
-  
+
   describe "to_base64" do
     it "has 44 characters" do
       expect(@key.to_base64.length).to eql(44)
     end
-  
+
     it "is a valid base64" do
-      expect(@key.to_base64).to eql('Xq5Tdftfeg6mUFZjY776KDDvRBvcsZGYrfMY+u6G1ks='      )
+      expect(@key.to_base64).to eql('Xq5Tdftfeg6mUFZjY776KDDvRBvcsZGYrfMY+u6G1ks=')
     end
   end
-  
+
   describe "from_base64(base64_key)" do
     it "parses base64 key" do
       @key = MoneyTree::PrivateKey.new(key: "Xq5Tdftfeg6mUFZjY776KDDvRBvcsZGYrfMY+u6G1ks=")
       expect(@key.to_hex).to eql("5eae5375fb5f7a0ea650566363befa2830ef441bdcb19198adf318faee86d64b")
     end
-    
+
     it "returns the key from base64 encoding" do
       expect(@key.from_base64("Xq5Tdftfeg6mUFZjY776KDDvRBvcsZGYrfMY+u6G1ks=")).to eql('5eae5375fb5f7a0ea650566363befa2830ef441bdcb19198adf318faee86d64b')
     end
-    
+
     it "raises an error on bad encoding" do
       expect { @key.from_base64("Xq5Tdftfeg6mUFZjY776KD&%#BbadBADrfMY+u6G1ks=") }.to raise_error(MoneyTree::Key::InvalidBase64Format)
     end
   end
-  
+
   describe "valid?(eckey)" do
     it "checks for a valid key" do
       expect(@key.valid?).to be_truthy
     end
   end
-  
+
   describe "parse_raw_key" do
     it "returns error if key is not Bignum, hex, base64, or wif formatted" do
       expect { @key = MoneyTree::PrivateKey.new(key: "Thisisnotakey") }.to raise_error(MoneyTree::Key::KeyFormatNotFound)

data/spec/lib/money-tree/public_key_spec.rb

@@ -1,111 +1,111 @@
 require 'spec_helper'
 
 describe MoneyTree::PublicKey do
-  
+
   describe "with a private key" do
     before do
       @private_key = MoneyTree::PrivateKey.new key: "5eae5375fb5f7a0ea650566363befa2830ef441bdcb19198adf318faee86d64b"
       @key = MoneyTree::PublicKey.new @private_key
     end
-  
+
     describe "to_hex(compressed: false)" do
       it "has 65 bytes" do
         expect(@key.uncompressed.to_hex.length).to eql(130)
       end
-    
+
       it "is a valid hex" do
-        expect(@key.uncompressed.to_hex).to eql('042dfc2557a007c93092c2915f11e8aa70c4f399a6753e2e908330014091580e4b11203096f1a1c5276a73f91b9465357004c2103cc42c63d6d330df589080d2e4'      )
+        expect(@key.uncompressed.to_hex).to eql('042dfc2557a007c93092c2915f11e8aa70c4f399a6753e2e908330014091580e4b11203096f1a1c5276a73f91b9465357004c2103cc42c63d6d330df589080d2e4')
       end
     end
-  
+
     describe "to_hex" do
       it "has 33 bytes" do
         expect(@key.to_hex.length).to eql(66)
       end
-  
+
       it "is a valid compressed hex" do
-        expect(@key.to_hex).to eql('022dfc2557a007c93092c2915f11e8aa70c4f399a6753e2e908330014091580e4b'      )
+        expect(@key.to_hex).to eql('022dfc2557a007c93092c2915f11e8aa70c4f399a6753e2e908330014091580e4b')
       end
     end
-  
+
     describe "to_fingerprint" do
       it "returns a valid fingerprint" do
         expect(@key.to_fingerprint).to eql("1fddf42e")
       end
     end
-  
+
     describe "to_address(compressed: false)" do
       it "has 34 characters" do
         expect(@key.uncompressed.to_address.length).to eql(34)
       end
-    
+
       it "is a valid bitcoin address" do
-        expect(@key.uncompressed.to_address).to eql('133bJA2xoVqBUsiR3uSkciMo5r15fLAaZg'      )
+        expect(@key.uncompressed.to_address).to eql('133bJA2xoVqBUsiR3uSkciMo5r15fLAaZg')
       end
     end
-  
+
     describe "to_compressed_address" do
       it "has 34 characters" do
         expect(@key.to_address.length).to eql(34)
       end
-    
+
       it "is a valid compressed bitcoin address" do
-        expect(@key.to_address).to eql('13uVqa35BMo4mYq9LiZrXVzoz9EFZ6aoXe'      )
+        expect(@key.to_address).to eql('13uVqa35BMo4mYq9LiZrXVzoz9EFZ6aoXe')
       end
     end
   end
-  
+
   describe "without a private key" do
     before do
       @key = MoneyTree::PublicKey.new '042dfc2557a007c93092c2915f11e8aa70c4f399a6753e2e908330014091580e4b11203096f1a1c5276a73f91b9465357004c2103cc42c63d6d330df589080d2e4'
     end
-    
+
     describe "to_hex(compressed: false)" do
       it "has 65 bytes" do
         expect(@key.uncompressed.to_hex.length).to eql(130)
       end
-    
+
       it "is a valid hex" do
-        expect(@key.uncompressed.to_hex).to eql('042dfc2557a007c93092c2915f11e8aa70c4f399a6753e2e908330014091580e4b11203096f1a1c5276a73f91b9465357004c2103cc42c63d6d330df589080d2e4'      )
+        expect(@key.uncompressed.to_hex).to eql('042dfc2557a007c93092c2915f11e8aa70c4f399a6753e2e908330014091580e4b11203096f1a1c5276a73f91b9465357004c2103cc42c63d6d330df589080d2e4')
       end
     end
-  
+
     describe "to_hex" do
       it "has 33 bytes" do
         expect(@key.compressed.to_hex.length).to eql(66)
       end
-  
+
       it "is a valid compressed hex" do
-        expect(@key.compressed.to_hex).to eql('022dfc2557a007c93092c2915f11e8aa70c4f399a6753e2e908330014091580e4b'      )
+        expect(@key.compressed.to_hex).to eql('022dfc2557a007c93092c2915f11e8aa70c4f399a6753e2e908330014091580e4b')
       end
     end
-  
+
     describe "to_fingerprint" do
       it "returns a valid fingerprint" do
         expect(@key.compressed.to_fingerprint).to eql("1fddf42e")
       end
     end
-  
+
     describe "to_address(compressed: false)" do
       it "has 34 characters" do
         expect(@key.uncompressed.to_address.length).to eql(34)
       end
-    
+
       it "is a valid bitcoin address" do
-        expect(@key.uncompressed.to_address).to eql('133bJA2xoVqBUsiR3uSkciMo5r15fLAaZg'      )
+        expect(@key.uncompressed.to_address).to eql('133bJA2xoVqBUsiR3uSkciMo5r15fLAaZg')
       end
     end
-  
+
     describe "to_compressed_address" do
       it "has 34 characters" do
         expect(@key.compressed.to_address.length).to eql(34)
       end
-    
+
       it "is a valid compressed bitcoin address" do
-        expect(@key.compressed.to_address).to eql('13uVqa35BMo4mYq9LiZrXVzoz9EFZ6aoXe'      )
+        expect(@key.compressed.to_address).to eql('13uVqa35BMo4mYq9LiZrXVzoz9EFZ6aoXe')
       end
     end
-    
+
     describe "#compression" do
       it "returns current compression setting" do
         @key.compression = :uncompressed
@@ -115,7 +115,7 @@ describe MoneyTree::PublicKey do
       end
     end
   end
-  
+
   describe "with a bad key" do
     it "raises KeyFormatNotFound" do
       expect { @key = MoneyTree::PublicKey.new 'THISISNOTAVALIDKEY' }.to raise_error(MoneyTree::Key::KeyFormatNotFound)
@@ -125,7 +125,7 @@ describe MoneyTree::PublicKey do
   describe "recalcuating public key" do
     it "produces same results" do
       results = []
-      100.times do 
+      100.times do
         results << MoneyTree::PublicKey.new('042dfc2557a007c93092c2915f11e8aa70c4f399a6753e2e908330014091580e4b11203096f1a1c5276a73f91b9465357004c2103cc42c63d6d330df589080d2e4').to_s
       end
       expect(results.uniq.length).to eql(1)
@@ -158,6 +158,18 @@ describe MoneyTree::PublicKey do
     end
   end
 
+  context "wobine's blackboard 101 series" do
+    # ref https://github.com/wobine/blackboard101/blob/e991ea0b98fd26059bf3806e5749b5e5f737e791/EllipticCurvesPart4-PrivateKeyToPublicKey.py
+    subject(:wobine) { MoneyTree::PrivateKey.new key: 'A0DC65FFCA799873CBEA0AC274015B9526505DAAAED385155425F7337704883E' }
+
+    it "always recovers wobine's public keys" do
+      expect(wobine.key).to eq 'a0dc65ffca799873cbea0ac274015b9526505daaaed385155425f7337704883e'
+      public_key = MoneyTree::PublicKey.new wobine
+      expect(public_key.key).to eq '020791dc70b75aa995213244ad3f4886d74d61ccd3ef658243fcad14c9ccee2b0a'
+      expect(public_key.uncompressed.to_hex).to eq '040791dc70b75aa995213244ad3f4886d74d61ccd3ef658243fcad14c9ccee2b0aa762fbc6ac0921b8f17025bb8458b92794ae87a133894d70d7995fc0b6b5ab90'
+    end
+  end
+
   context "testnet" do
     context 'with private key' do
       before do

data/spec/lib/money-tree/support_spec.rb

@@ -10,20 +10,20 @@ describe MoneyTree::Support do
       expect(sha256("8147786c4d15106333bf278d71dadaf1079ef2d2440a4dde37d747ded5403592")).to eql("507a5b8dfed0fc6fe8801743720cedec06aa5c6fca72b07c49964492fb98a714")
     end
   end
-  
+
   describe "ripemd160(str)" do
     it "properly calculates ripemd160 hash" do
       expect(ripemd160("abc", ascii: true)).to eql("8eb208f7e05d987a9b044a8e98c6b087f15a0bfc")
       expect(ripemd160("e8026715af68676e0287ec9aa774f8103e4bddd5505b209263a8ff97c6ea29cc")).to eql("166db6510884918f31a9d246404760db8154bf84")
     end
   end
-  
+
   describe "hmac_sha512_hex(key, message)" do
     it "properly calculates hmac sha512" do
       expect(hmac_sha512_hex("Jefe", "what do ya want for nothing?")).to eql("164b7a7bfcf819e2e395fbe73b56e0a387bd64222e831fd610270cd7ea2505549758bf75c05a994a6d034f65f8f0e6fdcaeab1a34d4a6b4b636e070a38bce737")
     end
   end
-  
+
   describe "hex_to_int" do
     it "converts hex to integer" do
       expect(hex_to_int("abcdef0123456789")).to eql(12379813738877118345)

data/spec/spec_helper.rb

@@ -1,3 +1,2 @@
-require 'simplecov'
 require 'money-tree'
 require 'pry'

metadata

@@ -1,156 +1,104 @@
 --- !ruby/object:Gem::Specification
 name: money-tree
 version: !ruby/object:Gem::Version
-  version: 0.10.0
+  version: 0.11.0
 platform: ruby
 authors:
 - Micah Winkelspecht
-autorequire: 
+- Afri Schoedon
+autorequire:
 bindir: bin
-cert_chain:
-- |
-  -----BEGIN CERTIFICATE-----
-  MIIEHDCCAoSgAwIBAgIBATANBgkqhkiG9w0BAQsFADAcMRowGAYDVQQDDBFtYXR0
-  L0RDPWdlbS9EQz1jbzAeFw0xODA1MzAyMTQwNDZaFw0xOTA1MzAyMTQwNDZaMBwx
-  GjAYBgNVBAMMEW1hdHQvREM9Z2VtL0RDPWNvMIIBojANBgkqhkiG9w0BAQEFAAOC
-  AY8AMIIBigKCAYEAxfbjMHFlxA2P+4YWPagKoGAMi4078imgXdFbD3Rloe6cGfYp
-  IMUQitiHrKi6fhSE0UjXmoP3qnYFddm1enN9zUAFRhHWv7xpINqSqss4PYAb5Anl
-  RYZu3jromop5aVodi15HUfu5z27MvBm4rAaN/dDRfh/rT2hDbTTh0HmvEaPUDfX6
-  TyflAttfabFvtY4qsD+ao8tks0DytqyuEWZ0tvQ6upOgHRNNuYDwDZB1T9v2dq2w
-  3goJFmOKBMMn7UH8WMjD3HiOuRD4tWhq5xWLjBqjzFlVPlZPgdCNyXeMMnLXER98
-  NY35cVWFFuqG+kZwy4MFKdE9WFTocLZxLFo0VVTNSpPara9HirbHtIo9jZNuop4S
-  g4JTf1F8dIWYii3sXoAYZfkl6rHVRP0G/OV5LcTfSS3QkmI5hNltz5FZzc+qI6S1
-  rTR1ZwTy1rRI3coFY7vDRaFWBoMbbo/DytgCE3+rfbVDxQrJa4aZ0iYDhu8LXEA1
-  VTtpf1EWYCOsYE1TAgMBAAGjaTBnMAkGA1UdEwQCMAAwCwYDVR0PBAQDAgSwMB0G
-  A1UdDgQWBBQ6QoDNre7LFgOukH2Cv+RqZyfUzjAWBgNVHREEDzANgQttYXR0QGdl
-  bS5jbzAWBgNVHRIEDzANgQttYXR0QGdlbS5jbzANBgkqhkiG9w0BAQsFAAOCAYEA
-  kOxYnOsB+NwHwLc2lHEZ8ubxanq2qIZDhvVQ4M31gwmba43xO7vq0ktFxYRvozs4
-  74dQ6bmY2e7njoFgeutyJwxulA+BC71mDQA1s4WsZo7Z2TRgB0GViVqHrzq+jY+M
-  p9mTHQqKH+2j0P9T4DXSzq4qOaBA3YROAwAzYI9N8MObeWkRt2pZ4zYQrAniP2nd
-  wzXs/G5lWbbntVcvQOfAAXBipSJ3X5P2EGpUytP9ZpGdezY5HZzuiJFcmCf1CM3t
-  VX4NZjbJak9gOY0AFD0Aw497sYenm0VBExclOmeRuZLffpWteTTL//utpG3bbFPl
-  jQ78uzsrexYTYW5IshjfSIf3TZxm50Z45pyOTow5EOP1Nd7OmKOcI8hrLGv5+AlD
-  hCnomUTUNsM4Rjwl5rzQiIn3ezv6+0tlg4rWJmVTuOGwcHk/oj1In2sPjCqm0pgx
-  TLnMa8gr6aUpuHR5s2N4ZH0Q2YIsaD6cv7DYXt+G4MRut3njOYHfkqsSVykO6hvr
-  -----END CERTIFICATE-----
-date: 2018-05-30 00:00:00.000000000 Z
+cert_chain: []
+date: 2022-11-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: ffi
+  name: openssl
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.2'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '2.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '2.2'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: simplecov
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: coveralls
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.10'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.10'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.4'
 description: A Ruby Gem implementation of Bitcoin HD Wallets
 email:
 - winkelspecht@gmail.com
+- gems@q9f.cc
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/donation_btc_qr_code.gif"
+- ".github/workflows/spec.yml"
 - ".gitignore"
 - ".rspec"
-- ".simplecov"
-- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
 - certs/mattatgemco.pem
 - checksum/money-tree-0.9.0.gem.sha512
-- donation_btc_qr_code.gif
 - lib/money-tree.rb
 - lib/money-tree/address.rb
 - lib/money-tree/key.rb
@@ -171,7 +119,7 @@ homepage: https://github.com/gemhq/money-tree
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -186,9 +134,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.7
-signing_key: 
+rubygems_version: 3.3.23
+signing_key:
 specification_version: 4
 summary: Bitcoin Hierarchical Deterministic Wallets in Ruby! (Bitcoin standard BIP0032)
 test_files:

data/.simplecov

@@ -1,7 +0,0 @@
-require 'coveralls'
-
-SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new([
-  SimpleCov::Formatter::HTMLFormatter,
-  Coveralls::SimpleCov::Formatter
-])
-SimpleCov.start

data/.travis.yml

@@ -1,3 +0,0 @@
-language: ruby
-rvm:
-  - 2.0.0