money-oxr 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f22f763f8ab1e4b42d2c5e3e0b63f7f8e560279b
-  data.tar.gz: 816d4178467ce2d53353f351a69cef092eb3126a
+  metadata.gz: 6d40cd83560c6539f8aab07757780f58fe9fa78d
+  data.tar.gz: 100dfdab0c1e84cfe0bbe736913aca1bb2382571
 SHA512:
-  metadata.gz: 1c53e24461edcf82f5d28b967ea764416cb183835af9450abc092e8ab93cd6a3f23e7069471e1a4a1172958266f6142780d085cf672108941f90f8e34552a432
-  data.tar.gz: 05a503ea60a6c0782ec6ad9982704f7e8d33d41487749142d66301984c1a22581056a5e6e6f6fc49c99bb7eff1038e195fd285272a5b93bc62699815111b7800
+  metadata.gz: 2b985081fda88720bede03904f2533002a66d09da3eaa0c085e198267c69103d3e812c1f582f07731c5db9c2bda87c3bc942ea5e85b5263ae3ecc21839d2dc42
+  data.tar.gz: f6e6bef059fb61f9828bb4eb91557f50a4d3530a1dfe6dc31c5c57a580f8c1ef7ce8afba05cd597d64a4ba954ce5a9f42221f9b226624f51befe5c76853ac55e

data/CHANGELOG.md

@@ -4,6 +4,13 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 
 [How to use a CHANGELOG](http://keepachangelog.com/)
 
+## [Unreleased]
+
+## [0.3.0] - 2018-03-21
+### Changed
+- Return nil in RateStore if rate is unknown.
+- Updated Money dependency to ~> 6.6
+
 ## [0.2.0] - 2018-03-19
 ### Added
 - Added safe handling of API request errors.

data/README.md

@@ -28,17 +28,15 @@ Or install it yourself as:
 
 With the gem, you do not need to manually add exchange rates. Calling load will
 load the rates from the cache file or download the rates from the API depending
-on your options.  The :source option defaults to
+on your options.
 
 ``` ruby
 require 'money_oxr/bank'
-oxr_bank = MoneyOXR::Bank.new(
+Money.default_bank = MoneyOXR::Bank.new(
   app_id: 'abcd1234',
-  cache_path: 'tmp/oxr.json',
+  cache_path: 'config/oxr.json',
   max_age: 86400
 )
-oxr_bank.store.load
-Money.default_bank = oxr_bank
 ```
 
 If you only want to load data from a file without ever fetching from the API,
@@ -46,26 +44,24 @@ the :app_id and :max_age options are not necessary.
 
 ``` ruby
 require 'money_oxr/bank'
-oxr_bank = MoneyOXR::Bank.new(
+Money.default_bank = MoneyOXR::Bank.new(
   cache_path: 'config/oxr.json'
 )
-oxr_bank.store.load
-Money.default_bank = oxr_bank
 ```
 
+### :source
+
 If you are on a paid plan from openexchangerates.org and you wish to use a different
-source currency, you may provide it with the :source option.
+source currency, you may provide it with the :source option. The default is `USD`.
 
 ``` ruby
 require 'money_oxr/bank'
-oxr_bank = MoneyOXR::Bank.new(
+Money.default_bank = MoneyOXR::Bank.new(
   app_id: 'abcd1234',
-  cache_path: 'tmp/oxr.json',
+  cache_path: 'config/oxr.json',
   max_age: 86400,
   source: 'GBP'
 )
-oxr_bank.store.load
-Money.default_bank = oxr_bank
 ```
 
 ## Development

data/lib/money_oxr/rates_store.rb

@@ -6,8 +6,6 @@ require 'open-uri'
 module MoneyOXR
   class RatesStore < Money::RatesStore::Memory
 
-    class UnsupportedCurrency < StandardError; end
-
     attr_reader :app_id, :source, :cache_path, :last_updated_at, :max_age, :on_api_failure
 
     def initialize(*)
@@ -23,15 +21,15 @@ module MoneyOXR
       load
       super || begin
         if iso_from == source
-          raise UnsupportedCurrency.new(iso_to)
+          nil
         elsif inverse_rate = super(iso_to, iso_from)
           add_rate(iso_from, iso_to, 1 / inverse_rate)
         elsif iso_to == source
-          raise UnsupportedCurrency.new(iso_from)
+          nil
         else
           rate1 = get_rate(iso_from, source)
           rate2 = get_rate(source, iso_to)
-          add_rate(iso_from, iso_to, rate1 * rate2)
+          rate1 && rate2 && add_rate(iso_from, iso_to, rate1 * rate2)
         end
       end
     end

data/money-oxr.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |spec|
   spec.name          = "money-oxr"
-  spec.version       = "0.2.0"
+  spec.version       = "0.3.0"
   spec.authors       = ["Ed Lebert"]
 
   spec.summary       = %q{A Money-compatible rate store that uses exchange rates from openexchangerates.org.}
@@ -14,7 +14,7 @@ Gem::Specification.new do |spec|
   end
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "money", "~> 6.0"
+  spec.add_dependency "money", "~> 6.6"
 
   spec.add_development_dependency "bundler", "~> 1.15"
   spec.add_development_dependency "rake", "~> 10.0"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: money-oxr
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Ed Lebert
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-19 00:00:00.000000000 Z
+date: 2018-03-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: money
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '6.6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '6.6'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement