money-open-exchange-rates 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 43e935f81c5a1c3daf5f791f0f77badd5b707659
-  data.tar.gz: 086c4f76ec5bcacf9e1af05bfb491428c06409b0
+  metadata.gz: c4fb222d3e754934179c179c0f929cb81a9edea4
+  data.tar.gz: 2333bf1a480b635834bfb05c6b378782981073cc
 SHA512:
-  metadata.gz: 200b48103eca5510fa653b0d86cd72ddaae6cae6d497af0c24803b6e4e8ce96f3bc5fe5da65522eefa69fdb913fbb84e815cb1d7e11776780620e0538557439b
-  data.tar.gz: d6605797a0b3b162b1a50d128c0621508254bef66f62e8ab79538ee2c93140cdf60238c8a9cb22e3b52305d03d4d6ade86aa0b0bfb97e28793e963549a6e5279
+  metadata.gz: 8971c43fdc68e4a969c4ec6660f59b4ad4f5d7b72abc2311e8f7011fb6f3a49e838b693f86304c8e738fa147f79b58381a61497609d13efb13c3de762a6bcabe
+  data.tar.gz: 886d5c8df122b357a33f6ea97c70fa2e2b1602da7b2b3545e674174dafc25752b3fb5dbf1c6ab495d804ff4d0ca9262838a8351345091f231d6645dc996a6ef8

data/History.md

@@ -0,0 +1,174 @@
+
+v0.4.1 / 2015-12-06
+==================
+
+  * Add more test for latest and historical urls
+  * used the correct URL for secure historical
+
+v0.4.0 / 2015-09-28
+===================
+
+  * Add webmock helpers for tests
+  * No need for TEST_APP_ID with webmock
+  * Add ChangeLog
+  * Support historical data endpoint with date
+  * move version into a module not depending on money
+  * Remove encodings headers
+  * Better secure_connection tests
+  * Better temp_cache_path and read_from_url use on tests
+  * Update inch to 0.7
+  * Add Money::Bank::OpenExchangeRatesBank::VERSION
+  * Update minitest and timecop
+  * Use inch for doc suggest
+  * Improve doc for #valid_rates?
+  * Added jruby-9.0.0.0 to travis
+  * Rakefile: add --display-style-guide option to rubocop
+  * Improve code documentation
+  * Update money gem to 6.6
+  * Added license badge
+  * Improve code documentation
+  * Remove useless doc attr_reader
+  * Improve code documentation
+  * Improve documentation of OpenExchangeRatesBank class
+  * Run rubocop on default rake
+  * Added rake rubocop task
+  * Added inch documentation badge
+  * Rename README.markdown to README.md
+  * Update README
+  * Add jruby-head to travis
+  * Add travis notifications config
+  * Make rubocop happy
+
+v0.3.1 / 2015-06-17
+===================
+
+  * Fix secure oer url (see #22)
+  * Test fail for #22; https
+  * More clear spec for ttl (see #17)
+  * Add minitest-line for debug
+  * Update license date
+  * Update license date
+
+v0.3.0 / 2015-06-14
+===================
+
+  * add ruby-head to travis.yml
+  * gem: syntax check
+  * test: syntax check
+  * Syntax fix with rubocop
+  * Use tr instead of gsub
+  * update monetize to 1.3
+  * Tests for the secure_connection option
+  * Updated README to include secure_connection example
+  * Added the secure_connection option to enable HTTPS connections to OER
+  * travis: added 2.2.0 version
+
+v0.2.3 / 2014-12-21
+===================
+
+  * Bump to 0.2.3
+  * Upgrade money to 6.5.0 and monetize to 1.1.0
+  * update not present exchange rate and know exchange
+  * Update latest.json
+  * Doc save_rates and code cleanup
+  * adjust tests to intentionally remove AED from data file and test conversions to AED
+  * setup reverse rates (ie. XYZ -> USD)
+  * travis: cache bundler
+  * README: added badges [ci skip]
+
+v0.2.0 / 2014-09-12
+===================
+
+  * update contributors and authors
+  * travis: remove jruby-head
+  * use exchange_with and get_rate from VariableExchange
+  * tests: unify raise testing
+  * tests: @bank to subject
+  * Revert "travis: cache bundle remove 1.9.3,jruby"
+  * travis: cache bundle remove 1.9.3,jruby
+  * README: update
+  * update money gem to 6.2.1
+  * travis: added config
+
+v0.1.7 / 2014-04-15
+===================
+
+  * Bump to 0.1.7
+  * test: expire_rates implementation testing
+  * Remove useless boolean return for expire_rates
+  * Added pry gem for debug
+  * Add the ability to expire rates after a fixed amount of time
+  * test: use const for get rate
+  * update case description in spec
+  * getting rate implementation moved from #exchange_with to own method
+  * test: remove deprecation warning about money 6.1.0
+  * test: Remove RR deprecation warning
+  * Added license on gemspec
+  * README: typo
+
+v0.1.5 / 2013-07-11
+===================
+
+  * Added Rakefile for tests
+  * Merge pull request #10 from weynsee/remove_multi_json
+  * use vanilla json instead of multi_json
+  * require at least ruby 1.9.2
+  * fix failing tests
+  * use https protocol for rubygems.org to avoid warnings
+
+v0.1.1 / 2012-10-01
+===================
+
+  * Bump to v0.1.1
+  * Some cleanup in tests.
+  * Use TEST_APP_ID_PATH.
+  * Update README for tests and app_id.
+  * Refactoring to cope with Proc for cache, allowing greater flexibility
+  * Tidy up formatting
+  * Added app_id necessary for ongoing usage of OER API
+
+v0.0.7 / 2012-07-23
+===================
+
+  * Bump to v0.0.7
+  * Added contributors.
+  * Update documentation - update_rates must be called prior to attempting a currency conversation
+  * Raise unknown rate format if can't find an exchange rate (rather than FloatDomainError)
+
+v0.0.6 / 2012-05-08
+===================
+
+  * Added invalid json case for save_rates.
+  * Use cache for exchange test and use same_currency?
+  * Update spec for money 5.0.0 version.
+  * Make sure cache file isn't overwritten if json returns an error
+  * Don't error out when exchanging from a currency to itself even if there are no rates
+  * Restructure to prevent writing empty cache file, and add spec
+
+v0.0.5 / 2012-03-29
+===================
+
+  * Better tests.
+  * Fix over issue over integer type rate.
+  * overwrite cache file in a block to make sure it's closed after writing
+  * add failing test when calling update_rates after save_rates
+  * Remove warning: already initialized constant STRINGIFIED_KEYS
+  * make tests pass for money 4.0.2
+  * round numbers correctly to make tests pass in 1.8.7-p358
+
+v0.0.4 / 2011-12-11
+===================
+
+  * Skip exchange unknown by Money and fix tests.
+  * Sync latest openexchangerates.
+
+v0.0.3 / 2011-10-19
+===================
+
+  * Dont check file exist for a cache...
+
+v0.0.2 / 2011-10-19
+===================
+
+  * [bugfix] check file exist on filesystem.
+  * Initial commit.

data/lib/money/bank/open_exchange_rates_bank.rb

@@ -21,7 +21,7 @@ class Money
       OER_HISTORICAL_URL = 'http://openexchangerates.org/historical/%s.json'
       # OpenExchangeRates secure url
       SECURE_OER_URL = OER_URL.gsub('http:', 'https:')
-      SECURE_OER_HISTORICAL_URL = OER_URL.gsub('http:', 'https:')
+      SECURE_OER_HISTORICAL_URL = OER_HISTORICAL_URL.gsub('http:', 'https:')
 
       # use https to fetch rates from Open Exchange Rates
       # disabled by default to support free-tier users

data/lib/open_exchange_rates_bank/version.rb

@@ -1,4 +1,4 @@
 # Module for version constant
 module OpenExchangeRatesBank
-  VERSION = '0.4.0'
+  VERSION = '0.4.1'
 end

data/test/integration/Gemfile

@@ -0,0 +1,2 @@
+gem 'money'
+gem 'money-open-exchange-rates'

data/test/integration/Gemfile.lock

@@ -0,0 +1,22 @@
+GEM
+  specs:
+    i18n (0.7.0)
+    json (1.8.3)
+    monetize (1.3.1)
+      money (~> 6.6)
+    money (6.6.1)
+      i18n (>= 0.6.4, <= 0.7.0)
+    money-open-exchange-rates (0.4.0)
+      json (~> 1.8)
+      monetize (~> 1.3)
+      money (~> 6.6)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  money
+  money-open-exchange-rates
+
+BUNDLED WITH
+   1.10.6

data/test/open_exchange_rates_bank_test.rb

@@ -7,6 +7,9 @@ describe Money::Bank::OpenExchangeRatesBank do
     Money::Bank::OpenExchangeRatesBank::OER_HISTORICAL_URL
   end
   let(:oer_secure_url) { Money::Bank::OpenExchangeRatesBank::SECURE_OER_URL }
+  let(:oer_historical_secure_url) do
+    Money::Bank::OpenExchangeRatesBank::SECURE_OER_HISTORICAL_URL
+  end
 
   let(:temp_cache_path) do
     data_file('tmp.json')
@@ -151,22 +154,72 @@ describe Money::Bank::OpenExchangeRatesBank do
       subject.app_id = TEST_APP_ID
     end
 
-    it "should use the non-secure http url if secure_connection isn't set" do
-      subject.secure_connection = nil
-      subject.source_url.must_equal "#{oer_url}?app_id=#{TEST_APP_ID}"
-      subject.source_url.must_include 'http://'
-    end
+    describe 'historical' do
+      before do
+        subject.date = '2015-01-01'
+      end
+
+      def historical_url
+        format("#{oer_historical_url}?app_id=#{TEST_APP_ID}",
+               subject.date)
+      end
+
+      def historical_secure_url
+        format("#{oer_historical_secure_url}?app_id=#{TEST_APP_ID}",
+               subject.date)
+      end
+
+      it 'should use the non-secure http url if secure_connection is nil' do
+        subject.secure_connection = nil
+        subject.source_url.must_equal historical_url
+        subject.source_url.must_include 'http://'
+        subject.source_url.must_include 'historical'
+      end
+
+      it 'should use the non-secure http url if secure_connection is false' do
+        subject.secure_connection = false
+        subject.source_url.must_equal historical_url
+        subject.source_url.must_include 'http://'
+        subject.source_url.must_include 'historical'
+      end
 
-    it 'should use the non-secure http url if secure_connection is false' do
-      subject.secure_connection = false
-      subject.source_url.must_equal "#{oer_url}?app_id=#{TEST_APP_ID}"
-      subject.source_url.must_include 'http://'
+      it 'should use the secure https url if secure_connection is true' do
+        subject.secure_connection = true
+        subject.source_url.must_equal historical_secure_url
+        subject.source_url.must_include 'https://'
+        subject.source_url.must_include 'historical'
+      end
     end
 
-    it 'should use the secure https url if secure_connection is set to true' do
-      subject.secure_connection = true
-      subject.source_url.must_equal "#{oer_secure_url}?app_id=#{TEST_APP_ID}"
-      subject.source_url.must_include 'https://'
+    describe 'latest' do
+      def source_url
+        "#{oer_url}?app_id=#{TEST_APP_ID}"
+      end
+
+      def source_secure_url
+        "#{oer_secure_url}?app_id=#{TEST_APP_ID}"
+      end
+
+      it 'should use the non-secure http url if secure_connection is nil' do
+        subject.secure_connection = nil
+        subject.source_url.must_equal source_url
+        subject.source_url.must_include 'http://'
+        subject.source_url.must_include 'latest'
+      end
+
+      it 'should use the non-secure http url if secure_connection is false' do
+        subject.secure_connection = false
+        subject.source_url.must_equal source_url
+        subject.source_url.must_include 'http://'
+        subject.source_url.must_include 'latest'
+      end
+
+      it 'should use the secure https url if secure_connection is true' do
+        subject.secure_connection = true
+        subject.source_url.must_equal source_secure_url
+        subject.source_url.must_include 'https://'
+        subject.source_url.must_include 'latest'
+      end
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: money-open-exchange-rates
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Laurent Arnoud
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-28 00:00:00.000000000 Z
+date: 2015-12-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: money
@@ -187,12 +187,15 @@ extra_rdoc_files:
 - README.md
 files:
 - Gemfile
+- History.md
 - LICENSE
 - README.md
 - lib/money/bank/open_exchange_rates_bank.rb
 - lib/open_exchange_rates_bank/version.rb
 - test/data/2015-01-01.json
 - test/data/latest.json
+- test/integration/Gemfile
+- test/integration/Gemfile.lock
 - test/open_exchange_rates_bank_test.rb
 - test/test_helper.rb
 homepage: http://github.com/spk/money-open-exchange-rates
@@ -215,7 +218,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: A gem that calculates the exchange rate using published rates from open-exchange-rates.