money-historical-bank 0.0.3 → 0.0.4

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA256:
+  metadata.gz: 21c9ce9d3105a6853c5a8fb3a5de1f9db1c5176e25aba677987836b8e735b9e0
+  data.tar.gz: 98f96e0111260245d8174c0386599e01b8958232ddf815d75232b1e1093e711c
+SHA512:
+  metadata.gz: c8232d2f2ae42575bf588d3cb794d612c459272559b1fb89da875dfa1c8845a6db38790a04a8ab2a8c0f56d24730fa42f3f5bc92013cd9d266a32c6a9d47a8cf
+  data.tar.gz: cb9f96adacf27e06a544cad7b3d828e624ee84d9e7b19795bca6c219ca60834a60e1cb23a74138f367de295b9db1157626dbe84be68ec47cda272ed6968362f9

data/Gemfile

@@ -1,4 +1,4 @@
-source :rubygems
+source 'https://rubygems.org'
 
 gemspec
 

data/{README.markdown → README.md}

@@ -1,5 +1,4 @@
-# Money Historical Bank
-[![Build Status](https://secure.travis-ci.org/coutud/money-historical-bank.png)](http://travis-ci.org/coutud/money-historical-bank)
+# Money Historical Bank [![TravisCI][badge]][travis]
 
 A gem that add a `Money::Bank` able to handle historical rates, and infer rates from limited rates.
 
@@ -47,5 +46,7 @@ The above copyright notice and this permission notice shall be included in all c
 
 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 
-
 Copyright © 2012 Damien Couture <wam@atwam.com>
+
+[travis]: https://travis-ci.org/github/atwam/money-historical-bank
+[badge]: https://travis-ci.org/atwam/money-historical-bank.svg

data/lib/money/bank/historical_bank.rb

@@ -14,7 +14,7 @@ class Money
       attr_reader :rates
       # Available formats for importing/exporting rates.
       RATE_FORMATS = [:json, :ruby, :yaml]
-      
+
       def setup
         @rates = {}
         @mutex = Mutex.new
@@ -38,7 +38,7 @@ class Money
           internal_set_rate(date, from, to, rate)
         end
       end
-      
+
       # Retrieve the rate for the given currencies. Uses +Mutex+ to synchronize
       # data access. If no rates have been set for +date+, will try to load them
       # using #load_data.
@@ -60,9 +60,9 @@ class Money
       #   bank.get_rate(d2, "CAD", "USD") #=> 0.803115
       def get_rate(date, from, to)
         @mutex.synchronize do
-          unless existing_rates = @rates[date]
+          unless existing_rates = @rates[date.to_s]
             load_data(date)
-            existing_rates = @rates[date]
+            existing_rates = @rates[date.to_s]
           end
           rate = nil
           if existing_rates
@@ -90,7 +90,7 @@ class Money
           rate
         end
       end
-      
+
       #
       # @overload exchange_with(from, to_currency)
       #   Exchanges the given +Money+ object to a new +Money+ object in
@@ -144,9 +144,9 @@ class Money
         end
         _to_currency_  = Currency.wrap(to_currency)
 
-        cents = BigDecimal.new(from.cents.to_s) / (BigDecimal.new(from.currency.subunit_to_unit.to_s) / BigDecimal.new(_to_currency_.subunit_to_unit.to_s))
+        cents = BigDecimal(from.cents.to_s) / (BigDecimal(from.currency.subunit_to_unit.to_s) / BigDecimal(_to_currency_.subunit_to_unit.to_s))
 
-        ex = cents * BigDecimal.new(rate.to_s)
+        ex = cents * BigDecimal(rate.to_s)
         ex = ex.to_f
         ex = if block_given?
                yield ex
@@ -257,7 +257,7 @@ class Money
       # @return [Numeric]
       def internal_set_rate(date, from, to, rate)
         if Money::Currency.find(from) && Money::Currency.find(to)
-          date_rates = @rates[date] ||= {}
+          date_rates = @rates[date.to_s] ||= {}
           date_rates[rate_key_for(from, to)] = rate
         end
       end

data/lib/money/bank/open_exchange_rates_loader.rb

@@ -7,19 +7,19 @@ require 'open-uri'
 class Money
   module Bank
     module OpenExchangeRatesLoader
-      HIST_URL = 'http://openexchangerates.org/historical/'
-      OER_URL = 'http://openexchangerates.org/latest.json'
+      HIST_URL = 'https://openexchangerates.org/api/historical/'
+      OER_URL = 'https://openexchangerates.org/api/latest.json'
 
       # Tries to load data from OpenExchangeRates for the given rate.
       # Won't do anything if there's no data available for that date
       # in OpenExchangeRates (short) history.
       def load_data(date)
         rates_source = if date == Date.today
-                         OER_URL
+                         OER_URL.dup
                        else
-                         # Should we use strftime, does to_s have better performance ? Or is it localized accross systems ?
-                         HIST_URL + date.to_s + '.json'
+                         HIST_URL + date.strftime('%Y-%m-%d') + '.json'
                        end
+        rates_source << "?app_id=#{ENV['OPENEXCHANGERATES_APP_ID']}" if ENV['OPENEXCHANGERATES_APP_ID']
         doc = Yajl::Parser.parse(open(rates_source).read)
 
         base_currency = doc['base'] || 'USD'

data/test/historical_bank_test.rb

@@ -17,14 +17,14 @@ describe Money::Bank::HistoricalBank do
       @bank.set_rate(d1, "USD", "EUR", 1.234)
       @bank.set_rate(d2, "GBP", "USD", 1.456)
 
-      @bank.get_rate(d1, "USD", "EUR").must_equal 1.234
-      @bank.get_rate(d2, "GBP", "USD").must_equal 1.456
+      assert_equal @bank.get_rate(d1, "USD", "EUR"), 1.234
+      assert_equal @bank.get_rate(d2, "GBP", "USD"), 1.456
     end
 
     it "shouldn't throw an error when internal_set_rate is called with a non existing currency" do
       d1 = Date.new(2011,1,1)
       @bank.set_rate(d1, "BLA", "ZZZ", 1.01)
-      @bank.rates.must_be_empty
+      assert_empty @bank.rates
     end
 
     it "should return the correct rate interpolated from existing pairs when asked" do
@@ -32,37 +32,73 @@ describe Money::Bank::HistoricalBank do
       @bank.set_rate(d1, "USD", "EUR", 1.234)
       @bank.set_rate(d1, "GBP", "USD", 1.456)
 
-      @bank.get_rate(d1, "EUR", "USD").must_be_within_epsilon 1.0 / 1.234
-      @bank.get_rate(d1, "GBP", "EUR").must_be_within_epsilon 1.456 * 1.234
+      assert_in_epsilon @bank.get_rate(d1, "EUR", "USD"), 1.0 / 1.234
+      assert_in_epsilon @bank.get_rate(d1, "GBP", "EUR"), 1.456 * 1.234
     end
 
     it "should return the correct rates using exchange_with a date" do
       d1 = Date.new(2001,1,1)
       @bank.set_rate(d1, "USD", "EUR", 0.73062465)
-      @bank.exchange_with(d1, 5000.to_money('EUR'), 'USD').cents.must_equal 684345
+      from = Money.new(5000, 'EUR')
+      assert_equal @bank.exchange_with(d1, from, 'USD').cents, 6843
     end
     it "should return the correct rates using exchange_with no date (today)" do
       d1 = Date.today
       @bank.set_rate(d1, "USD", "EUR", 0.8)
-      @bank.exchange_with(5000.to_money('EUR'), 'USD').cents.must_equal 625000
+      from = Money.new(5000, 'EUR')
+      assert_equal @bank.exchange_with(from, 'USD').cents, 6250
     end
 
   end
 
   describe 'no rates available yet' do
-    include RR::Adapters::TestUnit
     before do
       @bank = Money::Bank::HistoricalBank.new
       @cache_path = "#{File.dirname(__FILE__)}/test.json"
+      ENV['OPENEXCHANGERATES_APP_ID'] = nil
     end
 
     it 'should download new rates from url' do
       source = Money::Bank::OpenExchangeRatesLoader::HIST_URL + '2009-09-09.json'
       stub(@bank).open(source) { File.open @cache_path }
       d1 = Date.new(2009,9,9)
-      
+
       rate = @bank.get_rate(d1, 'USD', 'EUR')
-      rate.must_equal 0.73062465
+      assert_equal rate, 0.73062465
+    end
+
+    describe 'environment variable set with api id' do
+      before do
+        ENV['OPENEXCHANGERATES_APP_ID'] = 'example-of-app-id'
+      end
+      it 'should download new rates from url' do
+        source = Money::Bank::OpenExchangeRatesLoader::HIST_URL + '2009-09-09.json' + '?app_id=example-of-app-id'
+        stub(@bank).open(source) { File.open @cache_path }
+        d1 = Date.new(2009,9,9)
+
+        rate = @bank.get_rate(d1, 'USD', 'EUR')
+        assert_equal rate, 0.73062465
+      end
+    end
+
+
+  end
+
+  describe 'export/import' do
+    before do
+      @bank = Money::Bank::HistoricalBank.new
+    end
+    it "should store any rate stored for a date, and retrieve it after importing exported json" do
+      d1 = Date.new(2001,1,1)
+      d2 = Date.new(2002,1,1)
+      @bank.set_rate(d1, "USD", "EUR", 1.234)
+      @bank.set_rate(d2, "GBP", "USD", 1.456)
+
+      json = @bank.export_rates(:json)
+      @bank.import_rates(:json, json)
+
+      assert_equal @bank.get_rate(d1, "USD", "EUR"), 1.234
+      assert_equal @bank.get_rate(d2, "GBP", "USD"), 1.456
     end
   end
 

data/test/test_helper.rb

@@ -3,3 +3,5 @@ require 'minitest/autorun'
 require 'rr'
 require 'date'
 require 'money/bank/historical_bank'
+
+Money.rounding_mode = BigDecimal::ROUND_HALF_EVEN

metadata

@@ -1,100 +1,137 @@
 --- !ruby/object:Gem::Specification
 name: money-historical-bank
 version: !ruby/object:Gem::Version
-  version: 0.0.3
-  prerelease: 
+  version: 0.0.4
 platform: ruby
 authors:
 - atwam
+- Jon Allured
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-06-26 00:00:00.000000000 Z
+date: 2020-09-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: yajl-ruby
-  requirement: &70316487507440 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.8.3
+        version: '1.3'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.3.1
   type: :runtime
   prerelease: false
-  version_requirements: *70316487507440
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.3.1
 - !ruby/object:Gem::Dependency
   name: money
-  requirement: &70316487512020 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '6'
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.7.1
+        version: 6.13.1
   type: :runtime
   prerelease: false
-  version_requirements: *70316487512020
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '6'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 6.13.1
 - !ruby/object:Gem::Dependency
   name: minitest
-  requirement: &70316487531960 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '5.0'
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5'
   type: :development
   prerelease: false
-  version_requirements: *70316487531960
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '5.0'
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5'
 - !ruby/object:Gem::Dependency
   name: rr
-  requirement: &70316487543520 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.0.4
   type: :development
   prerelease: false
-  version_requirements: *70316487543520
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.0.4
 description: A gem that provides rates for the money gem. Able to handle history (rates
   varying in time), and auto download rates from open-exchange-rates. Highly inspired
   by money-open-exchange-rates gem.
-email: wam@atwam.com
+email:
+- wam@atwam.com
+- jon.allured@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files:
-- README.markdown
+- README.md
 files:
-- LICENSE
-- README.markdown
 - Gemfile
+- LICENSE
+- README.md
 - lib/money/bank/historical_bank.rb
 - lib/money/bank/open_exchange_rates_loader.rb
 - test/historical_bank_test.rb
 - test/test.json
 - test/test_helper.rb
 homepage: http://github.com/atwam/money-historical-bank
-licenses: []
+licenses:
+- MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 1.8.10
+rubygems_version: 3.0.3
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: A gem that offers exchange rates varying in time.
 test_files:
 - test/historical_bank_test.rb