money-currencylayer-bank 0.7.1 → 0.7.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c3f50af5ecdfe22212d99381d062f3db9bec09415f0734b54db59b64a8f42d47
-  data.tar.gz: 60aebccb74c462df8a0a8d7c48a73e86f8bb75f52c6520c7478792475416087c
+  metadata.gz: 0a9b7e40df85ebecee86ea25885a6e6f7b693855fe1674ddf54a41eb6af4b13e
+  data.tar.gz: 81eb04b152bb0bdb5c70bf55781e105aec71bf4f72aed5aa927c45974d399367
 SHA512:
-  metadata.gz: e0dd0f1cf80928b7b293ae220bdd684701aa5a03eee129520505940baef899225f27a360ff13a04798f51607a8802a551376eb0e025942266389788b1ddb93fb
-  data.tar.gz: 41fce81a38a14709b7439751d7ab3d1c944fb901eb9749a68cfbbc02b623d2809838a3849cb35e6679a71eeaef85d171fe008f7cba7a0d5a491fc88369c6a17f
+  metadata.gz: 1848cea60b4f6b925a6ff36cc9528726c7f4a996c393488e4cdfcbe73ee4b1a7d59539862a64582fa15d3419359855de0ae51bbc10dc29980d9bcf74ed8a31a9
+  data.tar.gz: 7187dbc293cb09e380f01ed2b09bf0ad15f7a8dcb0cb3f59decbff86859b4109e792a3f10b73cf36f44424452ad586c9f71305b954433ae6f7955e86b6926635

data/Gemfile

@@ -3,9 +3,3 @@
 source 'https://rubygems.org'
 
 gemspec
-
-group :test, :development do
-  platforms :ruby_19, :jruby_19 do
-    gem 'tins', '~> 1.6'
-  end
-end

data/lib/money/bank/currencylayer_bank.rb

@@ -1,4 +1,3 @@
-# encoding: UTF-8
 # frozen_string_literal: true
 
 require 'open-uri'
@@ -12,10 +11,10 @@ class Money
     # Memory class
     class Memory
       # Add method to reset the build in memory store
-      # @param [Hash] rt Optional initial exchange rate data.
+      # @param [Hash] rtd Optional initial exchange rate data.
       # @return [Object] store.
-      def reset!(rt = {})
-        transaction { @index = rt }
+      def reset!(rtd = {})
+        transaction { @index = rtd }
       end
     end
   end
@@ -123,6 +122,7 @@ class Money
           currency = exchange_rate.first[3..-1]
           rate = exchange_rate.last
           next unless Money::Currency.find(currency)
+
           add_rate(source, currency, rate)
           add_rate(currency, source, 1.0 / rate)
         end
@@ -135,7 +135,7 @@ class Money
       # @param [String] to_currency Currency ISO code. ex. 'CAD'
       # @param [Numeric] rate Rate to use when exchanging currencies.
       # @return [Numeric] rate.
-      def add_rate(from_currency, to_currency, rate)
+      def add_rate(from_currency, to_currency, rate) # rubocop:disable Lint/UselessMethodDefinition
         super
       end
 
@@ -188,6 +188,7 @@ class Money
       # @return [String] the remote API url
       def source_url
         raise NoAccessKey if access_key.nil? || access_key.empty?
+
         url = "#{currencylayer ? URL_CL : URL_AL}?source=#{source}"
         url = url.sub('http:', 'https:') if secure_connection
         url = "#{url}&access_key=#{access_key}" if currencylayer
@@ -218,9 +219,10 @@ class Money
       # @param text [String] parsed JSON content
       # @return [String,Integer]
       def store_in_cache(text)
-        if cache.is_a?(Proc)
+        case cache
+        when Proc
           cache.call(text)
-        elsif cache.is_a?(String) || cache.is_a?(Pathname)
+        when String, Pathname
           write_to_file(text)
         end
       end
@@ -258,7 +260,7 @@ class Money
       # Opens an url and reads the content
       # @return [String] unparsed JSON content
       def open_url
-        currencylayer ? URI.open(source_url).read : URI.open(source_url, apikey: access_key).read
+        currencylayer ? URI.open(source_url).read : URI.open(source_url, 'apikey' => access_key).read
       rescue OpenURI::HTTPError
         ''
       end

data/test/currencylayer_bank_test.rb

@@ -1,4 +1,3 @@
-# encoding: UTF-8
 # frozen_string_literal: true
 
 require File.expand_path(File.join(File.dirname(__FILE__), 'test_helper'))
@@ -81,7 +80,7 @@ describe Money::Bank::CurrencylayerBank do
     it 'should allow update after save' do
       begin
         subject.update_rates
-      rescue
+      rescue e
         assert false, 'Should allow updating after saving'
       end
     end
@@ -217,8 +216,9 @@ describe Money::Bank::CurrencylayerBank do
     end
 
     it 'should update itself with exchange rates from CurrencylayerBank' do
-      subject.rates.keys.each do |currency|
+      subject.rates.each_key do |currency|
         next unless Money::Currency.find(currency)
+
         subject.get_rate('USD', currency).must_be :>, 0
       end
     end

data/test/test_helper.rb

@@ -1,4 +1,3 @@
-# encoding: UTF-8
 # frozen_string_literal: true
 
 require 'minitest/autorun'
@@ -15,3 +14,10 @@ if TEST_ACCESS_KEY.nil? || TEST_ACCESS_KEY.empty?
   raise "Please add a valid access key to file #{TEST_ACCESS_KEY_PATH} or to " \
     ' TEST_ACCESS_KEY environment'
 end
+
+# Overwrite open-uri open method for tests with data from file instead of Url.
+module URI
+  def self.open(name, *_rest, &_block)
+    Kernel.open(name)
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: money-currencylayer-bank
 version: !ruby/object:Gem::Version
-  version: 0.7.1
+  version: 0.7.2
 platform: ruby
 authors:
 - Egon Zemmer
@@ -11,19 +11,19 @@ cert_chain: []
 date: 2022-10-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: money
+  name: json
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '6.7'
+        version: '1.8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '6.7'
+        version: '1.8'
 - !ruby/object:Gem::Dependency
   name: monetize
   requirement: !ruby/object:Gem::Requirement
@@ -39,117 +39,117 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.4'
 - !ruby/object:Gem::Dependency
-  name: json
+  name: money
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.8'
+        version: '6.7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.8'
+        version: '6.7'
 - !ruby/object:Gem::Dependency
-  name: minitest
+  name: inch
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.8'
+        version: '0.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.8'
+        version: '0.8'
 - !ruby/object:Gem::Dependency
-  name: minitest-line
+  name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.6'
+        version: '5.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.6'
+        version: '5.8'
 - !ruby/object:Gem::Dependency
-  name: rr
+  name: minitest-line
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.1'
+        version: '0.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.1'
+        version: '0.6'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.0'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.0'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
-  name: timecop
+  name: rr
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.8.1
+        version: '3.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.8.1
+        version: '3.1'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.49.1
+        version: 1.36.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.49.1
+        version: 1.36.0
 - !ruby/object:Gem::Dependency
-  name: inch
+  name: timecop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.7.1
+        version: 0.9.5
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.7.1
+        version: 0.9.5
 description: A gem that calculates the exchange rate using published rates from currencylayer.com
   and apilayer.com. Compatible with the money gem.
 email: office@phlegx.com
@@ -178,14 +178,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 1.9.3
+      version: '2.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.7
 requirements: []
-rubygems_version: 3.2.24
+rubygems_version: 3.3.24
 signing_key: 
 specification_version: 4
 summary: A gem that calculates the exchange rate using published rates from currencylayer.com