moneta-api 1.8.0 → 1.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4b259ad7ef797550ed047b3c8574a71e52b97f2e
-  data.tar.gz: ebc37bd7040d7fce6868e23d90704000827a5f7e
+  metadata.gz: 707c0f3b41b40cb9cd00965f1d619f9a674a329d
+  data.tar.gz: dfa069b11ecddc4ef7d50eae311589e712d0040b
 SHA512:
-  metadata.gz: d3a331bb23264266da8355fac205bb0287b253e84e6e03a1dd1e9134a433db26bd6d9557814d6c56e55e5b824a625794fa861f2729284133300163474b111a07
-  data.tar.gz: fe34ca732de7d0a369e3637ad99574d3c0efda9de2229a4145e6162342089276cc6ff7fe4bc6cf3cf7e0b4603b1383c7587d21a10e289f03df65409862cc5414
+  metadata.gz: 229958ad7ddb8837d51b0cde673a075f42a40befeabb55f6efb1c28cad8a3bc1444f76573e654034eec45888e74d5293875966c3155ec0752e2f7c471925e0dd
+  data.tar.gz: c6e3d3f19827dfd8a3f2e9ab3101a07dc3bb61c44e61912795eb7bf67529251f9966b5bd4ae60e7436f5d8e1602ab43355eaf9b88a880662b71e95c62ef635af

data/lib/moneta/api/http_exception.rb

@@ -1,17 +1,10 @@
 module Moneta
   module Api
     class HTTPException < Exception
-      attr_reader :code
-
-      def initialize(code, message)
-        super(message)
-
-        @code = code
-      end
-
+      attr_accessor :code
 
       def inspect
-        "#{ @code }: #{ message }"
+        "#{ code }: #{ message }"
       end
 
       def to_hash

data/lib/moneta/api/runtime_exception.rb

@@ -1,17 +1,10 @@
 module Moneta
   module Api
     class RuntimeException < Exception
-      attr_reader :code, :detail
-
-      def initialize(code, message, detail)
-        super(message)
-
-        @code = code
-        @detail = detail
-      end
+      attr_accessor :code, :detail
 
       def inspect
-        error = [ "#{ @code }: #{ message }" ]
+        error = [ "#{ code }: #{ message }" ]
         error += detail.collect { |key, value| "#{ key }: #{ Array(value).join($/) }" }
         error.join($/)
       end

data/lib/moneta/api/service_methods.rb

@@ -192,16 +192,20 @@ module Moneta
 
         ResponseFactory.build(response)
       rescue Savon::SOAPFault => e
-        error_details = e.to_hash[:fault]
+        details = e.to_hash[:fault]
 
-        message = error_details[:faultstring]
-        code = error_details[:faultcode]
-        detail = error_details[:detail]
+        exception = Moneta::Api::RuntimeException.new(details[:faultstring])
+        exception.code = details[:faultcode]
+        exception.detail = details[:detail]
 
-        raise Moneta::Api::RuntimeException.new(code, message, detail)
+        raise exception
       rescue Savon::HTTPError => e
         http = e.http
-        raise Moneta::Api::HTTPException.new(http.code, http.body)
+
+        exception = Moneta::Api::HTTPException.new(http.body)
+        exception.code = http.code
+
+        raise exception
       rescue HTTPI::Error => e
         raise Moneta::Api::ConnectionException.new(e.message)
       end

data/lib/moneta/api/version.rb

@@ -1,5 +1,5 @@
 module Moneta
   module Api
-    VERSION = '1.8.0'
+    VERSION = '1.9.0'
   end
 end

data/spec/lib/moneta/api/http_exception_spec.rb

@@ -2,7 +2,7 @@ describe Moneta::Api::HTTPException do
   let(:message) { 'Server Error' }
   let(:code) { '500' }
 
-  let(:exception) { described_class.new(code, message) }
+  let(:exception) { described_class.new(message).tap { |e| e.code = code } }
 
   describe '.to_hash' do
     subject { exception.to_hash }

data/spec/lib/moneta/api/runtime_exception_spec.rb

@@ -3,7 +3,12 @@ describe Moneta::Api::RuntimeException do
   let(:code) { 'SOAP-ENV:Client' }
   let(:detail) { { foo: ['bar'] } }
 
-  let(:exception) { described_class.new(code, message, detail) }
+  let(:exception) do
+    described_class.new(message).tap do |e|
+      e.code = code
+      e.detail = detail
+    end
+ end
 
   describe '.to_hash' do
     subject { exception.to_hash }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: moneta-api
 version: !ruby/object:Gem::Version
-  version: 1.8.0
+  version: 1.9.0
 platform: ruby
 authors:
 - ssnikolay