momm 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a45aa436a6e5e383aa428d867a364275fd238200
-  data.tar.gz: 69436a4520944e7e6be27f0d6029e5412c7943b0
+  metadata.gz: 88f614087dabe0ac7ecef7529fd568c0c1ddb058
+  data.tar.gz: 03a1106a8ecaf7d43d0589b2ebdb6b0fcb79ee46
 SHA512:
-  metadata.gz: 24bda37e47c9f1e8d450b41ae9ddf2ed94723d0d609affb54757c3f5343bfd8076537c80cd51b0f4529f29425b3f73da7d1ae01e47e6cc5389da52c62c85c344
-  data.tar.gz: 9b0f5931df09c80d82348bcda08bd6eea49e46d05d44cc6eb0097f4eff258417b8104960039a6e652fd529cb449e3cb87fea96cebdfa536b8f3a233165e35c21
+  metadata.gz: f6d66f452241aeac2a0ebf7003fd42880a228b47423a99f7edb8a6a8c6fcf926a3dd9ea04844d1ec958273804cf4b12c398e2381a2d32cc0854e1e4b1973c116
+  data.tar.gz: 12575b5a233a3c8a088a9a7b0c5f649237e1c9a7453023b4f5568b0b4bf0324b2bdb8ca3521895506c80477ec9a69df898024dd5180bb555e2dfe639bad22082

data/README.md

@@ -59,6 +59,7 @@ After the gem is installed, momm provide you a command line tool. The storage en
 ```
   $ momm rate GBP CNY                  # Exchange rate by default is today.
   $ momm exchange 100 GBP USD 2014-3-1 # Exchange rate at 2013-3-1
+  $ momm update                        # Fetch feeds from remote and update the storage
 ```
 
 #### Ruby
@@ -75,6 +76,8 @@ After the gem is installed, momm provide you a command line tool. The storage en
   Momm.exchange 100, 'GBP', 'USD', date: Date.today
   Momm.exchange_from_gbp_to_usd 100
   Momm.exchange_from_gbp_to_usd 100, date: "2014-3-4"
+
+  Momm.update! # Fetching the feeds from remote. Only do that if you find any abnormal.
 ```
 
 #### Configuration

data/bin/momm

@@ -4,7 +4,7 @@ $LOAD_PATH << File.dirname(__FILE__) + "/../lib" if $0 == __FILE__
 require 'optparse'
 require 'momm'
 
-OPERATIONS = %w{rate exchange}
+OPERATIONS = %w{rate exchange update}
 
 option_parser = OptionParser.new do |opts|
   opts.banner = Momm::BANNER
@@ -15,7 +15,7 @@ Supported commands:
 
  rate [country_code] [country_code] [YYYY-MM-DD]                   Display rate!
  exchange [money] [country_code] [country_code] [YYYY-MM-DD]       Exchange for you!
-
+ update                                                            Fetch feeds from Remote!
 Examples:
  momm exchange 20 GBP CNY      Convert the between currencies
  momm rate GBP CNY             Simply display the rate
@@ -57,6 +57,8 @@ if OPERATIONS.include?(op)
       end
 
       puts Momm.exchange money, from, to, date: date
+    when "update"
+      puts Momm.update!
     end
 
   rescue ArgumentError => ex

data/lib/momm.rb

@@ -54,17 +54,14 @@ module Momm
     # delegate the exchange, :currencies, exchange_rate,
     # as well as meta programmed methods to module level
     delegate [:currencies, :exchange, :exchange_rate,
-        :method_missing, :respond_to?] => :calculator
+        :method_missing, :respond_to?, :update! ] => :calculator
 
     private
 
     # Delegate the calculator
     def calculator
-      @calculator ||= if storage || feed
-        Calculator.new storage, feed
-      else
-        Calculator.new
-      end
+      @calculator = Calculator.new(
+        (storage || Memcached.new), (feed || Feeds::ECB.instance))
     end
   end
 

data/lib/momm/calculator.rb

@@ -16,14 +16,25 @@ module Momm
 
     attr_reader :storage, :feed
 
-    # delegate the client and update method from storage
-    delegate [:client, :update, :set_rate] => :storage
+    # delegate the client and set_rate method from storage
+    delegate [:client, :set_rate] => :storage
 
     # delegate the currencies method from feed
     delegate :currencies => :feed
 
-    # delegate the get rate method with a different naming
+    # delegate methods with different naming for overriding
     def_delegator :storage, :get_rate, :get_rate_origin
+    def_delegator :storage, :update, :origin_update
+
+
+    # Update the feeds. In most case, you do not need to call this,
+    # because Momm will update the feeds everytime she find something missing ;)
+    # == Returns
+    # nil
+    #
+    def update!
+      origin_update(feed.currency_rates)
+    end
 
     # Exchange Rate
     #
@@ -101,7 +112,7 @@ module Momm
       res = get_rate_origin(from, date)
       return res if res != 0 && res
 
-      update(feed.currency_rates)
+      update!
       get_rate_origin(from, date)
     end
 

data/lib/momm/memcached.rb

@@ -11,8 +11,8 @@ module Momm
 
     def initialize(options={})
       _options = DEFAULT_OPTIONS.dup.merge options
-      @connection = options.delete(:connection)
-      @options = options
+      @connection = _options.delete(:connection)
+      @options = _options
     end
 
     def client

data/lib/momm/storage.rb

@@ -54,13 +54,13 @@ module Momm
     #   An array looks like [{date: Date.now, currency: :CNY, rate: 1.23} ...]
     #
     # == Returns
-    # nil
+    # "OK"
     #
     def update(data)
       data.each do |d|
         set_rate d[:currency], d[:rate], d[:date]
       end
-      nil
+      "OK"
     end
 
     NotImplementedError = Class.new(StandardError)

data/lib/momm/version.rb

@@ -1,3 +1,3 @@
 module Momm
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/spec/momm/calculator_spec.rb

@@ -9,10 +9,6 @@ describe Momm::Calculator do
       calc.should respond_to :client
     end
 
-    it 'should response to update' do
-      calc.should respond_to :update
-    end
-
     it 'should response to set_rate' do
       calc.should respond_to :set_rate
     end
@@ -41,8 +37,8 @@ describe Momm::Calculator do
       calc.should respond_to :client
     end
 
-    it 'should response to update' do
-      calc.should respond_to :update
+    it 'should response to update!' do
+      calc.should respond_to :update!
     end
 
     it 'should response to set_rate' do

data/spec/momm/memcached_spec.rb

@@ -27,6 +27,8 @@ describe Momm::Memcached do
       money = rand(20)
       momm.set_rate :USD, money
       momm.get_rate(:USD).should == money
+
+      Momm.update!
     end
   end
 end

data/spec/momm/momm_spec.rb

@@ -17,5 +17,17 @@ describe Momm do
     it "should respond to exchange_rate_from_gbp_to_usd" do
       Momm.should respond_to :exchange_rate_from_gbp_to_usd
     end
+
+    it "should respond to update!" do
+      Momm.should respond_to :update!
+    end
+  end
+
+  context ".store" do
+    it "should be successfully switch to redis store halfway" do
+      Momm.store :redis_store
+      Momm.send(:calculator).storage.client.should be_a(Redis::Namespace)
+      Momm.store :memcached
+    end
   end
 end

data/spec/momm/redis_store_spec.rb

@@ -30,6 +30,8 @@ describe Momm::RedisStore do
 
       calc.set_rate :USD, money
       calc.get_rate(:USD).should == money
+
+      Momm.update!
     end
   end
 end

data/spec/momm/version_spec.rb

@@ -2,6 +2,6 @@ require 'spec_helper'
 
 describe 'momm version' do
   it 'should be correct' do
-    Momm::VERSION.should == '0.0.3'
+    Momm::VERSION.should == '0.0.4'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: momm
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Jingkai He