moments 0.0.2.alpha → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 50e1bdbcf9a083bb6213223ff6f9558bb8871c0f
-  data.tar.gz: b5657505ec91e49a9ca89de5a0e299a7c5fec436
+SHA256:
+  metadata.gz: 2cfe9d93c489151bacb9c2c4b8de955a038db05cddf2a6d7edcb60c24532f8f3
+  data.tar.gz: be776d177f3878449fb8aabab929cbe84bb31965e428cef9c31bd72d3ce964a7
 SHA512:
-  metadata.gz: e1c3176a225c6674a199dee03fe9d60912fb71f3eaa4adfa9d88f1c2e4a2215e7d3dfc9b5c76136de67a6945cf80fca4f4c96451de34379c347dac377ea10676
-  data.tar.gz: df0f0200d5bf1a5b8164751cbc4c242e79dc5de030302931de003fe88c14a5de3a95b511fd2898caabb1e147be8b592c0780052052ec49a11ab965543be1a48d
+  metadata.gz: 6b231e18ee429b37402e44571866f860a57e8b86957db6a18a75463fb6c3e325b7b7ec5dfe1da62d01259d78b749f3272bbd1c3078c268b8d1fbfcb70a3e55db
+  data.tar.gz: fab01ca909e9c5418ad1ca734a4709e11a81effe6bc283bf8cb5174f2d62548d29bd7a3bedc85be2c2b23902f6f614694bc45dc229184bb657c00bf0373dfdf4

data/.editorconfig

@@ -0,0 +1,12 @@
+# http://editorconfig.org
+
+root = true
+
+[*]
+charset = utf-8
+indent_style = space
+indent_size = 2
+end_of_line = lf
+insert_final_newline = true
+trim_trailing_whitespace = true
+max_line_length = 100

data/.gitignore

@@ -24,3 +24,5 @@ mkmf.log
 *.iml
 *.ipr
 *.iws
+.idea/
+.ruby-version

data/.rspec

@@ -1,2 +1,4 @@
+--warnings
 --color
 --format documentation
+--require spec_helper

data/.rubocop.yml

@@ -0,0 +1,42 @@
+Layout/LineLength:
+  Max: 100
+Layout/MultilineOperationIndentation:
+  EnforcedStyle: indented
+Layout/ArgumentAlignment:
+  EnforcedStyle: with_fixed_indentation
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+
+Lint/DeprecatedOpenSSLConstant:
+  Enabled: true
+Lint/MixedRegexpCaptureTypes:
+  Enabled: true
+Lint/RaiseException:
+  Enabled: true
+Lint/StructNewOverride:
+  Enabled: true
+
+Style/ExponentialNotation:
+  Enabled: true
+Style/HashEachMethods:
+  Enabled: true
+Style/HashTransformKeys:
+  Enabled: true
+Style/HashTransformValues:
+  Enabled: true
+Style/RedundantFetchBlock:
+  Enabled: true
+Style/RedundantRegexpCharacterClass:
+  Enabled: true
+Style/RedundantRegexpEscape:
+  Enabled: true
+Style/SlicingWithRange:
+  Enabled: true
+
+Metrics/ParameterLists:
+  CountKeywordArgs: false
+Metrics/BlockLength:
+  Exclude:
+    - spec/**/*

data/.travis.yml

@@ -1,10 +1,12 @@
+sudo: false
+cache: bundler
 language: ruby
 script: "bundle exec rspec"
+before_install:
+  - gem update --system
+  - gem --version
+  - bundle install
 rvm:
-  - 2.1.5
-  - jruby-19mode
-  - ruby-head
-  - jruby-head
-addons:
-  code_climate:
-    repo_token: 83c2e090282b16d91251419d1258e47c82d725056835a1daef193077cbb2a0e6
+  - 2.5.0
+  - 2.6.0
+  - 2.7.0

data/CHANGELOG.md

@@ -0,0 +1,32 @@
+# Changelog
+
+## [v0.1.0](https://github.com/excpt/moments/tree/v0.1.0) (2020-08-18)
+
+[Full Changelog](https://github.com/excpt/moments/compare/v0.0.2.alpha...v0.1.0)
+
+**Closed issues:**
+
+- Replace Travis CI with another CI [\#3](https://github.com/excpt/moments/issues/3)
+
+**Merged pull requests:**
+
+- Fix `\#in\_\*` for times with miliseconds [\#6](https://github.com/excpt/moments/pull/6) ([AlexWayfer](https://github.com/AlexWayfer))
+- Fix diffs with different timezones, `Date` diffs and `\#in\_years` [\#5](https://github.com/excpt/moments/pull/5) ([AlexWayfer](https://github.com/AlexWayfer))
+- Add `\#in\_\*` methods, like `\#in\_seconds` [\#4](https://github.com/excpt/moments/pull/4) ([AlexWayfer](https://github.com/AlexWayfer))
+- Many improvements [\#2](https://github.com/excpt/moments/pull/2) ([AlexWayfer](https://github.com/AlexWayfer))
+
+## [v0.0.2.alpha](https://github.com/excpt/moments/tree/v0.0.2.alpha) (2014-11-14)
+
+[Full Changelog](https://github.com/excpt/moments/compare/v0.0.1.alpha...v0.0.2.alpha)
+
+## [v0.0.1.alpha](https://github.com/excpt/moments/tree/v0.0.1.alpha) (2014-05-26)
+
+[Full Changelog](https://github.com/excpt/moments/compare/9b7612483150b52000ab4948d5c2217945230a1d...v0.0.1.alpha)
+
+**Closed issues:**
+
+- Test ticket from Code Climate [\#1](https://github.com/excpt/moments/issues/1)
+
+
+
+\* *This Changelog was automatically generated by [github_changelog_generator](https://github.com/github-changelog-generator/github-changelog-generator)*

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 gemspec

data/README.md

@@ -1,5 +1,6 @@
 # Moments [![Gem Version](https://badge.fury.io/rb/moments.svg)](http://badge.fury.io/rb/moments)
 
+[![Codeship Status for excpt/moments](https://codeship.com/projects/54ff9970-675f-0132-a1ba-760b27c1e7ed/status?branch=master)](https://codeship.com/projects/53081)
 [![Build Status](https://travis-ci.org/excpt/moments.svg?branch=master)](https://travis-ci.org/excpt/moments)
 [![Code Climate](https://codeclimate.com/github/excpt/moments.png)](https://codeclimate.com/github/excpt/moments)
 [![Test Coverage](https://codeclimate.com/github/excpt/moments/badges/coverage.svg)](https://codeclimate.com/github/excpt/moments)
@@ -11,29 +12,38 @@ Handles time differences and calculations.
 
 Add this line to your application's Gemfile:
 
-    gem 'moments'
+```ruby
+gem 'moments'
+```
 
 And then execute:
 
-    $ bundle
+```sh
+$ bundle
+```
 
 Or install it yourself as:
 
-    $ gem install moments
+```sh
+$ gem install moments
+```
 
 ## Usage
 
 ```ruby
 require 'moments'
 
-t1 = Time.now
-t2 = Time.new 2020, 1, 1
+t1 = Time.new 2015, 1, 1, 0, 0, 0
+t2 = Time.now # 2020, 8, 6, 19, 29, 6
 
-# Important: For now t1 must be equal or less than t2
 diff = Moments.difference t1, t2
 
 puts diff.to_hash
-# Output {:years=>5, :months=>7, :days=>5, :hours=>19, :minutes=>29, :seconds=>6}
+# { years: 5, months: 7, days: 5, hours: 19, minutes: 29, seconds: 6 }
+
+puts diff.in_months
+# 67 (5 * 12 + 7)
+# there are also methods for each component
 ```
 
 ## Contributing

data/Rakefile

@@ -1,2 +1,3 @@
-require "bundler/gem_tasks"
+# frozen_string_literal: true
 
+require 'bundler/gem_tasks'

data/lib/moments.rb

@@ -1,6 +1,9 @@
-require 'moments/version'
-require 'moments/difference'
+# frozen_string_literal: true
 
+require_relative 'moments/version'
+require_relative 'moments/difference'
+
+# Entrypoint for the moments gem
 module Moments
   def self.difference(from, to)
     Moments::Difference.new from, to

data/lib/moments/difference.rb

@@ -1,13 +1,34 @@
+# frozen_string_literal: true
+
+require 'date'
+
 module Moments
+  # Calculates differences between two given Time instances.
   class Difference
+    DATE_PARTS = {
+      years: :year,
+      months: :month,
+      days: :day
+    }.freeze
+
+    TIME_PARTS = {
+      hours: :hour,
+      minutes: :min,
+      seconds: :sec
+    }.freeze
+
+    private_constant :DATE_PARTS, :TIME_PARTS
+
+    # == Parameters:
+    # from::
+    #   A instance of Time
+    # to::
+    #   A instance of Time
     def initialize(from, to)
-      @from = from
-      @to   = to
+      @from = parse_argument from
+      @to = parse_argument to
 
-      if past?
-        message = "Start date (#{from}) must be less or equal than the end date (#{@to})."
-        raise ArgumentError.new(message)
-      end
+      @ordered_from, @ordered_to = [@from, @to].sort
 
       precise_difference
     end
@@ -28,15 +49,61 @@ module Moments
       @from > @to
     end
 
+    def in_seconds
+      @ordered_to.to_i - @ordered_from.to_i
+    end
+
+    def in_minutes
+      in_seconds / 60
+    end
+
+    def in_hours
+      in_minutes / 60
+    end
+
+    def in_days
+      in_hours / 24
+    end
+
+    def in_months
+      months_diff = @ordered_to.month - @ordered_from.month
+      months_diff -= 1 if months_diff.positive? && @ordered_to.mday < @ordered_from.mday
+
+      (@ordered_to.year - @ordered_from.year) * 12 + months_diff
+    end
+
+    def in_years
+      years_diff = @ordered_to.year - @ordered_from.year
+
+      return years_diff unless years_diff.positive?
+      return years_diff if @ordered_to.month > @ordered_from.month
+
+      if (@ordered_to.month < @ordered_from.month) || (@ordered_to.mday < @ordered_from.mday)
+        years_diff -= 1
+      end
+
+      years_diff
+    end
+
+    private
+
+    TIME_CLASSES = [Time, DateTime].freeze
+
+    private_constant :TIME_CLASSES
+
+    def parse_argument(value)
+      case value
+      when *TIME_CLASSES
+        value.to_time.getutc
+      when Date
+        value
+      else
+        raise ArgumentError, 'Unsupported format'
+      end
+    end
+
     def precise_difference
-      @diff = {
-        seconds: @to.sec - @from.sec,
-        minutes: @to.min - @from.min,
-        hours: @to.hour - @from.hour,
-        days: @to.day - @from.day,
-        months: @to.month - @from.month,
-        years: @to.year - @from.year,
-      }
+      @diff = calculate_diff
 
       calculate :seconds, :minutes
       calculate :minutes, :hours
@@ -47,37 +114,42 @@ module Moments
       @diff
     end
 
-    private :precise_difference
-
-    def calculate(attr, subtr, increment = 60)
-      if @diff[attr] < 0
-        @diff[attr] += increment
-        @diff[subtr] -= 1
+    def calculate_diff
+      are_time_parts = [@from, @to].all? do |value|
+        TIME_CLASSES.any? { |time_class| value.is_a?(time_class) }
       end
+
+      (are_time_parts ? DATE_PARTS.merge(TIME_PARTS) : DATE_PARTS)
+        .transform_values do |method_name|
+          @ordered_to.public_send(method_name) - @ordered_from.public_send(method_name)
+        end
     end
 
-    private :calculate
+    def calculate(attribute, difference, stepping = 60)
+      return unless @diff.key?(attribute) && @diff.key?(difference)
 
-    def calculate_days
-      if @diff[:days] < 0
-        previous_month_days = (Time.new(@to.year, @to.month, 1) - 1).day
-        @diff[:days] = precise_previous_month_days(@diff[:days], previous_month_days, @from.day)
-        @diff[:months] -= 1
-      end
+      return if @diff[attribute] >= 0
+
+      @diff[attribute] += stepping
+      @diff[difference] -= 1
     end
 
-    private :calculate_days
+    def calculate_days
+      return if @diff[:days] >= 0
+
+      previous_month_days = (Time.new(@to.year, @to.month, 1) - 1).day
+      @diff[:days] = precise_previous_month_days(
+        @diff[:days], previous_month_days, @from.day
+      )
+      @diff[:months] -= 1
+    end
 
     def precise_previous_month_days(days, previous, from)
       if previous < from
-        days = previous + days + (from - previous)
+        previous + days + (from - previous)
       else
-        days = previous + days
+        previous + days
       end
-
-      days
     end
-
-    private :precise_previous_month_days
   end
 end

data/lib/moments/version.rb

@@ -1,14 +1,23 @@
+# frozen_string_literal: true
+
+# Moments::Version module
 module Moments
   def self.gem_version
     Gem::Version.new VERSION::STRING
   end
 
+  # Moments version builder module
   module VERSION
+    # major version
     MAJOR = 0
-    MINOR = 0
-    TINY  = 2
-    PRE   = 'alpha'
+    # minor version
+    MINOR = 1
+    # patch version
+    PATCH = 0
+    # alpha, beta, etc. tag
+    PRE   = nil
 
-    STRING = [MAJOR, MINOR, TINY, PRE].compact.join('.')
+    # Build version string
+    STRING = [MAJOR, MINOR, PATCH, PRE].compact.join('.')
   end
 end

data/moments.gemspec

@@ -1,25 +1,25 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
-$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'moments/version'
+# frozen_string_literal: true
+
+require_relative 'lib/moments/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "moments"
-  spec.version       = Moments.gem_version
-  spec.authors       = ["Tim Rudat"]
-  spec.email         = ["timrudat@gmail.com"]
-  spec.summary       = %q{Handles time differences and calculations.}
-  spec.description   = %q{}
-  spec.homepage      = "https://github.com/excpt/moments"
-  spec.license       = "MIT"
+  spec.name        = 'moments'
+  spec.version     = Moments.gem_version
+  spec.authors     = ['Tim Rudat']
+  spec.email       = ['timrudat@gmail.com']
+  spec.summary     = 'Handles time differences.'
+  spec.description = ''
+  spec.homepage    = 'https://github.com/excpt/moments'
+  spec.license     = 'MIT'
 
   spec.files         = `git ls-files -z`.split("\x0")
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.add_development_dependency "bundler"
-  spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec"
-  spec.add_development_dependency "codeclimate-test-reporter"
+  spec.add_development_dependency 'bundler', '>= 1', '< 3'
+  spec.add_development_dependency 'codeclimate-test-reporter', '~> 1.0'
+  spec.add_development_dependency 'rake', '~> 13.0'
+  spec.add_development_dependency 'rspec', '~> 3.0'
+  spec.add_development_dependency 'rubocop', '~> 0.86.0'
 end