mollie-bank 0.0.2 → 0.0.3

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 447a33be843cdf4f114a7ff497b7bbd8b65b2644
+  data.tar.gz: 32288ae9b7b745babb662e74bdcccc1bc6e70a63
+SHA512:
+  metadata.gz: c27098173e74b9efca5bdfe74fcb455075723dea6dfb514a05150e2b677c8b0ae068476d1833bc9551577034c957f5dd373d609685937b0c04d53dbbb6684fa8
+  data.tar.gz: 1c66daea1abc9f0e93458f5c22911fd2ca65fe71c27958fd3d348afd412a91f0d5f2bd9a53b5c62aad2b77b4f5df6eaf7fbe52d686afeab002880f5244621ac6

data/.rvmrc

@@ -0,0 +1,48 @@
+#!/usr/bin/env bash
+
+# This is an RVM Project .rvmrc file, used to automatically load the ruby
+# development environment upon cd'ing into the directory
+
+# First we specify our desired <ruby>[@<gemset>], the @gemset name is optional,
+# Only full ruby name is supported here, for short names use:
+#     echo "rvm use 1.9.3" > .rvmrc
+environment_id="ruby-1.9.3-p125@mollie-bank"
+
+# Uncomment the following lines if you want to verify rvm version per project
+# rvmrc_rvm_version="1.10.3" # 1.10.1 seams as a safe start
+# eval "$(echo ${rvm_version}.${rvmrc_rvm_version} | awk -F. '{print "[[ "$1*65536+$2*256+$3" -ge "$4*65536+$5*256+$6" ]]"}' )" || {
+#   echo "This .rvmrc file requires at least RVM ${rvmrc_rvm_version}, aborting loading."
+#   return 1
+# }
+
+# First we attempt to load the desired environment directly from the environment
+# file. This is very fast and efficient compared to running through the entire
+# CLI and selector. If you want feedback on which environment was used then
+# insert the word 'use' after --create as this triggers verbose mode.
+if [[ -d "${rvm_path:-$HOME/.rvm}/environments"
+  && -s "${rvm_path:-$HOME/.rvm}/environments/$environment_id" ]]
+then
+  \. "${rvm_path:-$HOME/.rvm}/environments/$environment_id"
+  [[ -s "${rvm_path:-$HOME/.rvm}/hooks/after_use" ]] &&
+    \. "${rvm_path:-$HOME/.rvm}/hooks/after_use" || true
+else
+  # If the environment file has not yet been created, use the RVM CLI to select.
+  rvm --create  "$environment_id" || {
+    echo "Failed to create RVM environment '${environment_id}'."
+    return 1
+  }
+fi
+
+# If you use bundler, this might be useful to you:
+# if [[ -s Gemfile ]] && {
+#   ! builtin command -v bundle >/dev/null ||
+#   builtin command -v bundle | grep $rvm_path/bin/bundle >/dev/null
+# }
+# then
+#   printf "%b" "The rubygem 'bundler' is not installed. Installing it now.\n"
+#   gem install bundler
+# fi
+# if [[ -s Gemfile ]] && builtin command -v bundle >/dev/null
+# then
+#   bundle install | grep -vE '^Using|Your bundle is complete'
+# fi

data/.travis.yml

@@ -1,11 +1,17 @@
 language: ruby
+env:
+  - JRUBY_OPTS="-Xcext.enabled=true"
 rvm:
   - 1.8.7
   - 1.9.2
   - 1.9.3
-  - ree
+  - 2.0.0
+  - jruby-18mode
   - ruby-head
+  - jruby-head
+  - ree
+matrix:
+  allow_failures:
+    - rvm: ruby-head
+    - rvm: jruby-head
 script: "bundle exec rake spec"
-notifications:
-  recipients:
-    - manuel@manuelles.nl

data/README.md

@@ -1,10 +1,13 @@
-# Mollie-Bank [![Build Status](https://secure.travis-ci.org/manuelvanrijn/mollie-bank.png?branch=master)][travis] [![Dependency Status](https://gemnasium.com/manuelvanrijn/mollie-bank.png)][gemnasium]
+# Mollie-Bank [![Gem Version](https://badge.fury.io/rb/mollie-bank.png)][gemversion] [![Build Status](https://secure.travis-ci.org/manuelvanrijn/mollie-bank.png?branch=master)][travis] [![Coverage Status](https://coveralls.io/repos/manuelvanrijn/mollie-bank/badge.png?branch=gems-coveralls)][coveralls]
 
+[gemversion]: http://badge.fury.io/rb/mollie-bank
 [travis]: http://travis-ci.org/manuelvanrijn/mollie-bank
-[gemnasium]: https://gemnasium.com/manuelvanrijn/mollie-bank
+[coveralls]: https://coveralls.io/r/manuelvanrijn/mollie-bank?branch=gems-coveralls
 
 A simple implementation of the "TM Bank" by [Mollie](http://www.mollie.nl), but without the portforward stuff to test your iDeal transactions localy.
 
+![Mollie Bank](http://manuel.manuelles.nl/images/posts/mollie-bank.png)
+
 ## Getting started
 
 ### Install
@@ -40,3 +43,5 @@ A detailed overview of can be found in the [CHANGELOG](https://github.com/manuel
 ## Copyright
 
 Copyright © 2012 Manuel van Rijn. See [LICENSE](https://github.com/manuelvanrijn/mollie-bank/blob/master/LICENSE.md) for further details.
+
+[![githalytics.com alpha](https://cruel-carlota.pagodabox.com/c7f118ff9d18b3ec8268969b2c5fff65 "githalytics.com")](http://githalytics.com/manuelvanrijn/mollie-bank)

data/lib/mollie-bank.rb

@@ -1,5 +1,6 @@
 # EXTERNAL DEPS
-require 'sinatra'
+require 'sinatra/base'
+require 'sinatra/multi_route'
 require 'haml'
 require 'net/http'
 require 'uuid'

data/lib/mollie-bank/application/app.rb

@@ -2,6 +2,8 @@
 module MollieBank
   # The Sinatra Application
   class Application < Sinatra::Base
+    register Sinatra::MultiRoute
+
     set :static, true
     set :public_folder, File.expand_path('..', __FILE__)
 
@@ -71,7 +73,11 @@ module MollieBank
         rescue
         end
 
-        redirect returnurl
+        redirect_url = "#{returnurl}&transaction_id=#{transaction_id}"
+        # if return url already contains a '?' we have to append the transaction_id with a '&'
+        redirect_url = "#{returnurl}?transaction_id=#{transaction_id}" if returnurl.split('?').count == 1
+
+        redirect redirect_url
       end
     end
 
@@ -88,7 +94,7 @@ module MollieBank
     # @example
     #   # checks if a order was paid
     #   http://localhost:4567/xml/ideal?a=check
-    post '/xml/ideal' do
+    post '/xml/ideal', '/xml/ideal/' do
       content_type 'text/xml'
       case params[:a]
       when "banklist"
@@ -113,7 +119,8 @@ module MollieBank
 
         settings.storage.set(transaction_id, {:paid => false})
 
-        url_path = request.url.split('/xml/ideal')[0]
+        #url_path = request.url.split('/xml/ideal')[0]
+        url_path = "http://#{request.host}:#{Sinatra::Application.port}"
 
         haml :fetch, :layout => false, :locals => {
           :transaction_id => transaction_id,
@@ -149,7 +156,7 @@ module MollieBank
 
     # Render the XML error for a specific code
     #
-    # @param [int] error code
+    # @param [int] code
     def error(code)
       # Mollie codes taken from https://www.mollie.nl/support/documentatie/betaaldiensten/ideal/en/
       errors = []

data/lib/mollie-bank/version.rb

@@ -1,4 +1,4 @@
 module MollieBank
   # Version number of MollieBank
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/mollie-bank.gemspec

@@ -26,9 +26,11 @@ Gem::Specification.new do |s|
   s.add_development_dependency "yard"
   s.add_development_dependency "yard-sinatra"
   s.add_development_dependency "simplecov"
+  s.add_development_dependency "coveralls"
 
   s.add_dependency "rake", "> 0.9.0"
   s.add_dependency "uuid", "> 1.0"
   s.add_dependency "haml", "> 3.0"
-  s.add_dependency "sinatra", "~> 1.3.0"
+  s.add_dependency "sinatra", "~> 1.4.0"
+  s.add_dependency "sinatra-contrib", "~> 1.4.0"
 end

data/spec/backend_spec.rb

@@ -11,6 +11,16 @@ describe "backend" do
     xml.response.bank.bank_id.content.should == "0001"
     xml.response.bank.bank_name.content.should == "Mollie Bank"
   end
+  it "should also return the Mollie bank when requesting /xml/ideal/?a=banklist" do
+    post '/xml/ideal/', {
+      :a => 'banklist'
+    }
+
+    last_response.should be_ok
+    xml = Nokogiri::Slop(last_response.body)
+    xml.response.bank.bank_id.content.should == "0001"
+    xml.response.bank.bank_name.content.should == "Mollie Bank"
+  end
   it "should return the correct xml for /xml/ideal?a=fetch" do
     post '/xml/ideal', {
       :a => 'fetch',
@@ -27,7 +37,7 @@ describe "backend" do
     xml.response.order.transaction_id.content.should_not be_blank
     xml.response.order.amount.content.should == "1000"
     xml.response.order.currency.content.should == "EUR"
-    xml.response.order.URL.content.should contain "http://example.org/ideal?transaction_id="
+    xml.response.order.URL.content.should contain "http://example.org:4567/ideal?transaction_id="
     xml.response.order.message.content.should == "Your iDEAL-payment has successfully been setup. Your customer should visit the given URL to make the payment"
   end
   it "should return the true if paid" do

data/spec/frontend_spec.rb

@@ -57,6 +57,6 @@ describe "frontend" do
 
     last_response.should be_redirect
     follow_redirect!
-    last_request.url.should == 'http://example.org/return.html'
+    last_request.url.should == 'http://example.org/return.html?transaction_id=987654'
   end
 end

data/spec/spec_helper.rb

@@ -1,4 +1,9 @@
 require 'simplecov'
+require 'coveralls'
+SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
+  SimpleCov::Formatter::HTMLFormatter,
+  Coveralls::SimpleCov::Formatter
+]
 SimpleCov.start
 
 # Load the Sinatra app

metadata

@@ -1,137 +1,197 @@
 --- !ruby/object:Gem::Specification
 name: mollie-bank
 version: !ruby/object:Gem::Version
-  version: 0.0.2
-  prerelease: 
+  version: 0.0.3
 platform: ruby
 authors:
 - Manuel van Rijn
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-02-23 00:00:00.000000000 Z
+date: 2013-05-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &24437360 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *24437360
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: nokogiri
-  requirement: &24436620 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *24436620
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: webrat
-  requirement: &24436060 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *24436060
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: redcarpet
-  requirement: &24435380 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *24435380
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: yard
-  requirement: &24434740 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *24434740
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: yard-sinatra
-  requirement: &24433980 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *24433980
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
-  requirement: &24432620 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *24432620
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: coveralls
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &24431580 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>'
+    - - '>'
       - !ruby/object:Gem::Version
         version: 0.9.0
   type: :runtime
   prerelease: false
-  version_requirements: *24431580
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>'
+      - !ruby/object:Gem::Version
+        version: 0.9.0
 - !ruby/object:Gem::Dependency
   name: uuid
-  requirement: &24446720 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>'
+    - - '>'
       - !ruby/object:Gem::Version
         version: '1.0'
   type: :runtime
   prerelease: false
-  version_requirements: *24446720
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>'
+      - !ruby/object:Gem::Version
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: haml
-  requirement: &24444400 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>'
+    - - '>'
       - !ruby/object:Gem::Version
         version: '3.0'
   type: :runtime
   prerelease: false
-  version_requirements: *24444400
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>'
+      - !ruby/object:Gem::Version
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: sinatra
-  requirement: &24443540 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.3.0
+        version: 1.4.0
   type: :runtime
   prerelease: false
-  version_requirements: *24443540
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.4.0
+- !ruby/object:Gem::Dependency
+  name: sinatra-contrib
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.4.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.4.0
 description: A small sinatra server that supports all the actions Mollie iDeal API
   needs to make a payment. Now you can test your transactions on you local machine
   without having to make portforwards
@@ -144,6 +204,7 @@ extra_rdoc_files: []
 files:
 - .gitignore
 - .rspec
+- .rvmrc
 - .travis.yml
 - .yardopts
 - CHANGELOG.md
@@ -181,33 +242,30 @@ files:
 - spec/spec_helper.rb
 homepage: https://github.com/manuelvanrijn/mollie-bank
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 4653816000511860
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 4653816000511860
 requirements: []
 rubyforge_project: mollie-bank
-rubygems_version: 1.8.11
+rubygems_version: 2.0.0
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Mollie Bank server to make Mollie iDeal payments on your local machine
-test_files: []
+test_files:
+- spec/backend_spec.rb
+- spec/errors_spec.rb
+- spec/frontend_spec.rb
+- spec/spec_helper.rb
 has_rdoc: