mollie-bank 0.0.1 → 0.0.2

data/.gitignore

@@ -2,3 +2,6 @@
 .bundle
 Gemfile.lock
 pkg/*
+coverage/
+doc/
+.yardoc/

data/.rspec

@@ -0,0 +1,2 @@
+--color
+--format documentation

data/.travis.yml

@@ -0,0 +1,11 @@
+language: ruby
+rvm:
+  - 1.8.7
+  - 1.9.2
+  - 1.9.3
+  - ree
+  - ruby-head
+script: "bundle exec rake spec"
+notifications:
+  recipients:
+    - manuel@manuelles.nl

data/.yardopts

@@ -0,0 +1,3 @@
+--readme README.md
+--charset utf-8
+'lib/**/*.rb' - '*.md'

data/CHANGELOG.md

@@ -1,4 +1,9 @@
 # Changelog
 
+- **23 February 2012**: version 0.0.2
+    - New way for storing transactions
+    - Fully tested
+    - Documented
+
 - **16 February 2012**: version 0.0.1
     - Initial release

data/README.md

@@ -1,4 +1,7 @@
-# Mollie-Bank
+# Mollie-Bank [![Build Status](https://secure.travis-ci.org/manuelvanrijn/mollie-bank.png?branch=master)][travis] [![Dependency Status](https://gemnasium.com/manuelvanrijn/mollie-bank.png)][gemnasium]
+
+[travis]: http://travis-ci.org/manuelvanrijn/mollie-bank
+[gemnasium]: https://gemnasium.com/manuelvanrijn/mollie-bank
 
 A simple implementation of the "TM Bank" by [Mollie](http://www.mollie.nl), but without the portforward stuff to test your iDeal transactions localy.
 
@@ -12,19 +15,6 @@ To install the gem you should execute
 gem install mollie-bank
 ```
 
-Or if you are implementing this into a Rails project you could add the gem into your `Gemfile`.
-
-```
-gem 'mollie-bank'
-```
-
-Finally, if you don’t dig any of that gemming that’s so popular nowadays, you can install it as a plugin for you Rails project:
-
-```
-cd vendor/plugins
-git clone --depth 1 git://github.com/manuelvanrijn/mollie-bank.git mollie-bank
-```
-
 ### Running the Mollie Bank
 
 After installation you can simple run:
@@ -37,7 +27,7 @@ Check if it works by browsing to: [http://localhost:4567/](http://localhost:4567
 
 ## Howto implement
 
-By default all communication for iDeal transactions is through [https://secure.mollie.nl/xml/ideal](https://secure.mollie.nl/xml/ideal). To use the "Mollie Bank" gem, you have to change this path into http://localhost:4567/xml/ideal](http://localhost:4567/xml/ideal).
+By default all communication for iDeal transactions is through [https://secure.mollie.nl/xml/ideal](https://secure.mollie.nl/xml/ideal). To use the "Mollie Bank" gem, you have to change this path into [http://localhost:4567/xml/ideal](http://localhost:4567/xml/ideal).
 
 Of course you only want to use this in development mode, so you have to create some code to change this path only when it isn't in production mode.
 

data/Rakefile

@@ -1 +1,9 @@
 require "bundler/gem_tasks"
+require "rspec/core/rake_task"
+RSpec::Core::RakeTask.new("spec")
+
+require "yard"
+require "yard-sinatra"
+YARD::Rake::YardocTask.new do |t|
+  t.options += ["--title", "Mollie Bank #{MollieBank::VERSION} Documentation"]
+end

data/lib/mollie-bank.rb

@@ -1,12 +1,10 @@
 # EXTERNAL DEPS
 require 'sinatra'
-require 'sinatra/content_for'
-require 'sinatra/namespace'
-require 'sinatra/reloader'
 require 'haml'
 require 'net/http'
 require 'uuid'
 
 # LOCAL DEPS
 require 'mollie-bank/version'
+require 'mollie-bank/application/storage'
 require 'mollie-bank/application/app'

data/lib/mollie-bank/application/app.rb

@@ -1,20 +1,21 @@
+# MollieBank Module
 module MollieBank
+  # The Sinatra Application
   class Application < Sinatra::Base
-    helpers Sinatra::ContentFor
-    register Sinatra::Namespace
-    register Sinatra::Reloader
-
     set :static, true
     set :public_folder, File.expand_path('..', __FILE__)
 
     set :views, File.expand_path('../views/', __FILE__)
     set :haml, { :format => :html5 }
 
-    @@storage = Hash.new
+    set :storage, MollieBank::Storage
 
+    # Displays a information page of the Mollie-Bank gem
     get '/' do
       haml :info
     end
+
+    # Displays a bank page for finishing the transaction
     get '/ideal' do
       transaction_id = params[:transaction_id]
       description = params[:description]
@@ -25,11 +26,16 @@ module MollieBank
       if transaction_id.nil? or description.nil? or reporturl.nil? or returnurl.nil? or amount.nil?
         haml :html_error, :locals => { :message => "To few params have been supplied (expected to retrieve 'transaction_id', 'description', 'reporturl', 'returnurl' and 'amount')" }
       else
+        cent_amount = amount
         int, frac = ("%.2f" % (amount.to_f/100)).split('.')
         amount = "#{int},#{frac}"
 
-        @@storage["#{transaction_id}"]['reporturl'] = reporturl
-        @@storage["#{transaction_id}"]['returnurl'] = returnurl
+        transaction = settings.storage.get(transaction_id)
+        transaction[:reporturl] = reporturl
+        transaction[:returnurl] = returnurl
+        transaction[:amount] = cent_amount
+
+        settings.storage.set(transaction_id, transaction)
 
         url_path = request.url.split('/ideal?transaction_id=')[0]
 
@@ -43,83 +49,107 @@ module MollieBank
         }
       end
     end
+
+    # Background page that sends the paid = true or paid = false to the report url
     get '/payment' do
       transaction_id = params[:transaction_id]
       paid = params[:paid] == "true" ? true : false
 
       if transaction_id.nil? or paid.nil?
         haml :html_error, :locals => { :message => "To few params have been supplied" }
-      end
+      else
+        transaction = settings.storage.get(transaction_id)
+        reporturl = transaction[:reporturl]
+        returnurl = transaction[:returnurl]
+        transaction[:paid] = paid
 
-      @@storage["#{transaction_id}"]['paid'] = paid
-      reporturl = @@storage["#{transaction_id}"]['reporturl']
-      returnurl = @@storage["#{transaction_id}"]['returnurl']
+        settings.storage.set(transaction_id, transaction)
 
-      begin
-        reporturl = URI("#{reporturl}?transaction_id=#{transaction_id}")
-        res = Net::HTTP.get(reporturl)
-      rescue
-      end
+        begin
+          reporturl = URI("#{reporturl}?transaction_id=#{transaction_id}")
+          res = Net::HTTP.get(reporturl)
+        rescue
+        end
 
-      redirect returnurl
+        redirect returnurl
+      end
     end
 
-    namespace '/xml' do
-      post '/ideal' do
-        content_type 'text/xml'
-        case params[:a]
-        when "banklist"
-          haml :banklist, :layout => false
-        when "fetch"
-          return error(-2) unless params.has_key?("partnerid")
-          return error(-7) unless params.has_key?("description")
-          return error(-3) unless params.has_key?("reporturl")
-          return error(-12) unless params.has_key?("returnurl")
-          return error(-4) unless params.has_key?("amount")
-          return error(-14) unless params[:amount].to_i > 118
-          return error(-6) unless params.has_key?("bank_id")
-
-          partnerid = params[:partnerid]
-          description = params[:description]
-          reporturl = params[:reporturl]
-          returnurl = params[:returnurl]
-          amount = params[:amount]
-          bank_id = params[:bank_id]
-
-          transaction_id = UUID.new.generate.gsub('-', '')
-
-          @@storage["#{transaction_id}"] = Hash.new
-          @@storage["#{transaction_id}"]['paid'] = false
-
-          url_path = request.url.split('/xml/ideal')[0]
-
-          haml :fetch, :layout => false, :locals => {
-            :transaction_id => transaction_id,
-            :amount => amount,
-            :reporturl => reporturl,
-            :returnurl => returnurl,
-            :description => description,
-            :url_path => url_path
-          }
-        when "check"
-          return error(-11) unless params.has_key?("partnerid")
-          return error(-8) unless params.has_key?("transaction_id")
-
-          transaction_id = params[:transaction_id]
-          return error(-10) unless @@storage.has_key?("#{transaction_id}")
-
-          is_paid = @@storage["#{transaction_id}"]['paid']
-
-          haml :check, :layout => false, :locals => {
-            :transaction_id => transaction_id,
-            :is_paid => is_paid
-          }
-        else
-          error(-1)
-        end
+    # Displays the xml depending on the specified action
+    #
+    # @example
+    #   # returns a list of banks
+    #   http://localhost:4567/xml/ideal?a=banklist
+    #
+    # @example
+    #   # creates a new order
+    #   http://localhost:4567/xml/ideal?a=fetch
+    #
+    # @example
+    #   # checks if a order was paid
+    #   http://localhost:4567/xml/ideal?a=check
+    post '/xml/ideal' do
+      content_type 'text/xml'
+      case params[:a]
+      when "banklist"
+        haml :banklist, :layout => false
+      when "fetch"
+        return error(-2) unless params.has_key?("partnerid")
+        return error(-7) unless params.has_key?("description")
+        return error(-3) unless params.has_key?("reporturl")
+        return error(-12) unless params.has_key?("returnurl")
+        return error(-4) unless params.has_key?("amount")
+        return error(-14) unless params[:amount].to_i > 118
+        return error(-6) unless params.has_key?("bank_id")
+
+        partnerid = params[:partnerid]
+        description = params[:description]
+        reporturl = params[:reporturl]
+        returnurl = params[:returnurl]
+        amount = params[:amount]
+        bank_id = params[:bank_id]
+
+        transaction_id = UUID.new.generate.gsub('-', '')
+
+        settings.storage.set(transaction_id, {:paid => false})
+
+        url_path = request.url.split('/xml/ideal')[0]
+
+        haml :fetch, :layout => false, :locals => {
+          :transaction_id => transaction_id,
+          :amount => amount,
+          :reporturl => reporturl,
+          :returnurl => returnurl,
+          :description => description,
+          :url_path => url_path
+        }
+      when "check"
+        return error(-11) unless params.has_key?("partnerid")
+        return error(-8) unless params.has_key?("transaction_id")
+
+        transaction_id = params[:transaction_id]
+        transaction = settings.storage.get(transaction_id)
+        return error(-10) if transaction.nil?
+
+        is_paid = transaction[:paid]
+        amount = transaction[:amount]
+        transaction[:paid] = false
+
+        settings.storage.set(transaction_id, transaction)
+
+        haml :check, :layout => false, :locals => {
+          :transaction_id => transaction_id,
+          :amount => amount,
+          :is_paid => is_paid
+        }
+      else
+        error(-1)
       end
     end
 
+    # Render the XML error for a specific code
+    #
+    # @param [int] error code
     def error(code)
       # Mollie codes taken from https://www.mollie.nl/support/documentatie/betaaldiensten/ideal/en/
       errors = []

data/lib/mollie-bank/application/storage.rb

@@ -0,0 +1,23 @@
+module MollieBank
+  # The Storage class for storing a key value pair (without a database)
+  class Storage
+    @@_storage_object = {}
+
+    # Retrieve the value of the +key+
+    #
+    # @param [Object] key
+    # @return [Object] value
+    def self.get(key)
+      return nil unless @@_storage_object.has_key?key
+      @@_storage_object[key]
+    end
+
+    # Retrieve the value of the +key+
+    #
+    # @param [Object] key
+    # @param [Object] value
+    def self.set(key, value)
+      @@_storage_object[key] = value
+    end
+  end
+end

data/lib/mollie-bank/application/views/check.haml

@@ -2,7 +2,7 @@
 %response
   %order
     %transaction_id= "#{transaction_id}"
-    %amount 150
+    %amount= "#{amount}"
     %currency EUR
     - if is_paid
       %payed true

data/lib/mollie-bank/application/views/info.haml

@@ -1,6 +1,6 @@
 .hero-unit
-  %h1 Mollie Bank
-  %p Information page
+  %h1 Mollie Bank <small>v#{MollieBank::VERSION}</small>
+  %p Test your transactions on your local machine
 
 .row
   .span4
@@ -10,7 +10,8 @@
   .span4
     %h1 Step 2
     %p Make sure the <code>returnurl</code> and the <code>reporturl</code> are set to your local address. So for example you would have:
-    <code>http://localhost:3000/transactions/report</code>
+    <code>http://localhost/report.php</code> and<br /><br />
+    <code>http://localhost/return.php</code>
   .span4
     %h1 Step 3
-    You'll now see <strong>"Mollie Bank"</strong> in the bank selection.
+    Go to the bank selection page of your application and you'll now see <strong>"Mollie Bank"</strong> in the bank selection.

data/lib/mollie-bank/application/views/layout.haml

@@ -1,7 +1,7 @@
 !!! 5
 %html(lang="en")
   %head
-    %title Mollie Bank
+    %title Mollie Bank v#{MollieBank::VERSION}
     %link(rel="stylesheet" href="bootstrap/css/bootstrap.min.css")
     %link(rel="stylesheet" href="bootstrap/css/bootstrap.min.responsive")
     %link(rel="stylesheet" href="css/style.css")
@@ -13,7 +13,7 @@
             %span.i-bar
             %span.i-bar
             %span.i-bar
-          %a.brand(href="#") Mollie bank
+          %a.brand(href="#") Mollie Bank
 
     .container
 

data/lib/mollie-bank/version.rb

@@ -1,3 +1,4 @@
 module MollieBank
-  VERSION = "0.0.1"
+  # Version number of MollieBank
+  VERSION = "0.0.2"
 end

data/mollie-bank.gemspec

@@ -19,12 +19,16 @@ Gem::Specification.new do |s|
   s.default_executable  = 'mollie-bank'
   s.require_paths       = ["lib"]
 
-  # specify any dependencies here; for example:
-  s.add_development_dependency "sinatra-reloader"
+  s.add_development_dependency "rspec"
+  s.add_development_dependency "nokogiri"
+  s.add_development_dependency "webrat"
+  s.add_development_dependency "redcarpet"
+  s.add_development_dependency "yard"
+  s.add_development_dependency "yard-sinatra"
+  s.add_development_dependency "simplecov"
 
-  s.add_dependency "rake", "~> 0.9.0"
-  s.add_dependency "uuid", "~> 2.3"
-  s.add_dependency "haml", "~> 3.0"
+  s.add_dependency "rake", "> 0.9.0"
+  s.add_dependency "uuid", "> 1.0"
+  s.add_dependency "haml", "> 3.0"
   s.add_dependency "sinatra", "~> 1.3.0"
-  s.add_dependency "sinatra-contrib", "~> 1.3.1"
 end

data/spec/backend_spec.rb

@@ -0,0 +1,61 @@
+require 'spec_helper'
+
+describe "backend" do
+  it "should return the Mollie Bank when requesting /xml/ideal?a=banklist" do
+    post '/xml/ideal', {
+      :a => 'banklist'
+    }
+
+    last_response.should be_ok
+    xml = Nokogiri::Slop(last_response.body)
+    xml.response.bank.bank_id.content.should == "0001"
+    xml.response.bank.bank_name.content.should == "Mollie Bank"
+  end
+  it "should return the correct xml for /xml/ideal?a=fetch" do
+    post '/xml/ideal', {
+      :a => 'fetch',
+      :partnerid => '1234',
+      :description => 'description',
+      :reporturl => 'http://example.org/report',
+      :returnurl => 'http://example.org/return',
+      :amount => '1000',
+      :bank_id => '0001'
+    }
+    last_response.should be_ok
+
+    xml = Nokogiri::Slop(last_response.body)
+    xml.response.order.transaction_id.content.should_not be_blank
+    xml.response.order.amount.content.should == "1000"
+    xml.response.order.currency.content.should == "EUR"
+    xml.response.order.URL.content.should contain "http://example.org/ideal?transaction_id="
+    xml.response.order.message.content.should == "Your iDEAL-payment has successfully been setup. Your customer should visit the given URL to make the payment"
+  end
+  it "should return the true if paid" do
+    MollieBank::Storage.set('987654', {
+      :paid => true
+    })
+    post '/xml/ideal', {
+      :a => 'check',
+      :partnerid => '1234',
+      :transaction_id => '987654'
+    }
+
+    last_response.should be_ok
+    xml = Nokogiri::Slop(last_response.body)
+    xml.response.order.payed.content.should == "true"
+  end
+  it "should return the false not paid" do
+    MollieBank::Storage.set('987654', {
+      :paid => false
+    })
+    post '/xml/ideal', {
+      :a => 'check',
+      :partnerid => '1234',
+      :transaction_id => '987654'
+    }
+
+    last_response.should be_ok
+    xml = Nokogiri::Slop(last_response.body)
+    xml.response.order.payed.content.should == "false"
+  end
+end

data/spec/errors_spec.rb

@@ -0,0 +1,170 @@
+require 'spec_helper'
+
+describe "errors" do
+  describe "invalid /xml/ideal?a=" do
+    it "should return an error -1" do
+      post '/xml/ideal', {
+        :a => 'unknown'
+      }
+      xml = Nokogiri::Slop(last_response.body)
+      xml.response.item["type"].should == "error"
+
+      xml.response.item.errorcode.content.should == "-1"
+      xml.response.item.message.content.should == "Did not receive a proper input value."
+    end
+  end
+  describe "/xml/ideal?a=fetch" do
+    it "should return error -2  if partnerid isn't provided" do
+      post '/xml/ideal', {
+        :a => 'fetch',
+        :description => 'description',
+        :reporturl => 'http://example.org/report',
+        :returnurl => 'http://example.org/return',
+        :amount => '1000',
+        :bank_id => '0001'
+      }
+      last_response.should be_ok
+      xml = Nokogiri::Slop(last_response.body)
+      xml.response.item["type"].should == "error"
+
+      xml.response.item.errorcode.content.should == "-2"
+      xml.response.item.message.content.should == "A fetch was issued without specification of 'partnerid'."
+    end
+    it "should return error -7  if description isn't provided" do
+      post '/xml/ideal', {
+        :a => 'fetch',
+        :partnerid => '1234',
+        :reporturl => 'http://example.org/report',
+        :returnurl => 'http://example.org/return',
+        :amount => '1000',
+        :bank_id => '0001'
+      }
+      last_response.should be_ok
+      xml = Nokogiri::Slop(last_response.body)
+      xml.response.item["type"].should == "error"
+
+      xml.response.item.errorcode.content.should == "-7"
+      xml.response.item.message.content.should == "A fetch was issued without specification of 'description'."
+    end
+    it "should return error -3  if reporturl isn't provided" do
+      post '/xml/ideal', {
+        :a => 'fetch',
+        :partnerid => '1234',
+        :description => 'description',
+        :returnurl => 'http://example.org/return',
+        :amount => '1000',
+        :bank_id => '0001'
+      }
+      last_response.should be_ok
+      xml = Nokogiri::Slop(last_response.body)
+      xml.response.item["type"].should == "error"
+
+      xml.response.item.errorcode.content.should == "-3"
+      xml.response.item.message.content.should == "A fetch was issued without (proper) specification of 'reporturl'."
+    end
+    it "should return error -12 if returnurl isn't provided" do
+      post '/xml/ideal', {
+        :a => 'fetch',
+        :partnerid => '1234',
+        :description => 'description',
+        :reporturl => 'http://example.org/report',
+        :amount => '1000',
+        :bank_id => '0001'
+      }
+      last_response.should be_ok
+      xml = Nokogiri::Slop(last_response.body)
+      xml.response.item["type"].should == "error"
+
+      xml.response.item.errorcode.content.should == "-12"
+      xml.response.item.message.content.should == "A fetch was issued without (proper) specification of 'returnurl'."
+    end
+    it "should return error -4  if amount isn't provided" do
+      post '/xml/ideal', {
+        :a => 'fetch',
+        :partnerid => '1234',
+        :description => 'description',
+        :reporturl => 'http://example.org/report',
+        :returnurl => 'http://example.org/return',
+        :bank_id => '0001'
+      }
+      last_response.should be_ok
+      xml = Nokogiri::Slop(last_response.body)
+      xml.response.item["type"].should == "error"
+
+      xml.response.item.errorcode.content.should == "-4"
+      xml.response.item.message.content.should == "A fetch was issued without specification of 'amount'."
+    end
+    it "should return error -14 if amount is to low" do
+      post '/xml/ideal', {
+        :a => 'fetch',
+        :partnerid => '1234',
+        :description => 'description',
+        :reporturl => 'http://example.org/report',
+        :returnurl => 'http://example.org/return',
+        :amount => '100',
+        :bank_id => '0001'
+      }
+      last_response.should be_ok
+      xml = Nokogiri::Slop(last_response.body)
+      xml.response.item["type"].should == "error"
+
+      xml.response.item.errorcode.content.should == "-14"
+      xml.response.item.message.content.should == "Minimum amount for an ideal transaction is 1,18 EUR."
+    end
+    it "should return error -6  if bank_id isn't provided" do
+      post '/xml/ideal', {
+        :a => 'fetch',
+        :partnerid => '1234',
+        :description => 'description',
+        :reporturl => 'http://example.org/report',
+        :returnurl => 'http://example.org/return',
+        :amount => '1000'
+      }
+      last_response.should be_ok
+      xml = Nokogiri::Slop(last_response.body)
+      xml.response.item["type"].should == "error"
+
+      xml.response.item.errorcode.content.should == "-6"
+      xml.response.item.message.content.should == "A fetch was issues without specification of a known 'bank_id'."
+    end
+  end
+  describe "/xml/ideal?a=check" do
+    it "should return error -11 if partnerid isn't provided" do
+      post '/xml/ideal', {
+        :a => 'check',
+        :transaction_id => '1'
+      }
+      last_response.should be_ok
+      xml = Nokogiri::Slop(last_response.body)
+      xml.response.item["type"].should == "error"
+
+      xml.response.item.errorcode.content.should == "-11"
+      xml.response.item.message.content.should == "A check was issued without specification of your partner_id."
+    end
+    it "should return error -8  if transaction_id isn't provided" do
+      post '/xml/ideal', {
+        :a => 'check',
+        :partnerid => '1'
+      }
+      last_response.should be_ok
+      xml = Nokogiri::Slop(last_response.body)
+      xml.response.item["type"].should == "error"
+
+      xml.response.item.errorcode.content.should == "-8"
+      xml.response.item.message.content.should == "A check was issued without specification of transaction_id."
+    end
+    it "should return error -10 if transaction_id is unknown" do
+      post '/xml/ideal', {
+        :a => 'check',
+        :partnerid => '1234',
+        :transaction_id => '1234'
+      }
+      last_response.should be_ok
+      xml = Nokogiri::Slop(last_response.body)
+      xml.response.item["type"].should == "error"
+
+      xml.response.item.errorcode.content.should == "-10"
+      xml.response.item.message.content.should == "This is an unknown order."
+    end
+  end
+end

data/spec/frontend_spec.rb

@@ -0,0 +1,62 @@
+require 'spec_helper'
+
+describe "frontend" do
+  it "should show the home page when browsing to /" do
+    get '/'
+    last_response.should be_ok
+    last_response.body.should contain "Test your transactions on your local machine"
+    last_response.body.should contain "Step 1"
+    last_response.body.should contain "Step 2"
+    last_response.body.should contain "Step 3"
+  end
+  it "should who me an error when browsing to /ideal without parameters" do
+    get '/ideal'
+    last_response.should be_ok
+    last_response.body.should contain "Oh snap! You got an error!"
+    last_response.body.should contain "To few params have been supplied"
+  end
+  it "should show me the Mollie Bank page to make payment or not when browsing to /ideal with parameters" do
+    session = {"987654" => {"paid" => false}}
+    MollieBank::Storage.set('987654', {
+      :paid => false
+    })
+    get '/ideal', {
+      :transaction_id => '987654',
+      :amount => '1000',
+      :reporturl => 'http://example.org/report',
+      :returnurl => 'http://example.org/return',
+      :description => 'a_description'
+    }
+
+    last_response.should be_ok
+    last_response.body.should contain "Pay time!"
+    last_response.body.should contain "YES, I wish to pay"
+    last_response.body.should contain "NO, I do not want to pay"
+    last_response.body.should contain "10,00 EUR"
+    last_response.body.should contain "a_description"
+    last_response.body.should contain "http://example.org/report"
+    last_response.body.should contain "http://example.org/return"
+    last_response.body.should contain "987654"
+  end
+  it "should show an html error when not all parameter are supplied for /payment" do
+    get '/payment'
+    last_response.should be_ok
+    last_response.body.should contain "Oh snap! You got an error!"
+    last_response.body.should contain "To few params have been supplied"
+  end
+  it "should store the correct values" do
+    MollieBank::Storage.set('987654', {
+      :paid => false,
+      :reporturl => 'http://example.org/report.html',
+      :returnurl => 'http://example.org/return.html'
+    })
+    get '/payment', {
+      :transaction_id => '987654',
+      :paid => 'true'
+    }
+
+    last_response.should be_redirect
+    follow_redirect!
+    last_request.url.should == 'http://example.org/return.html'
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,20 @@
+require 'simplecov'
+SimpleCov.start
+
+# Load the Sinatra app
+require 'mollie-bank'
+
+require 'rspec'
+require 'webrat'
+require 'rack/test'
+require 'nokogiri'
+
+RSpec.configure do |conf|
+  conf.include Rack::Test::Methods
+  conf.include Webrat::Methods
+  conf.include Webrat::Matchers
+end
+
+def app
+  MollieBank::Application
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mollie-bank
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-02-16 00:00:00.000000000 Z
+date: 2012-02-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: sinatra-reloader
-  requirement: &14685600 !ruby/object:Gem::Requirement
+  name: rspec
+  requirement: &24437360 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,43 +21,109 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *14685600
+  version_requirements: *24437360
+- !ruby/object:Gem::Dependency
+  name: nokogiri
+  requirement: &24436620 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: *24436620
+- !ruby/object:Gem::Dependency
+  name: webrat
+  requirement: &24436060 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: *24436060
+- !ruby/object:Gem::Dependency
+  name: redcarpet
+  requirement: &24435380 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: *24435380
+- !ruby/object:Gem::Dependency
+  name: yard
+  requirement: &24434740 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: *24434740
+- !ruby/object:Gem::Dependency
+  name: yard-sinatra
+  requirement: &24433980 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: *24433980
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: &24432620 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: *24432620
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &14683820 !ruby/object:Gem::Requirement
+  requirement: &24431580 !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ~>
+    - - ! '>'
       - !ruby/object:Gem::Version
         version: 0.9.0
   type: :runtime
   prerelease: false
-  version_requirements: *14683820
+  version_requirements: *24431580
 - !ruby/object:Gem::Dependency
   name: uuid
-  requirement: &14770340 !ruby/object:Gem::Requirement
+  requirement: &24446720 !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ~>
+    - - ! '>'
       - !ruby/object:Gem::Version
-        version: '2.3'
+        version: '1.0'
   type: :runtime
   prerelease: false
-  version_requirements: *14770340
+  version_requirements: *24446720
 - !ruby/object:Gem::Dependency
   name: haml
-  requirement: &14769740 !ruby/object:Gem::Requirement
+  requirement: &24444400 !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ~>
+    - - ! '>'
       - !ruby/object:Gem::Version
         version: '3.0'
   type: :runtime
   prerelease: false
-  version_requirements: *14769740
+  version_requirements: *24444400
 - !ruby/object:Gem::Dependency
   name: sinatra
-  requirement: &14769220 !ruby/object:Gem::Requirement
+  requirement: &24443540 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -65,18 +131,7 @@ dependencies:
         version: 1.3.0
   type: :runtime
   prerelease: false
-  version_requirements: *14769220
-- !ruby/object:Gem::Dependency
-  name: sinatra-contrib
-  requirement: &14768560 !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 1.3.1
-  type: :runtime
-  prerelease: false
-  version_requirements: *14768560
+  version_requirements: *24443540
 description: A small sinatra server that supports all the actions Mollie iDeal API
   needs to make a payment. Now you can test your transactions on you local machine
   without having to make portforwards
@@ -88,6 +143,9 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .rspec
+- .travis.yml
+- .yardopts
 - CHANGELOG.md
 - Gemfile
 - LICENSE.md
@@ -106,6 +164,7 @@ files:
 - lib/mollie-bank/application/bootstrap/js/bootstrap.min.js
 - lib/mollie-bank/application/css/style.css
 - lib/mollie-bank/application/javascript/script.js
+- lib/mollie-bank/application/storage.rb
 - lib/mollie-bank/application/views/bank_page.haml
 - lib/mollie-bank/application/views/banklist.haml
 - lib/mollie-bank/application/views/check.haml
@@ -116,6 +175,10 @@ files:
 - lib/mollie-bank/application/views/layout.haml
 - lib/mollie-bank/version.rb
 - mollie-bank.gemspec
+- spec/backend_spec.rb
+- spec/errors_spec.rb
+- spec/frontend_spec.rb
+- spec/spec_helper.rb
 homepage: https://github.com/manuelvanrijn/mollie-bank
 licenses: []
 post_install_message: 
@@ -130,7 +193,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3185843689942159525
+      hash: 4653816000511860
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -139,7 +202,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3185843689942159525
+      hash: 4653816000511860
 requirements: []
 rubyforge_project: mollie-bank
 rubygems_version: 1.8.11
@@ -147,3 +210,4 @@ signing_key:
 specification_version: 3
 summary: Mollie Bank server to make Mollie iDeal payments on your local machine
 test_files: []
+has_rdoc: