RubyGems - moj_tribunals_config - Versions diffs - 0.8.0 → 1.0.0 - Mend

moj_tribunals_config 0.8.0 → 1.0.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (18) hide show

checksums.yaml +4 -4
data/.ruby-version +1 -0
data/Gemfile +6 -1
data/Gemfile.lock +22 -0
data/README.rdoc +4 -1
data/Rakefile +10 -8
data/VERSION +1 -1
data/config/tribunals/care-standards.yml +112 -113
data/config/tribunals/eat.yml +78 -79
data/config/tribunals/ftt-tax.yml +98 -99
data/config/tribunals/utiac.yml +118 -119
data/lib/moj/tribunals/config_loader.rb +10 -5
data/moj_tribunals_config.gemspec +13 -6
data/spec/lib/moj/tribunals/config_loader_spec.rb +90 -0
data/spec/spec_helper.rb +4 -0
metadata +34 -5
data/test/helper.rb +0 -34
data/test/test_moj_tribunals_config.rb +0 -7

checksums.yaml CHANGED Viewed

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c5f6584256f59e97b0fb29846d76c78bbde5edea
-  data.tar.gz: 4c1cdc203d96d67c3986e325fec6bf9df5c7c0a6
+  metadata.gz: 1233d2f0e695bc9ade2a8cf697017068fcf9ea32
+  data.tar.gz: be82f47ed17884dbc5182197da556f95098675cc
 SHA512:
-  metadata.gz: 5f5d38db5b49e7cf88a9019698cc81b329fbcc1abdf5c29f20396ccf410ae6302ea875eafcfd03f9c266332a2eb3390ab2cffaf2f70ad3b816446ccc7516f934
-  data.tar.gz: 2aa7144c5fc8038c049909bb4b7697d7a0c70360aeacd6a840fc41dd6b61f8059deb7946359358375ef4abe6367453b38c7f7678cce6ba9941c49037382e999e
+  metadata.gz: b6d4d277011b5c155f564091c370962f46e5aeb91130065a56e851f37b196cea3b466c59fbf8201bb12fd4c1df635a7301d94cece6f83e7c68cf046f15a51fe0
+  data.tar.gz: 375aa81fa53ac6d44bcaaeafff2668c824bd5664e00a96a32480fdbbb6fb19a2e2a56e288b4bfa2d1bb4718e0e1991283faf58bc4dd795e3f9e3162cdad29f5f

data/.ruby-version ADDED Viewed

	@@ -0,0 +1 @@
1	+ 2.1.5@moj_tribunals_config

data/Gemfile CHANGED Viewed

@@ -10,5 +10,10 @@ group :development do
   gem "rdoc", "~> 3.12"
   gem "bundler", "~> 1.0"
   gem "jeweler", "~> 2.0.1"
-  gem "simplecov", ">= 0"
 end
+group :development, :test do
+  gem 'byebug'
+  gem 'rspec'
+  gem "simplecov", ">= 0"
+end

data/Gemfile.lock CHANGED Viewed

@@ -9,8 +9,15 @@ GEM
       tzinfo (~> 1.1)
     addressable (2.3.6)
     builder (3.2.2)
+    byebug (3.5.1)
+      columnize (~> 0.8)
+      debugger-linecache (~> 1.2)
+      slop (~> 3.6)
+    columnize (0.9.0)
+    debugger-linecache (1.2.0)
     descendants_tracker (0.0.4)
       thread_safe (~> 0.3, >= 0.3.1)
+    diff-lcs (1.2.5)
     docile (1.1.5)
     faraday (0.9.1)
       multipart-post (>= 1.2, < 3)
@@ -54,6 +61,18 @@ GEM
     rake (10.4.2)
     rdoc (3.12.2)
       json (~> 1.4)
+    rspec (3.1.0)
+      rspec-core (~> 3.1.0)
+      rspec-expectations (~> 3.1.0)
+      rspec-mocks (~> 3.1.0)
+    rspec-core (3.1.7)
+      rspec-support (~> 3.1.0)
+    rspec-expectations (3.1.2)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.1.0)
+    rspec-mocks (3.1.3)
+      rspec-support (~> 3.1.0)
+    rspec-support (3.1.2)
     shoulda (3.5.0)
       shoulda-context (~> 1.0, >= 1.0.1)
       shoulda-matchers (>= 1.4.1, < 3.0)
@@ -65,6 +84,7 @@ GEM
       multi_json (~> 1.0)
       simplecov-html (~> 0.8.0)
     simplecov-html (0.8.0)
+    slop (3.6.0)
     thread_safe (0.3.4)
     tzinfo (1.2.2)
       thread_safe (~> 0.1)
@@ -74,7 +94,9 @@ PLATFORMS
 DEPENDENCIES
   bundler (~> 1.0)
+  byebug
   jeweler (~> 2.0.1)
   rdoc (~> 3.12)
+  rspec
   shoulda
   simplecov

data/README.rdoc CHANGED Viewed

@@ -1,5 +1,8 @@
 = moj_tribunals_config
+{<img src="https://codeclimate.com/github/ministryofjustice/moj_tribunals_config/badges/gpa.svg" />}[https://codeclimate.com/github/ministryofjustice/moj_tribunals_config]
+{<img src="https://codeclimate.com/github/ministryofjustice/moj_tribunals_config/badges/coverage.svg" />}[https://codeclimate.com/github/ministryofjustice/moj_tribunals_config]
 == To use:
 # add this line to your Gemfile:
@@ -24,7 +27,7 @@ To just load config for a specific tribunal, you can do:
   config_loader = Moj::Tribunals::ConfigLoader.new
   config_file = config_loader.config_file_for('utiac')
-  config_loader.load( config_file )
+  config_loader.load_file( config_file )
 == RailsConfig integration

data/Rakefile CHANGED Viewed

@@ -40,7 +40,7 @@ Jeweler::Tasks.new do |gem|
       config_loader = Moj::Tribunals::ConfigLoader.new
       config_file = config_loader.config_file_for('utiac')
-      config_loader.load( config_file )
+      config_loader.load_file( config_file )
     RailsConfig integration
     =======================
@@ -57,20 +57,22 @@ Jeweler::Tasks.new do |gem|
 end
 Jeweler::RubygemsDotOrgTasks.new
-require 'rake/testtask'
-Rake::TestTask.new(:test) do |test|
-  test.libs << 'lib' << 'test'
-  test.pattern = 'test/**/test_*.rb'
-  test.verbose = true
+begin
+  require 'rspec/core/rake_task'
+  RSpec::Core::RakeTask.new(:spec)
+rescue LoadError => e
+  puts e.inspect
 end
 desc "Code coverage detail"
 task :simplecov do
   ENV['COVERAGE'] = "true"
-  Rake::Task['test'].execute
+  Rake::Task['spec'].execute
 end
-task :default => :test
+task :default => :spec
 require 'rdoc/task'
 Rake::RDocTask.new do |rdoc|

data/VERSION CHANGED Viewed

	@@ -1 +1 @@
1	- 0.8.0
1	+ 1.0.0

data/config/tribunals/care-standards.yml CHANGED Viewed

@@ -1,113 +1,112 @@
-tribunal:
-  name: care-standards
-  title: Care Standards Tribunal
-  search_params:
-    - query
-    - search_field
-    - reported
-    - unreported
-    - country_guidance
-    - page
-    - sort_by
-    - judge_ids
-    - country_ids
-    - category_ids
-    - date_from
-    - date_to
-  allowed_snippet_tags:
-    - mark
-    - br
-  sort_columns:
-    promulgated_on:
-      directions:
-        desc:
-          text: Newest first
-    _score:
-      directions:
-        desc:
-          text: Relevance
-  date_facet_help_text: A judgement can be used as case law from the promulgation date.
-  facets:
-    category:
-      text: Schedule
-      collection: categories
-      ids: category_ids
-      all_link_text: All Schedules
-      help_text:
-    judge:
-      text: Chairman
-      collection: judges
-      ids: judge_ids
-      all_link_text: All Chairman
-      help_text:
-  table_view_properties:
-    appeal_number:
-      property: appeal_number
-      text: Appeal number
-    chairman:
-      property: judges
-      text: Chairman
-      formatters:
-        fetch:
-          method_name: fetch
-          args: "name"
-    applicant:
-      property: appellants
-      text: Applicant names
-      formatters:
-        fetch:
-          method_name: fetch
-          args: "name"
-    respondent:
-      property: respondents
-      text: Respondent names
-      formatters:
-        fetch:
-          method_name: fetch
-          args: "name"
-    category:
-      property: categories
-      text: Schedule
-      formatters:
-        fetch:
-          method_name: fetch
-          args: "name"
-    decision_date:
-      property: promulgated_on
-      text: Promulgation date
-      formatters:
-        to_date:
-          method_name: to_date
-          args:
-        strftime:
-          method_name: strftime
-          args: "%d/%m/%Y"
-  detail_view_properties:
-    appeal_number:
-      property: appeal_number
-      text: Appeal number
-    chairman:
-      property: judge_names
-      text: Chairman
-    applicant:
-      property: appellant_names
-      text: Applicant names
-    respondent:
-      property: respondent_names
-      text: Respondent names
-    category:
-      property: category_names
-      text: Schedule
-    decision_date:
-      property: promulgated_on
-      text: Promulgation date
-      formatters:
-        to_date:
-          method_name: to_date
-          args:
-        strftime:
-          method_name: strftime
-          args: "%d/%m/%Y"
-    notes:
-      property: notes
-      text: Notes
+name: care-standards
+title: Care Standards Tribunal
+search_params:
+  - query
+  - search_field
+  - reported
+  - unreported
+  - country_guidance
+  - page
+  - sort_by
+  - judge_ids
+  - country_ids
+  - category_ids
+  - date_from
+  - date_to
+allowed_snippet_tags:
+  - mark
+  - br
+sort_columns:
+  promulgated_on:
+    directions:
+      desc:
+        text: Newest first
+  _score:
+    directions:
+      desc:
+        text: Relevance
+date_facet_help_text: A judgement can be used as case law from the promulgation date.
+facets:
+  category:
+    text: Schedule
+    collection: categories
+    ids: category_ids
+    all_link_text: All Schedules
+    help_text:
+  judge:
+    text: Chairman
+    collection: judges
+    ids: judge_ids
+    all_link_text: All Chairman
+    help_text:
+table_view_properties:
+  appeal_number:
+    property: appeal_number
+    text: Appeal number
+  chairman:
+    property: judges
+    text: Chairman
+    formatters:
+      fetch:
+        method_name: fetch
+        args: "name"
+  applicant:
+    property: appellants
+    text: Applicant names
+    formatters:
+      fetch:
+        method_name: fetch
+        args: "name"
+  respondent:
+    property: respondents
+    text: Respondent names
+    formatters:
+      fetch:
+        method_name: fetch
+        args: "name"
+  category:
+    property: categories
+    text: Schedule
+    formatters:
+      fetch:
+        method_name: fetch
+        args: "name"
+  decision_date:
+    property: promulgated_on
+    text: Promulgation date
+    formatters:
+      to_date:
+        method_name: to_date
+        args:
+      strftime:
+        method_name: strftime
+        args: "%d/%m/%Y"
+detail_view_properties:
+  appeal_number:
+    property: appeal_number
+    text: Appeal number
+  chairman:
+    property: judge_names
+    text: Chairman
+  applicant:
+    property: appellant_names
+    text: Applicant names
+  respondent:
+    property: respondent_names
+    text: Respondent names
+  category:
+    property: category_names
+    text: Schedule
+  decision_date:
+    property: promulgated_on
+    text: Promulgation date
+    formatters:
+      to_date:
+        method_name: to_date
+        args:
+      strftime:
+        method_name: strftime
+        args: "%d/%m/%Y"
+  notes:
+    property: notes
+    text: Notes

data/config/tribunals/eat.yml CHANGED Viewed

@@ -1,79 +1,78 @@
-tribunal:
-  name: eat
-  title: Employment Access Tribunal
-  search_params:
-    - query
-    - search_field
-    - reported
-    - unreported
-    - country_guidance
-    - page
-    - sort_by
-    - judge_ids
-    - country_ids
-    - category_ids
-    - date_from
-    - date_to
-  allowed_snippet_tags:
-    - mark
-    - br
-  sort_columns:
-    promulgated_on:
-      directions:
-        desc:
-          text: Newest first
-    _score:
-      directions:
-        desc:
-          text: Relevance
-  facets:
-    country:
-      text: Country
-      collection: countries
-      ids: country_ids
-      all_link_text: All Countries
-    judge:
-      text: Judge
-      collection: judges
-      ids: judge_ids
-      all_link_text: All Judges
-  tabs:
-    reported:
-      text: Reported
-      count_method: reported_count
-      default: true
-    country_guidance:
-      text: Country Guidance
-      count_method: country_guidance_count
-      default: false
-    unreported:
-      text: Unreported
-      count_method: unreported_count
-      default: false
-  table_view_properties:
-    case_title:
-      property: case_title
-      text: Case title
-    keywords:
-      property: keywords
-      text: Keywords
-    promulgated_on:
-      property: promulgated_on
-      text: Promulgation date
-      formatters:
-        to_date:
-          method_name: to_date
-          args:
-        strftime:
-          method_name: strftime
-          args: "%d/%m/%Y"
-    country_name:
-      property: country_name
-      text: Country of Appellant
-    keywords:
-      property: keywords
-      text: keywords
-  detail_view_properties:
-    case_title:
-      property: case_title
-      text: Case title
+name: eat
+title: Employment Access Tribunal
+search_params:
+  - query
+  - search_field
+  - reported
+  - unreported
+  - country_guidance
+  - page
+  - sort_by
+  - judge_ids
+  - country_ids
+  - category_ids
+  - date_from
+  - date_to
+allowed_snippet_tags:
+  - mark
+  - br
+sort_columns:
+  promulgated_on:
+    directions:
+      desc:
+        text: Newest first
+  _score:
+    directions:
+      desc:
+        text: Relevance
+facets:
+  country:
+    text: Country
+    collection: countries
+    ids: country_ids
+    all_link_text: All Countries
+  judge:
+    text: Judge
+    collection: judges
+    ids: judge_ids
+    all_link_text: All Judges
+tabs:
+  reported:
+    text: Reported
+    count_method: reported_count
+    default: true
+  country_guidance:
+    text: Country Guidance
+    count_method: country_guidance_count
+    default: false
+  unreported:
+    text: Unreported
+    count_method: unreported_count
+    default: false
+table_view_properties:
+  case_title:
+    property: case_title
+    text: Case title
+  keywords:
+    property: keywords
+    text: Keywords
+  promulgated_on:
+    property: promulgated_on
+    text: Promulgation date
+    formatters:
+      to_date:
+        method_name: to_date
+        args:
+      strftime:
+        method_name: strftime
+        args: "%d/%m/%Y"
+  country_name:
+    property: country_name
+    text: Country of Appellant
+  keywords:
+    property: keywords
+    text: keywords
+detail_view_properties:
+  case_title:
+    property: case_title
+    text: Case title

data/config/tribunals/ftt-tax.yml CHANGED Viewed

@@ -1,99 +1,98 @@
-tribunal:
-  name: ftt-tax
-  title: Finance and Tax Tribunals
-  search_params:
-    - query
-    - search_field
-    - reported
-    - unreported
-    - country_guidance
-    - page
-    - sort_by
-    - judge_ids
-    - category_ids
-    - date_from
-    - date_to
-  allowed_snippet_tags:
-    - mark
-    - br
-  sort_columns:
-    promulgated_on:
-      directions:
-        desc:
-          text: Newest first
-    _score:
-      directions:
-        desc:
-          text: Relevance
-  date_facet_help_text: A judgement can be used as case law from the promulgation date.
-  facets:
-    category:
-      text: Category
-      collection: categories
-      ids: category_ids
-      all_link_text: All Categories
-      help_text:
-    judge:
-      text: Judge
-      collection: judges
-      ids: judge_ids
-      all_link_text: All Judges
-      help_text:
-  table_view_properties:
-    case_title:
-      property: case_title
-      text: Case title
-    file_number:
-      property: decision_number
-      text: File number
-    category:
-      property: category_names
-      text: Category
-    sub_category:
-      property: subcategory_names
-      text: Sub-category
-    promulgated_on:
-      property: promulgated_on
-      text: Promulgation date
-      formatters:
-        to_date:
-          method_name: to_date
-          args:
-        strftime:
-          method_name: strftime
-          args: "%d/%m/%Y"
-  detail_view_properties:
-    judges:
-      property: judge_names
-      text: Judges
-    appellants:
-      property: appellant_names
-      text: Appellants
-    respondents:
-      property: respondent_names
-      text: Respondents
-    category:
-      property: category_names
-      text: Category
-    sub_category:
-      property: subcategory_names
-      text: Sub-category
-    appeal_number:
-      property: appeal_number
-      text: Appeal number
-    file_number:
-      property: decision_number
-      text: File number
-    promulgated_on:
-      property: promulgated_on
-      text: Promulgation date
-      formatters:
-        to_date:
-          method_name: to_date
-          args:
-        strftime:
-          method_name: strftime
-          args: "%d/%m/%Y"
-    notes:
-      property: notes
-      text: Notes
+name: ftt-tax
+title: Finance and Tax Tribunals
+search_params:
+  - query
+  - search_field
+  - reported
+  - unreported
+  - country_guidance
+  - page
+  - sort_by
+  - judge_ids
+  - category_ids
+  - date_from
+  - date_to
+allowed_snippet_tags:
+  - mark
+  - br
+sort_columns:
+  promulgated_on:
+    directions:
+      desc:
+        text: Newest first
+  _score:
+    directions:
+      desc:
+        text: Relevance
+date_facet_help_text: A judgement can be used as case law from the promulgation date.
+facets:
+  category:
+    text: Category
+    collection: categories
+    ids: category_ids
+    all_link_text: All Categories
+    help_text:
+  judge:
+    text: Judge
+    collection: judges
+    ids: judge_ids
+    all_link_text: All Judges
+    help_text:
+table_view_properties:
+  case_title:
+    property: case_title
+    text: Case title
+  file_number:
+    property: decision_number
+    text: File number
+  category:
+    property: category_names
+    text: Category
+  sub_category:
+    property: subcategory_names
+    text: Sub-category
+  promulgated_on:
+    property: promulgated_on
+    text: Promulgation date
+    formatters:
+      to_date:
+        method_name: to_date
+        args:
+      strftime:
+        method_name: strftime
+        args: "%d/%m/%Y"
+detail_view_properties:
+  judges:
+    property: judge_names
+    text: Judges
+  appellants:
+    property: appellant_names
+    text: Appellants
+  respondents:
+    property: respondent_names
+    text: Respondents
+  category:
+    property: category_names
+    text: Category
+  sub_category:
+    property: subcategory_names
+    text: Sub-category
+  appeal_number:
+    property: appeal_number
+    text: Appeal number
+  file_number:
+    property: decision_number
+    text: File number
+  promulgated_on:
+    property: promulgated_on
+    text: Promulgation date
+    formatters:
+      to_date:
+        method_name: to_date
+        args:
+      strftime:
+        method_name: strftime
+        args: "%d/%m/%Y"
+  notes:
+    property: notes
+    text: Notes

data/config/tribunals/utiac.yml CHANGED Viewed

@@ -1,119 +1,118 @@
-tribunal:
-  name: utiac
-  title: Upper Tribunal Immigration and Asylum Chamber
-  search_params:
-    - query
-    - search_field
-    - reported
-    - unreported
-    - country_guidance
-    - page
-    - sort_by
-    - judge_ids
-    - country_ids
-    - date_from
-    - date_to
-  allowed_snippet_tags:
-    - mark
-    - br
-  sort_columns:
-    promulgated_on:
-      directions:
-        desc:
-          text: Newest first
-    _score:
-      directions:
-        desc:
-          text: Relevance
-  date_facet_help_text: A judgement can be used as case law from the promulgation date.
-  facets:
-    country:
-      text: Country
-      collection: countries
-      ids: country_ids
-      all_link_text: All Countries
-      help_text:
-    judge:
-      text: Judge
-      collection: judges
-      ids: judge_ids
-      all_link_text: All Judges
-  tabs:
-    reported:
-      text: Reported
-      count_method: reported_count
-      default: true
-      help_text:
-    country_guidance:
-      text: Country Guidance
-      count_method: country_guidance_count
-      default: false
-      help_text:
-    unreported:
-      text: Unreported
-      count_method: unreported_count
-      default: false
-      help_text:
-  table_view_properties:
-    case_title:
-      property: case_title
-      text: Case title
-    keywords:
-      property: keywords
-      text: Keywords
-    promulgated_on:
-      property: promulgated_on
-      text: Promulgation date
-      formatters:
-        to_date:
-          method_name: to_date
-          args:
-        strftime:
-          method_name: strftime
-          args: "%d/%m/%Y"
-    country_name:
-      property: country_name
-      text: Country of Appellant
-    keywords:
-      property: keywords
-      text: Keywords
-  detail_view_properties:
-    appeal_number:
-      property: appeal_number
-      text: Appeal number
-    ncn:
-      property: ncn
-      text: Neutral Citation Number
-    Status:
-      property: status
-      text: Status
-    country_name:
-      property: country_name
-      text: Country
-    country_guidance:
-      property: country_guidance
-      text: Used as country guidance
-      formatters:
-        present?:
-          method_name: present?
-        humanize:
-          method_name: humanize
-    keywords:
-      property: keywords
-      text: Keywords
-    judges:
-      property: judge_names
-      text: Judges
-    hearing_date:
-      property: hearing_date
-      text: Hearing Date
-    promulgated_on:
-      property: promulgated_on
-      text: Promulgation date
-      formatters:
-        to_date:
-          method_name: to_date
-          args:
-        strftime:
-          method_name: strftime
-          args: "%d/%m/%Y"
+name: utiac
+title: Upper Tribunal Immigration and Asylum Chamber
+search_params:
+  - query
+  - search_field
+  - reported
+  - unreported
+  - country_guidance
+  - page
+  - sort_by
+  - judge_ids
+  - country_ids
+  - date_from
+  - date_to
+allowed_snippet_tags:
+  - mark
+  - br
+sort_columns:
+  promulgated_on:
+    directions:
+      desc:
+        text: Newest first
+  _score:
+    directions:
+      desc:
+        text: Relevance
+date_facet_help_text: A judgement can be used as case law from the promulgation date.
+facets:
+  country:
+    text: Country
+    collection: countries
+    ids: country_ids
+    all_link_text: All Countries
+    help_text:
+  judge:
+    text: Judge
+    collection: judges
+    ids: judge_ids
+    all_link_text: All Judges
+tabs:
+  reported:
+    text: Reported
+    count_method: reported_count
+    default: true
+    help_text:
+  country_guidance:
+    text: Country Guidance
+    count_method: country_guidance_count
+    default: false
+    help_text:
+  unreported:
+    text: Unreported
+    count_method: unreported_count
+    default: false
+    help_text:
+table_view_properties:
+  case_title:
+    property: case_title
+    text: Case title
+  keywords:
+    property: keywords
+    text: Keywords
+  promulgated_on:
+    property: promulgated_on
+    text: Promulgation date
+    formatters:
+      to_date:
+        method_name: to_date
+        args:
+      strftime:
+        method_name: strftime
+        args: "%d/%m/%Y"
+  country_name:
+    property: country_name
+    text: Country of Appellant
+  keywords:
+    property: keywords
+    text: Keywords
+detail_view_properties:
+  appeal_number:
+    property: appeal_number
+    text: Appeal number
+  ncn:
+    property: ncn
+    text: Neutral Citation Number
+  Status:
+    property: status
+    text: Status
+  country_name:
+    property: country_name
+    text: Country
+  country_guidance:
+    property: country_guidance
+    text: Used as country guidance
+    formatters:
+      present?:
+        method_name: present?
+      humanize:
+        method_name: humanize
+  keywords:
+    property: keywords
+    text: Keywords
+  judges:
+    property: judge_names
+    text: Judges
+  hearing_date:
+    property: hearing_date
+    text: Hearing Date
+  promulgated_on:
+    property: promulgated_on
+    text: Promulgation date
+    formatters:
+      to_date:
+        method_name: to_date
+        args:
+      strftime:
+        method_name: strftime
+        args: "%d/%m/%Y"

data/lib/moj/tribunals/config_loader.rb CHANGED Viewed

@@ -27,14 +27,19 @@ module Moj
         Dir.glob(File.join(config_path, '*.yml'))
       end
-      private
+      def load_file(file)
+        YAML.load_file(file)
+      end
-        def load_file(file)
-          YAML.load_file(file)
-        end
+      private
         def default_config_path
-          File.join( File.dirname(__FILE__), '..', '..', '..', 'config', 'tribunals' )
+          File.expand_path(
+            File.join(
+              File.dirname(__FILE__),
+              '..', '..', '..', 'config', 'tribunals'
+            )
+          )
         end
     end
   end

data/moj_tribunals_config.gemspec CHANGED Viewed

@@ -2,17 +2,17 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: moj_tribunals_config 0.8.0 ruby lib
+# stub: moj_tribunals_config 1.0.0 ruby lib
 Gem::Specification.new do |s|
   s.name = "moj_tribunals_config"
-  s.version = "0.8.0"
+  s.version = "1.0.0"
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
   s.authors = ["Al Davidson"]
-  s.date = "2015-02-02"
-  s.description = "Used by tribunals_frontend and tribunals_api to share configuration.\n    To use:\n\n    1) add \"gem 'moj_tribunals_config'\" to your Gemfile\n    2) in an initializer, add the following code:\n\n      require 'moj_tribunals_config'\n\n      my_config = Moj::Tribunals::ConfigLoader.new.load\n\n    This will load the default config files from the gem.\n\n\n    To load different files, you can provide an alternative path \n    to the ConfigLoader.new method, e.g.\n\n      my_config = Moj::Tribunals::ConfigLoader.new('/my/alternative/config/path').load\n\n    To just load config for a specific tribunal, you can do:\n\n      config_loader = Moj::Tribunals::ConfigLoader.new\n      config_file = config_loader.config_file_for('utiac')\n      config_loader.load( config_file )\n\n    RailsConfig integration\n    =======================\n\n    If you're using the RailsConfig gem, your intializer can just do something like:\n\n    files = Moj::Tribunals::ConfigLoader.new.config_files\n    files.each{ |f| Settings.add_source!( f ) }\n    Settings.reload!\n  "
+  s.date = "2015-02-03"
+  s.description = "Used by tribunals_frontend and tribunals_api to share configuration.\n    To use:\n\n    1) add \"gem 'moj_tribunals_config'\" to your Gemfile\n    2) in an initializer, add the following code:\n\n      require 'moj_tribunals_config'\n\n      my_config = Moj::Tribunals::ConfigLoader.new.load\n\n    This will load the default config files from the gem.\n\n\n    To load different files, you can provide an alternative path \n    to the ConfigLoader.new method, e.g.\n\n      my_config = Moj::Tribunals::ConfigLoader.new('/my/alternative/config/path').load\n\n    To just load config for a specific tribunal, you can do:\n\n      config_loader = Moj::Tribunals::ConfigLoader.new\n      config_file = config_loader.config_file_for('utiac')\n      config_loader.load_file( config_file )\n\n    RailsConfig integration\n    =======================\n\n    If you're using the RailsConfig gem, your intializer can just do something like:\n\n    files = Moj::Tribunals::ConfigLoader.new.config_files\n    files.each{ |f| Settings.add_source!( f ) }\n    Settings.reload!\n  "
   s.email = "apdavidson@gmail.com"
   s.extra_rdoc_files = [
     "LICENSE.txt",
@@ -20,6 +20,7 @@ Gem::Specification.new do |s|
   ]
   s.files = [
     ".document",
+    ".ruby-version",
     "Gemfile",
     "Gemfile.lock",
     "LICENSE.txt",
@@ -33,8 +34,8 @@ Gem::Specification.new do |s|
     "lib/moj/tribunals/config_loader.rb",
     "lib/moj_tribunals_config.rb",
     "moj_tribunals_config.gemspec",
-    "test/helper.rb",
-    "test/test_moj_tribunals_config.rb"
+    "spec/lib/moj/tribunals/config_loader_spec.rb",
+    "spec/spec_helper.rb"
   ]
   s.homepage = "http://github.com/aldavidson/moj_tribunals_config"
   s.licenses = ["MIT"]
@@ -49,12 +50,16 @@ Gem::Specification.new do |s|
       s.add_development_dependency(%q<rdoc>, ["~> 3.12"])
       s.add_development_dependency(%q<bundler>, ["~> 1.0"])
       s.add_development_dependency(%q<jeweler>, ["~> 2.0.1"])
+      s.add_development_dependency(%q<byebug>, [">= 0"])
+      s.add_development_dependency(%q<rspec>, [">= 0"])
       s.add_development_dependency(%q<simplecov>, [">= 0"])
     else
       s.add_dependency(%q<shoulda>, [">= 0"])
       s.add_dependency(%q<rdoc>, ["~> 3.12"])
       s.add_dependency(%q<bundler>, ["~> 1.0"])
       s.add_dependency(%q<jeweler>, ["~> 2.0.1"])
+      s.add_dependency(%q<byebug>, [">= 0"])
+      s.add_dependency(%q<rspec>, [">= 0"])
       s.add_dependency(%q<simplecov>, [">= 0"])
     end
   else
@@ -62,6 +67,8 @@ Gem::Specification.new do |s|
     s.add_dependency(%q<rdoc>, ["~> 3.12"])
     s.add_dependency(%q<bundler>, ["~> 1.0"])
     s.add_dependency(%q<jeweler>, ["~> 2.0.1"])
+    s.add_dependency(%q<byebug>, [">= 0"])
+    s.add_dependency(%q<rspec>, [">= 0"])
     s.add_dependency(%q<simplecov>, [">= 0"])
   end
 end

data/spec/lib/moj/tribunals/config_loader_spec.rb ADDED Viewed

@@ -0,0 +1,90 @@
+require 'spec_helper'
+require 'moj/tribunals/config_loader'
+describe Moj::Tribunals::ConfigLoader do
+  describe '#initialize' do
+    context 'with no arguments' do
+      it 'defaults the config_path to default_config_path' do
+        expect(subject.config_path).to eq(subject.send(:default_config_path))
+      end
+    end
+    context 'given a config_path' do
+      let(:config_path){ '/my/config_path' }
+      subject{ Moj::Tribunals::ConfigLoader.new(config_path) }
+      it 'stores the given config_path' do
+        expect( subject.config_path ).to eq(config_path)
+      end
+    end
+  end
+  describe '#default_config_path' do
+    let(:path_to_config){ File.join(File.dirname(__FILE__), '..', '..', '..', '..', 'config', 'tribunals') }
+    let(:resolved_path_to_config){ File.expand_path( path_to_config ) }
+    it 'is the full path to the config/tribunals folder' do
+      expect(subject.send(:default_config_path)).to eq(resolved_path_to_config)
+    end
+  end
+  describe '#load_file' do
+    it 'loads the given file as YAML' do
+      expect(YAML).to receive(:load_file).with('/my/file')
+      subject.send(:load_file, '/my/file')
+    end
+    it 'returns the result of parsing the given file as YAML' do
+      allow(YAML).to receive(:load_file).with('/my/file').and_return( {key: 'value'} )
+      expect(subject.send(:load_file, '/my/file')).to eq({key: 'value'})
+    end
+  end
+  describe '#config_files' do
+    it 'returns all YAML files in the config folder' do
+      expect(subject.config_files.sort.map{|f| File.basename(f) } ).to eq(['care-standards.yml', 'eat.yml', 'ftt-tax.yml', 'utiac.yml'])
+    end
+  end
+  describe '#config_file_for' do
+    context 'given a tribunal name that exists as a config file' do
+      let(:tribunal){ 'ftt-tax' }
+      it 'returns the full path to the corresponding config file' do
+        expect(subject.config_file_for(tribunal)).to eq(File.join(subject.send(:config_path), "#{tribunal}.yml"))
+      end
+    end
+    context 'given a tribunal name that exists as a config file' do
+      let(:tribunal){ 'non_existent_tribunal' }
+      it 'returns the full path to the corresponding config file' do
+        expect(subject.config_file_for(tribunal)).to be_nil
+      end
+    end
+  end
+  describe '#load' do
+    it 'returns a hash' do
+      expect(subject.load).to be_a(Hash)
+    end
+    describe 'the returned Hash' do
+      let(:result){ subject.load }
+      describe 'each tribunal' do
+        let(:tribunals){ [:'care-standards', :eat, :'ftt-tax', :utiac] }
+        it 'has a top-level key' do
+          expect(result.keys).to eq( tribunals )
+        end
+        it 'has second-level keys for each value in the YAML file' do
+          tribunals.each do |tribunal|
+            expect(result[tribunal].keys.map(&:to_sym)).to include( :name, :title, :search_params )
+          end
+        end
+      end
+    end
+  end
+end

data/spec/spec_helper.rb ADDED Viewed

@@ -0,0 +1,4 @@
+require 'rspec'
+require 'simplecov'
+SimpleCov.start

metadata CHANGED Viewed

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: moj_tribunals_config
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Al Davidson
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2015-02-02 00:00:00.000000000 Z
+date: 2015-02-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: shoulda
@@ -66,6 +66,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 2.0.1
+- !ruby/object:Gem::Dependency
+  name: byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -88,7 +116,7 @@ description: "Used by tribunals_frontend and tribunals_api to share configuratio
   an alternative path \n    to the ConfigLoader.new method, e.g.\n\n      my_config
   = Moj::Tribunals::ConfigLoader.new('/my/alternative/config/path').load\n\n    To
   just load config for a specific tribunal, you can do:\n\n      config_loader = Moj::Tribunals::ConfigLoader.new\n
-  \     config_file = config_loader.config_file_for('utiac')\n      config_loader.load(
+  \     config_file = config_loader.config_file_for('utiac')\n      config_loader.load_file(
   config_file )\n\n    RailsConfig integration\n    =======================\n\n    If
   you're using the RailsConfig gem, your intializer can just do something like:\n\n
   \   files = Moj::Tribunals::ConfigLoader.new.config_files\n    files.each{ |f| Settings.add_source!(
@@ -101,6 +129,7 @@ extra_rdoc_files:
 - README.rdoc
 files:
 - ".document"
+- ".ruby-version"
 - Gemfile
 - Gemfile.lock
 - LICENSE.txt
@@ -114,8 +143,8 @@ files:
 - lib/moj/tribunals/config_loader.rb
 - lib/moj_tribunals_config.rb
 - moj_tribunals_config.gemspec
-- test/helper.rb
-- test/test_moj_tribunals_config.rb
+- spec/lib/moj/tribunals/config_loader_spec.rb
+- spec/spec_helper.rb
 homepage: http://github.com/aldavidson/moj_tribunals_config
 licenses:
 - MIT

data/test/helper.rb DELETED Viewed

@@ -1,34 +0,0 @@
-require 'simplecov'
-module SimpleCov::Configuration
-  def clean_filters
-    @filters = []
-  end
-end
-SimpleCov.configure do
-  clean_filters
-  load_adapter 'test_frameworks'
-end
-ENV["COVERAGE"] && SimpleCov.start do
-  add_filter "/.rvm/"
-end
-require 'rubygems'
-require 'bundler'
-begin
-  Bundler.setup(:default, :development)
-rescue Bundler::BundlerError => e
-  $stderr.puts e.message
-  $stderr.puts "Run `bundle install` to install missing gems"
-  exit e.status_code
-end
-require 'test/unit'
-require 'shoulda'
-$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
-$LOAD_PATH.unshift(File.dirname(__FILE__))
-require 'moj_tribunals_config'
-class Test::Unit::TestCase
-end

data/test/test_moj_tribunals_config.rb DELETED Viewed

@@ -1,7 +0,0 @@
-require 'helper'
-class TestMojTribunalsConfig < Test::Unit::TestCase
-  should "probably rename this file and start testing for real" do
-    flunk "hey buddy, you should probably rename this file and start testing for real"
-  end
-end