modular_engine 0.9.4 → 0.9.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5c33daf3960a34674243f24eb73f058337e5b3b0
-  data.tar.gz: 2cb5390b880b6a99c7a59f7d57fe52280fb0c565
+  metadata.gz: 6aae4aad5415d55229a5516ee37efa9761511e36
+  data.tar.gz: 1addaca9e979e0188ec51e8671fadd0a9f4b59db
 SHA512:
-  metadata.gz: b6527f9c576bae054b6b8f593cf461d7e8cefb0689e3f3b6757f7dbb087f438453af154696e4b6f5c7638dbd9c5e45ac58a648787d1c603a46cc9e477cc8eac3
-  data.tar.gz: c1ea6c4160d958828927452fa18a4b00ec045f0748f7ec1d157c77996ca5899a8795c2e5984792c3d517cb22eabdf417f9b20b274b170df490bd57dc476bce37
+  metadata.gz: 19ae11906725526d24b68fd78558d18d8c91f447ddd37a641af41d4adb660016f6c0ee332976e1dba5e381a8e59021910dbeb276a78efacd762af4dbb6460704
+  data.tar.gz: 46f97650548ab8c7ff0f8401314ceb90ff8547ade8cc6a51272d69c8d8f51605e5feb35de8d70abbdaf508b231c7a1e982a74f9e5439003c992fbb1cee8ca002

data/lib/generators/modular/engine_generator.rb

@@ -1,8 +1,6 @@
-#lib/generators/modular_engine_generator/install_generator.rb
 require 'rails/generators'
 require 'active_support/core_ext/hash/slice'
 require "rails/generators/rails/app/app_generator"
-#require "rails/generators/app_base"
 require 'date'
 
 module Modular
@@ -58,10 +56,10 @@ module Modular
     def test
       template "test/test_helper.rb"
       template "test/%namespaced_name%_test.rb"
-      append_file "Rakefile", <<-EOF
-  #{rakefile_test_tasks}
-
-  task default: :test
+      append_file "Rakefile", <<-EOF.gsub(/^\s+\|/, '')
+        |#{rakefile_test_tasks}
+        |
+        |task default: :test
       EOF
       if engine?
         template "test/integration/navigation_test.rb"
@@ -115,13 +113,13 @@ module Modular
     alias_method :app_path, :engine_path
 
     class_option :namespace,    type: :string, default: '',
-                                desc: 'Add one or more namespace to your modular engine. Ex: namespace1::namespace2'                      
+                                desc: 'Add one or more namespace to your modular engine. Ex: namespace1::namespace2'
 
     def initialize(*args)
       super
 
       unless engine_path
-        raise Error, "Engine name should be provided in arguments. For details run: rails g modular:engine --help"
+        raise Error, 'Engine name should be provided in arguments. For details run: rails g modular:engine --help'
       end
     end
 
@@ -196,7 +194,7 @@ module Modular
     end
 
     def namespaced_name
-      @namespaced_name ||= modules.join('/').downcase#name.gsub('-', '/')
+      @namespaced_name ||= modules.join('/').underscore#name.gsub('-', '/')
     end
 
   protected
@@ -226,7 +224,7 @@ module Modular
     end
 
     def engine_loader
-      @engine_loader ||= modules.join('_').downcase
+      @engine_loader ||= modules.join('_').underscore
     end
 
     def wrap_in_modules(content)
@@ -285,8 +283,8 @@ module Modular
         raise Rails::Generators::Error, "Invalid engine name #{original_name}. Please give a name which does not start with numbers."
       elsif Rails::Generators::RESERVED_NAMES.include?(name)
         raise Rails::Generators::Error, "Invalid engine name #{original_name}. Please give a name which does not match one of the reserved rails words."
-      elsif Object.const_defined?(camelized)
-        raise Rails::Generators::Error, "Invalid engine name #{original_name}, constant #{camelized} is already in use. Please choose another plugin name."
+      elsif Object.const_defined?(modules.first)
+        warn "[WARNING]: Constant #{modules.first} is already defined. Please choose another namespace."
       end
     end
 
@@ -311,10 +309,10 @@ module Modular
       app_path.sub(/^#{rails_app_path}\//, '')
     end
 
+    #TODO remove from project or finish it
     def rakefile_test_tasks
       ''
     end
-
   end
 
 end

data/lib/modular_engine/version.rb

@@ -1,3 +1,3 @@
 module ModularEngine
-  VERSION = "0.9.4"
+  VERSION = "0.9.5"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: modular_engine
 version: !ruby/object:Gem::Version
-  version: 0.9.4
+  version: 0.9.5
 platform: ruby
 authors:
 - Thibault
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-11 00:00:00.000000000 Z
+date: 2015-06-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler