mods_display 1.6.1 → 1.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 20b03e06562734d42e266b7cf94990c8e53255236e9fe2556fef3d765a5c46a6
-  data.tar.gz: 8ee71ec68c1fdc65ff0a696e07437d54813d7066d0775d934bb96a60f13d2a21
+  metadata.gz: 6e2d497d858d90fede285e8d03675de0c39802897a8bd2a029a369e420704fc9
+  data.tar.gz: 89f053e8c0d2e8ad75325fd15319113cbada0c0023079e97f91dcdc65dd3efc8
 SHA512:
-  metadata.gz: 05d001784ff0a12ce43372efcef6ecbb32b29b000f6459cd188b84566a7fa32e1d87d1481ceffaf23705edeb79dce71e7efe41cc9ab825d00b938cd0e4a4c57e
-  data.tar.gz: 33817a156ed6ae43b2fa626f002263ebd0617a270008c3f5459d993b5fb5fe06aba96000305e22008be78c25adce4b72aaee3d832ebee0093845328e71e131c2
+  metadata.gz: 8900b21680099143212fcd369df69e5321a4ae8e85b1de1708408d5a97e4fd469d4cb5ea8489debf0cc516a44baadccdedabeacd6446bc5f6d95164289bb7501
+  data.tar.gz: e5a85a9ead273ff102873f55424e5499138b8260ac1c1d3cd0cb0c3e55cf431ed564be1a686c44ecc37d0a9181903b72f4a080f067df893748f093888e2af83e

data/.rubocop_todo.yml

@@ -1,12 +1,12 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2023-10-25 22:18:52 UTC using RuboCop version 1.57.1.
+# on 2023-12-06 18:14:53 UTC using RuboCop version 1.58.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 1
+# Offense count: 2
 Capybara/SpecificMatcher:
   Exclude:
     - 'spec/helpers/record_helper_spec.rb'
@@ -22,15 +22,15 @@ Lint/ShadowingOuterLocalVariable:
   Exclude:
     - 'spec/helpers/record_helper_spec.rb'
 
-# Offense count: 16
+# Offense count: 15
 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
 Metrics/AbcSize:
-  Max: 44
+  Max: 42
 
-# Offense count: 3
+# Offense count: 2
 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:
-  Max: 146
+  Max: 132
 
 # Offense count: 1
 # Configuration parameters: LengthThreshold.
@@ -38,43 +38,22 @@ Metrics/CollectionLiteralLength:
   Exclude:
     - 'lib/mods_display/relator_codes.rb'
 
-# Offense count: 10
+# Offense count: 9
 # Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/CyclomaticComplexity:
-  Max: 18
+  Max: 12
 
-# Offense count: 16
+# Offense count: 18
 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 Metrics/MethodLength:
-  Max: 29
+  Max: 24
 
-# Offense count: 8
+# Offense count: 7
 # Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/PerceivedComplexity:
-  Max: 20
-
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: EnforcedStyleForLeadingUnderscores.
-# SupportedStylesForLeadingUnderscores: disallowed, required, optional
-Naming/MemoizedInstanceVariableName:
-  Exclude:
-    - 'lib/mods_display/fields/geo.rb'
+  Max: 13
 
-# Offense count: 7
-# Configuration parameters: EnforcedStyle, AllowedPatterns.
-# SupportedStyles: snake_case, camelCase
-Naming/MethodName:
-  Exclude:
-    - 'lib/mods_display/fields/abstract.rb'
-    - 'lib/mods_display/fields/audience.rb'
-    - 'lib/mods_display/fields/contents.rb'
-    - 'lib/mods_display/fields/field.rb'
-    - 'lib/mods_display/fields/genre.rb'
-    - 'lib/mods_display/fields/resource_type.rb'
-    - 'lib/mods_display/fields/subject.rb'
-
-# Offense count: 18
+# Offense count: 17
 RSpec/BeforeAfterAll:
   Enabled: false
 
@@ -104,13 +83,13 @@ RSpec/ExpectActual:
     - '**/spec/routing/**/*'
     - 'spec/fields/name_spec.rb'
 
-# Offense count: 25
+# Offense count: 39
 # Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly.
 # Include: **/*_spec*rb*, **/spec/**/*
 RSpec/FilePath:
   Enabled: false
 
-# Offense count: 99
+# Offense count: 96
 # Configuration parameters: AssignmentOnly.
 RSpec/InstanceVariable:
   Enabled: false
@@ -121,7 +100,7 @@ RSpec/IteratedExpectation:
     - 'spec/helpers/record_helper_spec.rb'
     - 'spec/integration/html_spec.rb'
 
-# Offense count: 1
+# Offense count: 4
 # Configuration parameters: .
 # SupportedStyles: have_received, receive
 RSpec/MessageSpies:
@@ -132,7 +111,7 @@ RSpec/MessageSpies:
 RSpec/MultipleMemoizedHelpers:
   Max: 6
 
-# Offense count: 2
+# Offense count: 8
 # Configuration parameters: AllowedGroups.
 RSpec/NestedGroups:
   Max: 4
@@ -144,19 +123,19 @@ RSpec/Rails/InferredSpecType:
   Exclude:
     - 'spec/helpers/record_helper_spec.rb'
 
-# Offense count: 25
+# Offense count: 39
 # Configuration parameters: Include, CustomTransform, IgnoreMethods, IgnoreMetadata.
 # Include: **/*_spec.rb
 RSpec/SpecFilePathFormat:
   Enabled: false
 
-# Offense count: 1
+# Offense count: 3
 # Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
 RSpec/VerifiedDoubles:
   Exclude:
     - 'spec/helpers/record_helper_spec.rb'
 
-# Offense count: 36
+# Offense count: 50
 # Configuration parameters: AllowedConstants.
 Style/Documentation:
   Enabled: false
@@ -174,12 +153,12 @@ Style/MultilineBlockChain:
   Exclude:
     - 'lib/mods_display/fields/imprint.rb'
 
-# Offense count: 10
+# Offense count: 13
 Style/OpenStructUse:
   Exclude:
     - 'spec/helpers/record_helper_spec.rb'
 
-# Offense count: 33
+# Offense count: 46
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
 # URISchemes: http, https

data/lib/mods_display/fields/geo.rb

@@ -25,7 +25,7 @@ module ModsDisplay
     end
 
     def geo_extensions
-      @geo_values ||= @stanford_mods_elements.select do |extension_element|
+      @geo_extensions ||= @stanford_mods_elements.select do |extension_element|
         displayLabel(extension_element) =~ /^geo:?$/
       end
     end

data/lib/mods_display/fields/nested_related_item.rb

@@ -8,14 +8,14 @@ module ModsDisplay
   class NestedRelatedItem < Field
     include ModsDisplay::RelatedItemConcerns
 
-    def initialize(values, value_renderer: ValueRenderer)
-      super(values)
+    def initialize(related_item_elements, value_renderer: ValueRenderer)
+      super(related_item_elements)
       @value_renderer = value_renderer
     end
 
     def fields
       @fields ||= begin
-        return_fields = RelatedItemValue.for_values(@stanford_mods_elements).map do |related_item_element|
+        return_fields = RelatedItemValue.for_stanford_mods_elements(@stanford_mods_elements).map do |related_item_element|
           next if related_item_element.collection?
           next unless render_nested_related_item?(related_item_element)
 
@@ -30,6 +30,20 @@ module ModsDisplay
       end
     end
 
+    # Used by exhibits
+    def to_html(view_context = ApplicationController.renderer)
+      helpers = view_context.respond_to?(:simple_format) ? view_context : ApplicationController.new.view_context
+
+      component = ModsDisplay::ListFieldComponent.with_collection(
+        fields,
+        value_transformer: ->(value) { helpers.format_mods_html(value.to_s) },
+        list_html_attributes: { class: 'mods_display_nested_related_items' },
+        list_item_html_attributes: { class: 'mods_display_nested_related_item open' }
+      )
+
+      view_context.render component, layout: false
+    end
+
     # this class provides html markup and is subclassed in purl application
     class ValueRenderer
       def initialize(related_item_element)

data/lib/mods_display/fields/related_item.rb

@@ -4,13 +4,13 @@ module ModsDisplay
   class RelatedItem < Field
     include ModsDisplay::RelatedItemConcerns
 
-    def initialize(values, value_renderer: ValueRenderer)
-      super(values)
+    def initialize(related_item_elements, value_renderer: ValueRenderer)
+      super(related_item_elements)
       @value_renderer = value_renderer
     end
 
     def fields
-      return_fields = RelatedItemValue.for_values(@stanford_mods_elements).map do |related_item_element|
+      return_fields = RelatedItemValue.for_stanford_mods_elements(@stanford_mods_elements).map do |related_item_element|
         next if related_item_element.collection?
         next if render_nested_related_item?(related_item_element)
 

data/lib/mods_display/related_item_concerns.rb

@@ -56,8 +56,8 @@ module ModsDisplay
         @type_attribute ||= get_attribute('type')
       end
 
-      def self.for_values(values)
-        values.map { |value| new(value) }
+      def self.for_stanford_mods_elements(stanford_mods_elements)
+        stanford_mods_elements.map { |element| new(element) }
       end
     end
   end

data/lib/mods_display/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ModsDisplay
-  VERSION = '1.6.1'
+  VERSION = '1.6.2'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mods_display
 version: !ruby/object:Gem::Version
-  version: 1.6.1
+  version: 1.6.2
 platform: ruby
 authors:
 - Jessie Keck
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-12-05 00:00:00.000000000 Z
+date: 2023-12-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: stanford-mods