mods_display 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d059d0bb717d798e323ae91d62ac65420e0b7e34
-  data.tar.gz: bea28312f2984465139f312e585a315ec8de992f
+  metadata.gz: 53261106f9194d4a55bfa879bed5de2456ec8cda
+  data.tar.gz: a337bd0562de9d50a6361f571bdc87ff48809b38
 SHA512:
-  metadata.gz: a7f53d54b8fbbd9dee47ccbee7120e63725e63057602da3a3cd50f569fc1d3335ed38a326d0ae072a25457f207d4ccc7722aa79a28dab3f442b2bf78f81ea35a
-  data.tar.gz: 306dee0b66098f941dcfbb8c8f8138b001cf4f34b06b398b73a118c9f785b73c9ebab33f9e7b0233aa7cb6d8122034a0bc77f87ba355d5bc29fa45046ba6dca6
+  metadata.gz: a41f34b9565c81f5ab3ce15c08e43bdedf5793021cef6e6f65526c13174f798288b0636ff8ce0332fbcfd5b69137caa2e3a015b6ba61e9417b62ced3d618e171
+  data.tar.gz: adaccbdda2e72b8eebadf19b18d1628c799efa300d63c0813dfc9112c1656eee3f583acd2309619dc1fbe97f0c90ee153e4898cab2cbf700bbb6dcc04a5a2eeb

data/lib/mods_display/fields/nested_related_item.rb

@@ -7,30 +7,34 @@ module ModsDisplay
     include ModsDisplay::RelatedItemConcerns
 
     def fields
-      return_fields = @values.map do |value|
-        next if related_item_is_a_collection?(value)
-        next unless render_nested_related_item?(value)
+      @fields ||= begin
+        return_fields = @values.map do |value|
+          next if related_item_is_a_collection?(value)
+          next unless render_nested_related_item?(value)
 
-        related_item_mods_object(value)
-      end.compact
-      collapse_fields(return_fields)
+          related_item_mods_object(value)
+        end.compact
+        collapse_fields(return_fields)
+      end
     end
 
     def to_html
-      return nil if fields.empty? || @config.ignore?
-      output = ''
-      fields.each do |field|
-        next unless field.values.any? { |f| f && !f.empty? }
-        output << "<dt#{label_class} #{sanitized_field_title(field.label)}>#{field.label}</dt>"
-        output << "<dd#{value_class}>"
-        output << '<ul class="mods_display_nested_related_items">'
-        output << field.values.map do |val|
-          "<li class='mods_display_nested_related_item open'>#{link_urls_and_email(val.to_s)}</li>"
-        end.join
-        output << '</ul>'
-        output << '</dd>'
+      return if fields.empty? || @config.ignore?
+      @to_html ||= begin
+        output = ''
+        fields.each do |field|
+          next unless field.values.any? { |f| f && !f.empty? }
+          output << "<dt#{label_class} #{sanitized_field_title(field.label)}>#{field.label}</dt>"
+          output << "<dd#{value_class}>"
+          output << '<ul class="mods_display_nested_related_items">'
+          output << field.values.map do |val|
+            "<li class='mods_display_nested_related_item open'>#{link_urls_and_email(val.to_s)}</li>"
+          end.join
+          output << '</ul>'
+          output << '</dd>'
+        end
+        output
       end
-      output
     end
 
     private

data/lib/mods_display/html.rb

@@ -1,6 +1,5 @@
 module ModsDisplay
   class HTML
-    attr_reader :title, :body
     def initialize(config, xml, klass)
       @config = config
       @stanford_mods = xml
@@ -24,9 +23,7 @@ module ModsDisplay
       body_fields[0] = :subTitle
       body_fields.each do |field_key|
         field = mods_field(@xml, field_key)
-        unless field.nil? || field.to_html.nil?
-          output << mods_field(@xml, field_key).to_html
-        end
+        output << field.to_html unless field.nil? || field.to_html.nil?
       end
       output << '</dl>'
     end

data/lib/mods_display/version.rb

@@ -1,3 +1,3 @@
 module ModsDisplay
-  VERSION = '0.5.0'
+  VERSION = '0.5.1'
 end

data/spec/fields/nested_related_item_spec.rb

@@ -29,11 +29,18 @@ describe ModsDisplay::NestedRelatedItem do
   end
 
   describe '#fields' do
+    let(:mods) { multi_constituent_fixture }
     subject(:fields) { nested_related_item.fields }
 
-    context 'when an element that should be nested' do
-      let(:mods) { multi_constituent_fixture }
+    describe 'memoization' do
+      it 'only calls related_item_mods_object once per item regardless of how many times the method is called' do
+        expect(nested_related_item).to receive(:related_item_mods_object).exactly(2).times
+
+        5.times { nested_related_item.fields }
+      end
+    end
 
+    context 'when an element that should be nested' do
       it 'has a field for each related item' do
         expect(fields.length).to eq 1
       end
@@ -59,6 +66,16 @@ describe ModsDisplay::NestedRelatedItem do
     subject(:html) { Capybara.string(nested_related_item.to_html) }
     let(:mods) { related_item_host_fixture }
 
+    describe 'memoization' do
+      let(:mods) { multi_constituent_fixture }
+
+      it 'only loops throug hthe fields once regardless of how many times the method is called' do
+        expect(nested_related_item.fields).to receive(:each).exactly(1).times.and_call_original
+
+        5.times { nested_related_item.to_html }
+      end
+    end
+
     it 'renders an unordered list with an embedded dl containing the metadata of the related item' do
       within(html.first('dd')) do |dd|
         expect(dd).to have_css('ul.mods_display_nested_related_items')

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mods_display
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Jessie Keck
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-28 00:00:00.000000000 Z
+date: 2017-12-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: stanford-mods