mods 3.0.3 → 3.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f6ac4089b58e673c2783c670e689cb6901bbad611a7271c95f1f8909726beb07
-  data.tar.gz: ee1ee35aeae21d319485212f56535e4bc06068470295f5adcf3ff8593a06c9d0
+  metadata.gz: ba231dc5a8e9d54605e9b7a066419c6d0bb63430bf0a245b7c143b206360daf6
+  data.tar.gz: 9ae4a4448f22fb661ff683dc1f4612be5a0531a7f41a1f8d0f2b59ef2232d180
 SHA512:
-  metadata.gz: 553a4d9e91f50357ff56b5e2c19404386852308c30f06f67ccf6baa586f74f3f4bdbfd05826d3225aac8a0793bdccd5049994e5df04ef691a86c7777a21e554c
-  data.tar.gz: a496b63bef0f1b512d0e3c87886ee80b6665dd90044387d5ce318cc2471d855fcac64839d7d95e9bca75ca1705d786ee0b6220e254b10d31fa32a79768521d66
+  metadata.gz: 7d8680c108fb0b5f915474530a73d097b52efd5ecb940b701a02d08228f56bf63be8194e034713949dfed6548a38236fe736089e0a792e453a50b00e627442ef
+  data.tar.gz: 3ddc2d8b385002a230a5a913f9f393ae8aabe4919569a19cd1c847404fe51e9ecc2e8e0951c87e07a312971eb5095619672487ffa9d0963cb7dfebbca11c8437

data/lib/mods/name.rb

@@ -2,8 +2,8 @@ module Mods
 
   class Name
 
-    CHILD_ELEMENTS = ['namePart', 'displayForm', 'affiliation', 'role', 'description']
-        
+    CHILD_ELEMENTS = ['namePart', 'displayForm', 'affiliation', 'role', 'nameIdentifier', 'description']
+
     # attributes on name node
     ATTRIBUTES = Mods::AUTHORITY_ATTRIBS + Mods::LANG_ATTRIBS + ['type', 'displayLabel', 'usage', 'altRepGroup', 'nameTitleGroup']
 
@@ -11,7 +11,7 @@ module Mods
     TYPES = ['personal', 'corporate', 'conference', 'family']
     # valid values for type attribute on namePart node <name><namePart type="val"/></name>
     NAME_PART_TYPES = ['date', 'family', 'given', 'termsOfAddress']
-  
+
   end
-  
+
 end

data/lib/mods/nom_terminology.rb

@@ -143,6 +143,9 @@ module Mods
           end
           n.displayForm :path => 'm:displayForm'
           n.affiliation :path => 'm:affiliation'
+          n.nameIdentifier :path => 'm:nameIdentifier' do |ni|
+            with_attributes(ni, Mods::LANG_ATTRIBS | %w[displayLabel type typeURI invalid])
+          end
           n.description_el :path => 'm:description' # description is used by Nokogiri
           n.role :path => 'm:role' do |r|
             r.roleTerm :path => 'm:roleTerm' do |rt|

data/lib/mods/version.rb

@@ -1,4 +1,4 @@
 module Mods
   # this is the Ruby Gem version
-  VERSION = '3.0.3'.freeze
+  VERSION = '3.0.4'.freeze
 end

data/spec/lib/name_spec.rb

@@ -197,6 +197,7 @@ RSpec.describe "Mods <name> Element" do
         <name>
           <namePart>Exciting Prints</namePart>
           <affiliation>whatever</affiliation>
+          <nameIdentifier typeURI="https://orcid.org" type="orcid">0000-0002-0666-0666</nameIdentifier>
           <description>anything</description>
           <role><roleTerm type='text'>some role</roleTerm></role>
         </name>
@@ -280,6 +281,26 @@ RSpec.describe "Mods <name> Element" do
     end
   end
 
+  context 'with a nameIdentifier' do
+    subject(:record) do
+      mods_record(<<-XML)
+        <name>
+          <name type="personal">Whoopie Goldberg</name>
+          <nameIdentifier typeURI="https://orcid.org" type="orcid">0000-0002-0666-0666</nameIdentifier>
+          <role><roleTerm type='text'>some role</roleTerm></role>
+        </name>
+      XML
+    end
+
+    it 'has the expected attributes for nameIdentifier' do
+      expect(record.plain_name.nameIdentifier.first).to have_attributes(
+        text: '0000-0002-0666-0666',
+        typeURI: 'https://orcid.org',
+        type_at: 'orcid'
+      )
+    end
+  end
+
   context 'without a family name and given name' do
     subject(:record) do
       mods_record("<name type='personal'>
@@ -349,6 +370,7 @@ RSpec.describe "Mods <name> Element" do
         </name>
         <name>
             <namePart>Daniel Craig</namePart>
+            <nameIdentifier typeURI="https://orcid.org" type="orcid">0000-0002-0666-0666</nameIdentifier>
             <role>
               <roleTerm type='text' authority='marcrelator'>Actor</roleTerm>
               <roleTerm type='code' authority='marcrelator'>cre</roleTerm>
@@ -363,6 +385,12 @@ RSpec.describe "Mods <name> Element" do
         have_attributes(role: have_attributes(value: ['CreatorFake', 'Actor'], code: ['cre'], authority: ['marcrelator', 'marcrelator'], size: 2)),
         have_attributes(role: have_attributes(value: ['Actor'], code: ['cre'], authority: ['marcrelator'], size: 1)),
       ])
+      expect(record.plain_name.last.nameIdentifier.first).to have_attributes(
+        text: '0000-0002-0666-0666',
+        typeURI: 'https://orcid.org',
+        type_at: 'orcid'
+      )
+      expect(record.plain_name.first.nameIdentifier).to be_empty
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mods
 version: !ruby/object:Gem::Version
-  version: 3.0.3
+  version: 3.0.4
 platform: ruby
 authors:
 - Naomi Dushay
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-07-13 00:00:00.000000000 Z
+date: 2023-10-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -222,7 +222,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.32
+rubygems_version: 3.4.13
 signing_key:
 specification_version: 4
 summary: Parse MODS (Metadata Object Description Schema) records.