mods 0.0.12 → 0.0.13

data/README.rdoc

@@ -37,7 +37,8 @@ TODO: Write usage instructions here
 
 == Releases
 
-(0.0.13 make namespace aware processing the default)
+(0.0.14 make namespace aware processing the default)
+0.0.13 really really fix removal of xsi:schemaLocation in jruby
 0.0.12 fix failing jruby test
 0.0.11 fix remove xsi:schemaLocation attribute from mods element when not using namespaces
 0.0.10 remove xsi:schemaLocation attribute from mods element when not using namespaces

data/lib/mods/reader.rb

@@ -43,8 +43,12 @@ module Mods
       if !@namespace_aware
         @mods_ng_xml.remove_namespaces!
         # xsi:schemaLocation attribute will cause problems in JRuby
-        @mods_ng_xml.root.remove_attribute('xsi:schemaLocation') if @mods_ng_xml.has_attribute?('xsi:schemaLocation')
+        if @mods_ng_xml.root && @mods_ng_xml.root.attributes.keys.include?('schemaLocation')
+          @mods_ng_xml.root.attributes['schemaLocation'].remove
+        end
         # doing weird re-reading of xml for jruby, which gets confused by its own cache
+        #   using pedantic is helpful for debugging
+#        @mods_ng_xml = Nokogiri::XML(@mods_ng_xml.to_s, nil, nil, Nokogiri::XML::ParseOptions::PEDANTIC)
         @mods_ng_xml = Nokogiri::XML(@mods_ng_xml.to_s)
       end
     end

data/lib/mods/version.rb

@@ -1,4 +1,4 @@
 module Mods
   # this is the Ruby Gem version
-  VERSION = "0.0.12"
+  VERSION = "0.0.13"
 end

data/spec/reader_spec.rb

@@ -92,13 +92,11 @@ describe "Mods::Reader" do
 			# Nokogiri treats namespaced attributes differently in jruby than in ruby
 			(ng_xml.root.has_attribute?('schemaLocation') || ng_xml.root.has_attribute?('xsi:schemaLocation')).should == true
 			r = Mods::Reader.new
-      r.namespace_aware = true
+      r.namespace_aware = false
       r.from_nk_node(ng_xml)
       # the below are different depending on jruby or ruby ... oy
-      has_a = r.mods_ng_xml.has_attribute?('schemaLocation')
-      has_a.should == false if has_a
-      has = r.mods_ng_xml.has_attribute?('xsi:schemaLocation')
-      has_a.should == false if has_a
+      r.mods_ng_xml.root.attributes.keys.should_not include('schemaLocation')
+      r.mods_ng_xml.root.attributes.keys.should_not include('xsi:schemaLocation')
     end
   end
   

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mods
 version: !ruby/object:Gem::Version
-  version: 0.0.12
+  version: 0.0.13
   prerelease: 
 platform: ruby
 authors:
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-11-14 00:00:00.000000000 Z
+date: 2012-11-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -214,7 +214,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 926175670330081860
+      hash: 1378644879324237983
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -223,7 +223,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 926175670330081860
+      hash: 1378644879324237983
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24