modis 3.1.0 → 3.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ac7dab784855560c744b5de5da3a74af89c62a705e7610fdbda79b76de63fa95
-  data.tar.gz: dc899fdf26e84610340b49853697e25ed9ecbd4e2bf1688b816678b5cc7ee318
+  metadata.gz: '09f5ddeac3bce850c66441dc94fe6d485cfd37d8b6d1bad30e9c5318a46f4cbe'
+  data.tar.gz: 499d4e3b84569c92a130c3b8b831bc91e568f993b60b5a075448aa920b807eb1
 SHA512:
-  metadata.gz: 0a62d99b1eb25f433443d9a82d64883241dd56da269c0acd7e05afce25b52d44ab6da9a468eff6cca35861f8e994879c4559f1516881ffdada6d386adefbef4f
-  data.tar.gz: 473c5451144f796824e539e295bb8e9bdd9b966716a4b3ffe76c2345ed427e2b858d9588b54248830362d0fa7a922a446f59e701012f6342bb78725b05c776b1
+  metadata.gz: 4372de7a42905bf81d110ecc6fe265dcd17ef1c00938cda35f93984cc543e3d0d85d20f20315c0054ac47f392657dd14cf033b4cb084ab10d3525a57c170f42e
+  data.tar.gz: 5efcd9e86a4dafff8f5e5b53922f9a9a181dfceef4963af27890e7aad6e4b378820f138e974a848c8e03deafd69ffcc3beda64ab500099ea81e7d1f87473afe5

data/.ruby-version

@@ -1 +1 @@
-2.5.3
+2.6.3

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 ## Unreleased
 
+## v3.2.0 - 2019-12-12
+
+- Add missing `#update` and `#update!`. [#27](https://github.com/rpush/modis/pull/27) by [@dsantosmerino](https://github.com/dsantosmerino).
+
 ## v3.1.0 - 2019-10-18
 
 - Test with Rails 6

data/lib/modis/persistence.rb

@@ -158,16 +158,22 @@ module Modis
       save(validate: false)
     end
 
-    def update_attributes(attrs)
+    def update(attrs)
       assign_attributes(attrs)
       save
     end
 
-    def update_attributes!(attrs)
+    alias update_attributes update
+    deprecate update_attributes: 'please, use update instead'
+
+    def update!(attrs)
       assign_attributes(attrs)
       save!
     end
 
+    alias update_attributes! update!
+    deprecate update_attributes!: 'please, use update! instead'
+
     private
 
     def coerce_for_persistence(value)

data/lib/modis/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Modis
-  VERSION = '3.1.0'
+  VERSION = '3.2.0'
 end

data/spec/persistence_spec.rb

@@ -249,6 +249,33 @@ describe Modis::Persistence do
     end
   end
 
+  describe 'update!' do
+    it 'updates the given attributes' do
+      model.update!(name: 'Derp', age: 29)
+      model.reload
+      expect(model.name).to eq 'Derp'
+      expect(model.age).to eq 29
+    end
+
+    it 'invokes callbacks' do
+      model.update!(name: 'Derp')
+      expect(model.called_callbacks).to_not be_empty
+    end
+
+    it 'updates all dirty attributes' do
+      model.age = 29
+      model.update!(name: 'Derp')
+      model.reload
+      expect(model.age).to eq 29
+    end
+
+    it 'raises an error if the model is invalid' do
+      expect do
+        model.update!(name: nil).to be false
+      end.to raise_error(Modis::RecordInvalid)
+    end
+  end
+
   describe 'update_attributes!' do
     it 'updates the given attributes' do
       model.update_attributes!(name: 'Derp', age: 29)
@@ -276,6 +303,31 @@ describe Modis::Persistence do
     end
   end
 
+  describe 'update' do
+    it 'updates the given attributes' do
+      model.update(name: 'Derp', age: 29)
+      model.reload
+      expect(model.name).to eq('Derp')
+      expect(model.age).to eq(29)
+    end
+
+    it 'invokes callbacks' do
+      model.update(name: 'Derp')
+      expect(model.called_callbacks).to_not be_empty
+    end
+
+    it 'updates all dirty attributes' do
+      model.age = 29
+      model.update(name: 'Derp')
+      model.reload
+      expect(model.age).to eq(29)
+    end
+
+    it 'returns false if the model is invalid' do
+      expect(model.update(name: nil)).to be false
+    end
+  end
+
   describe 'update_attributes' do
     it 'updates the given attributes' do
       model.update_attributes(name: 'Derp', age: 29)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: modis
 version: !ruby/object:Gem::Version
-  version: 3.1.0
+  version: 3.2.0
 platform: ruby
 authors:
 - Ian Leitch
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-10-18 00:00:00.000000000 Z
+date: 2019-12-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -259,8 +259,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.4
 signing_key: 
 specification_version: 4
 summary: ActiveModel + Redis